58396 2011-04-12 17:00:20 -0700 [Qt] http/tests/misc/favicon-loads-with-icon-loading-override.html fails 2014-02-03 03:17:32 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC All RESOLVED INVALID Qt, QtTriaged P2 Normal --- 87008 1 ossy webkit-unassigned alice.barraclough sam oldest_to_newest 384513 0 ossy 2011-04-12 17:00:20 -0700 http/tests/misc/favicon-loads-with-icon-loading-override.html introduced in http://trac.webkit.org/changeset/83628 and fails: http://build.webkit.org/results/Qt%20Linux%20Release/r83631%20%2831279%29/http/tests/misc/favicon-loads-with-icon-loading-override-pretty-diff.html 384515 1 alice.barraclough 2011-04-12 17:01:25 -0700 looking... 384536 2 alice.barraclough 2011-04-12 17:19:16 -0700 For Webkit on mac and windows, the siteicon loading preference maps to "WebKitLoadSiteIconsKey", which is defined in WebPreferenceKeysPrivate.h. Another example is the automatic image loading preference, which maps to "WebKitDisplayImagesKey" on mac and windows. On qt, i don't know/see where this preference gets mapped to key. I don't see it in qwebsettings.cpp I'm assuming that somewhere in qt there is a preference key mapping, because otherwise layoutTestController. overridePreference() wouldn't work for any preference. Another question i have is: if the preference keys aren't cross-platform, how are any tests that override preference expected to work cross-platform? 384539 3 ossy 2011-04-12 17:21:17 -0700 I added it to the Skipped list: http://trac.webkit.org/changeset/83670, because it seems we should add WebKitLoadSiteIconsKey somewhere to Qt layouttestcontroller. 384541 4 ossy 2011-04-12 17:22:31 -0700 (In reply to comment #2) > For Webkit on mac and windows, the siteicon loading preference maps to "WebKitLoadSiteIconsKey", which is defined in WebPreferenceKeysPrivate.h. > > Another example is the automatic image loading preference, which maps to "WebKitDisplayImagesKey" on mac and windows. On qt, i don't know/see where this preference gets mapped to key. I don't see it in qwebsettings.cpp > > I'm assuming that somewhere in qt there is a preference key mapping, because otherwise layoutTestController. overridePreference() wouldn't work for any preference. Another question i have is: if the preference keys aren't cross-platform, how are any tests that override preference expected to work cross-platform? Thanks for your help, we will check it. But it's too late for me now. (2:22 am) 384564 5 89320 alice.barraclough 2011-04-12 17:41:29 -0700 Created attachment 89320 patch I think that'll fix it, but I can't be sure. If more tweaks need to be added then feel free to take the patch and change it. No need to wait for me. 384569 6 alice.barraclough 2011-04-12 17:42:51 -0700 oh and if that does fix the issue then the skipped list addition could be removed as well. 392923 7 89320 vestbo 2011-04-26 16:04:29 -0700 Comment on attachment 89320 patch View in context: https://bugs.webkit.org/attachment.cgi?id=89320&action=review > Source/WebKit/qt/Api/qwebsettings.h:81 > + LoadSiteIcons The preference is only applicable if AutoLoadImages has been disabled, and the enum name should reflect that. AlwaysLoadSiteIcons perhaps? 975198 8 jturcotte 2014-02-03 03:17:32 -0800 === Bulk closing of Qt bugs === If you believe that this bug report is still relevant for a non-Qt port of webkit.org, please re-open it and remove [Qt] from the summary. If you believe that this is still an important QtWebKit bug, please fill a new report at https://bugreports.qt-project.org and add a link to this issue. See http://qt-project.org/wiki/ReportingBugsInQt for additional guidelines. 89320 2011-04-12 17:41:29 -0700 2011-04-26 16:04:28 -0700 patch qt-test-fix.txt text/plain 3374 alice.barraclough SW5kZXg6IFNvdXJjZS9XZWJLaXQvcXQvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9X ZWJLaXQvcXQvQ2hhbmdlTG9nCShyZXZpc2lvbiA4MzY3MykKKysrIFNvdXJjZS9XZWJLaXQvcXQv Q2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTEtMDQtMTIgIEFs aWNlIExpdSAgPGFsaWNlLmxpdUBhcHBsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTU4Mzk2CisgICAgICAgIFtRdF0gaHR0cC90ZXN0cy9taXNjL2Zhdmljb24tbG9hZHMt d2l0aC1pY29uLWxvYWRpbmctb3ZlcnJpZGUuaHRtbCBmYWlscyAgICAgICAgCisKKyAgICAgICAg KiBBcGkvcXdlYnNldHRpbmdzLmg6IEFkZCBuZXcgc2V0dGluZworICAgICAgICAqIEFwaS9xd2Vi c2V0dGluZ3MuY3BwOgorICAgICAgICAoUVdlYlNldHRpbmdzOjpRV2ViU2V0dGluZ3MpOiBzZXQg ZGVmYXVsdCB0byBmYWxzZQorCiAyMDExLTA0LTEyICBHZW9yZ2UgR3VvICA8R2VvcmdlLkd1b0Bu b2tpYS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgTGFzemxvIEdvbWJvcy4KSW5kZXg6IFNv dXJjZS9XZWJLaXQvcXQvQXBpL3F3ZWJzZXR0aW5ncy5jcHAKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNl L1dlYktpdC9xdC9BcGkvcXdlYnNldHRpbmdzLmNwcAkocmV2aXNpb24gODM2MzQpCisrKyBTb3Vy Y2UvV2ViS2l0L3F0L0FwaS9xd2Vic2V0dGluZ3MuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC01MTAs NiArNTEwLDcgQEAgUVdlYlNldHRpbmdzOjpRV2ViU2V0dGluZ3MoKQogICAgIGQtPmF0dHJpYnV0 ZXMuaW5zZXJ0KFFXZWJTZXR0aW5nczo6VGlsZWRCYWNraW5nU3RvcmVFbmFibGVkLCBmYWxzZSk7 CiAgICAgZC0+YXR0cmlidXRlcy5pbnNlcnQoUVdlYlNldHRpbmdzOjpGcmFtZUZsYXR0ZW5pbmdF bmFibGVkLCBmYWxzZSk7CiAgICAgZC0+YXR0cmlidXRlcy5pbnNlcnQoUVdlYlNldHRpbmdzOjpT aXRlU3BlY2lmaWNRdWlya3NFbmFibGVkLCB0cnVlKTsKKyAgICBkLT5hdHRyaWJ1dGVzLmluc2Vy dChRV2ViU2V0dGluZ3M6OkxvYWRTaXRlSWNvbnMsIGZhbHNlKTsKICAgICBkLT5vZmZsaW5lU3Rv cmFnZURlZmF1bHRRdW90YSA9IDUgKiAxMDI0ICogMTAyNDsKICAgICBkLT5kZWZhdWx0VGV4dEVu Y29kaW5nID0gUUxhdGluMVN0cmluZygiaXNvLTg4NTktMSIpOwogfQpJbmRleDogU291cmNlL1dl YktpdC9xdC9BcGkvcXdlYnNldHRpbmdzLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdC9x dC9BcGkvcXdlYnNldHRpbmdzLmgJKHJldmlzaW9uIDgzNjM0KQorKysgU291cmNlL1dlYktpdC9x dC9BcGkvcXdlYnNldHRpbmdzLmgJKHdvcmtpbmcgY29weSkKQEAgLTc3LDcgKzc3LDggQEAgcHVi bGljOgogICAgICAgICBTaXRlU3BlY2lmaWNRdWlya3NFbmFibGVkLAogICAgICAgICBKYXZhc2Ny aXB0Q2FuQ2xvc2VXaW5kb3dzLAogICAgICAgICBXZWJHTEVuYWJsZWQsCi0gICAgICAgIEh5cGVy bGlua0F1ZGl0aW5nRW5hYmxlZAorICAgICAgICBIeXBlcmxpbmtBdWRpdGluZ0VuYWJsZWQsCisg ICAgICAgIExvYWRTaXRlSWNvbnMKICAgICB9OwogICAgIGVudW0gV2ViR3JhcGhpYyB7CiAgICAg ICAgIE1pc3NpbmdJbWFnZUdyYXBoaWMsCkluZGV4OiBUb29scy9DaGFuZ2VMb2cKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gVG9vbHMvQ2hhbmdlTG9nCShyZXZpc2lvbiA4MzY3MykKKysrIFRvb2xzL0NoYW5nZUxv Zwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBACisyMDExLTA0LTEyICBBbGljZSBMaXUg IDxhbGljZS5saXVAYXBwbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01 ODM5NgorICAgICAgICBbUXRdIGh0dHAvdGVzdHMvbWlzYy9mYXZpY29uLWxvYWRzLXdpdGgtaWNv bi1sb2FkaW5nLW92ZXJyaWRlLmh0bWwgZmFpbHMgICAgICAgIAorCisgICAgICAgICogRHVtcFJl bmRlclRyZWUvcXQvTGF5b3V0VGVzdENvbnRyb2xsZXJRdC5jcHA6CisgICAgICAgIChMYXlvdXRU ZXN0Q29udHJvbGxlcjo6b3ZlcnJpZGVQcmVmZXJlbmNlKToKKyAgICAgICAgQWRkIGNhc2UgZm9y IFdlYktpdExvYWRTaXRlSWNvbnNLZXkuCisKIDIwMTEtMDQtMTIgIEJyZW50IEZ1bGdoYW0gIDxi ZnVsZ2hhbUB3ZWJraXQub3JnPgogCiAgICAgICAgIFVucmV2aWV3ZWQgYnVpbGQgY29ycmVjdGlv biBmb3IgV2luQ2Fpcm8gYm90IGFmdGVyIHI4MzYzOS4KSW5kZXg6IFRvb2xzL0R1bXBSZW5kZXJU cmVlL3F0L0xheW91dFRlc3RDb250cm9sbGVyUXQuY3BwCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL0R1 bXBSZW5kZXJUcmVlL3F0L0xheW91dFRlc3RDb250cm9sbGVyUXQuY3BwCShyZXZpc2lvbiA4MzYz NCkKKysrIFRvb2xzL0R1bXBSZW5kZXJUcmVlL3F0L0xheW91dFRlc3RDb250cm9sbGVyUXQuY3Bw CSh3b3JraW5nIGNvcHkpCkBAIC02MjgsNiArNjI4LDggQEAgdm9pZCBMYXlvdXRUZXN0Q29udHJv bGxlcjo6b3ZlcnJpZGVQcmVmZQogICAgICAgICBzZXR0aW5ncy0+c2V0QXR0cmlidXRlKFFXZWJT ZXR0aW5nczo6V2ViR0xFbmFibGVkLCB2YWx1ZS50b0Jvb2woKSk7CiAgICAgZWxzZSBpZiAobmFt ZSA9PSAiV2ViS2l0SHlwZXJsaW5rQXVkaXRpbmdFbmFibGVkIikKICAgICAgICAgc2V0dGluZ3Mt PnNldEF0dHJpYnV0ZShRV2ViU2V0dGluZ3M6Okh5cGVybGlua0F1ZGl0aW5nRW5hYmxlZCwgdmFs dWUudG9Cb29sKCkpOworICAgIGVsc2UgaWYgKG5hbWUgPT0gIldlYktpdExvYWRTaXRlSWNvbnNL ZXkiKQorICAgICAgICBzZXR0aW5ncy0+c2V0QXR0cmlidXRlKFFXZWJTZXR0aW5nczo6TG9hZFNp dGVJY29ucywgdmFsdWUudG9Cb29sKCkpOwogICAgIGVsc2UKICAgICAgICAgcHJpbnRmKCJFUlJP UjogTGF5b3V0VGVzdENvbnRyb2xsZXI6Om92ZXJyaWRlUHJlZmVyZW5jZSgpIGRvZXMgbm90IHN1 cHBvcnQgdGhlICclcycgcHJlZmVyZW5jZVxuIiwKICAgICAgICAgICAgIG5hbWUudG9MYXRpbjEo KS5kYXRhKCkpOwo=