58386 2011-04-12 15:54:13 -0700 [chromium] Fix spellcheck regression in context menus 2011-04-12 16:22:23 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 jam jam jianli oldest_to_newest 384448 0 jam 2011-04-12 15:54:13 -0700 [chromium] Fix spellcheck regression in context menus 384453 1 89292 jam 2011-04-12 15:57:53 -0700 Created attachment 89292 Patch 384454 2 jam 2011-04-12 15:58:45 -0700 My original change was incorrect, since the offset is 0 when the first word is the one that's misspelt. The length will be non-zero if there's a misspelling though, per WebSpellCheckClient comments. 384483 3 jam 2011-04-12 16:22:23 -0700 Committed r83660: <http://trac.webkit.org/changeset/83660> 89292 2011-04-12 15:57:53 -0700 2011-04-12 16:01:17 -0700 Patch bug-58386-20110412155723.patch text/plain 2586 jam SW5kZXg6IFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNv dXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCShyZXZpc2lvbiA4MzY1NikKKysrIFNvdXJj ZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMg QEAKKzIwMTEtMDQtMTIgIEpvaG4gQWJkLUVsLU1hbGVrICA8amFtQGNocm9taXVtLm9yZz4KKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbY2hyb21pdW1d IEZpeCBzcGVsbGNoZWNrIHJlZ3Jlc3Npb24gaW4gY29udGV4dCBtZW51cworICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTgzODYKKworICAgICAgICAqIHNy Yy9Db250ZXh0TWVudUNsaWVudEltcGwuY3BwOgorICAgICAgICAoV2ViS2l0OjpDb250ZXh0TWVu dUNsaWVudEltcGw6OmdldEN1c3RvbU1lbnVGcm9tRGVmYXVsdEl0ZW1zKToKKwogMjAxMS0wNC0x MiAgQWxvayBQcml5YWRhcnNoaSAgPGFsb2twQGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZp ZXdlZCBieSBKYW1lcyBSb2JpbnNvbi4KSW5kZXg6IFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3Jj L0NvbnRleHRNZW51Q2xpZW50SW1wbC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdC9j aHJvbWl1bS9zcmMvQ29udGV4dE1lbnVDbGllbnRJbXBsLmNwcAkocmV2aXNpb24gODM2NTApCisr KyBTb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9Db250ZXh0TWVudUNsaWVudEltcGwuY3BwCSh3 b3JraW5nIGNvcHkpCkBAIC0yNjQsOSArMjY0LDggQEAgUGxhdGZvcm1NZW51RGVzY3JpcHRpb24g Q29udGV4dE1lbnVDbGllbgogICAgICAgICAgICAgICAgICAgICBtX3dlYlZpZXctPnNwZWxsQ2hl Y2tDbGllbnQoKS0+c3BlbGxDaGVjaygKICAgICAgICAgICAgICAgICAgICAgICAgIGRhdGEubWlz c3BlbGxlZFdvcmQsIG1pc3NwZWxsZWRPZmZzZXQsIG1pc3NwZWxsZWRMZW5ndGgsCiAgICAgICAg ICAgICAgICAgICAgICAgICAmZGF0YS5kaWN0aW9uYXJ5U3VnZ2VzdGlvbnMpOwotICAgICAgICAg ICAgICAgICAgICBpZiAoIW1pc3NwZWxsZWRPZmZzZXQpCisgICAgICAgICAgICAgICAgICAgIGlm ICghbWlzc3BlbGxlZExlbmd0aCkKICAgICAgICAgICAgICAgICAgICAgICAgIGRhdGEubWlzc3Bl bGxlZFdvcmQucmVzZXQoKTsKLQogICAgICAgICAgICAgICAgIH0KICAgICAgICAgICAgIH0KICAg ICAgICAgfQpJbmRleDogTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91 dFRlc3RzL0NoYW5nZUxvZwkocmV2aXNpb24gODM2NTYpCisrKyBMYXlvdXRUZXN0cy9DaGFuZ2VM b2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxMiBAQAorMjAxMS0wNC0xMiAgSm9obiBBYmQt RWwtTWFsZWsgIDxqYW1AY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFtjaHJvbWl1bV0gRml4IHNwZWxsY2hlY2sgcmVncmVzc2lv biBpbiBjb250ZXh0IG1lbnVzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD01ODM4NgorCisgICAgICAgICogcGxhdGZvcm0vY2hyb21pdW0vdGVzdF9leHBl Y3RhdGlvbnMudHh0OgorCiAyMDExLTA0LTExICBKZXIgTm9ibGUgIDxqZXIubm9ibGVAYXBwbGUu Y29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IFNpbW9uIEZyYXNlci4KSW5kZXg6IExheW91dFRl c3RzL3BsYXRmb3JtL2Nocm9taXVtL3Rlc3RfZXhwZWN0YXRpb25zLnR4dAo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9jaHJvbWl1bS90ZXN0X2V4cGVjdGF0aW9ucy50eHQJKHJl dmlzaW9uIDgzNjUwKQorKysgTGF5b3V0VGVzdHMvcGxhdGZvcm0vY2hyb21pdW0vdGVzdF9leHBl Y3RhdGlvbnMudHh0CSh3b3JraW5nIGNvcHkpCkBAIC0zNDk1LDkgKzM0OTUsNiBAQCBCVUdXSzU4 MzI4IEdQVSBNQUMgREVCVUcgOiBjb21wb3NpdGluZy93CiAKIEJVR0NSNzkxNzMgR1BVIExJTlVY IERFQlVHIDogZmFzdC9jYW52YXMvYWNjZXNzLXplcm8tc2l6ZWQtY2FudmFzLmh0bWwgPSBQQVNT IENSQVNICiAKLS8vIFJlZ3Jlc3Npb24gY2F1c2VkIGJ5IHI4MzYxNy4gamFtIGlzIGdvaW5nIHRv IGZpeCBpdC4KLUJVR0pBTTogZWRpdGluZy9zcGVsbGluZy9jb250ZXh0LW1lbnUtc3VnZ2VzdGlv bnMuaHRtbCA9IFRFWFQKLQogLy8gUmVncmVzc2lvbiBjYXVzZWQgYnkgcjgzNjI4LgogQlVHQ1I3 OTI0MSA6IGh0dHAvdGVzdHMvbWlzYy9mYXZpY29uLWxvYWRzLXdpdGgtaWNvbi1sb2FkaW5nLW92 ZXJyaWRlLmh0bWwgPSBURVhUCiAK