5838 2005-11-26 13:53:57 -0800 DumpRenderTree should test for Ahem before doing anything else 2005-11-28 14:15:29 -0800 1 1 1 Unclassified WebKit Tools / Tests 420+ Mac OS X 10.4 RESOLVED FIXED P4 Normal --- 1 eric hyatt ap oldest_to_newest 24588 0 eric 2005-11-26 13:53:57 -0800 DumpRenderTree should test for Ahem before doing anything else If it doesn't find it, it should tell the user how to get it. 24611 1 4815 ap 2005-11-27 01:32:40 -0800 Created attachment 4815 Proposed patch I have also thought about automatically activating a local copy of Ahem for DumpRenderTree, but that smells of over-engineering :) 24714 2 4815 darin 2005-11-27 18:25:38 -0800 Comment on attachment 4815 Proposed patch Looks fine. 4815 2005-11-27 01:32:40 -0800 2005-11-27 18:25:38 -0800 Proposed patch AhemPatch.txt text/plain 1073 ap SW5kZXg6IER1bXBSZW5kZXJUcmVlL0R1bXBSZW5kZXJUcmVlLm0KPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQpSQ1MgZmls ZTogL2N2cy9yb290L1dlYktpdFRvb2xzL0R1bXBSZW5kZXJUcmVlL0R1bXBSZW5kZXJUcmVlLm0s dgpyZXRyaWV2aW5nIHJldmlzaW9uIDEuMTkKZGlmZiAtcCAtdSAtcjEuMTkgRHVtcFJlbmRlclRy ZWUvRHVtcFJlbmRlclRyZWUubQotLS0gRHVtcFJlbmRlclRyZWUvRHVtcFJlbmRlclRyZWUubQk5 IE9jdCAyMDA1IDAyOjU3OjIwIC0wMDAwCTEuMTkKKysrIER1bXBSZW5kZXJUcmVlL0R1bXBSZW5k ZXJUcmVlLm0JMjcgTm92IDIwMDUgMDk6MzQ6MDkgLTAwMDAKQEAgLTE0Myw2ICsxNDMsMTEgQEAg aW50IG1haW4oaW50IGFyZ2MsIGNvbnN0IGNoYXIgKmFyZ3ZbXSkKICAgICAgICAgICAgICAgICBi cmVhazsKICAgICAgICAgfQogICAgIAorICAgIGlmIChbW1tOU0ZvbnRNYW5hZ2VyIHNoYXJlZEZv bnRNYW5hZ2VyXSBhdmFpbGFibGVNZW1iZXJzT2ZGb250RmFtaWx5OkAiQWhlbSJdIGNvdW50XSA9 PSAwKSB7CisJCWZwcmludGYoc3RkZXJyLCAiXG5BaGVtIGZvbnQgaXMgbm90IGF2YWlsYWJsZS4g VGhpcyBzcGVjaWFsIHNpbXBsZSBmb250IGlzIHVzZWQgdG8gY29uc3RydWN0IGNlcnRhaW4gdHlw ZXMgb2YgcHJlZGljdGFibGUgdGVzdHMuXG5cblRvIHJ1biByZWdyZXNzaW9uIHRlc3RzLCBwbGVh c2UgZ2V0IGl0IGZyb20gPGh0dHA6Ly93ZWJraXQub3BlbmRhcndpbi5vcmcvcXVhbGl0eS9BaGVt LnR0Zj4uXG4iKTsKKwkJZXhpdCgxKTsKKyAgICB9CisgICAgCiAgICAgV2ViVmlldyAqd2ViVmll dyA9IFtbV2ViVmlldyBhbGxvY10gaW5pdFdpdGhGcmFtZTpOU01ha2VSZWN0KDAsIDAsIHdpZHRo LCBoZWlnaHQpXTsKICAgICBXYWl0VW50aWxEb25lRGVsZWdhdGUgKmRlbGVnYXRlID0gW1tXYWl0 VW50aWxEb25lRGVsZWdhdGUgYWxsb2NdIGluaXRdOwogICAgIEVkaXRpbmdEZWxlZ2F0ZSAqZWRp dGluZ0RlbGVnYXRlID0gW1tFZGl0aW5nRGVsZWdhdGUgYWxsb2NdIGluaXRdOwo=