58379 2011-04-12 14:53:50 -0700 The default backspace event handler should mark the event as handled if navigation succeeds 2011-04-12 19:28:08 -0700 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 ananta ananta ap commit-queue oldest_to_newest 384404 0 ananta 2011-04-12 14:53:50 -0700 The EventHandler::defaultBackspaceEventHandler function should mark the event as handled only if the back/forward navigation was successful. This breaks ChromeFrame (which embeds Chrome->Webkit in IE)where some of the pages are rendered in the host browser like IE. Scenario:- 1. IE navigates to foo.com 2. A navigation to bar.com which renders in ChromeFrame. 3. Hitting backspace on bar.com should go back to foo.com which does not happen as the backspace event is eaten by webkit. 384424 1 89282 ananta 2011-04-12 15:31:05 -0700 Created attachment 89282 Initial patch 384426 2 89282 ap 2011-04-12 15:36:10 -0700 Comment on attachment 89282 Initial patch View in context: https://bugs.webkit.org/attachment.cgi?id=89282&action=review > Source/WebCore/ChangeLog:3 > + https://bugs.webkit.org/show_bug.cgi?id=58379 Please add bug title before the link. > Source/WebCore/ChangeLog:9 > + No new tests. (OOPS!) The patch cannot be landed with OOPS, so you need to explain why there are no new tests instead of leaving the line as is. 384436 3 89285 ananta 2011-04-12 15:46:43 -0700 Created attachment 89285 Patch with review comments addressed 384444 4 89285 ap 2011-04-12 15:50:44 -0700 Comment on attachment 89285 Patch with review comments addressed View in context: https://bugs.webkit.org/attachment.cgi?id=89285&action=review > Source/WebCore/ChangeLog:3 > + https://bugs.webkit.org/show_bug.cgi?id=58379 Still no bug title. > Source/WebCore/ChangeLog:9 > + No new tests added as there is no change in functionality. This is not accurate. The patch fixes a bug, so of course there is change in functionality. 384460 5 89294 ananta 2011-04-12 16:02:19 -0700 Created attachment 89294 Explanation added as to why there are no tests. Added the title before the bug link as requested. 384487 6 89294 ap 2011-04-12 16:26:30 -0700 Comment on attachment 89294 Explanation added as to why there are no tests. Added the title before the bug link as requested. Ugh, sorry that I didn't notice it before. You have removed the Not Reviewed line that was added by prepare-ChangeLog, so commit queue won't be able to put the reviewer name in. Please add it back (I suggest running prepare-ChangeLog again to see how exactly it should look). 384498 7 89304 ananta 2011-04-12 16:35:03 -0700 Created attachment 89304 Created a new patch after running the prepare-changelog script. Sorry about removing the Reviewed by line 384534 8 89304 ap 2011-04-12 17:17:34 -0700 Comment on attachment 89304 Created a new patch after running the prepare-changelog script. Sorry about removing the Reviewed by line In normal case, it feels weird to let the event fly further if we happen to be at the first or last page, but block it otherwise. But this is what we do elsewhere in this file, so it's perfectly fine for this patch. 384627 9 89304 commit-queue 2011-04-12 19:28:01 -0700 Comment on attachment 89304 Created a new patch after running the prepare-changelog script. Sorry about removing the Reviewed by line Clearing flags on attachment: 89304 Committed r83688: <http://trac.webkit.org/changeset/83688> 384628 10 commit-queue 2011-04-12 19:28:08 -0700 All reviewed patches have been landed. Closing bug. 89282 2011-04-12 15:31:05 -0700 2011-04-12 15:46:43 -0700 Initial patch history_patch.txt text/plain 1512 ananta SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDgzNjQ3KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTEtMDQtMTIgIEFuYW50YW5h cmF5YW5hbiBHIEl5ZW5nYXIgIDxhbmFudGFAY2hyb21pdW0ub3JnPgorCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01ODM3OQorCisgICAgICAgIFRoZSBk ZWZhdWx0IGJhY2tzcGFjZSBldmVudCBoYW5kbGVyIHNob3VsZCBtYXJrIHRoZSBldmVudCBhcyBo YW5kbGVkIG9ubHkgaWYgd2Ugd2VyZSBhYmxlIHRvIHN1Y2Nlc3NmdWxseQorICAgICAgICBuYXZp Z2F0ZSBiYWNrd2FyZHMgb3IgZm9yd2FyZHMuIFRoZXNlIG5hdmlnYXRpb25zIGNhbiBmYWlsIGlm IHRoZXJlIGlzIG5vdyBiYWNrL2ZvcndhcmQgaGlzdG9yeS4gVGhpcyBjYW4KKyAgICAgICAgb2Nj dXIgaW4gY2FzZXMgbGlrZSBDaHJvbWVGcmFtZSB3aGVyZSBoaXN0b3J5IGlzIG1hbmFnZWQgYnkg YW4gZXh0ZXJuYWwgYnJvd3NlciBsaWtlIElFLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cy4gKE9P UFMhKQorCisgICAgICAgICogcGFnZS9FdmVudEhhbmRsZXIuY3BwOgorICAgICAgICAoV2ViQ29y ZTo6RXZlbnRIYW5kbGVyOjpkZWZhdWx0QmFja3NwYWNlRXZlbnRIYW5kbGVyKToKKwogMjAxMS0w NC0xMSAgU3RlcGhhbmllIExld2lzICA8c2xld2lzQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZp ZXdlZCBieSBPbGl2ZXIgSHVudC4KSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3BhZ2UvRXZlbnRIYW5k bGVyLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9wYWdlL0V2ZW50SGFuZGxlci5j cHAJKHJldmlzaW9uIDgzNjQ3KQorKysgU291cmNlL1dlYkNvcmUvcGFnZS9FdmVudEhhbmRsZXIu Y3BwCSh3b3JraW5nIGNvcHkpCkBAIC0yODg5LDEyICsyODg5LDE1IEBAIHZvaWQgRXZlbnRIYW5k bGVyOjpkZWZhdWx0QmFja3NwYWNlRXZlbnQKICAgICBpZiAoIXBhZ2UpCiAgICAgICAgIHJldHVy bjsKIAorICAgIGJvb2wgaGFuZGxlZEV2ZW50ID0gZmFsc2U7CisKICAgICBpZiAoZXZlbnQtPnNo aWZ0S2V5KCkpCi0gICAgICAgIHBhZ2UtPmdvRm9yd2FyZCgpOworICAgICAgICBoYW5kbGVkRXZl bnQgPSBwYWdlLT5nb0ZvcndhcmQoKTsKICAgICBlbHNlCi0gICAgICAgIHBhZ2UtPmdvQmFjaygp OworICAgICAgICBoYW5kbGVkRXZlbnQgPSBwYWdlLT5nb0JhY2soKTsKIAotICAgIGV2ZW50LT5z ZXREZWZhdWx0SGFuZGxlZCgpOworICAgIGlmIChoYW5kbGVkRXZlbnQpCisgICAgICAgIGV2ZW50 LT5zZXREZWZhdWx0SGFuZGxlZCgpOwogfQogCiAK 89285 2011-04-12 15:46:43 -0700 2011-04-12 16:02:19 -0700 Patch with review comments addressed history_patch.txt text/plain 1549 ananta SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDgzNjQ3KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTEtMDQtMTIgIEFuYW50YW5h cmF5YW5hbiBHIEl5ZW5nYXIgIDxhbmFudGFAY2hyb21pdW0ub3JnPgorCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01ODM3OQorCisgICAgICAgIFRoZSBk ZWZhdWx0IGJhY2tzcGFjZSBldmVudCBoYW5kbGVyIHNob3VsZCBtYXJrIHRoZSBldmVudCBhcyBo YW5kbGVkIG9ubHkgaWYgd2Ugd2VyZSBhYmxlIHRvIHN1Y2Nlc3NmdWxseQorICAgICAgICBuYXZp Z2F0ZSBiYWNrd2FyZHMgb3IgZm9yd2FyZHMuIFRoZXNlIG5hdmlnYXRpb25zIGNhbiBmYWlsIGlm IHRoZXJlIGlzIG5vdyBiYWNrL2ZvcndhcmQgaGlzdG9yeS4gVGhpcyBjYW4KKyAgICAgICAgb2Nj dXIgaW4gY2FzZXMgbGlrZSBDaHJvbWVGcmFtZSB3aGVyZSBoaXN0b3J5IGlzIG1hbmFnZWQgYnkg YW4gZXh0ZXJuYWwgYnJvd3NlciBsaWtlIElFLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cyBhZGRl ZCBhcyB0aGVyZSBpcyBubyBjaGFuZ2UgaW4gZnVuY3Rpb25hbGl0eS4KKworICAgICAgICAqIHBh Z2UvRXZlbnRIYW5kbGVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkV2ZW50SGFuZGxlcjo6ZGVm YXVsdEJhY2tzcGFjZUV2ZW50SGFuZGxlcik6CisKIDIwMTEtMDQtMTEgIFN0ZXBoYW5pZSBMZXdp cyAgPHNsZXdpc0BhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgT2xpdmVyIEh1bnQu CkluZGV4OiBTb3VyY2UvV2ViQ29yZS9wYWdlL0V2ZW50SGFuZGxlci5jcHAKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gU291cmNlL1dlYkNvcmUvcGFnZS9FdmVudEhhbmRsZXIuY3BwCShyZXZpc2lvbiA4MzY0NykK KysrIFNvdXJjZS9XZWJDb3JlL3BhZ2UvRXZlbnRIYW5kbGVyLmNwcAkod29ya2luZyBjb3B5KQpA QCAtMjg4OSwxMiArMjg4OSwxNSBAQCB2b2lkIEV2ZW50SGFuZGxlcjo6ZGVmYXVsdEJhY2tzcGFj ZUV2ZW50CiAgICAgaWYgKCFwYWdlKQogICAgICAgICByZXR1cm47CiAKKyAgICBib29sIGhhbmRs ZWRFdmVudCA9IGZhbHNlOworCiAgICAgaWYgKGV2ZW50LT5zaGlmdEtleSgpKQotICAgICAgICBw YWdlLT5nb0ZvcndhcmQoKTsKKyAgICAgICAgaGFuZGxlZEV2ZW50ID0gcGFnZS0+Z29Gb3J3YXJk KCk7CiAgICAgZWxzZQotICAgICAgICBwYWdlLT5nb0JhY2soKTsKKyAgICAgICAgaGFuZGxlZEV2 ZW50ID0gcGFnZS0+Z29CYWNrKCk7CiAKLSAgICBldmVudC0+c2V0RGVmYXVsdEhhbmRsZWQoKTsK KyAgICBpZiAoaGFuZGxlZEV2ZW50KQorICAgICAgICBldmVudC0+c2V0RGVmYXVsdEhhbmRsZWQo KTsKIH0KIAogCg== 89294 2011-04-12 16:02:19 -0700 2011-04-12 16:35:03 -0700 Explanation added as to why there are no tests. Added the title before the bug link as requested. history_patch.txt text/plain 1729 ananta SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDgzNjQ3KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTggQEAKKzIwMTEtMDQtMTIgIEFuYW50YW5h cmF5YW5hbiBHIEl5ZW5nYXIgIDxhbmFudGFAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFRoZSBk ZWZhdWx0IGJhY2tzcGFjZSBldmVudCBoYW5kbGVyIHNob3VsZCBtYXJrIHRoZSBldmVudCBhcyBo YW5kbGVkIGlmIG5hdmlnYXRpb24gc3VjY2VlZHMuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD01ODM3OQorCisgICAgICAgIFdlIHNob3VsZCBtYXJrIHRo ZSBldmVudCBhcyBoYW5kbGVkIG9ubHkgaWYgd2Ugd2VyZSBhYmxlIHRvIHN1Y2Nlc3NmdWxseSBu YXZpZ2F0ZSBiYWNrd2FyZHMgb3IgZm9yd2FyZHMuCisgICAgICAgIFRoZXNlIG5hdmlnYXRpb25z IGNhbiBmYWlsIGlmIHRoZXJlIGlzIG5vdyBiYWNrL2ZvcndhcmQgaGlzdG9yeS4gVGhpcyBjYW4g b2NjdXIgaW4gY2FzZXMgbGlrZSBDaHJvbWVGcmFtZQorICAgICAgICB3aGVyZSBoaXN0b3J5IGlz IG1hbmFnZWQgYnkgYW4gZXh0ZXJuYWwgYnJvd3NlciBsaWtlIElFLgorCisgICAgICAgIE5vIG5l dyB0ZXN0cyBhZGRlZCBhcyB0aGlzIHNjZW5hcmlvIGNhbiBvY2N1ciB3aGVuIHRoZSBoaXN0b3J5 IHZpZXcgaXMgc3BsaXQgYWNyb3NzIHR3byBicm93c2VycyAoV2ViS2l0IGFuZCBJRSkKKyAgICAg ICAgSXQgaXMgbm9uIHRyaXZpYWwgdG8gc2ltdWxhdGUgdGhpcyBlbnZpcm9ubWVudC4KKworICAg ICAgICAqIHBhZ2UvRXZlbnRIYW5kbGVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkV2ZW50SGFu ZGxlcjo6ZGVmYXVsdEJhY2tzcGFjZUV2ZW50SGFuZGxlcik6CisKIDIwMTEtMDQtMTEgIFN0ZXBo YW5pZSBMZXdpcyAgPHNsZXdpc0BhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgT2xp dmVyIEh1bnQuCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9wYWdlL0V2ZW50SGFuZGxlci5jcHAKPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcGFnZS9FdmVudEhhbmRsZXIuY3BwCShyZXZpc2lv biA4MzY0NykKKysrIFNvdXJjZS9XZWJDb3JlL3BhZ2UvRXZlbnRIYW5kbGVyLmNwcAkod29ya2lu ZyBjb3B5KQpAQCAtMjg4OSwxMiArMjg4OSwxNSBAQCB2b2lkIEV2ZW50SGFuZGxlcjo6ZGVmYXVs dEJhY2tzcGFjZUV2ZW50CiAgICAgaWYgKCFwYWdlKQogICAgICAgICByZXR1cm47CiAKKyAgICBi b29sIGhhbmRsZWRFdmVudCA9IGZhbHNlOworCiAgICAgaWYgKGV2ZW50LT5zaGlmdEtleSgpKQot ICAgICAgICBwYWdlLT5nb0ZvcndhcmQoKTsKKyAgICAgICAgaGFuZGxlZEV2ZW50ID0gcGFnZS0+ Z29Gb3J3YXJkKCk7CiAgICAgZWxzZQotICAgICAgICBwYWdlLT5nb0JhY2soKTsKKyAgICAgICAg aGFuZGxlZEV2ZW50ID0gcGFnZS0+Z29CYWNrKCk7CiAKLSAgICBldmVudC0+c2V0RGVmYXVsdEhh bmRsZWQoKTsKKyAgICBpZiAoaGFuZGxlZEV2ZW50KQorICAgICAgICBldmVudC0+c2V0RGVmYXVs dEhhbmRsZWQoKTsKIH0KIAogCg== 89304 2011-04-12 16:35:03 -0700 2011-04-12 19:28:01 -0700 Created a new patch after running the prepare-changelog script. Sorry about removing the Reviewed by line history_patch.txt text/plain 1779 ananta SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDgzNjYxKQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjAgQEAKKzIwMTEtMDQtMTIgIEFuYW50YW5h cmF5YW5hbiBHIEl5ZW5nYXIgIDxhbmFudGFAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoZSBkZWZhdWx0IGJhY2tzcGFjZSBl dmVudCBoYW5kbGVyIHNob3VsZCBtYXJrIHRoZSBldmVudCBhcyBoYW5kbGVkIGlmIG5hdmlnYXRp b24gc3VjY2VlZHMuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD01ODM3OQorCisgICAgICAgIFdlIHNob3VsZCBtYXJrIHRoZSBldmVudCBhcyBoYW5kbGVk IG9ubHkgaWYgd2Ugd2VyZSBhYmxlIHRvIHN1Y2Nlc3NmdWxseSBuYXZpZ2F0ZSBiYWNrd2FyZHMg b3IgZm9yd2FyZHMuCisgICAgICAgIFRoZXNlIG5hdmlnYXRpb25zIGNhbiBmYWlsIGlmIHRoZXJl IGlzIG5vdyBiYWNrL2ZvcndhcmQgaGlzdG9yeS4gVGhpcyBjYW4gb2NjdXIgaW4gY2FzZXMgbGlr ZSBDaHJvbWVGcmFtZQorICAgICAgICB3aGVyZSBoaXN0b3J5IGlzIG1hbmFnZWQgYnkgYW4gZXh0 ZXJuYWwgYnJvd3NlciBsaWtlIElFLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cyBhZGRlZCBhcyB0 aGlzIHNjZW5hcmlvIGNhbiBvY2N1ciB3aGVuIHRoZSBoaXN0b3J5IHZpZXcgaXMgc3BsaXQgYWNy b3NzIHR3byBicm93c2VycyAoV2ViS2l0IGFuZCBJRSkKKyAgICAgICAgSXQgaXMgbm9uIHRyaXZp YWwgdG8gc2ltdWxhdGUgdGhpcyBlbnZpcm9ubWVudC4KKworICAgICAgICAqIHBhZ2UvRXZlbnRI YW5kbGVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkV2ZW50SGFuZGxlcjo6ZGVmYXVsdEJhY2tz cGFjZUV2ZW50SGFuZGxlcik6CisKIDIwMTEtMDQtMTIgIEx1aXogQWdvc3RpbmkgIDxsdWl6LmFn b3N0aW5pQG9wZW5ib3NzYS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgQW5kcmVhcyBLbGlu Zy4KSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3BhZ2UvRXZlbnRIYW5kbGVyLmNwcAo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBTb3VyY2UvV2ViQ29yZS9wYWdlL0V2ZW50SGFuZGxlci5jcHAJKHJldmlzaW9uIDgzNjQ3 KQorKysgU291cmNlL1dlYkNvcmUvcGFnZS9FdmVudEhhbmRsZXIuY3BwCSh3b3JraW5nIGNvcHkp CkBAIC0yODg5LDEyICsyODg5LDE1IEBAIHZvaWQgRXZlbnRIYW5kbGVyOjpkZWZhdWx0QmFja3Nw YWNlRXZlbnQKICAgICBpZiAoIXBhZ2UpCiAgICAgICAgIHJldHVybjsKIAorICAgIGJvb2wgaGFu ZGxlZEV2ZW50ID0gZmFsc2U7CisKICAgICBpZiAoZXZlbnQtPnNoaWZ0S2V5KCkpCi0gICAgICAg IHBhZ2UtPmdvRm9yd2FyZCgpOworICAgICAgICBoYW5kbGVkRXZlbnQgPSBwYWdlLT5nb0Zvcndh cmQoKTsKICAgICBlbHNlCi0gICAgICAgIHBhZ2UtPmdvQmFjaygpOworICAgICAgICBoYW5kbGVk RXZlbnQgPSBwYWdlLT5nb0JhY2soKTsKIAotICAgIGV2ZW50LT5zZXREZWZhdWx0SGFuZGxlZCgp OworICAgIGlmIChoYW5kbGVkRXZlbnQpCisgICAgICAgIGV2ZW50LT5zZXREZWZhdWx0SGFuZGxl ZCgpOwogfQogCiAK