58371 2011-04-12 13:37:01 -0700 [chromium] Fix spelling layout tests since virtual function changed 2011-04-12 16:31:50 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 jam jam eric jianli oldest_to_newest 384316 0 jam 2011-04-12 13:37:01 -0700 [chromium] Fix spelling layout tests since virtual function changed 384317 1 89264 jam 2011-04-12 13:37:23 -0700 Created attachment 89264 Patch 384321 2 jianli 2011-04-12 13:40:03 -0700 Please also update ChangeLog. 384325 3 eric 2011-04-12 13:45:07 -0700 ChangeLog fail. also, strange commit message. :( And failed to close the bug. :( webkit-patch will do this all for you. But I can understand that our tools can be confusing to those not familiar with them. 384330 4 jam 2011-04-12 13:50:06 -0700 (In reply to comment #3) > ChangeLog fail. > > also, strange commit message. :( > > And failed to close the bug. :( > > webkit-patch will do this all for you. But I can understand that our tools can be confusing to those not familiar with them. sorry, I was in a hurry to fix the build. I thought it's ok to commit manually for tree fixes? I think I was confused because I ran webkit-patch in Tools/DumpRenderTree/chromium, and it didn't find a ChangeLog there. 384333 5 eric 2011-04-12 13:52:48 -0700 (In reply to comment #4) > (In reply to comment #3) > > ChangeLog fail. > > > > also, strange commit message. :( > > > > And failed to close the bug. :( > > > > webkit-patch will do this all for you. But I can understand that our tools can be confusing to those not familiar with them. > > sorry, I was in a hurry to fix the build. I thought it's ok to commit manually for tree fixes? > > I think I was confused because I ran webkit-patch in Tools/DumpRenderTree/chromium, and it didn't find a ChangeLog there. Understandable. And yes, its certainly acceptable to commit build fixes w/o much process. We still generally have ChangeLogs for them. Seems like you got bit by Chromium's DRT missing a ChangeLog. Thanks for the quick fix. 384441 6 89287 jam 2011-04-12 15:49:23 -0700 Created attachment 89287 Patch 384443 7 jam 2011-04-12 15:50:30 -0700 please ignore the latest patch, that was uploaded here by accident 384493 8 89287 eric 2011-04-12 16:31:50 -0700 Comment on attachment 89287 Patch I'm sorry our tools have caused you so much trouble. There is a bug about webkit-patch needing to warn people when uploading to closed patches. 89264 2011-04-12 13:37:23 -0700 2011-04-12 15:49:21 -0700 Patch bug-58371-20110412133653.patch text/plain 1620 jam SW5kZXg6IFRvb2xzL0R1bXBSZW5kZXJUcmVlL2Nocm9taXVtL1dlYlZpZXdIb3N0LmNwcAo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBUb29scy9EdW1wUmVuZGVyVHJlZS9jaHJvbWl1bS9XZWJWaWV3SG9zdC5jcHAJ KHJldmlzaW9uIDgzNjE1KQorKysgVG9vbHMvRHVtcFJlbmRlclRyZWUvY2hyb21pdW0vV2ViVmll d0hvc3QuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC00MDYsNyArNDA2LDcgQEAgYm9vbCBXZWJWaWV3 SG9zdDo6aGFuZGxlQ3VycmVudEtleWJvYXJkRQogICAgIHJldHVybiBmcmFtZS0+ZXhlY3V0ZUNv bW1hbmQoV2ViU3RyaW5nOjpmcm9tVVRGOChtX2VkaXRDb21tYW5kTmFtZSksIFdlYlN0cmluZzo6 ZnJvbVVURjgobV9lZGl0Q29tbWFuZFZhbHVlKSk7CiB9CiAKLXZvaWQgV2ViVmlld0hvc3Q6OnNw ZWxsQ2hlY2soY29uc3QgV2ViU3RyaW5nJiB0ZXh0LCBpbnQmIG1pc3NwZWxsZWRPZmZzZXQsIGlu dCYgbWlzc3BlbGxlZExlbmd0aCkKK3ZvaWQgV2ViVmlld0hvc3Q6OnNwZWxsQ2hlY2soY29uc3Qg V2ViU3RyaW5nJiB0ZXh0LCBpbnQmIG1pc3NwZWxsZWRPZmZzZXQsIGludCYgbWlzc3BlbGxlZExl bmd0aCwgV2ViVmVjdG9yPFdlYlN0cmluZz4qIG9wdGlvbmFsU3VnZ2VzdGlvbnMpCiB7CiAgICAg Ly8gQ2hlY2sgdGhlIHNwZWxsaW5nIG9mIHRoZSBnaXZlbiB0ZXh0LgogICAgIG1fc3BlbGxjaGVj ay5zcGVsbENoZWNrV29yZCh0ZXh0LCAmbWlzc3BlbGxlZE9mZnNldCwgJm1pc3NwZWxsZWRMZW5n dGgpOwpJbmRleDogVG9vbHMvRHVtcFJlbmRlclRyZWUvY2hyb21pdW0vV2ViVmlld0hvc3QuaAo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBUb29scy9EdW1wUmVuZGVyVHJlZS9jaHJvbWl1bS9XZWJWaWV3SG9zdC5o CShyZXZpc2lvbiA4MzYxNSkKKysrIFRvb2xzL0R1bXBSZW5kZXJUcmVlL2Nocm9taXVtL1dlYlZp ZXdIb3N0LmgJKHdvcmtpbmcgY29weSkKQEAgLTEwNiw3ICsxMDYsNyBAQCBjbGFzcyBXZWJWaWV3 SG9zdCA6IHB1YmxpYyBXZWJLaXQ6OldlYlNwCiAgICAgdmlydHVhbCBib29sIG5hdmlnYXRlKGNv bnN0IFRlc3ROYXZpZ2F0aW9uRW50cnkmLCBib29sIHJlbG9hZCk7CiAKICAgICAvLyBXZWJLaXQ6 OldlYlNwZWxsQ2hlY2tDbGllbnQKLSAgICB2aXJ0dWFsIHZvaWQgc3BlbGxDaGVjayhjb25zdCBX ZWJLaXQ6OldlYlN0cmluZyYsIGludCYgb2Zmc2V0LCBpbnQmIGxlbmd0aCk7CisgICAgdmlydHVh bCB2b2lkIHNwZWxsQ2hlY2soY29uc3QgV2ViS2l0OjpXZWJTdHJpbmcmLCBpbnQmIG9mZnNldCwg aW50JiBsZW5ndGgsIFdlYktpdDo6V2ViVmVjdG9yPFdlYktpdDo6V2ViU3RyaW5nPiogb3B0aW9u YWxTdWdnZXN0aW9ucyk7CiAgICAgdmlydHVhbCB2b2lkIHJlcXVlc3RDaGVja2luZ09mVGV4dChj b25zdCBXZWJLaXQ6OldlYlN0cmluZyYsIFdlYktpdDo6V2ViVGV4dENoZWNraW5nQ29tcGxldGlv biopOwogICAgIHZpcnR1YWwgV2ViS2l0OjpXZWJTdHJpbmcgYXV0b0NvcnJlY3RXb3JkKGNvbnN0 IFdlYktpdDo6V2ViU3RyaW5nJik7CiAK 89287 2011-04-12 15:49:23 -0700 2011-04-12 16:31:50 -0700 Patch bug-58371-20110412154853.patch text/plain 2018 jam SW5kZXg6IFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL0NvbnRleHRNZW51Q2xpZW50SW1wbC5j cHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvQ29udGV4dE1lbnVD bGllbnRJbXBsLmNwcAkocmV2aXNpb24gODM2NTApCisrKyBTb3VyY2UvV2ViS2l0L2Nocm9taXVt L3NyYy9Db250ZXh0TWVudUNsaWVudEltcGwuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0yNjQsOSAr MjY0LDggQEAgUGxhdGZvcm1NZW51RGVzY3JpcHRpb24gQ29udGV4dE1lbnVDbGllbgogICAgICAg ICAgICAgICAgICAgICBtX3dlYlZpZXctPnNwZWxsQ2hlY2tDbGllbnQoKS0+c3BlbGxDaGVjaygK ICAgICAgICAgICAgICAgICAgICAgICAgIGRhdGEubWlzc3BlbGxlZFdvcmQsIG1pc3NwZWxsZWRP ZmZzZXQsIG1pc3NwZWxsZWRMZW5ndGgsCiAgICAgICAgICAgICAgICAgICAgICAgICAmZGF0YS5k aWN0aW9uYXJ5U3VnZ2VzdGlvbnMpOwotICAgICAgICAgICAgICAgICAgICBpZiAoIW1pc3NwZWxs ZWRPZmZzZXQpCisgICAgICAgICAgICAgICAgICAgIGlmICghbWlzc3BlbGxlZExlbmd0aCkKICAg ICAgICAgICAgICAgICAgICAgICAgIGRhdGEubWlzc3BlbGxlZFdvcmQucmVzZXQoKTsKLQogICAg ICAgICAgICAgICAgIH0KICAgICAgICAgICAgIH0KICAgICAgICAgfQpJbmRleDogVG9vbHMvQ2hh bmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL0NoYW5nZUxvZwkocmV2aXNpb24gODM2NTApCisr KyBUb29scy9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxNCBAQAorMjAxMS0w NC0xMiAgSm9obiBBYmQtRWwtTWFsZWsgIDxqYW1AY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtjaHJvbWl1bV0gRml4IHNwZWxs aW5nIGxheW91dCB0ZXN0cyBzaW5jZSB2aXJ0dWFsIGZ1bmN0aW9uIGNoYW5nZWQKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTU4MzcxCisKKyAgICAgICAg KiBEdW1wUmVuZGVyVHJlZS9jaHJvbWl1bS9XZWJWaWV3SG9zdC5jcHA6CisgICAgICAgIChXZWJW aWV3SG9zdDo6c3BlbGxDaGVjayk6CisgICAgICAgICogRHVtcFJlbmRlclRyZWUvY2hyb21pdW0v V2ViVmlld0hvc3QuaDoKKwogMjAxMS0wNC0xMiAgRGlyayBQcmFua2UgIDxkcHJhbmtlQGNocm9t aXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBUb255IENoYW5nLgpJbmRleDogTGF5b3V0 VGVzdHMvcGxhdGZvcm0vY2hyb21pdW0vdGVzdF9leHBlY3RhdGlvbnMudHh0Cj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIExheW91dFRlc3RzL3BsYXRmb3JtL2Nocm9taXVtL3Rlc3RfZXhwZWN0YXRpb25zLnR4dAko cmV2aXNpb24gODM2NTApCisrKyBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9jaHJvbWl1bS90ZXN0X2V4 cGVjdGF0aW9ucy50eHQJKHdvcmtpbmcgY29weSkKQEAgLTM0OTUsOSArMzQ5NSw2IEBAIEJVR1dL NTgzMjggR1BVIE1BQyBERUJVRyA6IGNvbXBvc2l0aW5nL3cKIAogQlVHQ1I3OTE3MyBHUFUgTElO VVggREVCVUcgOiBmYXN0L2NhbnZhcy9hY2Nlc3MtemVyby1zaXplZC1jYW52YXMuaHRtbCA9IFBB U1MgQ1JBU0gKIAotLy8gUmVncmVzc2lvbiBjYXVzZWQgYnkgcjgzNjE3LiBqYW0gaXMgZ29pbmcg dG8gZml4IGl0LgotQlVHSkFNOiBlZGl0aW5nL3NwZWxsaW5nL2NvbnRleHQtbWVudS1zdWdnZXN0 aW9ucy5odG1sID0gVEVYVAotCiAvLyBSZWdyZXNzaW9uIGNhdXNlZCBieSByODM2MjguCiBCVUdD Ujc5MjQxIDogaHR0cC90ZXN0cy9taXNjL2Zhdmljb24tbG9hZHMtd2l0aC1pY29uLWxvYWRpbmct b3ZlcnJpZGUuaHRtbCA9IFRFWFQKIAo=