<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>58364</bug_id>
          
          <creation_ts>2011-04-12 12:45:44 -0700</creation_ts>
          <short_desc>[chromium] TilingData mishandles very small texture sizes</short_desc>
          <delta_ts>2011-04-14 13:50:15 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebCore Misc.</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>All</rep_platform>
          <op_sys>All</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          <blocked>57113</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Adrienne Walker">enne</reporter>
          <assigned_to name="Adrienne Walker">enne</assigned_to>
          <cc>enne</cc>
    
    <cc>jamesr</cc>
    
    <cc>scheib</cc>
    
    <cc>vangelis</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>384268</commentid>
    <comment_count>0</comment_count>
    <who name="Adrienne Walker">enne</who>
    <bug_when>2011-04-12 12:45:44 -0700</bug_when>
    <thetext>[chromium] TilingData mishandles very small texture sizes</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>384271</commentid>
    <comment_count>1</comment_count>
      <attachid>89250</attachid>
    <who name="Adrienne Walker">enne</who>
    <bug_when>2011-04-12 12:49:37 -0700</bug_when>
    <thetext>Created attachment 89250
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>384351</commentid>
    <comment_count>2</comment_count>
      <attachid>89250</attachid>
    <who name="Vincent Scheib">scheib</who>
    <bug_when>2011-04-12 14:01:17 -0700</bug_when>
    <thetext>Comment on attachment 89250
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=89250&amp;action=review

I don&apos;t think this is the right way to fix the problem -- see notes and suggested test cases.

&gt; Source/WebCore/platform/graphics/gpu/TilingData.cpp:69
&gt; +    m_maxTextureSize = max(3, maxTextureSize);

I think we must respect max texture size. If a max is passed in that&apos;s too restrictive to function, tiling data should hand out 0s for the computation accessors such as numTiles(). 

If you did perform logic here, the case of no border texels should allow small maximums.

&gt; Source/WebKit/chromium/tests/TilingDataTest.cpp:56
&gt; +    EXPECT_EQ(0, TilingData(4,  0,  4, false).numTiles());

EXPECT_EQ(0, TilingData(-10,  1,  1, false).numTiles());
EXPECT_EQ(0, TilingData(-1,  1,  1, false).numTiles());
EXPECT_EQ(0, TilingData(0,  1,  1, false).numTiles());

&gt; Source/WebKit/chromium/tests/TilingDataTest.cpp:58
&gt; +    EXPECT_EQ(1, TilingData(1,  1,  1, false).numTiles());

EXPECT_EQ(2, TilingData(1,  1,  2, false).numTiles());

&gt; Source/WebKit/chromium/tests/TilingDataTest.cpp:99
&gt; +    EXPECT_EQ(0, TilingData(4,  0,  4, true).numTiles());

EXPECT_EQ(0, TilingData(-10,  1,  1, true).numTiles());
EXPECT_EQ(0, TilingData(-1,  1,  1, true).numTiles());
EXPECT_EQ(0, TilingData(0,  1,  1, true).numTiles());

&gt; Source/WebKit/chromium/tests/TilingDataTest.cpp:101
&gt; +    EXPECT_EQ(1, TilingData(1,  1,  1, true).numTiles());

If the max texture size can&apos;t accommodate borders, then it&apos;s a no go:
EXPECT_EQ(0, TilingData(1,  1,  1, true).numTiles()); //fix for previous line
EXPECT_EQ(0, TilingData(1,  1,  2, true).numTiles());

&gt; Source/WebKit/chromium/tests/TilingDataTest.cpp:-378
&gt; -    EXPECT_EQ(16, data.numTilesY());

This test shouldn&apos;t need to be modified? If no border texels, a max size of 2 should be valid.

This test block should be duplicated for the case with border texels.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>384522</commentid>
    <comment_count>3</comment_count>
      <attachid>89310</attachid>
    <who name="Adrienne Walker">enne</who>
    <bug_when>2011-04-12 17:09:07 -0700</bug_when>
    <thetext>Created attachment 89310
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>384526</commentid>
    <comment_count>4</comment_count>
    <who name="Adrienne Walker">enne</who>
    <bug_when>2011-04-12 17:10:57 -0700</bug_when>
    <thetext>(In reply to comment #2)
&gt; (From update of attachment 89250 [details])
&gt; View in context: https://bugs.webkit.org/attachment.cgi?id=89250&amp;action=review
&gt; 
&gt; I don&apos;t think this is the right way to fix the problem -- see notes and suggested test cases.

Good suggestion--that keeps TilingData more clean.  I can put the min texture size in LayerTilerChromium instead.

&gt; [everything else]

Can&apos;t argue with more tests.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>384556</commentid>
    <comment_count>5</comment_count>
      <attachid>89310</attachid>
    <who name="Vincent Scheib">scheib</who>
    <bug_when>2011-04-12 17:34:45 -0700</bug_when>
    <thetext>Comment on attachment 89310
Patch

LGTM</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>384558</commentid>
    <comment_count>6</comment_count>
      <attachid>89310</attachid>
    <who name="James Robinson">jamesr</who>
    <bug_when>2011-04-12 17:35:56 -0700</bug_when>
    <thetext>Comment on attachment 89310
Patch

Works for me too!</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>384572</commentid>
    <comment_count>7</comment_count>
    <who name="Adrienne Walker">enne</who>
    <bug_when>2011-04-12 17:50:53 -0700</bug_when>
    <thetext>Committed r83674: &lt;http://trac.webkit.org/changeset/83674&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>385882</commentid>
    <comment_count>8</comment_count>
    <who name="Adrienne Walker">enne</who>
    <bug_when>2011-04-14 11:07:59 -0700</bug_when>
    <thetext>Reopening because I think the implications of the previous patch were misunderstood.  After some discussion with Vince, it seems like the better approach would be to return 1 tile in case tile size == texture size.  This would also prevent the need for a &quot;minimum texture size&quot; in bug 57113.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>385885</commentid>
    <comment_count>9</comment_count>
      <attachid>89609</attachid>
    <who name="Adrienne Walker">enne</who>
    <bug_when>2011-04-14 11:09:27 -0700</bug_when>
    <thetext>Created attachment 89609
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>385909</commentid>
    <comment_count>10</comment_count>
      <attachid>89609</attachid>
    <who name="Vincent Scheib">scheib</who>
    <bug_when>2011-04-14 11:30:32 -0700</bug_when>
    <thetext>Comment on attachment 89609
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=89609&amp;action=review

&gt; Source/WebCore/platform/graphics/gpu/TilingData.cpp:48
&gt; +        return totalSize &gt; 0 &amp;&amp; maxTextureSize == totalSize ? 1 : 0;

&gt;= totalSize

&gt; Source/WebKit/chromium/tests/TilingDataTest.cpp:110
&gt; +    EXPECT_EQ(1, TilingData(2,  2,  2, true).numTiles());

EXPECT_EQ(1, TilingData(2,  1,  1, true).numTiles());</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>385914</commentid>
    <comment_count>11</comment_count>
      <attachid>89614</attachid>
    <who name="Adrienne Walker">enne</who>
    <bug_when>2011-04-14 11:43:19 -0700</bug_when>
    <thetext>Created attachment 89614
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>385993</commentid>
    <comment_count>12</comment_count>
      <attachid>89614</attachid>
    <who name="Vincent Scheib">scheib</who>
    <bug_when>2011-04-14 13:25:31 -0700</bug_when>
    <thetext>Comment on attachment 89614
Patch

LGTM</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>385994</commentid>
    <comment_count>13</comment_count>
      <attachid>89614</attachid>
    <who name="James Robinson">jamesr</who>
    <bug_when>2011-04-14 13:26:52 -0700</bug_when>
    <thetext>Comment on attachment 89614
Patch

Works for me.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>386008</commentid>
    <comment_count>14</comment_count>
    <who name="Adrienne Walker">enne</who>
    <bug_when>2011-04-14 13:50:15 -0700</bug_when>
    <thetext>Committed r83891: &lt;http://trac.webkit.org/changeset/83891&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>89250</attachid>
            <date>2011-04-12 12:49:37 -0700</date>
            <delta_ts>2011-04-12 17:09:05 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-58364-20110412124936.patch</filename>
            <type>text/plain</type>
            <size>5169</size>
            <attacher name="Adrienne Walker">enne</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogODM2MTEKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No
YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCA4MTBkNmNmYjYwNTZlMDgw
NmYxYmM1OGVkNjA2NDI0OTFjZmY3ZGYyLi43MDYzMjFhYzgyYjg5Mzk3MDYxYmM0NmE0ZTM2MGU3
OTQ3MDQwODgzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291
cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTEtMDQtMTIgIEFkcmll
bm5lIFdhbGtlciAgPGVubmVAZ29vZ2xlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP
RFkgKE9PUFMhKS4KKworICAgICAgICBbY2hyb21pdW1dIFRpbGluZ0RhdGEgbWlzaGFuZGxlcyB2
ZXJ5IHNtYWxsIHRleHR1cmUgc2l6ZXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv
c2hvd19idWcuY2dpP2lkPTU4MzY0CisKKyAgICAgICAgSGFuZGxlIGVkZ2UgY2FzZXMgb2Ygc21h
bGwgdGV4dHVyZXMgKDEgb3IgMiBwaXhlbHMpIGJ5IGVuc3VyaW5nIGEKKyAgICAgICAgbWluaW11
bSB0ZXh0dXJlIHNpemUgb2YgMy4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2dwdS9U
aWxpbmdEYXRhLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlRpbGluZ0RhdGE6OlRpbGluZ0RhdGEp
OgorICAgICAgICAoV2ViQ29yZTo6VGlsaW5nRGF0YTo6c2V0TWF4VGV4dHVyZVNpemUpOgorCiAy
MDExLTA0LTExICBBYmhpc2hlayBBcnlhICA8aW5mZXJub0BjaHJvbWl1bS5vcmc+CiAKICAgICAg
ICAgUmV2aWV3ZWQgYnkgRGF2ZSBIeWF0dC4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3Bs
YXRmb3JtL2dyYXBoaWNzL2dwdS9UaWxpbmdEYXRhLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRm
b3JtL2dyYXBoaWNzL2dwdS9UaWxpbmdEYXRhLmNwcAppbmRleCAxMzcwNTQzY2Y1MDBjZDA2NDY5
YTg3YzkxMmUxYzFiZmE2ZTE2MWNjLi4zZjJjYmU1YjliNzg5ODRjMTRlNWEzN2IyNmQxNTJkMjU1
NGNiYmNjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9ncHUv
VGlsaW5nRGF0YS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3B1
L1RpbGluZ0RhdGEuY3BwCkBAIC00OSwxMiArNDksMTEgQEAgc3RhdGljIGludCBjb21wdXRlTnVt
VGlsZXMoaW50IG1heFRleHR1cmVTaXplLCBpbnQgdG90YWxTaXplLCBpbnQgYm9yZGVyVGV4ZWxz
KQogfQogCiBUaWxpbmdEYXRhOjpUaWxpbmdEYXRhKGludCBtYXhUZXh0dXJlU2l6ZSwgaW50IHRv
dGFsU2l6ZVgsIGludCB0b3RhbFNpemVZLCBib29sIGhhc0JvcmRlclRleGVscykKLSAgICA6IG1f
bWF4VGV4dHVyZVNpemUobWF4VGV4dHVyZVNpemUpCi0gICAgLCBtX3RvdGFsU2l6ZVgodG90YWxT
aXplWCkKKyAgICA6IG1fdG90YWxTaXplWCh0b3RhbFNpemVYKQogICAgICwgbV90b3RhbFNpemVZ
KHRvdGFsU2l6ZVkpCiAgICAgLCBtX2JvcmRlclRleGVscyhoYXNCb3JkZXJUZXhlbHMgPyAxIDog
MCkKIHsKLSAgICByZWNvbXB1dGVOdW1UaWxlcygpOworICAgIHNldE1heFRleHR1cmVTaXplKG1h
eFRleHR1cmVTaXplKTsKIH0KIAogdm9pZCBUaWxpbmdEYXRhOjpzZXRUb3RhbFNpemUoaW50IHRv
dGFsU2l6ZVgsIGludCB0b3RhbFNpemVZKQpAQCAtNjYsNyArNjUsOCBAQCB2b2lkIFRpbGluZ0Rh
dGE6OnNldFRvdGFsU2l6ZShpbnQgdG90YWxTaXplWCwgaW50IHRvdGFsU2l6ZVkpCiAKIHZvaWQg
VGlsaW5nRGF0YTo6c2V0TWF4VGV4dHVyZVNpemUoaW50IG1heFRleHR1cmVTaXplKQogewotICAg
IG1fbWF4VGV4dHVyZVNpemUgPSBtYXhUZXh0dXJlU2l6ZTsKKyAgICAvLyBEb24ndCBjcmVhdGUg
dmVyeSBzbWFsbCB0ZXh0dXJlcy4gVGhlcmUncyBubyByb29tIGZvciBib3JkZXJzLgorICAgIG1f
bWF4VGV4dHVyZVNpemUgPSBtYXgoMywgbWF4VGV4dHVyZVNpemUpOwogICAgIHJlY29tcHV0ZU51
bVRpbGVzKCk7CiB9CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdl
TG9nIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKaW5kZXggZmMwZWVlMzMwMzVh
ZjU0ZTJiMzQ1NTExNTJlODlmMTk0ODE1NDcwNC4uYmYyYzYzYmVhMTE4NjM2MzlmYjBhODlkZWQz
NjQxOGVhOTA4NWY3NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VM
b2cKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBA
QAorMjAxMS0wNC0xMiAgQWRyaWVubmUgV2Fsa2VyICA8ZW5uZUBnb29nbGUuY29tPgorCisgICAg
ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtjaHJvbWl1bV0gVGls
aW5nRGF0YSBtaXNoYW5kbGVzIHZlcnkgc21hbGwgdGV4dHVyZSBzaXplcworICAgICAgICBodHRw
czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTgzNjQKKworICAgICAgICBVcGRh
dGUgdGVzdCBmb3IgdGlsaW5nIHdpdGggcmVxdWVzdGVkIHRleHR1cmUgc2l6ZXMgb2YgMS0zLgor
ICAgICAgICBBbHNvIHVwZGF0ZSB0ZXh0IHRvIGhhbmRsZSBjYXNlcyB3aGVyZSAwIHRpbGVzIGFy
ZSBjcmVhdGVkLgorCisgICAgICAgICogdGVzdHMvVGlsaW5nRGF0YVRlc3QuY3BwOgorICAgICAg
ICAoV2ViQ29yZTo6VEVTVCk6CisKIDIwMTEtMDQtMTEgIFBhdmVsIFBvZGl2aWxvdiAgPHBvZGl2
aWxvdkBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgUGF2ZWwgRmVsZG1hbi4K
ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vdGVzdHMvVGlsaW5nRGF0YVRlc3Qu
Y3BwIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS90ZXN0cy9UaWxpbmdEYXRhVGVzdC5jcHAKaW5k
ZXggYTQxZjdmZTEzNzA3NGY3ZmMwNWYyMzQ0MWM2OTIxZmZjMDBmODU1ZC4uYjI4MWEyZThkNWM2
YzMzYzY4MTkwMzVlZGIxMGNmMDBjMmZlYTIzMSAxMDA3NTUKLS0tIGEvU291cmNlL1dlYktpdC9j
aHJvbWl1bS90ZXN0cy9UaWxpbmdEYXRhVGVzdC5jcHAKKysrIGIvU291cmNlL1dlYktpdC9jaHJv
bWl1bS90ZXN0cy9UaWxpbmdEYXRhVGVzdC5jcHAKQEAgLTQ5LDYgKzQ5LDE2IEBAIFRFU1QoVGls
aW5nRGF0YVRlc3QsIG51bVRpbGVzX05vVGlsaW5nKQogCiBURVNUKFRpbGluZ0RhdGFUZXN0LCBu
dW1UaWxlc19UaWxpbmdOb0JvcmRlcnMpCiB7CisgICAgRVhQRUNUX0VRKDAsIFRpbGluZ0RhdGEo
MCwgIDAsICAwLCBmYWxzZSkubnVtVGlsZXMoKSk7CisgICAgRVhQRUNUX0VRKDAsIFRpbGluZ0Rh
dGEoMCwgIDQsICAwLCBmYWxzZSkubnVtVGlsZXMoKSk7CisgICAgRVhQRUNUX0VRKDAsIFRpbGlu
Z0RhdGEoMCwgIDAsICA0LCBmYWxzZSkubnVtVGlsZXMoKSk7CisgICAgRVhQRUNUX0VRKDAsIFRp
bGluZ0RhdGEoNCwgIDQsICAwLCBmYWxzZSkubnVtVGlsZXMoKSk7CisgICAgRVhQRUNUX0VRKDAs
IFRpbGluZ0RhdGEoNCwgIDAsICA0LCBmYWxzZSkubnVtVGlsZXMoKSk7CisKKyAgICBFWFBFQ1Rf
RVEoMSwgVGlsaW5nRGF0YSgxLCAgMSwgIDEsIGZhbHNlKS5udW1UaWxlcygpKTsKKyAgICBFWFBF
Q1RfRVEoMSwgVGlsaW5nRGF0YSgyLCAgMiwgIDIsIGZhbHNlKS5udW1UaWxlcygpKTsKKyAgICBF
WFBFQ1RfRVEoMSwgVGlsaW5nRGF0YSgzLCAgMywgIDMsIGZhbHNlKS5udW1UaWxlcygpKTsKKwog
ICAgIEVYUEVDVF9FUSgxLCBUaWxpbmdEYXRhKDQsICAxLCAgNCwgZmFsc2UpLm51bVRpbGVzKCkp
OwogICAgIEVYUEVDVF9FUSgxLCBUaWxpbmdEYXRhKDQsICAyLCAgNCwgZmFsc2UpLm51bVRpbGVz
KCkpOwogICAgIEVYUEVDVF9FUSgxLCBUaWxpbmdEYXRhKDQsICAzLCAgNCwgZmFsc2UpLm51bVRp
bGVzKCkpOwpAQCAtODIsNiArOTIsMTYgQEAgVEVTVChUaWxpbmdEYXRhVGVzdCwgbnVtVGlsZXNf
VGlsaW5nTm9Cb3JkZXJzKQogCiBURVNUKFRpbGluZ0RhdGFUZXN0LCBudW1UaWxlc19UaWxpbmdX
aXRoQm9yZGVycykKIHsKKyAgICBFWFBFQ1RfRVEoMCwgVGlsaW5nRGF0YSgwLCAgMCwgIDAsIHRy
dWUpLm51bVRpbGVzKCkpOworICAgIEVYUEVDVF9FUSgwLCBUaWxpbmdEYXRhKDAsICA0LCAgMCwg
dHJ1ZSkubnVtVGlsZXMoKSk7CisgICAgRVhQRUNUX0VRKDAsIFRpbGluZ0RhdGEoMCwgIDAsICA0
LCB0cnVlKS5udW1UaWxlcygpKTsKKyAgICBFWFBFQ1RfRVEoMCwgVGlsaW5nRGF0YSg0LCAgNCwg
IDAsIHRydWUpLm51bVRpbGVzKCkpOworICAgIEVYUEVDVF9FUSgwLCBUaWxpbmdEYXRhKDQsICAw
LCAgNCwgdHJ1ZSkubnVtVGlsZXMoKSk7CisKKyAgICBFWFBFQ1RfRVEoMSwgVGlsaW5nRGF0YSgx
LCAgMSwgIDEsIHRydWUpLm51bVRpbGVzKCkpOworICAgIEVYUEVDVF9FUSgxLCBUaWxpbmdEYXRh
KDIsICAyLCAgMiwgdHJ1ZSkubnVtVGlsZXMoKSk7CisgICAgRVhQRUNUX0VRKDEsIFRpbGluZ0Rh
dGEoMywgIDMsICAzLCB0cnVlKS5udW1UaWxlcygpKTsKKwogICAgIEVYUEVDVF9FUSgxLCBUaWxp
bmdEYXRhKDMsICAxLCAgMywgdHJ1ZSkubnVtVGlsZXMoKSk7CiAgICAgRVhQRUNUX0VRKDEsIFRp
bGluZ0RhdGEoMywgIDIsICAzLCB0cnVlKS5udW1UaWxlcygpKTsKICAgICBFWFBFQ1RfRVEoMSwg
VGlsaW5nRGF0YSgzLCAgMywgIDMsIHRydWUpLm51bVRpbGVzKCkpOwpAQCAtMzcyLDEwICszOTIs
MTAgQEAgVEVTVChUaWxpbmdEYXRhVGVzdCwgc2V0TWF4VGV4dHVyZVNpemUpCiAgICAgRVhQRUNU
X0VRKDEsIGRhdGEubnVtVGlsZXNYKCkpOwogICAgIEVYUEVDVF9FUSgxLCBkYXRhLm51bVRpbGVz
WSgpKTsKIAotICAgIGRhdGEuc2V0TWF4VGV4dHVyZVNpemUoMik7Ci0gICAgRVhQRUNUX0VRKDIs
IGRhdGEubWF4VGV4dHVyZVNpemUoKSk7Ci0gICAgRVhQRUNUX0VRKDgsIGRhdGEubnVtVGlsZXNY
KCkpOwotICAgIEVYUEVDVF9FUSgxNiwgZGF0YS5udW1UaWxlc1koKSk7CisgICAgZGF0YS5zZXRN
YXhUZXh0dXJlU2l6ZSg0KTsKKyAgICBFWFBFQ1RfRVEoNCwgZGF0YS5tYXhUZXh0dXJlU2l6ZSgp
KTsKKyAgICBFWFBFQ1RfRVEoNCwgZGF0YS5udW1UaWxlc1goKSk7CisgICAgRVhQRUNUX0VRKDgs
IGRhdGEubnVtVGlsZXNZKCkpOwogCiAgICAgZGF0YS5zZXRNYXhUZXh0dXJlU2l6ZSg1KTsKICAg
ICBFWFBFQ1RfRVEoNSwgZGF0YS5tYXhUZXh0dXJlU2l6ZSgpKTsK
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>89310</attachid>
            <date>2011-04-12 17:09:07 -0700</date>
            <delta_ts>2011-04-14 11:09:24 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-58364-20110412170906.patch</filename>
            <type>text/plain</type>
            <size>5460</size>
            <attacher name="Adrienne Walker">enne</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogODM2MTEKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No
YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCA4MTBkNmNmYjYwNTZlMDgw
NmYxYmM1OGVkNjA2NDI0OTFjZmY3ZGYyLi5lODk3MTJlYTJmODM2MjNiNDJkYWJiNzg1NjExZmUy
MWU0OWQ1MGJkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291
cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTEtMDQtMTIgIEFkcmll
bm5lIFdhbGtlciAgPGVubmVAZ29vZ2xlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP
RFkgKE9PUFMhKS4KKworICAgICAgICBbY2hyb21pdW1dIFRpbGluZ0RhdGEgbWlzaGFuZGxlcyB2
ZXJ5IHNtYWxsIHRleHR1cmUgc2l6ZXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv
c2hvd19idWcuY2dpP2lkPTU4MzY0CisKKyAgICAgICAgVXNlIHplcm8gdGlsZXMgd2hlbiB0aGUg
dGV4dHVyZSBzaXplIGlzIHRvbyBzbWFsbCBmb3IgdGlsaW5nLgorCisgICAgICAgICogcGxhdGZv
cm0vZ3JhcGhpY3MvZ3B1L1RpbGluZ0RhdGEuY3BwOgorICAgICAgICAoV2ViQ29yZTo6VGlsaW5n
RGF0YTo6VGlsaW5nRGF0YSk6CisgICAgICAgIChXZWJDb3JlOjpUaWxpbmdEYXRhOjpzZXRNYXhU
ZXh0dXJlU2l6ZSk6CisKIDIwMTEtMDQtMTEgIEFiaGlzaGVrIEFyeWEgIDxpbmZlcm5vQGNocm9t
aXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBEYXZlIEh5YXR0LgpkaWZmIC0tZ2l0IGEv
U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3B1L1RpbGluZ0RhdGEuY3BwIGIvU291
cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3B1L1RpbGluZ0RhdGEuY3BwCmluZGV4IDEz
NzA1NDNjZjUwMGNkMDY0NjlhODdjOTEyZTFjMWJmYTZlMTYxY2MuLmExZmMyOTc4MTUyZGNjMzI0
ZjZkZTY2YzAzZWNiODc2MjBlYTM0NWIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRm
b3JtL2dyYXBoaWNzL2dwdS9UaWxpbmdEYXRhLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0
Zm9ybS9ncmFwaGljcy9ncHUvVGlsaW5nRGF0YS5jcHAKQEAgLTQ0LDYgKzQ0LDkgQEAgbmFtZXNw
YWNlIFdlYkNvcmUgewogCiBzdGF0aWMgaW50IGNvbXB1dGVOdW1UaWxlcyhpbnQgbWF4VGV4dHVy
ZVNpemUsIGludCB0b3RhbFNpemUsIGludCBib3JkZXJUZXhlbHMpCiB7CisgICAgaWYgKG1heFRl
eHR1cmVTaXplIC0gMiAqIGJvcmRlclRleGVscyA8PSAwKQorICAgICAgICByZXR1cm4gMDsKKwog
ICAgIGludCBudW1UaWxlcyA9IG1heCgxLCAxICsgKHRvdGFsU2l6ZSAtIDEgLSAyICogYm9yZGVy
VGV4ZWxzKSAvIChtYXhUZXh0dXJlU2l6ZSAtIDIgKiBib3JkZXJUZXhlbHMpKTsKICAgICByZXR1
cm4gdG90YWxTaXplID4gMCA/IG51bVRpbGVzIDogMDsKIH0KZGlmZiAtLWdpdCBhL1NvdXJjZS9X
ZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VM
b2cKaW5kZXggZmMwZWVlMzMwMzVhZjU0ZTJiMzQ1NTExNTJlODlmMTk0ODE1NDcwNC4uNzNkYzJj
YjhkYjI1NWQxY2I2MjZlYzZiMmVlYzIwOTRmZmE5MWJkMiAxMDA2NDQKLS0tIGEvU291cmNlL1dl
YktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFu
Z2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxMS0wNC0xMiAgQWRyaWVubmUgV2Fsa2VyICA8ZW5u
ZUBnb29nbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg
ICAgICAgIFtjaHJvbWl1bV0gVGlsaW5nRGF0YSBtaXNoYW5kbGVzIHZlcnkgc21hbGwgdGV4dHVy
ZSBzaXplcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9
NTgzNjQKKworICAgICAgICBVcGRhdGUgdGVzdCB0byBwcm9wZXJseSBoYW5kbGUgdGV4dHVyZSBz
aXplcyBvZiAwLTMuCisKKyAgICAgICAgKiB0ZXN0cy9UaWxpbmdEYXRhVGVzdC5jcHA6CisgICAg
ICAgIChXZWJDb3JlOjpURVNUKToKKwogMjAxMS0wNC0xMSAgUGF2ZWwgUG9kaXZpbG92ICA8cG9k
aXZpbG92QGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBQYXZlbCBGZWxkbWFu
LgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS90ZXN0cy9UaWxpbmdEYXRhVGVz
dC5jcHAgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3Rlc3RzL1RpbGluZ0RhdGFUZXN0LmNwcApp
bmRleCBhNDFmN2ZlMTM3MDc0ZjdmYzA1ZjIzNDQxYzY5MjFmZmMwMGY4NTVkLi5mMTJiMWNlNTM1
M2JlNjc4MjFjZDg3ZjI4NmVkYzZiNDRmNDBhNjlhIDEwMDc1NQotLS0gYS9Tb3VyY2UvV2ViS2l0
L2Nocm9taXVtL3Rlc3RzL1RpbGluZ0RhdGFUZXN0LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L2No
cm9taXVtL3Rlc3RzL1RpbGluZ0RhdGFUZXN0LmNwcApAQCAtNDksNiArNDksMjAgQEAgVEVTVChU
aWxpbmdEYXRhVGVzdCwgbnVtVGlsZXNfTm9UaWxpbmcpCiAKIFRFU1QoVGlsaW5nRGF0YVRlc3Qs
IG51bVRpbGVzX1RpbGluZ05vQm9yZGVycykKIHsKKyAgICBFWFBFQ1RfRVEoMCwgVGlsaW5nRGF0
YSgwLCAgMCwgIDAsIGZhbHNlKS5udW1UaWxlcygpKTsKKyAgICBFWFBFQ1RfRVEoMCwgVGlsaW5n
RGF0YSgwLCAgNCwgIDAsIGZhbHNlKS5udW1UaWxlcygpKTsKKyAgICBFWFBFQ1RfRVEoMCwgVGls
aW5nRGF0YSgwLCAgMCwgIDQsIGZhbHNlKS5udW1UaWxlcygpKTsKKyAgICBFWFBFQ1RfRVEoMCwg
VGlsaW5nRGF0YSg0LCAgNCwgIDAsIGZhbHNlKS5udW1UaWxlcygpKTsKKyAgICBFWFBFQ1RfRVEo
MCwgVGlsaW5nRGF0YSg0LCAgMCwgIDQsIGZhbHNlKS5udW1UaWxlcygpKTsKKyAgICBFWFBFQ1Rf
RVEoMCwgVGlsaW5nRGF0YSgtOCwgMSwgIDEsIGZhbHNlKS5udW1UaWxlcygpKTsKKyAgICBFWFBF
Q1RfRVEoMCwgVGlsaW5nRGF0YSgtMSwgMSwgIDEsIGZhbHNlKS5udW1UaWxlcygpKTsKKyAgICBF
WFBFQ1RfRVEoMCwgVGlsaW5nRGF0YSgwLCAgMSwgIDEsIGZhbHNlKS5udW1UaWxlcygpKTsKKwor
ICAgIEVYUEVDVF9FUSgxLCBUaWxpbmdEYXRhKDEsICAxLCAgMSwgZmFsc2UpLm51bVRpbGVzKCkp
OworICAgIEVYUEVDVF9FUSgyLCBUaWxpbmdEYXRhKDEsICAxLCAgMiwgZmFsc2UpLm51bVRpbGVz
KCkpOworICAgIEVYUEVDVF9FUSgxLCBUaWxpbmdEYXRhKDIsICAyLCAgMiwgZmFsc2UpLm51bVRp
bGVzKCkpOworICAgIEVYUEVDVF9FUSgxLCBUaWxpbmdEYXRhKDMsICAzLCAgMywgZmFsc2UpLm51
bVRpbGVzKCkpOworCiAgICAgRVhQRUNUX0VRKDEsIFRpbGluZ0RhdGEoNCwgIDEsICA0LCBmYWxz
ZSkubnVtVGlsZXMoKSk7CiAgICAgRVhQRUNUX0VRKDEsIFRpbGluZ0RhdGEoNCwgIDIsICA0LCBm
YWxzZSkubnVtVGlsZXMoKSk7CiAgICAgRVhQRUNUX0VRKDEsIFRpbGluZ0RhdGEoNCwgIDMsICA0
LCBmYWxzZSkubnVtVGlsZXMoKSk7CkBAIC04Miw2ICs5NiwxOSBAQCBURVNUKFRpbGluZ0RhdGFU
ZXN0LCBudW1UaWxlc19UaWxpbmdOb0JvcmRlcnMpCiAKIFRFU1QoVGlsaW5nRGF0YVRlc3QsIG51
bVRpbGVzX1RpbGluZ1dpdGhCb3JkZXJzKQogeworICAgIEVYUEVDVF9FUSgwLCBUaWxpbmdEYXRh
KDAsICAwLCAgMCwgdHJ1ZSkubnVtVGlsZXMoKSk7CisgICAgRVhQRUNUX0VRKDAsIFRpbGluZ0Rh
dGEoMCwgIDQsICAwLCB0cnVlKS5udW1UaWxlcygpKTsKKyAgICBFWFBFQ1RfRVEoMCwgVGlsaW5n
RGF0YSgwLCAgMCwgIDQsIHRydWUpLm51bVRpbGVzKCkpOworICAgIEVYUEVDVF9FUSgwLCBUaWxp
bmdEYXRhKDQsICA0LCAgMCwgdHJ1ZSkubnVtVGlsZXMoKSk7CisgICAgRVhQRUNUX0VRKDAsIFRp
bGluZ0RhdGEoNCwgIDAsICA0LCB0cnVlKS5udW1UaWxlcygpKTsKKyAgICBFWFBFQ1RfRVEoMCwg
VGlsaW5nRGF0YSgtOCwgMSwgIDEsIHRydWUpLm51bVRpbGVzKCkpOworICAgIEVYUEVDVF9FUSgw
LCBUaWxpbmdEYXRhKC0xLCAxLCAgMSwgdHJ1ZSkubnVtVGlsZXMoKSk7CisgICAgRVhQRUNUX0VR
KDAsIFRpbGluZ0RhdGEoMCwgIDEsICAxLCB0cnVlKS5udW1UaWxlcygpKTsKKworICAgIEVYUEVD
VF9FUSgwLCBUaWxpbmdEYXRhKDEsICAxLCAgMSwgdHJ1ZSkubnVtVGlsZXMoKSk7CisgICAgRVhQ
RUNUX0VRKDAsIFRpbGluZ0RhdGEoMSwgIDEsICAyLCB0cnVlKS5udW1UaWxlcygpKTsKKyAgICBF
WFBFQ1RfRVEoMCwgVGlsaW5nRGF0YSgyLCAgMiwgIDIsIHRydWUpLm51bVRpbGVzKCkpOworCiAg
ICAgRVhQRUNUX0VRKDEsIFRpbGluZ0RhdGEoMywgIDEsICAzLCB0cnVlKS5udW1UaWxlcygpKTsK
ICAgICBFWFBFQ1RfRVEoMSwgVGlsaW5nRGF0YSgzLCAgMiwgIDMsIHRydWUpLm51bVRpbGVzKCkp
OwogICAgIEVYUEVDVF9FUSgxLCBUaWxpbmdEYXRhKDMsICAzLCAgMywgdHJ1ZSkubnVtVGlsZXMo
KSk7CkBAIC0zNjEsNyArMzg4LDcgQEAgVEVTVChUaWxpbmdEYXRhVGVzdCwgc2V0VG90YWxTaXpl
KQogICAgIEVYUEVDVF9FUSgyLCBkYXRhLnRpbGVTaXplWSgyKSk7CiB9CiAKLVRFU1QoVGlsaW5n
RGF0YVRlc3QsIHNldE1heFRleHR1cmVTaXplKQorVEVTVChUaWxpbmdEYXRhVGVzdCwgc2V0TWF4
VGV4dHVyZVNpemVOb0JvcmRlcnMpCiB7CiAgICAgVGlsaW5nRGF0YSBkYXRhKDgsIDE2LCAzMiwg
ZmFsc2UpOwogICAgIEVYUEVDVF9FUSgyLCBkYXRhLm51bVRpbGVzWCgpKTsKQEAgLTM4Myw0ICs0
MTAsMjYgQEAgVEVTVChUaWxpbmdEYXRhVGVzdCwgc2V0TWF4VGV4dHVyZVNpemUpCiAgICAgRVhQ
RUNUX0VRKDcsIGRhdGEubnVtVGlsZXNZKCkpOwogfQogCitURVNUKFRpbGluZ0RhdGFUZXN0LCBz
ZXRNYXhUZXh0dXJlU2l6ZUJvcmRlcnMpCit7CisgICAgVGlsaW5nRGF0YSBkYXRhKDgsIDE2LCAz
MiwgdHJ1ZSk7CisgICAgRVhQRUNUX0VRKDMsIGRhdGEubnVtVGlsZXNYKCkpOworICAgIEVYUEVD
VF9FUSg1LCBkYXRhLm51bVRpbGVzWSgpKTsKKworICAgIGRhdGEuc2V0TWF4VGV4dHVyZVNpemUo
MzIpOworICAgIEVYUEVDVF9FUSgzMiwgZGF0YS5tYXhUZXh0dXJlU2l6ZSgpKTsKKyAgICBFWFBF
Q1RfRVEoMSwgZGF0YS5udW1UaWxlc1goKSk7CisgICAgRVhQRUNUX0VRKDEsIGRhdGEubnVtVGls
ZXNZKCkpOworCisgICAgZGF0YS5zZXRNYXhUZXh0dXJlU2l6ZSgyKTsKKyAgICBFWFBFQ1RfRVEo
MiwgZGF0YS5tYXhUZXh0dXJlU2l6ZSgpKTsKKyAgICBFWFBFQ1RfRVEoMCwgZGF0YS5udW1UaWxl
c1goKSk7CisgICAgRVhQRUNUX0VRKDAsIGRhdGEubnVtVGlsZXNZKCkpOworCisgICAgZGF0YS5z
ZXRNYXhUZXh0dXJlU2l6ZSg1KTsKKyAgICBFWFBFQ1RfRVEoNSwgZGF0YS5tYXhUZXh0dXJlU2l6
ZSgpKTsKKyAgICBFWFBFQ1RfRVEoNSwgZGF0YS5udW1UaWxlc1goKSk7CisgICAgRVhQRUNUX0VR
KDEwLCBkYXRhLm51bVRpbGVzWSgpKTsKK30KKwogfSAvLyBuYW1lc3BhY2UK
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>89609</attachid>
            <date>2011-04-14 11:09:27 -0700</date>
            <delta_ts>2011-04-14 11:43:17 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-58364-20110414110926.patch</filename>
            <type>text/plain</type>
            <size>3067</size>
            <attacher name="Adrienne Walker">enne</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogODM4NjkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No
YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBkY2M5MzE3OTc2MjBlMjhj
NzllODM4Mjg3MGM2MjExMjYzYjU5MzMzLi5jYmRlYzYxMGJmZGY3ZjE0YjdkYWNjYjU1NmI2NTk5
ZDIyZDFiYzNhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291
cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTEtMDQtMTQgIEFkcmll
bm5lIFdhbGtlciAgPGVubmVAZ29vZ2xlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP
RFkgKE9PUFMhKS4KKworICAgICAgICBbY2hyb21pdW1dIFRpbGluZ0RhdGEgc2hvdWxkIHJldHVy
biAxIHRpbGUgd2hlbiB0aWxlIHNpemUgaXMgdGV4dHVyZSBzaXplLgorICAgICAgICBodHRwczov
L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTgzNjQKKworICAgICAgICAqIHBsYXRm
b3JtL2dyYXBoaWNzL2dwdS9UaWxpbmdEYXRhLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OmNvbXB1
dGVOdW1UaWxlcyk6CisKIDIwMTEtMDQtMTQgIEtldmluIE9sbGl2aWVyICA8a2V2aW5vQHRoZW9s
bGl2aWVycy5jb20+CiAKICAgICAgICAgW3d4XSBVbnJldmlld2VkIGJ1aWxkIGZpeGVzIGZvciB3
eE1TVyBhbmQgd3ggMi45LjEuMS4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt
L2dyYXBoaWNzL2dwdS9UaWxpbmdEYXRhLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dy
YXBoaWNzL2dwdS9UaWxpbmdEYXRhLmNwcAppbmRleCBhMWZjMjk3ODE1MmRjYzMyNGY2ZGU2NmMw
M2VjYjg3NjIwZWEzNDViLi4yYTkzOWQwMTVkNTJkMWM0OGM0YTc5NDk3YWE0NTlhMTQ5OGEwZDMz
IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9ncHUvVGlsaW5n
RGF0YS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3B1L1RpbGlu
Z0RhdGEuY3BwCkBAIC00NSw3ICs0NSw3IEBAIG5hbWVzcGFjZSBXZWJDb3JlIHsKIHN0YXRpYyBp
bnQgY29tcHV0ZU51bVRpbGVzKGludCBtYXhUZXh0dXJlU2l6ZSwgaW50IHRvdGFsU2l6ZSwgaW50
IGJvcmRlclRleGVscykKIHsKICAgICBpZiAobWF4VGV4dHVyZVNpemUgLSAyICogYm9yZGVyVGV4
ZWxzIDw9IDApCi0gICAgICAgIHJldHVybiAwOworICAgICAgICByZXR1cm4gdG90YWxTaXplID4g
MCAmJiBtYXhUZXh0dXJlU2l6ZSA9PSB0b3RhbFNpemUgPyAxIDogMDsKIAogICAgIGludCBudW1U
aWxlcyA9IG1heCgxLCAxICsgKHRvdGFsU2l6ZSAtIDEgLSAyICogYm9yZGVyVGV4ZWxzKSAvICht
YXhUZXh0dXJlU2l6ZSAtIDIgKiBib3JkZXJUZXhlbHMpKTsKICAgICByZXR1cm4gdG90YWxTaXpl
ID4gMCA/IG51bVRpbGVzIDogMDsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0v
Q2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKaW5kZXggZjJmNzE5
NTJkYmIzNDhhMTM2OTVmZWZjYTg5ZTlhNGVjNDE4MjNmNC4uYWFjZmUxN2UwMTMwNWQ4ODkwZWJi
Y2IxMzI3YzQ3ZDQwZjM3NDdhMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9D
aGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKQEAgLTEsMyAr
MSwxNSBAQAorMjAxMS0wNC0xNCAgQWRyaWVubmUgV2Fsa2VyICA8ZW5uZUBnb29nbGUuY29tPgor
CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtjaHJvbWl1
bV0gVGlsaW5nRGF0YSBzaG91bGQgcmV0dXJuIDEgdGlsZSBpZiB0aWxlIHNpemUgaXMgdGV4dHVy
ZSBzaXplLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9
NTgzNjQKKworICAgICAgICBVcGRhdGUgdGVzdCB0byBwcm9wZXJseSBoYW5kbGUgdGhpcyBjYXNl
LgorCisgICAgICAgICogdGVzdHMvVGlsaW5nRGF0YVRlc3QuY3BwOgorICAgICAgICAoV2ViQ29y
ZTo6VEVTVCk6CisKIDIwMTEtMDQtMTQgIEJpbGwgQnVkZ2UgIDxiYnVkZ2VAY2hyb21pdW0ub3Jn
PgogCiAgICAgICAgIFJldmlld2VkIGJ5IERhcmluIEZpc2hlci4KZGlmZiAtLWdpdCBhL1NvdXJj
ZS9XZWJLaXQvY2hyb21pdW0vdGVzdHMvVGlsaW5nRGF0YVRlc3QuY3BwIGIvU291cmNlL1dlYktp
dC9jaHJvbWl1bS90ZXN0cy9UaWxpbmdEYXRhVGVzdC5jcHAKaW5kZXggZjEyYjFjZTUzNTNiZTY3
ODIxY2Q4N2YyODZlZGM2YjQ0ZjQwYTY5YS4uNjA5MmFkNDJhZmI3ZWU1MDFkNjEwYWZkN2RjMzcz
NzcyOWNhYWZiMCAxMDA3NTUKLS0tIGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS90ZXN0cy9UaWxp
bmdEYXRhVGVzdC5jcHAKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS90ZXN0cy9UaWxpbmdE
YXRhVGVzdC5jcHAKQEAgLTEwNSw5ICsxMDUsOSBAQCBURVNUKFRpbGluZ0RhdGFUZXN0LCBudW1U
aWxlc19UaWxpbmdXaXRoQm9yZGVycykKICAgICBFWFBFQ1RfRVEoMCwgVGlsaW5nRGF0YSgtMSwg
MSwgIDEsIHRydWUpLm51bVRpbGVzKCkpOwogICAgIEVYUEVDVF9FUSgwLCBUaWxpbmdEYXRhKDAs
ICAxLCAgMSwgdHJ1ZSkubnVtVGlsZXMoKSk7CiAKLSAgICBFWFBFQ1RfRVEoMCwgVGlsaW5nRGF0
YSgxLCAgMSwgIDEsIHRydWUpLm51bVRpbGVzKCkpOworICAgIEVYUEVDVF9FUSgxLCBUaWxpbmdE
YXRhKDEsICAxLCAgMSwgdHJ1ZSkubnVtVGlsZXMoKSk7CiAgICAgRVhQRUNUX0VRKDAsIFRpbGlu
Z0RhdGEoMSwgIDEsICAyLCB0cnVlKS5udW1UaWxlcygpKTsKLSAgICBFWFBFQ1RfRVEoMCwgVGls
aW5nRGF0YSgyLCAgMiwgIDIsIHRydWUpLm51bVRpbGVzKCkpOworICAgIEVYUEVDVF9FUSgxLCBU
aWxpbmdEYXRhKDIsICAyLCAgMiwgdHJ1ZSkubnVtVGlsZXMoKSk7CiAKICAgICBFWFBFQ1RfRVEo
MSwgVGlsaW5nRGF0YSgzLCAgMSwgIDMsIHRydWUpLm51bVRpbGVzKCkpOwogICAgIEVYUEVDVF9F
USgxLCBUaWxpbmdEYXRhKDMsICAyLCAgMywgdHJ1ZSkubnVtVGlsZXMoKSk7Cg==
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>89614</attachid>
            <date>2011-04-14 11:43:19 -0700</date>
            <delta_ts>2011-04-14 13:26:51 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-58364-20110414114318.patch</filename>
            <type>text/plain</type>
            <size>3854</size>
            <attacher name="Adrienne Walker">enne</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogODM4NjkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No
YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBkY2M5MzE3OTc2MjBlMjhj
NzllODM4Mjg3MGM2MjExMjYzYjU5MzMzLi5jYmRlYzYxMGJmZGY3ZjE0YjdkYWNjYjU1NmI2NTk5
ZDIyZDFiYzNhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291
cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTEtMDQtMTQgIEFkcmll
bm5lIFdhbGtlciAgPGVubmVAZ29vZ2xlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP
RFkgKE9PUFMhKS4KKworICAgICAgICBbY2hyb21pdW1dIFRpbGluZ0RhdGEgc2hvdWxkIHJldHVy
biAxIHRpbGUgd2hlbiB0aWxlIHNpemUgaXMgdGV4dHVyZSBzaXplLgorICAgICAgICBodHRwczov
L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTgzNjQKKworICAgICAgICAqIHBsYXRm
b3JtL2dyYXBoaWNzL2dwdS9UaWxpbmdEYXRhLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OmNvbXB1
dGVOdW1UaWxlcyk6CisKIDIwMTEtMDQtMTQgIEtldmluIE9sbGl2aWVyICA8a2V2aW5vQHRoZW9s
bGl2aWVycy5jb20+CiAKICAgICAgICAgW3d4XSBVbnJldmlld2VkIGJ1aWxkIGZpeGVzIGZvciB3
eE1TVyBhbmQgd3ggMi45LjEuMS4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt
L2dyYXBoaWNzL2dwdS9UaWxpbmdEYXRhLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dy
YXBoaWNzL2dwdS9UaWxpbmdEYXRhLmNwcAppbmRleCBhMWZjMjk3ODE1MmRjYzMyNGY2ZGU2NmMw
M2VjYjg3NjIwZWEzNDViLi4yNDE1ZWU0NmQ3ZGRmZWFjZjQ3ZTlhZGFiZWNkZTAzNjk2NjQ1OTc2
IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9ncHUvVGlsaW5n
RGF0YS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3B1L1RpbGlu
Z0RhdGEuY3BwCkBAIC00NSw3ICs0NSw3IEBAIG5hbWVzcGFjZSBXZWJDb3JlIHsKIHN0YXRpYyBp
bnQgY29tcHV0ZU51bVRpbGVzKGludCBtYXhUZXh0dXJlU2l6ZSwgaW50IHRvdGFsU2l6ZSwgaW50
IGJvcmRlclRleGVscykKIHsKICAgICBpZiAobWF4VGV4dHVyZVNpemUgLSAyICogYm9yZGVyVGV4
ZWxzIDw9IDApCi0gICAgICAgIHJldHVybiAwOworICAgICAgICByZXR1cm4gdG90YWxTaXplID4g
MCAmJiBtYXhUZXh0dXJlU2l6ZSA+PSB0b3RhbFNpemUgPyAxIDogMDsKIAogICAgIGludCBudW1U
aWxlcyA9IG1heCgxLCAxICsgKHRvdGFsU2l6ZSAtIDEgLSAyICogYm9yZGVyVGV4ZWxzKSAvICht
YXhUZXh0dXJlU2l6ZSAtIDIgKiBib3JkZXJUZXhlbHMpKTsKICAgICByZXR1cm4gdG90YWxTaXpl
ID4gMCA/IG51bVRpbGVzIDogMDsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0v
Q2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKaW5kZXggZjJmNzE5
NTJkYmIzNDhhMTM2OTVmZWZjYTg5ZTlhNGVjNDE4MjNmNC4uYWFjZmUxN2UwMTMwNWQ4ODkwZWJi
Y2IxMzI3YzQ3ZDQwZjM3NDdhMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9D
aGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKQEAgLTEsMyAr
MSwxNSBAQAorMjAxMS0wNC0xNCAgQWRyaWVubmUgV2Fsa2VyICA8ZW5uZUBnb29nbGUuY29tPgor
CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtjaHJvbWl1
bV0gVGlsaW5nRGF0YSBzaG91bGQgcmV0dXJuIDEgdGlsZSBpZiB0aWxlIHNpemUgaXMgdGV4dHVy
ZSBzaXplLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9
NTgzNjQKKworICAgICAgICBVcGRhdGUgdGVzdCB0byBwcm9wZXJseSBoYW5kbGUgdGhpcyBjYXNl
LgorCisgICAgICAgICogdGVzdHMvVGlsaW5nRGF0YVRlc3QuY3BwOgorICAgICAgICAoV2ViQ29y
ZTo6VEVTVCk6CisKIDIwMTEtMDQtMTQgIEJpbGwgQnVkZ2UgIDxiYnVkZ2VAY2hyb21pdW0ub3Jn
PgogCiAgICAgICAgIFJldmlld2VkIGJ5IERhcmluIEZpc2hlci4KZGlmZiAtLWdpdCBhL1NvdXJj
ZS9XZWJLaXQvY2hyb21pdW0vdGVzdHMvVGlsaW5nRGF0YVRlc3QuY3BwIGIvU291cmNlL1dlYktp
dC9jaHJvbWl1bS90ZXN0cy9UaWxpbmdEYXRhVGVzdC5jcHAKaW5kZXggZjEyYjFjZTUzNTNiZTY3
ODIxY2Q4N2YyODZlZGM2YjQ0ZjQwYTY5YS4uNzU3M2RjN2Y3MmZhZjgxZTIxNTM0MzM0OTIyZjUy
MTJlZDUwMjE5OCAxMDA3NTUKLS0tIGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS90ZXN0cy9UaWxp
bmdEYXRhVGVzdC5jcHAKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS90ZXN0cy9UaWxpbmdE
YXRhVGVzdC5jcHAKQEAgLTYwLDYgKzYwLDEwIEBAIFRFU1QoVGlsaW5nRGF0YVRlc3QsIG51bVRp
bGVzX1RpbGluZ05vQm9yZGVycykKIAogICAgIEVYUEVDVF9FUSgxLCBUaWxpbmdEYXRhKDEsICAx
LCAgMSwgZmFsc2UpLm51bVRpbGVzKCkpOwogICAgIEVYUEVDVF9FUSgyLCBUaWxpbmdEYXRhKDEs
ICAxLCAgMiwgZmFsc2UpLm51bVRpbGVzKCkpOworICAgIEVYUEVDVF9FUSgyLCBUaWxpbmdEYXRh
KDEsICAyLCAgMSwgZmFsc2UpLm51bVRpbGVzKCkpOworICAgIEVYUEVDVF9FUSgxLCBUaWxpbmdE
YXRhKDIsICAxLCAgMSwgZmFsc2UpLm51bVRpbGVzKCkpOworICAgIEVYUEVDVF9FUSgxLCBUaWxp
bmdEYXRhKDIsICAxLCAgMiwgZmFsc2UpLm51bVRpbGVzKCkpOworICAgIEVYUEVDVF9FUSgxLCBU
aWxpbmdEYXRhKDIsICAyLCAgMSwgZmFsc2UpLm51bVRpbGVzKCkpOwogICAgIEVYUEVDVF9FUSgx
LCBUaWxpbmdEYXRhKDIsICAyLCAgMiwgZmFsc2UpLm51bVRpbGVzKCkpOwogICAgIEVYUEVDVF9F
USgxLCBUaWxpbmdEYXRhKDMsICAzLCAgMywgZmFsc2UpLm51bVRpbGVzKCkpOwogCkBAIC0xMDUs
OSArMTA5LDEzIEBAIFRFU1QoVGlsaW5nRGF0YVRlc3QsIG51bVRpbGVzX1RpbGluZ1dpdGhCb3Jk
ZXJzKQogICAgIEVYUEVDVF9FUSgwLCBUaWxpbmdEYXRhKC0xLCAxLCAgMSwgdHJ1ZSkubnVtVGls
ZXMoKSk7CiAgICAgRVhQRUNUX0VRKDAsIFRpbGluZ0RhdGEoMCwgIDEsICAxLCB0cnVlKS5udW1U
aWxlcygpKTsKIAotICAgIEVYUEVDVF9FUSgwLCBUaWxpbmdEYXRhKDEsICAxLCAgMSwgdHJ1ZSku
bnVtVGlsZXMoKSk7CisgICAgRVhQRUNUX0VRKDEsIFRpbGluZ0RhdGEoMSwgIDEsICAxLCB0cnVl
KS5udW1UaWxlcygpKTsKICAgICBFWFBFQ1RfRVEoMCwgVGlsaW5nRGF0YSgxLCAgMSwgIDIsIHRy
dWUpLm51bVRpbGVzKCkpOwotICAgIEVYUEVDVF9FUSgwLCBUaWxpbmdEYXRhKDIsICAyLCAgMiwg
dHJ1ZSkubnVtVGlsZXMoKSk7CisgICAgRVhQRUNUX0VRKDAsIFRpbGluZ0RhdGEoMSwgIDIsICAx
LCB0cnVlKS5udW1UaWxlcygpKTsKKyAgICBFWFBFQ1RfRVEoMSwgVGlsaW5nRGF0YSgyLCAgMSwg
IDEsIHRydWUpLm51bVRpbGVzKCkpOworICAgIEVYUEVDVF9FUSgxLCBUaWxpbmdEYXRhKDIsICAx
LCAgMiwgdHJ1ZSkubnVtVGlsZXMoKSk7CisgICAgRVhQRUNUX0VRKDEsIFRpbGluZ0RhdGEoMiwg
IDIsICAxLCB0cnVlKS5udW1UaWxlcygpKTsKKyAgICBFWFBFQ1RfRVEoMSwgVGlsaW5nRGF0YSgy
LCAgMiwgIDIsIHRydWUpLm51bVRpbGVzKCkpOwogCiAgICAgRVhQRUNUX0VRKDEsIFRpbGluZ0Rh
dGEoMywgIDEsICAzLCB0cnVlKS5udW1UaWxlcygpKTsKICAgICBFWFBFQ1RfRVEoMSwgVGlsaW5n
RGF0YSgzLCAgMiwgIDMsIHRydWUpLm51bVRpbGVzKCkpOwo=
</data>
<flag name="review"
          id="82321"
          type_id="1"
          status="+"
          setter="jamesr"
    />
          </attachment>
      

    </bug>

</bugzilla>