<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>58351</bug_id>
          
          <creation_ts>2011-04-12 11:12:11 -0700</creation_ts>
          <short_desc>Review tool should work well on iPad</short_desc>
          <delta_ts>2011-04-12 13:55:37 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>New Bugs</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Other</rep_platform>
          <op_sys>OS X 10.5</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Adam Barth">abarth</reporter>
          <assigned_to name="Adam Barth">abarth</assigned_to>
          <cc>commit-queue</cc>
    
    <cc>eric</cc>
    
    <cc>ojan</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>384169</commentid>
    <comment_count>0</comment_count>
    <who name="Adam Barth">abarth</who>
    <bug_when>2011-04-12 11:12:11 -0700</bug_when>
    <thetext>Review tool should work well on iPad</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>384170</commentid>
    <comment_count>1</comment_count>
      <attachid>89230</attachid>
    <who name="Adam Barth">abarth</who>
    <bug_when>2011-04-12 11:14:17 -0700</bug_when>
    <thetext>Created attachment 89230
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>384171</commentid>
    <comment_count>2</comment_count>
      <attachid>89230</attachid>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2011-04-12 11:15:10 -0700</bug_when>
    <thetext>Comment on attachment 89230
Patch

Amen!  Android has this same trouble too.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>384172</commentid>
    <comment_count>3</comment_count>
    <who name="Adam Barth">abarth</who>
    <bug_when>2011-04-12 11:16:20 -0700</bug_when>
    <thetext>&gt; Amen!  Android has this same trouble too.

fishd tells me this bug is fixed on Android, but I haven&apos;t tested it.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>384174</commentid>
    <comment_count>4</comment_count>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2011-04-12 11:17:27 -0700</bug_when>
    <thetext>So I just have to wait for my honeycomb or whatever?  The browser on my Nexus S always displays the bar in a random place. :)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>384198</commentid>
    <comment_count>5</comment_count>
      <attachid>89230</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2011-04-12 11:41:09 -0700</bug_when>
    <thetext>Comment on attachment 89230
Patch

Clearing flags on attachment: 89230

Committed r83616: &lt;http://trac.webkit.org/changeset/83616&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>384200</commentid>
    <comment_count>6</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2011-04-12 11:41:15 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>384336</commentid>
    <comment_count>7</comment_count>
    <who name="Adam Barth">abarth</who>
    <bug_when>2011-04-12 13:55:37 -0700</bug_when>
    <thetext>(In reply to comment #4)
&gt; So I just have to wait for my honeycomb or whatever?  The browser on my Nexus S always displays the bar in a random place. :)

That&apos;s why I&apos;d rather do a feature detect than a UA detect.  Maybe Ojan knows how to properly feature detect the strange fixed position / scrolling interaction on iOS?</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>89230</attachid>
            <date>2011-04-12 11:14:17 -0700</date>
            <delta_ts>2011-04-12 11:41:09 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-58351-20110412111416.patch</filename>
            <type>text/plain</type>
            <size>1587</size>
            <attacher name="Adam Barth">abarth</attacher>
            
              <data encoding="base64">SW5kZXg6IFdlYnNpdGVzL2J1Z3Mud2Via2l0Lm9yZy9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g
V2Vic2l0ZXMvYnVncy53ZWJraXQub3JnL0NoYW5nZUxvZwkocmV2aXNpb24gODM2MTIpCisrKyBX
ZWJzaXRlcy9idWdzLndlYmtpdC5vcmcvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMg
KzEsMTggQEAKKzIwMTEtMDQtMTIgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9yZz4KKwor
ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBSZXZpZXcgdG9v
bCBzaG91bGQgd29yayB3ZWxsIG9uIGlQYWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v
cmcvc2hvd19idWcuY2dpP2lkPTU4MzUxCisKKyAgICAgICAgT24gdGhlIGlQYWQsIHRoZSB0b29s
YmFyIGVuZHMgdXAgYXQgc29tZSByYW5kb20gcG9zaXRpb24gaW4gdGhlIG1pZGRsZQorICAgICAg
ICBvZiB0aGUgcGFnZSBiZWNhdXNlIG9mIGhvdyBwb3NpdGlvbjpmaXhlZCBpbnRlcmFjdHMgd2l0
aCBzY3JvbGxpbmcgb24KKyAgICAgICAgdGhlIGlQYWQuICBJIGZlZWwgYSBiaXQgZGlydHkgdXNp
bmcgYSB1c2VyIGFnZW50IGRldGVjdCwgYnV0IEknbSBub3QKKyAgICAgICAgc3VyZSBpZiB0aGVy
ZSdzIGEgYmV0dGVyIHdheSB0byBkZXRlY3Qgd2hldGhlciB0aGUgdXNlciBhZ2VudCBoYXMgdGhp
cworICAgICAgICBiZWhhdmlvci4KKworICAgICAgICAqIGNvZGUtcmV2aWV3LmpzOgorCiAyMDEx
LTAzLTE1ICBEYXZpZCBMZXZpbiAgPGxldmluQGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZp
ZXdlZCBieSBBZGFtIEJhcnRoLgpJbmRleDogV2Vic2l0ZXMvYnVncy53ZWJraXQub3JnL2NvZGUt
cmV2aWV3LmpzCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYnNpdGVzL2J1Z3Mud2Via2l0Lm9yZy9jb2RlLXJl
dmlldy5qcwkocmV2aXNpb24gODM2MDgpCisrKyBXZWJzaXRlcy9idWdzLndlYmtpdC5vcmcvY29k
ZS1yZXZpZXcuanMJKHdvcmtpbmcgY29weSkKQEAgLTEwMzYsNiArMTAzNiwxMSBAQCB2YXIgQ09E
RV9SRVZJRVdfVU5JVFRFU1Q7CiAgIH0KIAogICBmdW5jdGlvbiB1cGRhdGVUb29sYmFyQW5jaG9y
U3RhdGUoKSB7CisgICAgLy8gRm9yIGlQYWQsIHdlIGFsd2F5cyBsZWF2ZSB0aGUgdG9vbGJhciBh
dCB0aGUgYm90dG9tIG9mIHRoZSBkb2N1bWVudAorICAgIC8vIGJlY2F1c2Ugb2YgdGhlIGlQYWQn
cyBoYW5kbGluZyBvZiBwb3NpdGlvbjpmaXhlZCBhbmQgc2Nyb2xsaW5nLgorICAgIGlmIChuYXZp
Z2F0b3IucGxhdGZvcm0uaW5kZXhPZigiaVBhZCIpICE9IC0xKQorICAgICAgcmV0dXJuOworCiAg
ICAgdmFyIHRvb2xiYXIgPSAkKCcjdG9vbGJhcicpOwogICAgIC8vIFVuYW5jaG9yIHRoZSB0b29s
YmFyIGFuZCB0aGVuIHNlZSBpZiBpdCdzIGJvdHRvbSBpcyBiZWxvdyB0aGUgYm9keSdzIGJvdHRv
bS4KICAgICB0b29sYmFyLnRvZ2dsZUNsYXNzKCdhbmNob3JlZCcsIGZhbHNlKTsK
</data>

          </attachment>
      

    </bug>

</bugzilla>