58350 2011-04-12 11:11:13 -0700 WebKit2: Spelling and Grammar Checking: Make sure to remove the markings from the document when spelling and/or grammar checking is disabled 2011-04-12 13:29:11 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) All Windows 7 RESOLVED FIXED InRadar P2 Normal --- 1 jberlin jberlin andersca jberlin oldest_to_newest 384168 0 jberlin 2011-04-12 11:11:13 -0700 <rdar://problem/8824396> Right now it isn't done at all on Windows, and on Mac only in WKView.mm. We also need to make sure to do this when the context menu items are selected on Mac. 384270 1 89249 jberlin 2011-04-12 12:48:13 -0700 Created attachment 89249 Patch 384297 2 89249 jberlin 2011-04-12 13:28:30 -0700 Comment on attachment 89249 Patch Committed in http://trac.webkit.org/changeset/83627 89249 2011-04-12 12:48:13 -0700 2011-04-12 13:28:30 -0700 Patch unmarkTextInWebProcess.patch text/plain 6602 jberlin SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDgzNjExKQorKysgU291cmNlL1dlYktpdDIvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMzQgQEAKKzIwMTEtMDQtMTIgIEplc3NpZSBC ZXJsaW4gIDxqYmVybGluQGFwcGxlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBXZWJLaXQyOiBTcGVsbGluZyBhbmQgR3JhbW1hciBDaGVja2lu ZzogTWFrZSBzdXJlIHRvIHJlbW92ZSB0aGUgbWFya2luZ3MgZnJvbSB0aGUgZG9jdW1lbnQKKyAg ICAgICAgd2hlbiBzcGVsbGluZyBhbmQvb3IgZ3JhbW1hciBjaGVja2luZyBpcyBkaXNhYmxlZC4K KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTU4MzUwCisK KyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL21hYy9XS1ZpZXcubW06CisgICAgICAgICgtW1dLVmll dyB0b2dnbGVDb250aW51b3VzU3BlbGxDaGVja2luZzpdKToKKyAgICAgICAgTW92ZSB0aGUgY2Fs bCB0byB1bm1hcmsgdGhlIGVycm9ycyB0byB0aGUgV2ViUHJvY2Vzcy4KKyAgICAgICAgKC1bV0tW aWV3IHNldEdyYW1tYXJDaGVja2luZ0VuYWJsZWQ6XSk6CisgICAgICAgIERpdHRvLgorICAgICAg ICAoLVtXS1ZpZXcgdG9nZ2xlR3JhbW1hckNoZWNraW5nOl0pOgorICAgICAgICBEaXR0by4KKwor ICAgICAgICAqIFVJUHJvY2Vzcy9XZWJQYWdlUHJveHkuY3BwOgorICAgICAgICBSZW1vdmUgdW51 c2VkIGZ1bmN0aW9ucy4KKyAgICAgICAgKiBVSVByb2Nlc3MvV2ViUGFnZVByb3h5Lmg6CisgICAg ICAgIERpdHRvLgorICAgICAgICAqIFdlYlByb2Nlc3MvV2ViUGFnZS9XZWJQYWdlLm1lc3NhZ2Vz LmluOgorICAgICAgICBEaXR0by4KKyAgICAgICAgKiBXZWJQcm9jZXNzL1dlYlBhZ2UvV2ViUGFn ZS5oOgorCisgICAgICAgICogV2ViUHJvY2Vzcy9XZWJQcm9jZXNzLmNwcDoKKyAgICAgICAgKFdl YktpdDo6V2ViUHJvY2Vzczo6c2V0VGV4dENoZWNrZXJTdGF0ZSk6CisgICAgICAgIElmIGdyYW1t YXIgb3Igc3BlbGxpbmcgY2hlY2tpbmcgaXMgZGlzYWJsZWQsIHVubWFyayBhbGwgdGhlIHBhZ2Vz LgorICAgICAgICBEb2luZyBpdCBoZXJlIGFsbG93cyBtYWtlcyBpdCBwb3NzaWJsZSB0byB1bm1h cmsgYWxsIHBhZ2VzIGluIGEgY3Jvc3MtcGxhdGZvcm0gd2F5IHRoYXQgaXMKKyAgICAgICAgdHJp Z2dlcmVkIGJvdGggYnkgc2VsZWN0aW5nIHRoZSB0aGUgY29udGV4dCBtZW51IGl0ZW1zIGFuZCBi eSBhbnkgb3RoZXIgbWV0aG9kcyBvZiB1cGRhdGluZworICAgICAgICB0aGUgZW5hYmxlZCAvIGRp c2FibGVkIHN0YXRlLgorCiAyMDExLTA0LTEyICBBbGVqYW5kcm8gRy4gQ2FzdHJvICA8YWxleEBp Z2FsaWEuY29tPgogCiAgICAgICAgIEZpeGVkIEdUSyBjb21waWxhdGlvbiBhZnRlciByODM0NTQu CkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvV2ViUGFnZVByb3h5LmNwcAo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvV2ViUGFnZVByb3h5LmNwcAkocmV2aXNp b24gODM0ODYpCisrKyBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvV2ViUGFnZVByb3h5LmNwcAko d29ya2luZyBjb3B5KQpAQCAtMjM3NywxNiArMjM3Nyw2IEBAIHZvaWQgV2ViUGFnZVByb3h5Ojpj aGFuZ2VTcGVsbGluZ1RvV29yZCgKICAgICBwcm9jZXNzKCktPnNlbmQoTWVzc2FnZXM6OldlYlBh Z2U6OkNoYW5nZVNwZWxsaW5nVG9Xb3JkKHdvcmQpLCBtX3BhZ2VJRCk7CiB9CiAKLXZvaWQgV2Vi UGFnZVByb3h5Ojp1bm1hcmtBbGxNaXNzcGVsbGluZ3MoKQotewotICAgIHByb2Nlc3MoKS0+c2Vu ZChNZXNzYWdlczo6V2ViUGFnZTo6VW5tYXJrQWxsTWlzc3BlbGxpbmdzKCksIG1fcGFnZUlEKTsK LX0KLQotdm9pZCBXZWJQYWdlUHJveHk6OnVubWFya0FsbEJhZEdyYW1tYXIoKQotewotICAgIHBy b2Nlc3MoKS0+c2VuZChNZXNzYWdlczo6V2ViUGFnZTo6VW5tYXJrQWxsQmFkR3JhbW1hcigpLCBt X3BhZ2VJRCk7Ci19Ci0KIHZvaWQgV2ViUGFnZVByb3h5OjpyZWdpc3RlckVkaXRDb21tYW5kKFBh c3NSZWZQdHI8V2ViRWRpdENvbW1hbmRQcm94eT4gY29tbWFuZFByb3h5LCBVbmRvT3JSZWRvIHVu ZG9PclJlZG8pCiB7CiAgICAgbV9wYWdlQ2xpZW50LT5yZWdpc3RlckVkaXRDb21tYW5kKGNvbW1h bmRQcm94eSwgdW5kb09yUmVkbyk7CkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvV2Vi UGFnZVByb3h5LmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1dlYlBh Z2VQcm94eS5oCShyZXZpc2lvbiA4MzQ4NikKKysrIFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9X ZWJQYWdlUHJveHkuaAkod29ya2luZyBjb3B5KQpAQCAtNDU0LDggKzQ1NCw2IEBAIHB1YmxpYzoK IAogICAgIHZvaWQgYWR2YW5jZVRvTmV4dE1pc3NwZWxsaW5nKGJvb2wgc3RhcnRCZWZvcmVTZWxl Y3Rpb24pIGNvbnN0OwogICAgIHZvaWQgY2hhbmdlU3BlbGxpbmdUb1dvcmQoY29uc3QgU3RyaW5n JiB3b3JkKTsKLSAgICB2b2lkIHVubWFya0FsbE1pc3NwZWxsaW5ncygpOwotICAgIHZvaWQgdW5t YXJrQWxsQmFkR3JhbW1hcigpOwogI2lmIFBMQVRGT1JNKE1BQykKICAgICB2b2lkIHVwcGVyY2Fz ZVdvcmQoKTsKICAgICB2b2lkIGxvd2VyY2FzZVdvcmQoKTsKSW5kZXg6IFNvdXJjZS9XZWJLaXQy L1VJUHJvY2Vzcy9BUEkvbWFjL1dLVmlldy5tbQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0 Mi9VSVByb2Nlc3MvQVBJL21hYy9XS1ZpZXcubW0JKHJldmlzaW9uIDgzNDg2KQorKysgU291cmNl L1dlYktpdDIvVUlQcm9jZXNzL0FQSS9tYWMvV0tWaWV3Lm1tCSh3b3JraW5nIGNvcHkpCkBAIC03 NTgsOSArNzU4LDYgQEAgLSAoSUJBY3Rpb24pdG9nZ2xlQ29udGludW91c1NwZWxsQ2hlY2tpbgog ICAgIFRleHRDaGVja2VyOjpzZXRDb250aW51b3VzU3BlbGxDaGVja2luZ0VuYWJsZWQoc3BlbGxD aGVja2luZ0VuYWJsZWQpOwogCiAgICAgX2RhdGEtPl9wYWdlLT5wcm9jZXNzKCktPnVwZGF0ZVRl eHRDaGVja2VyU3RhdGUoKTsKLQotICAgIGlmICghc3BlbGxDaGVja2luZ0VuYWJsZWQpCi0gICAg ICAgIF9kYXRhLT5fcGFnZS0+dW5tYXJrQWxsTWlzc3BlbGxpbmdzKCk7CiB9CiAKIC0gKEJPT0wp aXNHcmFtbWFyQ2hlY2tpbmdFbmFibGVkCkBAIC03NzUsOSArNzcyLDYgQEAgLSAodm9pZClzZXRH cmFtbWFyQ2hlY2tpbmdFbmFibGVkOihCT09MKQogICAgIAogICAgIFRleHRDaGVja2VyOjpzZXRH cmFtbWFyQ2hlY2tpbmdFbmFibGVkKGZsYWcpOwogICAgIF9kYXRhLT5fcGFnZS0+cHJvY2Vzcygp LT51cGRhdGVUZXh0Q2hlY2tlclN0YXRlKCk7Ci0KLSAgICBpZiAoIWZsYWcpCi0gICAgICAgIF9k YXRhLT5fcGFnZS0+dW5tYXJrQWxsQmFkR3JhbW1hcigpOwogfQogCiAtIChJQkFjdGlvbil0b2dn bGVHcmFtbWFyQ2hlY2tpbmc6KGlkKXNlbmRlcgpAQCAtNzg2LDkgKzc4MCw2IEBAIC0gKElCQWN0 aW9uKXRvZ2dsZUdyYW1tYXJDaGVja2luZzooaWQpc2UKICAgICBUZXh0Q2hlY2tlcjo6c2V0R3Jh bW1hckNoZWNraW5nRW5hYmxlZChncmFtbWFyQ2hlY2tpbmdFbmFibGVkKTsKIAogICAgIF9kYXRh LT5fcGFnZS0+cHJvY2VzcygpLT51cGRhdGVUZXh0Q2hlY2tlclN0YXRlKCk7Ci0KLSAgICBpZiAo IWdyYW1tYXJDaGVja2luZ0VuYWJsZWQpCi0gICAgICAgIF9kYXRhLT5fcGFnZS0+dW5tYXJrQWxs QmFkR3JhbW1hcigpOwogfQogCiAtIChJQkFjdGlvbil0b2dnbGVBdXRvbWF0aWNTcGVsbGluZ0Nv cnJlY3Rpb246KGlkKXNlbmRlcgpJbmRleDogU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQ cm9jZXNzLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBy b2Nlc3MuY3BwCShyZXZpc2lvbiA4MzQ4NikKKysrIFNvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3Mv V2ViUHJvY2Vzcy5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTgwMiw3ICs4MDIsMjIgQEAgdm9pZCBX ZWJQcm9jZXNzOjpzdG9wTWVtb3J5U2FtcGxlcigpCiAKIHZvaWQgV2ViUHJvY2Vzczo6c2V0VGV4 dENoZWNrZXJTdGF0ZShjb25zdCBUZXh0Q2hlY2tlclN0YXRlJiB0ZXh0Q2hlY2tlclN0YXRlKQog eworICAgIGJvb2wgY29udGludW91c1NwZWxsQ2hlY2tpbmdUdXJuZWRPZmYgPSAhdGV4dENoZWNr ZXJTdGF0ZS5pc0NvbnRpbnVvdXNTcGVsbENoZWNraW5nRW5hYmxlZCAmJiBtX3RleHRDaGVja2Vy U3RhdGUuaXNDb250aW51b3VzU3BlbGxDaGVja2luZ0VuYWJsZWQ7CisgICAgYm9vbCBncmFtbWFy Q2hlY2tpbmdUdXJuZWRPZmYgPSAhdGV4dENoZWNrZXJTdGF0ZS5pc0dyYW1tYXJDaGVja2luZ0Vu YWJsZWQgJiYgbV90ZXh0Q2hlY2tlclN0YXRlLmlzR3JhbW1hckNoZWNraW5nRW5hYmxlZDsKKwog ICAgIG1fdGV4dENoZWNrZXJTdGF0ZSA9IHRleHRDaGVja2VyU3RhdGU7CisKKyAgICBpZiAoIWNv bnRpbnVvdXNTcGVsbENoZWNraW5nVHVybmVkT2ZmICYmICFncmFtbWFyQ2hlY2tpbmdUdXJuZWRP ZmYpCisgICAgICAgIHJldHVybjsKKworICAgIEhhc2hNYXA8dWludDY0X3QsIFJlZlB0cjxXZWJQ YWdlPiA+OjppdGVyYXRvciBlbmQgPSBtX3BhZ2VNYXAuZW5kKCk7CisgICAgZm9yIChIYXNoTWFw PHVpbnQ2NF90LCBSZWZQdHI8V2ViUGFnZT4gPjo6aXRlcmF0b3IgaXQgPSBtX3BhZ2VNYXAuYmVn aW4oKTsgaXQgIT0gZW5kOyArK2l0KSB7CisgICAgICAgIFdlYlBhZ2UqIHBhZ2UgPSAoKml0KS5z ZWNvbmQuZ2V0KCk7CisgICAgICAgIGlmIChjb250aW51b3VzU3BlbGxDaGVja2luZ1R1cm5lZE9m ZikKKyAgICAgICAgICAgIHBhZ2UtPnVubWFya0FsbE1pc3NwZWxsaW5ncygpOworICAgICAgICBp ZiAoZ3JhbW1hckNoZWNraW5nVHVybmVkT2ZmKQorICAgICAgICAgICAgcGFnZS0+dW5tYXJrQWxs QmFkR3JhbW1hcigpOworICAgIH0KIH0KIAogfSAvLyBuYW1lc3BhY2UgV2ViS2l0CkluZGV4OiBT b3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvV2ViUGFnZS5oCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IFNvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9XZWJQYWdlLmgJKHJldmlzaW9uIDgz NDg2KQorKysgU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL1dlYlBhZ2UuaAkod29y a2luZyBjb3B5KQpAQCAtMzg1LDYgKzM4NSw5IEBAIHB1YmxpYzoKIAogICAgIHZvaWQgZm9yY2VS ZXBhaW50V2l0aG91dENhbGxiYWNrKCk7CiAKKyAgICB2b2lkIHVubWFya0FsbE1pc3NwZWxsaW5n cygpOworICAgIHZvaWQgdW5tYXJrQWxsQmFkR3JhbW1hcigpOworCiAjaWYgUExBVEZPUk0oTUFD KQogICAgIHZvaWQgc2V0RHJhZ1NvdXJjZShOU09iamVjdCAqKTsKICNlbmRpZgpAQCAtNTE3LDgg KzUyMCw2IEBAIHByaXZhdGU6CiAKICAgICB2b2lkIGFkdmFuY2VUb05leHRNaXNzcGVsbGluZyhi b29sIHN0YXJ0QmVmb3JlU2VsZWN0aW9uKTsKICAgICB2b2lkIGNoYW5nZVNwZWxsaW5nVG9Xb3Jk KGNvbnN0IFN0cmluZyYgd29yZCk7Ci0gICAgdm9pZCB1bm1hcmtBbGxNaXNzcGVsbGluZ3MoKTsK LSAgICB2b2lkIHVubWFya0FsbEJhZEdyYW1tYXIoKTsKICNpZiBQTEFURk9STShNQUMpCiAgICAg dm9pZCB1cHBlcmNhc2VXb3JkKCk7CiAgICAgdm9pZCBsb3dlcmNhc2VXb3JkKCk7CkluZGV4OiBT b3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvV2ViUGFnZS5tZXNzYWdlcy5pbgo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvV2ViUGFnZS5tZXNz YWdlcy5pbgkocmV2aXNpb24gODM0ODYpCisrKyBTb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dl YlBhZ2UvV2ViUGFnZS5tZXNzYWdlcy5pbgkod29ya2luZyBjb3B5KQpAQCAtMTQxLDggKzE0MSw2 IEBAIG1lc3NhZ2VzIC0+IFdlYlBhZ2UgewogICAgICMgU3BlbGxpbmcgYW5kIGdyYW1tYXIuCiAg ICAgQWR2YW5jZVRvTmV4dE1pc3NwZWxsaW5nKGJvb2wgc3RhcnRCZWZvcmVTZWxlY3Rpb24pCiAg ICAgQ2hhbmdlU3BlbGxpbmdUb1dvcmQoV1RGOjpTdHJpbmcgd29yZCkKLSAgICBVbm1hcmtBbGxN aXNzcGVsbGluZ3MoKQotICAgIFVubWFya0FsbEJhZEdyYW1tYXIoKQogI2lmIFBMQVRGT1JNKE1B QykKICAgICBVcHBlcmNhc2VXb3JkKCk7CiAgICAgTG93ZXJjYXNlV29yZCgpOwo=