58344 2011-04-12 10:23:59 -0700 webkitpy.common.checkout.diff_parser errors when parsing SVN property changes 2023-11-16 07:00:46 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC OS X 10.5 NEW P2 Normal --- 1 dbates webkit-unassigned abarth eric jbedard jcraig oldest_to_newest 384109 0 dbates 2011-04-12 10:23:59 -0700 It seems that webkitpy.common.checkout.diff_parser doesn't know how to parse SVN property changes. 1. Apply the patch for bug #53625 2. Run, svn propset allow-tabs 1 Tools/Scripts/webkitperl/VCSUtils_unittest/parseDiffWithMockFiles.pl 3. Run, Tools/Scripts/webkit-patch land 53625 Then I received the following output: dbatesRIM:WebKit dbates$ Tools/Scripts/webkit-patch land 53625 ... Fetching: https://bugs.webkit.org/show_bug.cgi?id=53625&ctype=xml Guessing "Eric Seidel" as reviewer from attachment 89082 on bug 53625. WARNING: Patch's size is 22 kbytes. Patches 20k or smaller are more likely to be reviewed. Larger patches may sit unreviewed for a long time. webkitpy.common.checkout.diff_parser: [ERROR] Unexpected diff format when parsing a chunk: '' webkitpy.common.checkout.diff_parser: [ERROR] Unexpected diff format when parsing a chunk: 'Property changes on: Tools/Scripts/webkitperl/VCSUtils_unittest/parseDiffWithMockFiles.pl' webkitpy.common.checkout.diff_parser: [ERROR] Unexpected diff format when parsing a chunk: '___________________________________________________________________' webkitpy.common.checkout.diff_parser: [ERROR] Unexpected diff format when parsing a chunk: 'Added: allow-tabs' webkitpy.common.checkout.diff_parser: [ERROR] Unexpected diff format when parsing a chunk: '' Parsing ChangeLog: /Users/dbates/Desktop/WebKit/Tools/ChangeLog Committed r83603: <http://trac.webkit.org/changeset/83603> Updating bug 53625 Reading Keychain for bugs.webkit.org account and password. Click "Allow" to continue... ... In particular, notice the webkitpy.common.checkout.diff_parser errors. 1993093 1 gsnedders 2023-11-16 06:59:04 -0800 *** Bug 132210 has been marked as a duplicate of this bug. *** 1993094 2 gsnedders 2023-11-16 07:00:46 -0800 Do we actually still need support for SVN in the diff_parser?