<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>58334</bug_id>
          
          <creation_ts>2011-04-12 09:13:41 -0700</creation_ts>
          <short_desc>LayoutTestController.computedStyleIncludingVisitedInfo-based tests don&apos;t work in WK2</short_desc>
          <delta_ts>2011-12-27 16:00:52 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Tools / Tests</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>All</rep_platform>
          <op_sys>All</op_sys>
          <bug_status>NEW</bug_status>
          <resolution></resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Brady Eidson">beidson</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>samuel.white</cc>
    
    <cc>sam</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>384047</commentid>
    <comment_count>0</comment_count>
    <who name="Brady Eidson">beidson</who>
    <bug_when>2011-04-12 09:13:41 -0700</bug_when>
    <thetext>LayoutTestController.computedStyleIncludingVisitedInfo-based tests don&apos;t work in WK2

All such tests use both computedStyleIncludingVisitedInfo and keepWebHistory, both of which *are* implemented in WKTR.

However, something must not be working right.  Currently the 4 known failures due to this bug are:
fast/history/nested-visited-test.html
fast/history/self-is-visited.html
fast/history/sibling-visited-test.html
state-url-sets-links-visited.html

All of these visually pass in a WK2 browser.

The failures all involve the returned style for the inspected nodes not correctly showing their visitedness.

Two obvious theories:
1 - computedStyleIncludingVisitedInfo doesn&apos;t work right
2 - Visited links go through a round trip to the UIProcess and don&apos;t get back to the WebProcess in time, therefore we&apos;re being bitten by IPC asynchronicity</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>384055</commentid>
    <comment_count>1</comment_count>
    <who name="Brady Eidson">beidson</who>
    <bug_when>2011-04-12 09:22:41 -0700</bug_when>
    <thetext>Added a new failing test to the skipped list and reclassified the 3 others in r83595</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>527364</commentid>
    <comment_count>2</comment_count>
    <who name="Samuel White">samuel.white</who>
    <bug_when>2011-12-27 07:38:13 -0800</bug_when>
    <thetext>platform/mac/accessibility/search-predicate.html was added to the skipped list in r103704. It fails because visited links are not properly reported as visited in WK2 and do not report the appropriate style change.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>527492</commentid>
    <comment_count>3</comment_count>
    <who name="Brady Eidson">beidson</who>
    <bug_when>2011-12-27 16:00:52 -0800</bug_when>
    <thetext>(In reply to comment #2)
&gt; platform/mac/accessibility/search-predicate.html was added to the skipped list in r103704. It fails because visited links are not properly reported as visited in WK2 and do not report the appropriate style change.

To the end user visited links work fine in WebKit 2.  See my original hypothesis from 2011-4-12:

&gt;1 - computedStyleIncludingVisitedInfo doesn&apos;t work right
&gt;2 - Visited links go through a round trip to the UIProcess and don&apos;t get back to the WebProcess in time, therefore we&apos;re being bitten by IPC asynchronicity</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>