58333 2011-04-12 09:13:41 -0700 [GTK] arguments passed to build-jsc are not taken into account 2011-11-03 10:42:01 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Other Linux RESOLVED FIXED P2 Normal --- 0 thouraya.andolsi webkit-unassigned commit-queue eric mrobinson pnormand webkit.review.bot xan.lopez oldest_to_newest 384046 0 thouraya.andolsi 2011-04-12 09:13:41 -0700 Hello, Arguments passed to build-jsc and build-webkit scripts are not taken into account. I will submit a patch to fix the problem. Regards, Thouraya. 384054 1 89214 thouraya.andolsi 2011-04-12 09:18:59 -0700 Created attachment 89214 Fix arguments issue 384076 2 89218 thouraya.andolsi 2011-04-12 09:50:33 -0700 Created attachment 89218 Fix arguments issue 384145 3 89218 eric 2011-04-12 10:50:27 -0700 Comment on attachment 89218 Fix arguments issue I'm rubber-stamping this on the assumption that this is the way teh gtk folks want build-webkit to work for them. 384244 4 89218 commit-queue 2011-04-12 12:24:49 -0700 Comment on attachment 89218 Fix arguments issue Clearing flags on attachment: 89218 Committed r83621: <http://trac.webkit.org/changeset/83621> 384245 5 commit-queue 2011-04-12 12:24:53 -0700 All reviewed patches have been landed. Closing bug. 384288 6 89218 pnormand 2011-04-12 13:12:06 -0700 Comment on attachment 89218 Fix arguments issue View in context: https://bugs.webkit.org/attachment.cgi?id=89218&action=review > Tools/Scripts/build-webkit:577 > + push(@options, @ARGV); I come a bit late as this landed. But I don't think that specific change is needed. What options exactly do you want to pass? For instance build-webkit --gtk --with-gtk=3.0 --video calls configure --with-gtk=3.0 --enable-video already. Without that patch. 384355 7 pnormand 2011-04-12 14:06:59 -0700 (In reply to comment #6) > (From update of attachment 89218 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=89218&action=review > > > Tools/Scripts/build-webkit:577 > > + push(@options, @ARGV); > > I come a bit late as this landed. But I don't think that specific change is needed. What options exactly do you want to pass? > For instance build-webkit --gtk --with-gtk=3.0 --video calls configure --with-gtk=3.0 --enable-video already. Without that patch. And indeed... http://build.webkit.org/builders/GTK%20Linux%2064-bit%20Debug/builds/21388/steps/jscore-test/logs/stdio configure: error: unrecognized option: `--gtk' Try `../../configure --help' for more information Please roll out. 384401 8 pnormand 2011-04-12 14:43:18 -0700 Rolled out in http://trac.webkit.org/changeset/83643 384764 9 thouraya.andolsi 2011-04-13 03:00:35 -0700 Hello, using build-jsc as it is and running: Tools/Scripts/build-jsc --gtk --host="${target_arch}" I get the error below : checking whether we are cross compiling... configure: error: in `/home/team/work/Webkit-tot-dev/WebKitBuild/Release': configure: error: cannot run C compiled programs. If you meant to cross compile, use `--host'. using build-webkit as it is and running: Tools/Scripts/build-webkit --gtk --host="${target_arch}" --disable-geolocation geolocation is not disabled and I got a link error due to missed library geloc Regards, Thouraya. 384768 10 pnormand 2011-04-13 03:09:20 -0700 (In reply to comment #9) > Hello, > > using build-jsc as it is and running: Tools/Scripts/build-jsc --gtk --host="${target_arch}" > > I get the error below : > > checking whether we are cross compiling... configure: error: in `/home/team/work/Webkit-tot-dev/WebKitBuild/Release': > configure: error: cannot run C compiled programs. > If you meant to cross compile, use `--host'. > Maybe your build-jsc change made sense, not sure. > > > using build-webkit as it is and running: Tools/Scripts/build-webkit --gtk --host="${target_arch}" --disable-geolocation > > geolocation is not disabled and I got a link error due to missed library geloc > build-webkit --help --[no-]geolocation Toggle Geolocation support (default: 1) 384772 11 89218 pnormand 2011-04-13 03:14:59 -0700 Comment on attachment 89218 Fix arguments issue View in context: https://bugs.webkit.org/attachment.cgi?id=89218&action=review > Tools/Scripts/build-jsc:71 > + $result = buildGtkProject("JavaScriptCore", 0, @ARGV); Probably should remove --gtk from that args first, like Qt does just below. checkForArgumentAndRemoveFromARGV("--gtk"); 384779 12 thouraya.andolsi 2011-04-13 03:59:29 -0700 renamed the bug 384781 13 89362 thouraya.andolsi 2011-04-13 04:07:44 -0700 Created attachment 89362 Fix arguments issue 384782 14 thouraya.andolsi 2011-04-13 04:09:35 -0700 Hello, (In reply to comment #11) > (From update of attachment 89218 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=89218&action=review > > > Tools/Scripts/build-jsc:71 > > + $result = buildGtkProject("JavaScriptCore", 0, @ARGV); > > Probably should remove --gtk from that args first, like Qt does just below. > > checkForArgumentAndRemoveFromARGV("--gtk"); Added it. Thank you, Regards, Thouraya. 384816 15 pnormand 2011-04-13 05:56:18 -0700 (In reply to comment #14) > Hello, > > (In reply to comment #11) > > (From update of attachment 89218 [details] [details]) > > View in context: https://bugs.webkit.org/attachment.cgi?id=89218&action=review > > > > > Tools/Scripts/build-jsc:71 > > > + $result = buildGtkProject("JavaScriptCore", 0, @ARGV); > > > > Probably should remove --gtk from that args first, like Qt does just below. > > > > checkForArgumentAndRemoveFromARGV("--gtk"); > > I assume you tested this with a clean/full build? That change looks good. Having a --help option in build-jsc would be nice too but i guess this could be part of another patch. 423314 16 89362 eric 2011-06-18 20:00:30 -0700 Comment on attachment 89362 Fix arguments issue What are we going to do here? How does this patch move forward? 423404 17 mrobinson 2011-06-19 16:24:17 -0700 (In reply to comment #16) > (From update of attachment 89362 [details]) > What are we going to do here? How does this patch move forward? It would be nice if thouraya could confirm that he tested a full build. If he's moved on, this patch is probably safe to cq. 495621 18 89362 webkit.review.bot 2011-11-03 10:41:56 -0700 Comment on attachment 89362 Fix arguments issue Clearing flags on attachment: 89362 Committed r99216: <http://trac.webkit.org/changeset/99216> 495622 19 webkit.review.bot 2011-11-03 10:42:01 -0700 All reviewed patches have been landed. Closing bug. 89214 2011-04-12 09:18:59 -0700 2011-04-12 09:50:33 -0700 Fix arguments issue 0001-Fix-arguments-issue.patch text/plain 2001 thouraya.andolsi RnJvbSAyNjU5ODU5NTEzM2NiOGIyNTliODJkMWY1YzlhOGY2MzNmMWExYzJmIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBUaG91cmF5YSBBTkRPTFNJIDx0aG91cmF5YS5hbmRvbHNpQHN0 LmNvbT4KRGF0ZTogVHVlLCAxMiBBcHIgMjAxMSAxNzoyMzo0MCArMDIwMApTdWJqZWN0OiBbUEFU Q0hdIEZpeCBhcmd1bWVudHMgcHJvYmxlbS4KCi0tLQogVG9vbHMvQ2hhbmdlTG9nICAgICAgICAg ICAgfCAgIDExICsrKysrKysrKysrCiBUb29scy9TY3JpcHRzL2J1aWxkLWpzYyAgICB8ICAgIDIg Ky0KIFRvb2xzL1NjcmlwdHMvYnVpbGQtd2Via2l0IHwgICAgMSArCiAzIGZpbGVzIGNoYW5nZWQs IDEzIGluc2VydGlvbnMoKyksIDEgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvVG9vbHMvQ2hh bmdlTG9nIGIvVG9vbHMvQ2hhbmdlTG9nCmluZGV4IDllZTJjN2IuLjkzZDY4MTQgMTAwNjQ0Ci0t LSBhL1Rvb2xzL0NoYW5nZUxvZworKysgYi9Ub29scy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBA QAorMjAxMS0wNC0xMiAgVGhvdXJheWEgQU5ET0xTSSAgPHRob3VyYXlhLmFuZG9sc2lAc3QuY29t PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtHVEtd IGFyZ3VtZW50cyBwYXNzZWQgdG8gYnVpbGQtanNjIGFuZCBidWlsZC13ZWJraXQgc2NyaXB0cyBh cmUgbm90IHRha2VuIGludG8gYWNjb3VudAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9NTgzMzMKKworICAgICAgICAqIFNjcmlwdHMvYnVpbGQtanNjOgor ICAgICAgICAqIFNjcmlwdHMvYnVpbGQtd2Via2l0OgorICAgICAgICAqIFNjcmlwdHMvd2Via2l0 cHkvdGhpcmRwYXJ0eS9fX2luaXRfXy5weToKKwogMjAxMS0wNC0xMSAgU2FtIFdlaW5pZyAgPHNh bUB3ZWJraXQub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEFuZGVycyBDYXJsc3Nvbi4KZGlm ZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvYnVpbGQtanNjIGIvVG9vbHMvU2NyaXB0cy9idWlsZC1q c2MKaW5kZXggYmRhYmQ1YS4uNjVkZGY4MyAxMDA3NTUKLS0tIGEvVG9vbHMvU2NyaXB0cy9idWls ZC1qc2MKKysrIGIvVG9vbHMvU2NyaXB0cy9idWlsZC1qc2MKQEAgLTY4LDcgKzY4LDcgQEAgaWYg KGlzQXBwbGVNYWNXZWJLaXQoKSkgewogfSBlbHNpZiAoaXNBcHBsZVdpbldlYktpdCgpKSB7CiAg ICAgJHJlc3VsdCA9IGJ1aWxkVmlzdWFsU3R1ZGlvUHJvamVjdCgiSmF2YVNjcmlwdENvcmUudmNw cm9qL0phdmFTY3JpcHRDb3JlLnNsbiIpOwogfSBlbHNpZiAoaXNHdGsoKSkgewotICAgICRyZXN1 bHQgPSBidWlsZEd0a1Byb2plY3QoIkphdmFTY3JpcHRDb3JlIik7CisgICAgJHJlc3VsdCA9IGJ1 aWxkR3RrUHJvamVjdCgiSmF2YVNjcmlwdENvcmUiLCAwLCBAQVJHVik7CiB9IGVsc2lmIChpc1F0 KCkpIHsKICAgICAjIFJlbW92ZSBkdXBsaWNhdGVkIC0tcXQgb3B0aW9ucyB0byBhdm9pZCBwYXNz aW5nIHRoZW0gdG8gcW1ha2UKICAgICBjaGVja0ZvckFyZ3VtZW50QW5kUmVtb3ZlRnJvbUFSR1Yo Ii0tcXQiKTsKZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvYnVpbGQtd2Via2l0IGIvVG9vbHMv U2NyaXB0cy9idWlsZC13ZWJraXQKaW5kZXggNjk1NTJlZC4uYmUzNGJmMiAxMDA3NTUKLS0tIGEv VG9vbHMvU2NyaXB0cy9idWlsZC13ZWJraXQKKysrIGIvVG9vbHMvU2NyaXB0cy9idWlsZC13ZWJr aXQKQEAgLTU3NCw2ICs1NzQsNyBAQCBmb3IgbXkgJGRpciAoQHByb2plY3RzKSB7CiAKICAgICBt eSAkcHJvamVjdCA9IGJhc2VuYW1lKCRkaXIpOwogICAgIGlmIChpc0d0aygpKSB7CisgICAgICAg IHB1c2goQG9wdGlvbnMsIEBBUkdWKTsKICAgICAgICAgJHJlc3VsdCA9IGJ1aWxkR3RrUHJvamVj dCgkcHJvamVjdCwgJGNsZWFuLCAgQG9wdGlvbnMpOwogICAgIH0gZWxzaWYgKGlzUXQoKSkgewog ICAgICAgICAjRklYTUU6ICRkaXIgc2hvdWxkIHByb2JhYmx5IGJlICRwcm9qZWN0LgotLSAKMS43 LjIuMwoK 89218 2011-04-12 09:50:33 -0700 2011-04-13 03:14:59 -0700 Fix arguments issue 0001-Fix-arguments-problem.patch text/plain 1948 thouraya.andolsi RnJvbSAyM2RjYTgyZDRjOGNjZGFiNWI4ZDNhNzkxM2I2ZGIzZjU4N2Q0MTY3IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBUaG91cmF5YSBBTkRPTFNJIDx0aG91cmF5YS5hbmRvbHNpQHN0 LmNvbT4KRGF0ZTogVHVlLCAxMiBBcHIgMjAxMSAxNzo1MjoyNSArMDIwMApTdWJqZWN0OiBbUEFU Q0hdIEZpeCBhcmd1bWVudHMgcHJvYmxlbS4KCi0tLQogVG9vbHMvQ2hhbmdlTG9nICAgICAgICAg ICAgfCAgIDEwICsrKysrKysrKysKIFRvb2xzL1NjcmlwdHMvYnVpbGQtanNjICAgIHwgICAgMiAr LQogVG9vbHMvU2NyaXB0cy9idWlsZC13ZWJraXQgfCAgICAxICsKIDMgZmlsZXMgY2hhbmdlZCwg MTIgaW5zZXJ0aW9ucygrKSwgMSBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9Ub29scy9DaGFu Z2VMb2cgYi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggOWVlMmM3Yi4uMjUzY2YxNiAxMDA2NDQKLS0t IGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBA CisyMDExLTA0LTEyICBUaG91cmF5YSBBTkRPTFNJICA8dGhvdXJheWEuYW5kb2xzaUBzdC5jb20+ CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW0dUS10g YXJndW1lbnRzIHBhc3NlZCB0byBidWlsZC1qc2MgYW5kIGJ1aWxkLXdlYmtpdCBzY3JpcHRzIGFy ZSBub3QgdGFrZW4gaW50byBhY2NvdW50CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD01ODMzMworCisgICAgICAgICogU2NyaXB0cy9idWlsZC1qc2M6Cisg ICAgICAgICogU2NyaXB0cy9idWlsZC13ZWJraXQ6CisKIDIwMTEtMDQtMTEgIFNhbSBXZWluaWcg IDxzYW1Ad2Via2l0Lm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBBbmRlcnMgQ2FybHNzb24u CmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL2J1aWxkLWpzYyBiL1Rvb2xzL1NjcmlwdHMvYnVp bGQtanNjCmluZGV4IGJkYWJkNWEuLjY1ZGRmODMgMTAwNzU1Ci0tLSBhL1Rvb2xzL1NjcmlwdHMv YnVpbGQtanNjCisrKyBiL1Rvb2xzL1NjcmlwdHMvYnVpbGQtanNjCkBAIC02OCw3ICs2OCw3IEBA IGlmIChpc0FwcGxlTWFjV2ViS2l0KCkpIHsKIH0gZWxzaWYgKGlzQXBwbGVXaW5XZWJLaXQoKSkg ewogICAgICRyZXN1bHQgPSBidWlsZFZpc3VhbFN0dWRpb1Byb2plY3QoIkphdmFTY3JpcHRDb3Jl LnZjcHJvai9KYXZhU2NyaXB0Q29yZS5zbG4iKTsKIH0gZWxzaWYgKGlzR3RrKCkpIHsKLSAgICAk cmVzdWx0ID0gYnVpbGRHdGtQcm9qZWN0KCJKYXZhU2NyaXB0Q29yZSIpOworICAgICRyZXN1bHQg PSBidWlsZEd0a1Byb2plY3QoIkphdmFTY3JpcHRDb3JlIiwgMCwgQEFSR1YpOwogfSBlbHNpZiAo aXNRdCgpKSB7CiAgICAgIyBSZW1vdmUgZHVwbGljYXRlZCAtLXF0IG9wdGlvbnMgdG8gYXZvaWQg cGFzc2luZyB0aGVtIHRvIHFtYWtlCiAgICAgY2hlY2tGb3JBcmd1bWVudEFuZFJlbW92ZUZyb21B UkdWKCItLXF0Iik7CmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL2J1aWxkLXdlYmtpdCBiL1Rv b2xzL1NjcmlwdHMvYnVpbGQtd2Via2l0CmluZGV4IDY5NTUyZWQuLmJlMzRiZjIgMTAwNzU1Ci0t LSBhL1Rvb2xzL1NjcmlwdHMvYnVpbGQtd2Via2l0CisrKyBiL1Rvb2xzL1NjcmlwdHMvYnVpbGQt d2Via2l0CkBAIC01NzQsNiArNTc0LDcgQEAgZm9yIG15ICRkaXIgKEBwcm9qZWN0cykgewogCiAg ICAgbXkgJHByb2plY3QgPSBiYXNlbmFtZSgkZGlyKTsKICAgICBpZiAoaXNHdGsoKSkgeworICAg ICAgICBwdXNoKEBvcHRpb25zLCBAQVJHVik7CiAgICAgICAgICRyZXN1bHQgPSBidWlsZEd0a1By b2plY3QoJHByb2plY3QsICRjbGVhbiwgIEBvcHRpb25zKTsKICAgICB9IGVsc2lmIChpc1F0KCkp IHsKICAgICAgICAgI0ZJWE1FOiAkZGlyIHNob3VsZCBwcm9iYWJseSBiZSAkcHJvamVjdC4KLS0g CjEuNy4yLjMKCg== 89362 2011-04-13 04:07:44 -0700 2011-11-03 10:41:55 -0700 Fix arguments issue 0001-fix-arguments-issue.patch text/plain 1458 thouraya.andolsi RnJvbSAyZDU3N2ZhZmZiODNjYjNlYTZmZTAyZTk4MDBmMDBkYTAxZDQxZWJmIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBUaG91cmF5YSBBTkRPTFNJIDx0aG91cmF5YS5hbmRvbHNpQHN0 LmNvbT4KRGF0ZTogV2VkLCAxMyBBcHIgMjAxMSAxMjoxMjowOSArMDIwMApTdWJqZWN0OiBbUEFU Q0hdIGZpeCBhcmd1bWVudHMgaXNzdWUKCi0tLQogVG9vbHMvQ2hhbmdlTG9nICAgICAgICAgfCAg ICA5ICsrKysrKysrKwogVG9vbHMvU2NyaXB0cy9idWlsZC1qc2MgfCAgICAzICsrLQogMiBmaWxl cyBjaGFuZ2VkLCAxMSBpbnNlcnRpb25zKCspLCAxIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBh L1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCBhODFhZjNiLi41MjUxYmNi IDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0x LDMgKzEsMTIgQEAKKzIwMTEtMDQtMTMgIFRob3VyYXlhIEFORE9MU0kgIDx0aG91cmF5YS5hbmRv bHNpQHN0LmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBbR1RLXSBhcmd1bWVudHMgcGFzc2VkIHRvIGJ1aWxkLWpzYyBhcmUgbm90IHRha2VuIGlu dG8gYWNjb3VudAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9NTgzMzMKKworICAgICAgICAqIFNjcmlwdHMvYnVpbGQtanNjOgorCiAyMDExLTA0LTEyICBL ZW50IFRhbXVyYSAgPHRrZW50QGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBE aW1pdHJpIEdsYXprb3YuCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL2J1aWxkLWpzYyBiL1Rv b2xzL1NjcmlwdHMvYnVpbGQtanNjCmluZGV4IGJkYWJkNWEuLmNjZmI3YTcgMTAwNzU1Ci0tLSBh L1Rvb2xzL1NjcmlwdHMvYnVpbGQtanNjCisrKyBiL1Rvb2xzL1NjcmlwdHMvYnVpbGQtanNjCkBA IC02OCw3ICs2OCw4IEBAIGlmIChpc0FwcGxlTWFjV2ViS2l0KCkpIHsKIH0gZWxzaWYgKGlzQXBw bGVXaW5XZWJLaXQoKSkgewogICAgICRyZXN1bHQgPSBidWlsZFZpc3VhbFN0dWRpb1Byb2plY3Qo IkphdmFTY3JpcHRDb3JlLnZjcHJvai9KYXZhU2NyaXB0Q29yZS5zbG4iKTsKIH0gZWxzaWYgKGlz R3RrKCkpIHsKLSAgICAkcmVzdWx0ID0gYnVpbGRHdGtQcm9qZWN0KCJKYXZhU2NyaXB0Q29yZSIp OworICAgIGNoZWNrRm9yQXJndW1lbnRBbmRSZW1vdmVGcm9tQVJHVigiLS1ndGsiKTsKKyAgICAk cmVzdWx0ID0gYnVpbGRHdGtQcm9qZWN0KCJKYXZhU2NyaXB0Q29yZSIsIDAsIEBBUkdWKTsKIH0g ZWxzaWYgKGlzUXQoKSkgewogICAgICMgUmVtb3ZlIGR1cGxpY2F0ZWQgLS1xdCBvcHRpb25zIHRv IGF2b2lkIHBhc3NpbmcgdGhlbSB0byBxbWFrZQogICAgIGNoZWNrRm9yQXJndW1lbnRBbmRSZW1v dmVGcm9tQVJHVigiLS1xdCIpOwotLSAKMS43LjIuMwoK