58330 2011-04-12 08:55:16 -0700 Page tears and stutters in WebKit2 when page is > 2048 pixels wide 2011-04-12 15:43:24 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 cmarrin cmarrin simon.fraser oldest_to_newest 384038 0 cmarrin 2011-04-12 08:55:16 -0700 From <rdar://problem/9000193>. Open Window with animated Flash or composited content (often http://cnn.com has animated Flash on the front page), make the Window wider than 2048 pixels and then scroll. Page tears and stutters. This is caused because in this case the root (non-composited) content is in a Tiled Layer which updates asynchronously, so different tiles are updated at different times. 384058 1 89215 cmarrin 2011-04-12 09:27:42 -0700 Created attachment 89215 Patch 384127 2 89215 simon.fraser 2011-04-12 10:41:05 -0700 Comment on attachment 89215 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=89215&action=review > Source/WebCore/platform/graphics/GraphicsLayer.h:263 > + bool allowTiledLayer() const { return m_allowTiledLayer; } > + virtual void setAllowTiledLayer(bool b) { m_allowTiledLayer = b; } Previous to this, knowledge of tiled layers was hidden in GraphicsLayerCA. I think these methods should be on GraphicsLayerCA, and LayerTreeHost should cast. 384433 3 cmarrin 2011-04-12 15:43:24 -0700 Committed r83653: <http://trac.webkit.org/changeset/83653> 89215 2011-04-12 09:27:42 -0700 2011-04-12 10:41:05 -0700 Patch bug-58330-20110412092742.patch text/plain 6235 cmarrin SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDgzNTkzKQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjcgQEAKKzIwMTEtMDQtMTIgIENocmlzIE1h cnJpbiAgPGNtYXJyaW5AYXBwbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIFBhZ2UgdGVhcnMgYW5kIHN0dXR0ZXJzIGluIFdlYktpdDIgd2hl biBwYWdlIGlzID4gMjA0OCBwaXhlbHMgd2lkZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTgzMzAKKworICAgICAgICBBZGRlZCBBUEkgdG8gR3JhcGhp Y3NMYXllciB0byBkaXNhYmxlIHN3aXRjaGluZyB0byB0aWxlZCBsYXllcnMuIFRoaXMgaXMgCisg ICAgICAgIHNldCBpbiB0aGUgbm9uQ29tcG9zaXRlZENvbnRlbnRMYXllciBpbiBXSzIsIGNhdXNp bmcgdGhhdCBsYXllciB0byBuZXZlcgorICAgICAgICBzd2l0Y2ggdG8gdGlsZXMgYW5kIGF2b2lk aW5nIHRoZSBhc3luY2hyb25vdXMgdXBkYXRlIG9mIHRoZSBjb250ZW50IGR1cmluZworICAgICAg ICBzY3JvbGwuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9HcmFwaGljc0xheWVyLmNw cDoKKyAgICAgICAgKFdlYkNvcmU6OkdyYXBoaWNzTGF5ZXI6OkdyYXBoaWNzTGF5ZXIpOgorICAg ICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL0dyYXBoaWNzTGF5ZXIuaDoKKyAgICAgICAgKFdlYkNv cmU6OkdyYXBoaWNzTGF5ZXI6OmFsbG93VGlsZWRMYXllcik6CisgICAgICAgIChXZWJDb3JlOjpH cmFwaGljc0xheWVyOjpzZXRBbGxvd1RpbGVkTGF5ZXIpOgorICAgICAgICAqIHBsYXRmb3JtL2dy YXBoaWNzL2NhL0dyYXBoaWNzTGF5ZXJDQS5jcHA6CisgICAgICAgICAgICBPdmVycmlkZSBzZXRB bGxvd1RpbGVkTGF5ZXIoKSBhbmQgc2ltdWxhdGUgYSBTaXplQ2hhbmdlZCBhY3Rpb24gdG8gCisg ICAgICAgICAgICBwcm9wZXJseSBzd2l0Y2ggYmV0d2VlbiB0aWxlZCBhbmQgdW50aWxlZCBsYXll ci4KKyAgICAgICAgKFdlYkNvcmU6OkdyYXBoaWNzTGF5ZXJDQTo6c2V0QWxsb3dUaWxlZExheWVy KToKKyAgICAgICAgKFdlYkNvcmU6OkdyYXBoaWNzTGF5ZXJDQTo6cmVxdWlyZXNUaWxlZExheWVy KToKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9jYS9HcmFwaGljc0xheWVyQ0EuaDoKKwog MjAxMS0wNC0xMiAgQ3NhYmEgT3N6dHJvZ29uw6FjICA8b3NzeUB3ZWJraXQub3JnPgogCiAgICAg ICAgIFJldmlld2VkIGJ5IEJlbmphbWluIFBvdWxhaW4uCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9ncmFwaGljcy9HcmFwaGljc0xheWVyLmNwcAo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9HcmFwaGljc0xheWVyLmNwcAkocmV2aXNpb24gODM1 MTApCisrKyBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9HcmFwaGljc0xheWVyLmNw cAkod29ya2luZyBjb3B5KQpAQCAtNzQsNiArNzQsNyBAQCBHcmFwaGljc0xheWVyOjpHcmFwaGlj c0xheWVyKEdyYXBoaWNzTGF5CiAgICAgLCBtX21hc2tzVG9Cb3VuZHMoZmFsc2UpCiAgICAgLCBt X2RyYXdzQ29udGVudChmYWxzZSkKICAgICAsIG1fYWNjZWxlcmF0ZXNEcmF3aW5nKGZhbHNlKQor ICAgICwgbV9hbGxvd1RpbGVkTGF5ZXIodHJ1ZSkKICAgICAsIG1fcGFpbnRpbmdQaGFzZShHcmFw aGljc0xheWVyUGFpbnRBbGwpCiAgICAgLCBtX2NvbnRlbnRzT3JpZW50YXRpb24oQ29tcG9zaXRp bmdDb29yZGluYXRlc1RvcERvd24pCiAgICAgLCBtX3BhcmVudCgwKQpJbmRleDogU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvR3JhcGhpY3NMYXllci5oCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0dyYXBoaWNzTGF5ZXIuaAkocmV2aXNpb24g ODM1MTApCisrKyBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9HcmFwaGljc0xheWVy LmgJKHdvcmtpbmcgY29weSkKQEAgLTI1OSw2ICsyNTksOSBAQCBwdWJsaWM6CiAgICAgYm9vbCBh Y2NlbGVyYXRlc0RyYXdpbmcoKSBjb25zdCB7IHJldHVybiBtX2FjY2VsZXJhdGVzRHJhd2luZzsg fQogICAgIHZpcnR1YWwgdm9pZCBzZXRBY2NlbGVyYXRlc0RyYXdpbmcoYm9vbCBiKSB7IG1fYWNj ZWxlcmF0ZXNEcmF3aW5nID0gYjsgfQogCisgICAgYm9vbCBhbGxvd1RpbGVkTGF5ZXIoKSBjb25z dCB7IHJldHVybiBtX2FsbG93VGlsZWRMYXllcjsgfQorICAgIHZpcnR1YWwgdm9pZCBzZXRBbGxv d1RpbGVkTGF5ZXIoYm9vbCBiKSB7IG1fYWxsb3dUaWxlZExheWVyID0gYjsgfQorCiAgICAgLy8g VGhlIGNvbG9yIHVzZWQgdG8gcGFpbnQgdGhlIGxheWVyIGJhY2tncm91bmRzCiAgICAgY29uc3Qg Q29sb3ImIGJhY2tncm91bmRDb2xvcigpIGNvbnN0IHsgcmV0dXJuIG1fYmFja2dyb3VuZENvbG9y OyB9CiAgICAgdmlydHVhbCB2b2lkIHNldEJhY2tncm91bmRDb2xvcihjb25zdCBDb2xvciYpOwpA QCAtNDAxLDYgKzQwNCw3IEBAIHByb3RlY3RlZDoKICAgICBib29sIG1fbWFza3NUb0JvdW5kcyA6 IDE7CiAgICAgYm9vbCBtX2RyYXdzQ29udGVudCA6IDE7CiAgICAgYm9vbCBtX2FjY2VsZXJhdGVz RHJhd2luZyA6IDE7CisgICAgYm9vbCBtX2FsbG93VGlsZWRMYXllciA6IDE7CiAKICAgICBHcmFw aGljc0xheWVyUGFpbnRpbmdQaGFzZSBtX3BhaW50aW5nUGhhc2U7CiAgICAgQ29tcG9zaXRpbmdD b29yZGluYXRlc09yaWVudGF0aW9uIG1fY29udGVudHNPcmllbnRhdGlvbjsgLy8gYWZmZWN0cyBv cmllbnRhdGlvbiBvZiBsYXllciBjb250ZW50cwpJbmRleDogU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vZ3JhcGhpY3MvY2EvR3JhcGhpY3NMYXllckNBLmNwcAo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jYS9HcmFwaGljc0xheWVyQ0EuY3BwCShyZXZpc2lv biA4MzUxMCkKKysrIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2NhL0dyYXBoaWNz TGF5ZXJDQS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTQ5Miw2ICs0OTIsMTcgQEAgdm9pZCBHcmFw aGljc0xheWVyQ0E6OnNldEFjY2VsZXJhdGVzRHJhdwogICAgIG5vdGVMYXllclByb3BlcnR5Q2hh bmdlZChBY2NlbGVyYXRlc0RyYXdpbmdDaGFuZ2VkKTsKIH0KIAordm9pZCBHcmFwaGljc0xheWVy Q0E6OnNldEFsbG93VGlsZWRMYXllcihib29sIGFsbG93VGlsZWRMYXllcikKK3sKKyAgICBpZiAo YWxsb3dUaWxlZExheWVyID09IG1fYWxsb3dUaWxlZExheWVyKQorICAgICAgICByZXR1cm47CisK KyAgICBHcmFwaGljc0xheWVyOjpzZXRBbGxvd1RpbGVkTGF5ZXIoYWxsb3dUaWxlZExheWVyKTsK KyAgICAKKyAgICAvLyBIYW5kbGluZyB0aGlzIGFzIGEgU2l6ZUNoYW5nZWQgd2lsbCBjYXVzZSB1 c2UgdG8gc3dpdGNoIGluIG9yIG91dCBvZiB0aWxlZCBsYXllciBhcyBuZWVkZWQKKyAgICBub3Rl TGF5ZXJQcm9wZXJ0eUNoYW5nZWQoU2l6ZUNoYW5nZWQpOworfQorCiB2b2lkIEdyYXBoaWNzTGF5 ZXJDQTo6c2V0QmFja2dyb3VuZENvbG9yKGNvbnN0IENvbG9yJiBjb2xvcikKIHsKICAgICBpZiAo bV9iYWNrZ3JvdW5kQ29sb3JTZXQgJiYgbV9iYWNrZ3JvdW5kQ29sb3IgPT0gY29sb3IpCkBAIC0y MDA1LDcgKzIwMTYsNyBAQCBGbG9hdFNpemUgR3JhcGhpY3NMYXllckNBOjpjb25zdHJhaW5lZFNp CiAKIGJvb2wgR3JhcGhpY3NMYXllckNBOjpyZXF1aXJlc1RpbGVkTGF5ZXIoY29uc3QgRmxvYXRT aXplJiBzaXplKSBjb25zdAogewotICAgIGlmICghbV9kcmF3c0NvbnRlbnQpCisgICAgaWYgKCFt X2RyYXdzQ29udGVudCB8fCAhbV9hbGxvd1RpbGVkTGF5ZXIpCiAgICAgICAgIHJldHVybiBmYWxz ZTsKIAogICAgIC8vIEZJWE1FOiBjYXRjaCB6ZXJvLXNpemUgaGVpZ2h0IG9yIHdpZHRoIGhlcmUg KG9yIGVhcmxpZXIpPwpJbmRleDogU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2Ev R3JhcGhpY3NMYXllckNBLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v Z3JhcGhpY3MvY2EvR3JhcGhpY3NMYXllckNBLmgJKHJldmlzaW9uIDgzNTEwKQorKysgU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2EvR3JhcGhpY3NMYXllckNBLmgJKHdvcmtpbmcg Y29weSkKQEAgLTgzLDYgKzgzLDcgQEAgcHVibGljOgogICAgIHZpcnR1YWwgdm9pZCBzZXRNYXNr c1RvQm91bmRzKGJvb2wpOwogICAgIHZpcnR1YWwgdm9pZCBzZXREcmF3c0NvbnRlbnQoYm9vbCk7 CiAgICAgdmlydHVhbCB2b2lkIHNldEFjY2VsZXJhdGVzRHJhd2luZyhib29sKTsKKyAgICB2aXJ0 dWFsIHZvaWQgc2V0QWxsb3dUaWxlZExheWVyKGJvb2wpOwogCiAgICAgdmlydHVhbCB2b2lkIHNl dEJhY2tncm91bmRDb2xvcihjb25zdCBDb2xvciYpOwogICAgIHZpcnR1YWwgdm9pZCBjbGVhckJh Y2tncm91bmRDb2xvcigpOwpJbmRleDogU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwkocmV2aXNpb24gODM1OTMpCisrKyBTb3Vy Y2UvV2ViS2l0Mi9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxNiBAQAorMjAx MS0wNC0xMiAgQ2hyaXMgTWFycmluICA8Y21hcnJpbkBhcHBsZS5jb20+CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUGFnZSB0ZWFycyBhbmQgc3R1dHRl cnMgaW4gV2ViS2l0MiB3aGVuIHBhZ2UgaXMgPiAyMDQ4IHBpeGVscyB3aWRlCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01ODMzMAorCisgICAgICAgIFR1 cm4gb2ZmIHRpbGluZyBmb3Igbm9uQ29tcG9zaXRlZENvbnRlbnRMYXllciB0byBhdm9pZCB0ZWFy aW5nIHdoZW4KKyAgICAgICAgc2Nyb2xsaW5nIHZlcnkgd2lkZSAoPiAyMDQ4KSB3aW5kb3dzLgor CisgICAgICAgICogV2ViUHJvY2Vzcy9XZWJQYWdlL2NhL0xheWVyVHJlZUhvc3RDQS5jcHA6Cisg ICAgICAgIChXZWJLaXQ6OkxheWVyVHJlZUhvc3RDQTo6aW5pdGlhbGl6ZSk6CisKIDIwMTEtMDQt MTIgIEFsZWphbmRybyBHLiBDYXN0cm8gIDxhbGV4QGlnYWxpYS5jb20+CiAKICAgICAgICAgRml4 ZWQgR1RLIGNvbXBpbGF0aW9uIGFmdGVyIHI4MzQ1NC4KSW5kZXg6IFNvdXJjZS9XZWJLaXQyL1dl YlByb2Nlc3MvV2ViUGFnZS9jYS9MYXllclRyZWVIb3N0Q0EuY3BwCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNv dXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9jYS9MYXllclRyZWVIb3N0Q0EuY3BwCShy ZXZpc2lvbiA4MzUxMCkKKysrIFNvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9jYS9M YXllclRyZWVIb3N0Q0EuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC01OSw2ICs1OSw3IEBAIHZvaWQg TGF5ZXJUcmVlSG9zdENBOjppbml0aWFsaXplKCkKICAgICBzdGF0aWNfY2FzdDxHcmFwaGljc0xh eWVyQ0EqPihtX3Jvb3RMYXllci5nZXQoKSktPnBsYXRmb3JtQ0FMYXllcigpLT5zZXRHZW9tZXRy eUZsaXBwZWQodHJ1ZSk7CiAKICAgICBtX25vbkNvbXBvc2l0ZWRDb250ZW50TGF5ZXIgPSBHcmFw aGljc0xheWVyOjpjcmVhdGUodGhpcyk7CisgICAgbV9ub25Db21wb3NpdGVkQ29udGVudExheWVy LT5zZXRBbGxvd1RpbGVkTGF5ZXIoZmFsc2UpOwogI2lmbmRlZiBOREVCVUcKICAgICBtX25vbkNv bXBvc2l0ZWRDb250ZW50TGF5ZXItPnNldE5hbWUoIkxheWVyVHJlZUhvc3Qgbm9uLWNvbXBvc2l0 ZWQgY29udGVudCIpOwogI2VuZGlmCg==