<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>58315</bug_id>
          
          <creation_ts>2011-04-12 05:37:48 -0700</creation_ts>
          <short_desc>REGRESSION (r81479): generate-inspector-idl fails on native win32</short_desc>
          <delta_ts>2011-04-18 04:29:35 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Tools / Tests</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>All</rep_platform>
          <op_sys>All</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          <dependson>56294</dependson>
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Patrick R. Gansterer">paroga</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>commit-queue</cc>
    
    <cc>pfeldman</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>383949</commentid>
    <comment_count>0</comment_count>
    <who name="Patrick R. Gansterer">paroga</who>
    <bug_when>2011-04-12 05:37:48 -0700</bug_when>
    <thetext>generate-inspector-idl fails if Inspector.json contains carriage return characters.
You get them if you use a _git_ checkout with autocrlf enabled.
To solve this we can:
a) Add &quot;-crlf&quot; git attribute in &quot;.gitattributes&quot;
b) Replace &apos;\r\n&apos; before passing the content to eval
c) Use a JSON parser</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>387373</commentid>
    <comment_count>1</comment_count>
      <attachid>89950</attachid>
    <who name="Patrick R. Gansterer">paroga</who>
    <bug_when>2011-04-17 10:23:07 -0700</bug_when>
    <thetext>Created attachment 89950
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>387633</commentid>
    <comment_count>2</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2011-04-18 04:27:12 -0700</bug_when>
    <thetext>The commit-queue encountered the following flaky tests while processing attachment 89950:

http/tests/xmlhttprequest/cross-origin-authorization.html bug 52398 (author: ap@webkit.org)
The commit-queue is continuing to process your patch.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>387634</commentid>
    <comment_count>3</comment_count>
      <attachid>89950</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2011-04-18 04:29:31 -0700</bug_when>
    <thetext>Comment on attachment 89950
Patch

Clearing flags on attachment: 89950

Committed r84130: &lt;http://trac.webkit.org/changeset/84130&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>387635</commentid>
    <comment_count>4</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2011-04-18 04:29:35 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>89950</attachid>
            <date>2011-04-17 10:23:07 -0700</date>
            <delta_ts>2011-04-18 04:29:31 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-58315-20110417192304.patch</filename>
            <type>text/plain</type>
            <size>1278</size>
            <attacher name="Patrick R. Gansterer">paroga</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogODQxMDMKZGlmZiAtLWdpdCBhLy5naXRhdHRyaWJ1dGVzIGIv
LmdpdGF0dHJpYnV0ZXMKaW5kZXggODExN2Q4YTg4NGIxNDU0NWUzNjhjOGVjMGEyZmJmZDY2MTMw
ZjkyNi4uNmYyNDMyMWFkOGQ0NGM4NTBlZmM0ZGJlYzBlZDU1MGIwYWNkYTUzNyAxMDA2NDQKLS0t
IGEvLmdpdGF0dHJpYnV0ZXMKKysrIGIvLmdpdGF0dHJpYnV0ZXMKQEAgLTE5Nyw2ICsxOTcsNyBA
QCBQZXJmb3JtYW5jZVRlc3RzL1N1blNwaWRlci90ZXN0cy9wYXJzZS1vbmx5L2pxdWVyeS0xLjMu
Mi5qcyAtY3JsZgogU291cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9BY2Nlc3NpYmlsaXR5QWxs
SW5PbmUuY3BwIC1jcmxmCiBTb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9qcy9KU0V4Y2VwdGlvbkJh
c2UuY3BwIC1jcmxmCiBTb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9qcy9KU0V4Y2VwdGlvbkJhc2Uu
aCAtY3JsZgorU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3Rvci5qc29uIC1jcmxmCiBT
b3VyY2UvV2ViQ29yZS9tYW51YWwtdGVzdHMvRE9NQ29udGV4dE1lbnVFdmVudC5odG1sIC1jcmxm
CiBTb3VyY2UvV2ViQ29yZS9tYW51YWwtdGVzdHMvY3Vyc29yLW1heC1zaXplLmh0bWwgLWNybGYK
IFNvdXJjZS9XZWJDb3JlL21hbnVhbC10ZXN0cy9kcmFnLXdpdGgtZGl2LW9yLWltYWdlLWFzLWRh
dGEtaW1hZ2UuaHRtbCAtY3JsZgpkaWZmIC0tZ2l0IGEvQ2hhbmdlTG9nIGIvQ2hhbmdlTG9nCmlu
ZGV4IDgwZDA0M2I3YjE5Y2U4MzMyZjg3NGM0MzY0NWJlMDI1OGUxMThkYTcuLjkxMWM2ZjIzYTM4
MTNhM2ZhM2JkYWFiZWJjZWI3MDQ2NjVmMzM0YTEgMTAwNjQ0Ci0tLSBhL0NoYW5nZUxvZworKysg
Yi9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAorMjAxMS0wNC0xNyAgUGF0cmljayBHYW5zdGVy
ZXIgIDxwYXJvZ2FAd2Via2l0Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P
UFMhKS4KKworICAgICAgICBSRUdSRVNTSU9OIChyODE0NzkpOiBnZW5lcmF0ZS1pbnNwZWN0b3It
aWRsIGZhaWxzIG9uIG5hdGl2ZSB3aW4zMgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y
Zy9zaG93X2J1Zy5jZ2k/aWQ9NTgzMTUKKworICAgICAgICBEaXNhYmxlIGdpdCBhdXRvY3JsZiBm
b3IgSW5zcGVjdG9yLmpzb24uCisKKyAgICAgICAgKiAuZ2l0YXR0cmlidXRlczoKKwogMjAxMS0w
NC0xNiAgUGF0cmljayBHYW5zdGVyZXIgIDxwYXJvZ2FAd2Via2l0Lm9yZz4KIAogICAgICAgICBS
ZXZpZXdlZCBieSBFcmljIFNlaWRlbC4K
</data>

          </attachment>
      

    </bug>

</bugzilla>