58314 2011-04-12 04:20:48 -0700 Web Inspector: Breakpoints and execution line decoration should stay in place if the edited line is not whitespace 2011-04-12 07:02:12 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 aandrey webkit-unassigned apavlov bweinstein commit-queue joepeck keishi loislo pfeldman pmuellr rik timothy yurys oldest_to_newest 383926 0 aandrey 2011-04-12 04:20:48 -0700 If we edit a line that has a breakpoint or other decoration (e.g. execution line), we should move the breakpoint below only if the edited line become a whitespace. Most common case: user puts a line break at the beginning of the line. 383927 1 89188 aandrey 2011-04-12 04:23:43 -0700 Created attachment 89188 Patch 383979 2 89188 commit-queue 2011-04-12 07:02:06 -0700 Comment on attachment 89188 Patch Clearing flags on attachment: 89188 Committed r83586: <http://trac.webkit.org/changeset/83586> 383980 3 commit-queue 2011-04-12 07:02:12 -0700 All reviewed patches have been landed. Closing bug. 89188 2011-04-12 04:23:43 -0700 2011-04-12 07:02:06 -0700 Patch bug-58314-20110412152340.patch text/plain 2087 aandrey U3VidmVyc2lvbiBSZXZpc2lvbjogODM1NjkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBiNWY2NmRlZjk2ZjQyYjA5 NDRkOWEwYmM5OGM0NWRiMTE5NGEzMTIxLi5hZWI2MmY5ODk5ZWY2NTAyMDQ1N2VmNjY3NDRmNjNm YjdlZjc5MzhkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTEtMDQtMTIgIEFuZHJl eSBBZGFpa2luICA8YWFuZHJleUBnb29nbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIFdlYiBJbnNwZWN0b3I6IEJyZWFrcG9pbnRzIGFuZCBl eGVjdXRpb24gbGluZSBkZWNvcmF0aW9uIHNob3VsZCBzdGF5IGluIHBsYWNlIGlmIHRoZSBlZGl0 ZWQgbGluZSBpcyBub3Qgd2hpdGVzcGFjZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9NTgzMTQKKworICAgICAgICAqIGluc3BlY3Rvci9mcm9udC1lbmQv U291cmNlRnJhbWUuanM6CisgICAgICAgIChXZWJJbnNwZWN0b3IuU291cmNlRnJhbWUucHJvdG90 eXBlLl9saW5lTnVtYmVyQWZ0ZXJFZGl0aW5nKToKKwogMjAxMS0wNC0wNiAgUGhpbGlwcGUgTm9y bWFuZCAgPHBub3JtYW5kQGlnYWxpYS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgTWFydGlu IFJvYmluc29uLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVu ZC9Tb3VyY2VGcmFtZS5qcyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvU291 cmNlRnJhbWUuanMKaW5kZXggYjAwMjY5NGYzYjYxOGZhMjY4NWI3YzFhMzRjMTA0Mjc3YjY4OWJh Mi4uZmI0ZjcwYWY3YjVjYjBlYzdkZDI3N2QwM2FjNWU3MmVmMGRlMTNkNyAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9Tb3VyY2VGcmFtZS5qcworKysgYi9T b3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1NvdXJjZUZyYW1lLmpzCkBAIC0yNzQs OCArMjc0LDE1IEBAIFdlYkluc3BlY3Rvci5Tb3VyY2VGcmFtZS5wcm90b3R5cGUgPSB7CiAgICAg ICAgIHZhciBzaGlmdE9mZnNldCA9IGxpbmVOdW1iZXIgPD0gb2xkUmFuZ2Uuc3RhcnRMaW5lID8g MCA6IG5ld1JhbmdlLmxpbmVzQ291bnQgLSBvbGRSYW5nZS5saW5lc0NvdW50OwogCiAgICAgICAg IC8vIFNwZWNpYWwgY2FzZSBvZiBlZGl0aW5nIHRoZSBsaW5lIGl0c2VsZi4gV2Ugc2hvdWxkIGRl Y2lkZSB3aGV0aGVyIHRoZSBsaW5lIG51bWJlciBzaG91bGQgbW92ZSBiZWxvdyBvciBub3QuCi0g ICAgICAgIGlmIChsaW5lTnVtYmVyID09PSBvbGRSYW5nZS5zdGFydExpbmUgJiYgbGluZU51bWJl ciArIDEgPD0gbmV3UmFuZ2UuZW5kTGluZSAmJiB0aGlzLl90ZXh0TW9kZWwubGluZUxlbmd0aChs aW5lTnVtYmVyKSA8IHRoaXMuX3RleHRNb2RlbC5saW5lTGVuZ3RoKGxpbmVOdW1iZXIgKyAxKSkK LSAgICAgICAgICAgIHNoaWZ0T2Zmc2V0ID0gMTsKKyAgICAgICAgaWYgKGxpbmVOdW1iZXIgPT09 IG9sZFJhbmdlLnN0YXJ0TGluZSkgeworICAgICAgICAgICAgdmFyIHdoaXRlU3BhY2VzUmVnZXgg PSAvXltcc1x4QTBdKiQvOworICAgICAgICAgICAgZm9yICh2YXIgaSA9IDA7IGxpbmVOdW1iZXIg KyBpIDw9IG5ld1JhbmdlLmVuZExpbmU7ICsraSkgeworICAgICAgICAgICAgICAgIGlmICghd2hp dGVTcGFjZXNSZWdleC50ZXN0KHRoaXMuX3RleHRNb2RlbC5saW5lKGxpbmVOdW1iZXIgKyBpKSkp IHsKKyAgICAgICAgICAgICAgICAgICAgc2hpZnRPZmZzZXQgPSBpOworICAgICAgICAgICAgICAg ICAgICBicmVhazsKKyAgICAgICAgICAgICAgICB9CisgICAgICAgICAgICB9CisgICAgICAgIH0K IAogICAgICAgICB2YXIgbmV3TGluZU51bWJlciA9IE1hdGgubWF4KDAsIGxpbmVOdW1iZXIgKyBz aGlmdE9mZnNldCk7CiAgICAgICAgIGlmIChvbGRSYW5nZS5zdGFydExpbmUgPCBsaW5lTnVtYmVy ICYmIGxpbmVOdW1iZXIgPCBvbGRSYW5nZS5lbmRMaW5lKQo=