58311 2011-04-12 02:28:28 -0700 Member field in PluginView for efl port is not initialized 2011-04-20 08:42:17 -0700 1 1 1 Unclassified WebKit Plug-ins 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 0 mariusz.g webkit-unassigned abarth commit-queue eric gyuyoung.kim l.slachciak mariusz.g webkit.review.bot oldest_to_newest 383906 0 mariusz.g 2011-04-12 02:28:28 -0700 Initialize m_window member field for efl port in constructor. 383908 1 89180 mariusz.g 2011-04-12 02:33:06 -0700 Created attachment 89180 Initializing of m_window member field in PluginView's constructor for efl port 384153 2 89180 eric 2011-04-12 10:55:35 -0700 Comment on attachment 89180 Initializing of m_window member field in PluginView's constructor for efl port View in context: https://bugs.webkit.org/attachment.cgi?id=89180&action=review OK. > Source/WebCore/ChangeLog:8 > + No new tests. (OOPS!) This prevents the CQ from landing yoru patch. You should have replaced this with a string saying how testing isn't needed/possible for this patch. 389120 3 90323 mariusz.g 2011-04-20 02:02:41 -0700 Created attachment 90323 Initializing of m_window member field in PluginView's constructor for efl port 389164 4 90323 kling 2011-04-20 05:51:52 -0700 Comment on attachment 90323 Initializing of m_window member field in PluginView's constructor for efl port Sure. 389171 5 90323 commit-queue 2011-04-20 06:20:50 -0700 Comment on attachment 90323 Initializing of m_window member field in PluginView's constructor for efl port Clearing flags on attachment: 90323 Committed r84362: <http://trac.webkit.org/changeset/84362> 389172 6 commit-queue 2011-04-20 06:20:55 -0700 All reviewed patches have been landed. Closing bug. 389250 7 webkit.review.bot 2011-04-20 08:42:17 -0700 http://trac.webkit.org/changeset/84362 might have broken GTK Linux 32-bit Debug 89180 2011-04-12 02:33:06 -0700 2011-04-20 02:02:57 -0700 Initializing of m_window member field in PluginView's constructor for efl port init.patch text/plain 1178 mariusz.g ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBjMDZiN2RlLi5iZGQ2ZmUzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUg QEAKKzIwMTEtMDQtMTIgIE1hcml1c3ogR3J6ZWdvcmN6eWsgIDxtYXJpdXN6LmdAc2Ftc3VuZy5j b20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW0VG TF0gSW5pdGlhbGl6aW5nIG1fd2luZG93IG1lbWJlciBmaWVsZCBpbiBQbHVnaW5WaWV3LmNwcCBm b3IgZWZsIHBvcnQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTU4MzExCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLiAoT09QUyEpCisKKyAgICAgICAgKiBw bHVnaW5zL1BsdWdpblZpZXcuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UGx1Z2luVmlldzo6UGx1 Z2luVmlldyk6CisKIDIwMTEtMDQtMTIgIFZzZXZvbG9kIFZsYXNvdiAgPHZzZXZpa0BjaHJvbWl1 bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgUGF2ZWwgRmVsZG1hbi4KZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJDb3JlL3BsdWdpbnMvUGx1Z2luVmlldy5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9w bHVnaW5zL1BsdWdpblZpZXcuY3BwCmluZGV4IDE0YTgwNzEuLjg4YjhjNjQgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJDb3JlL3BsdWdpbnMvUGx1Z2luVmlldy5jcHAKKysrIGIvU291cmNlL1dlYkNv cmUvcGx1Z2lucy9QbHVnaW5WaWV3LmNwcApAQCAtODU5LDcgKzg1OSw3IEBAIFBsdWdpblZpZXc6 OlBsdWdpblZpZXcoRnJhbWUqIHBhcmVudEZyYW1lLCBjb25zdCBJbnRTaXplJiBzaXplLCBQbHVn aW5QYWNrYWdlKiBwCiAgICAgLCBtX3dtUHJpbnRIREMoMCkKICAgICAsIG1faGF2ZVVwZGF0ZWRQ bHVnaW5XaWRnZXQoZmFsc2UpCiAjZW5kaWYKLSNpZiAoUExBVEZPUk0oUVQpICYmIE9TKFdJTkRP V1MpKSB8fCBkZWZpbmVkKFhQX01BQ09TWCkKKyNpZiAoUExBVEZPUk0oUVQpICYmIE9TKFdJTkRP V1MpKSB8fCBkZWZpbmVkKFhQX01BQ09TWCkgfHwgUExBVEZPUk0oRUZMKQogICAgICwgbV93aW5k b3coMCkKICNlbmRpZgogI2lmIGRlZmluZWQoWFBfTUFDT1NYKQo= 90323 2011-04-20 02:02:41 -0700 2011-04-20 06:20:50 -0700 Initializing of m_window member field in PluginView's constructor for efl port init.patch text/plain 1210 mariusz.g ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBjMDZiN2RlLi5iZGQ2ZmUzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUg QEAKKzIwMTEtMDQtMTIgIE1hcml1c3ogR3J6ZWdvcmN6eWsgIDxtYXJpdXN6LmdAc2Ftc3VuZy5j b20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW0VG TF0gSW5pdGlhbGl6aW5nIG1fd2luZG93IG1lbWJlciBmaWVsZCBpbiBQbHVnaW5WaWV3LmNwcCBm b3IgZWZsIHBvcnQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTU4MzExCisKKyAgICAgICAgTm8gbmV3IHRlc3RzIG5lZWRlZDogb25seSBpbml0aWFsaXpp bmcgY2xhc3MgbWVtYmVyLgorCisgICAgICAgICogcGx1Z2lucy9QbHVnaW5WaWV3LmNwcDoKKyAg ICAgICAgKFdlYkNvcmU6OlBsdWdpblZpZXc6OlBsdWdpblZpZXcpOgorCiAyMDExLTA0LTEyICBW c2V2b2xvZCBWbGFzb3YgIDx2c2V2aWtAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2Vk IGJ5IFBhdmVsIEZlbGRtYW4uCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbHVnaW5zL1Bs dWdpblZpZXcuY3BwIGIvU291cmNlL1dlYkNvcmUvcGx1Z2lucy9QbHVnaW5WaWV3LmNwcAppbmRl eCAxNGE4MDcxLi44OGI4YzY0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbHVnaW5zL1Bs dWdpblZpZXcuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsdWdpbnMvUGx1Z2luVmlldy5jcHAK QEAgLTg1OSw3ICs4NTksNyBAQCBQbHVnaW5WaWV3OjpQbHVnaW5WaWV3KEZyYW1lKiBwYXJlbnRG cmFtZSwgY29uc3QgSW50U2l6ZSYgc2l6ZSwgUGx1Z2luUGFja2FnZSogcAogICAgICwgbV93bVBy aW50SERDKDApCiAgICAgLCBtX2hhdmVVcGRhdGVkUGx1Z2luV2lkZ2V0KGZhbHNlKQogI2VuZGlm Ci0jaWYgKFBMQVRGT1JNKFFUKSAmJiBPUyhXSU5ET1dTKSkgfHwgZGVmaW5lZChYUF9NQUNPU1gp CisjaWYgKFBMQVRGT1JNKFFUKSAmJiBPUyhXSU5ET1dTKSkgfHwgZGVmaW5lZChYUF9NQUNPU1gp IHx8IFBMQVRGT1JNKEVGTCkKICAgICAsIG1fd2luZG93KDApCiAjZW5kaWYKICNpZiBkZWZpbmVk KFhQX01BQ09TWCkKCg==