58309 2011-04-12 02:15:55 -0700 [GTK] fast/canvas/DrawImageSinglePixelStretch.html fails 2013-04-18 09:18:55 -0700 1 1 1 Unclassified WebKit Canvas 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED Gtk, LayoutTestFailure P2 Normal --- 1 pnormand mrobinson d-r krit leandro mdelaney7 mrobinson nishant.646 nishant.bansal rakuco webkit.review.bot zan oldest_to_newest 383903 0 pnormand 2011-04-12 02:15:55 -0700 The color inside the rectangle is not uniform, it's more like a gradient. Will skip for now. 384197 1 mdelaney7 2011-04-12 11:39:19 -0700 Yea, that's the incorrect behavior you're seeing then. It does show a 'FAILED', correct? I've interpreted this portion of the spec as the inspiration for this test: "If the original image data is a bitmap image, the value painted at a point in the destination rectangle is computed by filtering the original image data. The user agent may use any filtering algorithm (for example bilinear interpolation or nearest-neighbor). When the filtering algorithm requires a pixel value from outside the original image data, it must instead use the value from the nearest edge pixel. (That is, the filter uses 'clamp-to-edge' behavior.)" It also came to my attention that many rendering platforms don't usually do this behavior of clamp to edge because it's not desired in cases where tiling of an image happens and such. Though, the pixels can be first copied into a buffer image and then drawn to effectively create the clamp to edge behavior. 838174 2 nishant.bansal 2013-02-20 23:38:27 -0800 The same issue is also present in EFL port. 838468 3 krit 2013-02-21 08:50:53 -0800 Can you upload and expected and actual image for comparison please? 839033 4 189642 mrobinson 2013-02-21 17:00:13 -0800 Created attachment 189642 Patch 839038 5 mrobinson 2013-02-21 17:09:21 -0800 (In reply to comment #3) > Can you upload and expected and actual image for comparison please? The test is a text dump, but with a bit of tinkering I was able to see the canvas. It's clear that the issue is that we are sampling outside the source rectangle. I've uploaded a patch fixing the issue. 839453 6 nishant.bansal 2013-02-22 04:12:16 -0800 I tried this patch. The issue is still present in EFL port. 839570 7 mrobinson 2013-02-22 07:54:44 -0800 (In reply to comment #6) > I tried this patch. The issue is still present in EFL port. What version of Cairo? Also, are you using a backend other than image? 840838 8 nishant.bansal 2013-02-25 03:20:54 -0800 (In reply to comment #7) > (In reply to comment #6) > > I tried this patch. The issue is still present in EFL port. > > What version of Cairo? Also, are you using a backend other than image? cairo version is 1.12.4. I didn't understand your second query. 841598 9 nishant.bansal 2013-02-25 21:20:12 -0800 There was some build problem or something. I tried this patch on the latest webkit and it worked fine. 841665 10 mrobinson 2013-02-25 23:05:05 -0800 (In reply to comment #9) > There was some build problem or something. I tried this patch on the latest webkit and it worked fine. Thanks for the information. Dirk, maybe you would be willing to review this patch? 874300 11 189642 alex 2013-04-11 17:15:06 -0700 Comment on attachment 189642 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=189642&action=review LGTM! > Source/WebCore/platform/graphics/cairo/PlatformContextCairo.cpp:196 > + // The pattern transformation properly scales the pattern for when the source rectangle is a Nit, "for when" -> "when" 877929 12 189642 mrobinson 2013-04-18 09:18:50 -0700 Comment on attachment 189642 Patch Clearing flags on attachment: 189642 Committed r148681: <http://trac.webkit.org/changeset/148681> 877931 13 mrobinson 2013-04-18 09:18:55 -0700 All reviewed patches have been landed. Closing bug. 189642 2013-02-21 17:00:13 -0800 2013-04-18 09:18:50 -0700 Patch bug-58309-20130221165633.patch text/plain 6204 mrobinson U3VidmVyc2lvbiBSZXZpc2lvbjogMTQzNjIwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNDMzOGVhYTFmZTQ0NDli NmU3NWFiZmEzMDk2MjY2MzRhZGZhMzZjMC4uZjAyMTc2MzEyZGVlYzI3M2IxZWJiMDJlYmMyMWFj MmU4MDM5NDBlYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIxIEBACiAyMDEzLTAyLTIxICBNYXJ0 aW4gUm9iaW5zb24gIDxtcm9iaW5zb25AaWdhbGlhLmNvbT4KIAorICAgICAgICBbR1RLXSBmYXN0 L2NhbnZhcy9EcmF3SW1hZ2VTaW5nbGVQaXhlbFN0cmV0Y2guaHRtbCBmYWlscworICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTgzMDkKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBObyBuZXcgdGVzdHMuIFRoaXMg cGF0Y2ggdW5za2lwcyBhIHRlc3QuCisKKyAgICAgICAgUHJldmVudCBzYW1wbGluZyBvdXRzaWRl IHNvdXJjZSBib3VuZGFyaWVzLCBieSBjcmVhdGluZyBzdWJzdXJmYWNlcyBmcm9tIHNvdXJjZSBz dXJmYWNlcy4KKyAgICAgICAgVGhpcyBhbHNvIHJlcXVpcmVzIGNhcmVmdWwgaGFuZGxpbmcgb2Yg bmVnYXRpdmUgYW5kIGZsb2F0aW5nIHNvdXJjZSByZWN0YW5nbGVzLgorCisgICAgICAgICogcGxh dGZvcm0vZ3JhcGhpY3MvY2Fpcm8vUGxhdGZvcm1Db250ZXh0Q2Fpcm8uY3BwOgorICAgICAgICAo V2ViQ29yZTo6UGxhdGZvcm1Db250ZXh0Q2Fpcm86OmRyYXdTdXJmYWNlVG9Db250ZXh0KTogVXNl IGEgc3Vic3VyZmFjZSB0byBwcmV2ZW50IHNhbXBsaW5nCisgICAgICAgIG91dHNpZGUgcmVjdGFu Z2xlIGJvdW5kYXJpZXMuCisKKzIwMTMtMDItMjEgIE1hcnRpbiBSb2JpbnNvbiAgPG1yb2JpbnNv bkBpZ2FsaWEuY29tPgorCiAgICAgICAgIEEgY291cGxlIG1vcmUgJ21ha2UgZGlzdCcgZml4ZXMg Zm9yIFdlYktpdEdUSysuCiAKICAgICAgICAgKiBHTlVtYWtlZmlsZS5saXN0LmFtOiBBZGQgYSBt aXNzaW5nIGZpbGUgdG8gdGhlIHNvdXJjZSBsaXN0LgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2Fpcm8vUGxhdGZvcm1Db250ZXh0Q2Fpcm8uY3BwIGIvU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2Fpcm8vUGxhdGZvcm1Db250ZXh0Q2Fpcm8u Y3BwCmluZGV4IDg2NWQxNTI5NDQ4OGYwMTBiZDdlYmFhM2RmYWIyOTQ4ZWM0MDZkNjEuLjE0N2Rj MTVhZGZlMTM5YzIxNjA4OGRiZjg3OGYyMzYxZGI3MjM2ZjkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2NhaXJvL1BsYXRmb3JtQ29udGV4dENhaXJvLmNwcAor KysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jYWlyby9QbGF0Zm9ybUNvbnRl eHRDYWlyby5jcHAKQEAgLTE1NCwxMiArMTU0LDI4IEBAIHN0YXRpYyB2b2lkIGRyYXdQYXR0ZXJu VG9DYWlyb0NvbnRleHQoY2Fpcm9fdCogY3IsIGNhaXJvX3BhdHRlcm5fdCogcGF0dGVybiwgY29u CiAgICAgICAgIGNhaXJvX2ZpbGwoY3IpOwogfQogCi12b2lkIFBsYXRmb3JtQ29udGV4dENhaXJv OjpkcmF3U3VyZmFjZVRvQ29udGV4dChjYWlyb19zdXJmYWNlX3QqIHN1cmZhY2UsIGNvbnN0IEZs b2F0UmVjdCYgZGVzdFJlY3QsIGNvbnN0IEZsb2F0UmVjdCYgc3JjUmVjdCwgR3JhcGhpY3NDb250 ZXh0KiBjb250ZXh0KQordm9pZCBQbGF0Zm9ybUNvbnRleHRDYWlybzo6ZHJhd1N1cmZhY2VUb0Nv bnRleHQoY2Fpcm9fc3VyZmFjZV90KiBzdXJmYWNlLCBjb25zdCBGbG9hdFJlY3QmIGRlc3RSZWN0 LCBjb25zdCBGbG9hdFJlY3QmIG9yaWdpbmFsU3JjUmVjdCwgR3JhcGhpY3NDb250ZXh0KiBjb250 ZXh0KQogewotICAgIC8vIElmIHdlJ3JlIGRyYXdpbmcgYSBzdWIgcG9ydGlvbiBvZiB0aGUgaW1h Z2Ugb3Igc2NhbGluZyB0aGVuIGNyZWF0ZQotICAgIC8vIGEgcGF0dGVybiB0cmFuc2Zvcm1hdGlv biBvbiB0aGUgaW1hZ2UgYW5kIGRyYXcgdGhlIHRyYW5zZm9ybWVkIHBhdHRlcm4uCi0gICAgLy8g VGVzdCB1c2luZyBleGFtcGxlIHNpdGUgYXQgaHR0cDovL3d3dy5tZXllcndlYi5jb20vZXJpYy9j c3MvZWRnZS9jb21wbGV4c3BpcmFsL2RlbW8uaHRtbAotICAgIFJlZlB0cjxjYWlyb19wYXR0ZXJu X3Q+IHBhdHRlcm4gPSBhZG9wdFJlZihjYWlyb19wYXR0ZXJuX2NyZWF0ZV9mb3Jfc3VyZmFjZShz dXJmYWNlKSk7CisgICAgRmxvYXRSZWN0IHNyY1JlY3QgPSBvcmlnaW5hbFNyY1JlY3Q7CisKKyAg ICAvLyBXZSBuZWVkIHRvIGFjY291bnQgZm9yIG5lZ2F0aXZlIHNvdXJjZSBkaW1lbnNpb25zIGJ5 IGZsaXBwaW5nIHRoZSByZWN0YW5nbGUuCisgICAgaWYgKG9yaWdpbmFsU3JjUmVjdC53aWR0aCgp IDwgMCkgeworICAgICAgICBzcmNSZWN0LnNldFgob3JpZ2luYWxTcmNSZWN0LngoKSArIG9yaWdp bmFsU3JjUmVjdC53aWR0aCgpKTsKKyAgICAgICAgc3JjUmVjdC5zZXRXaWR0aChzdGQ6OmZhYnMo b3JpZ2luYWxTcmNSZWN0LndpZHRoKCkpKTsKKyAgICB9CisgICAgaWYgKG9yaWdpbmFsU3JjUmVj dC5oZWlnaHQoKSA8IDApIHsKKyAgICAgICAgc3JjUmVjdC5zZXRZKG9yaWdpbmFsU3JjUmVjdC55 KCkgKyBvcmlnaW5hbFNyY1JlY3QuaGVpZ2h0KCkpOworICAgICAgICBzcmNSZWN0LnNldEhlaWdo dChzdGQ6OmZhYnMob3JpZ2luYWxTcmNSZWN0LmhlaWdodCgpKSk7CisgICAgfQorCisgICAgLy8g Q2Fpcm8gc3Vic3VyZmFjZXMgZG9uJ3Qgc3VwcG9ydCBmbG9hdGluZyBwb2ludCBib3VuZGFyaWVz IHdlbGwsIHNvIHdlIGV4cGFuZCB0aGUgcmVjdGFuZ2xlLgorICAgIEludFJlY3QgZXhwYW5kZWRT cmNSZWN0KGVuY2xvc2luZ0ludFJlY3Qoc3JjUmVjdCkpOworCisgICAgLy8gV2UgdXNlIGEgc3Vi c3VyZmFjZSBoZXJlIHNvIHRoYXQgd2UgZG9uJ3QgZW5kIHVwIHNhbXBsaW5nIG91dHNpZGUgdGhl IG9yaWdpbmFsU3JjUmVjdCByZWN0YW5nbGUuCisgICAgLy8gU2VlIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD01ODMwOQorICAgIFJlZlB0cjxjYWlyb19zdXJmYWNlX3Q+ IHN1YnN1cmZhY2UgPSBhZG9wdFJlZihjYWlyb19zdXJmYWNlX2NyZWF0ZV9mb3JfcmVjdGFuZ2xl KAorICAgICAgICBzdXJmYWNlLCBleHBhbmRlZFNyY1JlY3QueCgpLCBleHBhbmRlZFNyY1JlY3Qu eSgpLCBleHBhbmRlZFNyY1JlY3Qud2lkdGgoKSwgZXhwYW5kZWRTcmNSZWN0LmhlaWdodCgpKSk7 CisgICAgUmVmUHRyPGNhaXJvX3BhdHRlcm5fdD4gcGF0dGVybiA9IGFkb3B0UmVmKGNhaXJvX3Bh dHRlcm5fY3JlYXRlX2Zvcl9zdXJmYWNlKHN1YnN1cmZhY2UuZ2V0KCkpKTsKIAogICAgIEFTU0VS VChtX3N0YXRlKTsKICAgICBzd2l0Y2ggKG1fc3RhdGUtPm1faW1hZ2VJbnRlcnBvbGF0aW9uUXVh bGl0eSkgewpAQCAtMTc3LDkgKzE5MywxNSBAQCB2b2lkIFBsYXRmb3JtQ29udGV4dENhaXJvOjpk cmF3U3VyZmFjZVRvQ29udGV4dChjYWlyb19zdXJmYWNlX3QqIHN1cmZhY2UsIGNvbnN0CiAgICAg fQogICAgIGNhaXJvX3BhdHRlcm5fc2V0X2V4dGVuZChwYXR0ZXJuLmdldCgpLCBDQUlST19FWFRF TkRfUEFEKTsKIAotICAgIGZsb2F0IHNjYWxlWCA9IHNyY1JlY3Qud2lkdGgoKSAvIGRlc3RSZWN0 LndpZHRoKCk7Ci0gICAgZmxvYXQgc2NhbGVZID0gc3JjUmVjdC5oZWlnaHQoKSAvIGRlc3RSZWN0 LmhlaWdodCgpOwotICAgIGNhaXJvX21hdHJpeF90IG1hdHJpeCA9IHsgc2NhbGVYLCAwLCAwLCBz Y2FsZVksIHNyY1JlY3QueCgpLCBzcmNSZWN0LnkoKSB9OworICAgIC8vIFRoZSBwYXR0ZXJuIHRy YW5zZm9ybWF0aW9uIHByb3Blcmx5IHNjYWxlcyB0aGUgcGF0dGVybiBmb3Igd2hlbiB0aGUgc291 cmNlIHJlY3RhbmdsZSBpcyBhCisgICAgLy8gZGlmZmVyZW50IHNpemUgdGhhbiB0aGUgZGVzdGlu YXRpb24gcmVjdGFuZ2xlLiBXZSBhbHNvIGFjY291bnQgZm9yIGFueSBvZmZzZXQgd2UgaW50cm9k dWNlZAorICAgIC8vIGJ5IGV4cGFuZGluZyBmbG9hdGluZyBwb2ludCBzb3VyY2UgcmVjdGFuZ2xl IHNpemVzLiBJdCdzIGltcG9ydGFudCB0byB0YWtlIHRoZSBhYnNvbHV0ZSB2YWx1ZQorICAgIC8v IG9mIHRoZSBzY2FsZSBzaW5jZSB0aGUgb3JpZ2luYWwgd2lkdGggYW5kIGhlaWdodCBtaWdodCBi ZSBuZWdhdGl2ZS4KKyAgICBmbG9hdCBzY2FsZVggPSBzdGQ6OmZhYnMoc3JjUmVjdC53aWR0aCgp IC8gZGVzdFJlY3Qud2lkdGgoKSk7CisgICAgZmxvYXQgc2NhbGVZID0gc3RkOjpmYWJzKHNyY1Jl Y3QuaGVpZ2h0KCkgLyBkZXN0UmVjdC5oZWlnaHQoKSk7CisgICAgZmxvYXQgbGVmdFBhZGRpbmcg PSBzdGF0aWNfY2FzdDxmbG9hdD4oZXhwYW5kZWRTcmNSZWN0LngoKSkgLSBmbG9vcmYoc3JjUmVj dC54KCkpOworICAgIGZsb2F0IHRvcFBhZGRpbmcgPSBzdGF0aWNfY2FzdDxmbG9hdD4oZXhwYW5k ZWRTcmNSZWN0LnkoKSkgLSBmbG9vcmYoc3JjUmVjdC55KCkpOworICAgIGNhaXJvX21hdHJpeF90 IG1hdHJpeCA9IHsgc2NhbGVYLCAwLCAwLCBzY2FsZVksIGxlZnRQYWRkaW5nLCB0b3BQYWRkaW5n IH07CiAgICAgY2Fpcm9fcGF0dGVybl9zZXRfbWF0cml4KHBhdHRlcm4uZ2V0KCksICZtYXRyaXgp OwogCiAgICAgU2hhZG93Qmx1ciYgc2hhZG93ID0gY29udGV4dC0+cGxhdGZvcm1Db250ZXh0KCkt PnNoYWRvd0JsdXIoKTsKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91 dFRlc3RzL0NoYW5nZUxvZwppbmRleCA1OWM1MjVmMDMyMDhkYWQ1MTBmOGNiZWY3ZmQwNWZjY2E1 ODBkYjlhLi5mYTA0NzYwNDNkOGYxOTk1NjdmOTkyNzBjNWUyZTJjOWQxNjZmMWMxIDEwMDY0NAot LS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTIgQEAKKzIwMTMtMDItMjEgIE1hcnRpbiBSb2JpbnNvbiAgPG1yb2JpbnNvbkBp Z2FsaWEuY29tPgorCisgICAgICAgIFtHVEtdIGZhc3QvY2FudmFzL0RyYXdJbWFnZVNpbmdsZVBp eGVsU3RyZXRjaC5odG1sIGZhaWxzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD01ODMwOQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgICogcGxhdGZvcm0vZ3RrL1Rlc3RFeHBlY3RhdGlvbnM6IFVuc2tpcCBhIHRl c3Qgd2hpY2ggaXMgbm93IHBhc3NpbmcuCisKIDIwMTMtMDItMjEgIEFuZHJlaSBCdWN1ciAgPGFi dWN1ckBhZG9iZS5jb20+CiAKICAgICAgICAgLXdlYmtpdC1tYXJnaW4tY29sbGFwc2U6IHNlcGFy YXRlIGRvZXNuJ3Qgd29yayBjb3JyZWN0bHkgZm9yIGJlZm9yZSBtYXJnaW5zCmRpZmYgLS1naXQg YS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9ndGsvVGVzdEV4cGVjdGF0aW9ucyBiL0xheW91dFRlc3Rz L3BsYXRmb3JtL2d0ay9UZXN0RXhwZWN0YXRpb25zCmluZGV4IDc4NjY1NDQ3N2FiMTA5YmY0ZWE4 NTllYTVjYTBmMjczOTMwOWZmNjMuLmVkYmQ4ZTc0NzIxYWYwMTFiMzYyOTZiODIzMWM5YTNmMTc4 NjJlNWMgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL3BsYXRmb3JtL2d0ay9UZXN0RXhwZWN0YXRp b25zCisrKyBiL0xheW91dFRlc3RzL3BsYXRmb3JtL2d0ay9UZXN0RXhwZWN0YXRpb25zCkBAIC0x MTU0LDggKzExNTQsNiBAQCBCdWcoR1RLKSBlZGl0aW5nL3NwZWxsaW5nL21hcmtlcnMuaHRtbCBb IFNraXAgXQogIyB0ZXN0UnVubmVyLm92ZXJyaWRlUHJlZmVyZW5jZSgiV2ViS2l0RGVmYXVsdEZv bnRTaXplIi4uLikgZG9lcyBub3QgdGFrZSBpbnRvIGFjY291bnQgc2NyZWVuIERQSQogd2Via2l0 Lm9yZy9iLzU3MTYwIGZhc3QvaGFybmVzcy9vdmVycmlkZS1wcmVmZXJlbmNlcy0yLmh0bWwgWyBG YWlsdXJlIF0KIAotd2Via2l0Lm9yZy9iLzU4MzA5IGZhc3QvY2FudmFzL0RyYXdJbWFnZVNpbmds ZVBpeGVsU3RyZXRjaC5odG1sIFsgRmFpbHVyZSBdCi0KICMgRXhwb3NlIHRpdGxlIGRpcmVjdGlv biBpbiBXZWJLaXQgQVBJCiB3ZWJraXQub3JnL2IvNTg4NDUgZmFzdC9kb20vdGl0bGUtZGlyZWN0 aW9uYWxpdHkuaHRtbCBbIEZhaWx1cmUgXQogd2Via2l0Lm9yZy9iLzU4ODQ1IGZhc3QvZG9tL3Rp dGxlLWRpcmVjdGlvbmFsaXR5LXJlbW92ZUNoaWxkLmh0bWwgWyBGYWlsdXJlIF0K