58304 2011-04-12 01:16:47 -0700 REGRESSION: WK2: misspelled AX attributes no longer returned from text fields 2011-04-12 10:47:26 -0700 1 1 1 Unclassified WebKit Accessibility 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED InRadar P2 Normal --- 1 cfleizach cfleizach oldest_to_newest 383870 0 cfleizach 2011-04-12 01:16:47 -0700 When typing in to an edit field,VoiceOver does not announce the presence of a mis-spelled word with the announcement "mis-spelled" followed by the mis-spelled word. 383871 1 cfleizach 2011-04-12 01:16:58 -0700 rdar://9258679 383878 2 89169 cfleizach 2011-04-12 01:36:01 -0700 Created attachment 89169 patch 383883 3 89169 mitz 2011-04-12 01:44:25 -0700 Comment on attachment 89169 patch View in context: https://bugs.webkit.org/attachment.cgi?id=89169&action=review > Source/WebCore/accessibility/mac/AccessibilityObjectWrapper.mm:491 > + unsigned size = results.size(); > + for (unsigned i = 0; i < size; i++) { Please use size_t for a Vector’s size and the loop variable. > Source/WebCore/accessibility/mac/AccessibilityObjectWrapper.mm:492 > + const TextCheckingResult* result = &results[i]; A more natural way to do this in C++ would be const TextCheckingResult& result = results[i]; > Source/WebCore/accessibility/mac/AccessibilityObjectWrapper.mm:493 > + AXAttributeStringSetNumber(attrString, NSAccessibilityMisspelledTextAttribute, [NSNumber numberWithBool:YES], NSMakeRange(result->location + range.location, result->length)); Allocating and autoreleasing an NSNumber each time through the loop is not so great, but no worse than what the old code did. 384024 4 cfleizach 2011-04-12 08:46:45 -0700 http://trac.webkit.org/changeset/83589 384096 5 cfleizach 2011-04-12 10:14:43 -0700 broke leopard mac because checkParagraph is not available there 384097 6 cfleizach 2011-04-12 10:14:50 -0700 will fix now 384139 7 cfleizach 2011-04-12 10:47:26 -0700 http://trac.webkit.org/changeset/83609 to fix the leopard build 89169 2011-04-12 01:36:01 -0700 2011-04-12 01:44:25 -0700 patch patch.txt text/plain 2989 cfleizach SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDgzNTY0KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTggQEAKKzIwMTEtMDQtMTIgIENocmlzIEZs ZWl6YWNoICA8Y2ZsZWl6YWNoQGFwcGxlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBSRUdSRVNTSU9OOiBXSzI6IG1pc3NwZWxsZWQgQVggYXR0 cmlidXRlcyBubyBsb25nZXIgcmV0dXJuZWQgZnJvbSB0ZXh0IGZpZWxkcworICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTgzMDQKKworICAgICAgICBjaGVj a1NwZWxsaW5nT2ZTdHJpbmcgaXMgbm8gbG9uZ2VyIGltcGxlbWVudGVkIGluIFdLMi4gQWNjZXNz aWJpbGl0eSBuZWVkcyB0byBjaGFuZ2UgdG8gdXNlCisgICAgICAgIGNoZWNrVGV4dE9mUGFyYWdy YXBoIGluIG9yZGVyIHRvIHJldHJpZXZlIG1pc3NwZWxsZWQgcmFuZ2VzLgorCisgICAgICAgIEV4 aXN0aW5nIHRlc3RzIGNvdmVyIHRoaXMgZnVuY3Rpb25hbGl0eS4KKworICAgICAgICAqIGFjY2Vz c2liaWxpdHkvbWFjL0FjY2Vzc2liaWxpdHlPYmplY3RXcmFwcGVyLm1tOgorICAgICAgICAoQVhB dHRyaWJ1dGVTdHJpbmdTZXRTcGVsbGluZyk6CisKIDIwMTEtMDQtMTIgIFZzZXZvbG9kIFZsYXNv diAgPHZzZXZpa0BjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgUGF2ZWwgRmVs ZG1hbi4KSW5kZXg6IFNvdXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkvbWFjL0FjY2Vzc2liaWxp dHlPYmplY3RXcmFwcGVyLm1tCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2FjY2Vzc2li aWxpdHkvbWFjL0FjY2Vzc2liaWxpdHlPYmplY3RXcmFwcGVyLm1tCShyZXZpc2lvbiA4MzU1OCkK KysrIFNvdXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkvbWFjL0FjY2Vzc2liaWxpdHlPYmplY3RX cmFwcGVyLm1tCSh3b3JraW5nIGNvcHkpCkBAIC00ODEsMjEgKzQ4MSwxNiBAQAogc3RhdGljIHZv aWQgQVhBdHRyaWJ1dGVTdHJpbmdTZXRTcGVsbGluZyhOU011dGFibGVBdHRyaWJ1dGVkU3RyaW5n KiBhdHRyU3RyaW5nLCBOb2RlKiBub2RlLCBjb25zdCBVQ2hhciogY2hhcnMsIGludCBjaGFyTGVu Z3RoLCBOU1JhbmdlIHJhbmdlKQogewogICAgIC8vIENoZWNrIHRoZSBzcGVsbGluZyBkaXJlY3Rs eSBzaW5jZSBkb2N1bWVudC0+bWFya2Vyc0Zvck5vZGUoKSBkb2VzIG5vdCBzdG9yZSB0aGUgbWlz c3BlbGxlZCBtYXJraW5nIHdoZW4gdGhlIGN1cnNvciBpcyBpbiBhIHdvcmQuCi0gICAgaW50IGN1 cnJlbnRQb3NpdGlvbiA9IDA7Ci0gICAgd2hpbGUgKGNoYXJMZW5ndGggPiAwKSB7Ci0gICAgICAg IGNvbnN0IFVDaGFyKiBjaGFyRGF0YSA9IGNoYXJzICsgY3VycmVudFBvc2l0aW9uOwotICAgICAg ICBUZXh0Q2hlY2tlckNsaWVudCogY2hlY2tlciA9IG5vZGUtPmRvY3VtZW50KCktPmZyYW1lKCkt PmVkaXRvcigpLT50ZXh0Q2hlY2tlcigpOworICAgIFRleHRDaGVja2VyQ2xpZW50KiBjaGVja2Vy ID0gbm9kZS0+ZG9jdW1lbnQoKS0+ZnJhbWUoKS0+ZWRpdG9yKCktPnRleHRDaGVja2VyKCk7CiAK LSAgICAgICAgaW50IG1pc3NwZWxsaW5nTG9jYXRpb24gPSAtMTsKLSAgICAgICAgaW50IG1pc3Nw ZWxsaW5nTGVuZ3RoID0gMDsKLSAgICAgICAgY2hlY2tlci0+Y2hlY2tTcGVsbGluZ09mU3RyaW5n KGNoYXJEYXRhLCBjaGFyTGVuZ3RoLCAmbWlzc3BlbGxpbmdMb2NhdGlvbiwgJm1pc3NwZWxsaW5n TGVuZ3RoKTsKLSAgICAgICAgaWYgKG1pc3NwZWxsaW5nTG9jYXRpb24gPT0gLTEgfHwgIW1pc3Nw ZWxsaW5nTGVuZ3RoKQotICAgICAgICAgICAgYnJlYWs7Ci0gICAgICAgIAotICAgICAgICBOU1Jh bmdlIHNwZWxsUmFuZ2UgPSBOU01ha2VSYW5nZShyYW5nZS5sb2NhdGlvbiArIGN1cnJlbnRQb3Np dGlvbiArIG1pc3NwZWxsaW5nTG9jYXRpb24sIG1pc3NwZWxsaW5nTGVuZ3RoKTsKLSAgICAgICAg QVhBdHRyaWJ1dGVTdHJpbmdTZXROdW1iZXIoYXR0clN0cmluZywgTlNBY2Nlc3NpYmlsaXR5TWlz c3BlbGxlZFRleHRBdHRyaWJ1dGUsIFtOU051bWJlciBudW1iZXJXaXRoQm9vbDpZRVNdLCBzcGVs bFJhbmdlKTsKLSAgICAgICAgY2hhckxlbmd0aCAtPSAobWlzc3BlbGxpbmdMb2NhdGlvbiArIG1p c3NwZWxsaW5nTGVuZ3RoKTsKLSAgICAgICAgY3VycmVudFBvc2l0aW9uICs9IChtaXNzcGVsbGlu Z0xvY2F0aW9uICsgbWlzc3BlbGxpbmdMZW5ndGgpOworICAgIC8vIGNoZWNrVGV4dE9mUGFyYWdy YXBoIGlzIHRoZSBvbmx5IHNwZWxsaW5nL2dyYW1tYXIgY2hlY2tlciBpbXBsZW1lbnRlZCBpbiBX SzEgYW5kIFdLMgorICAgIFZlY3RvcjxUZXh0Q2hlY2tpbmdSZXN1bHQ+IHJlc3VsdHM7CisgICAg Y2hlY2tlci0+Y2hlY2tUZXh0T2ZQYXJhZ3JhcGgoY2hhcnMsIGNoYXJMZW5ndGgsIFRleHRDaGVj a2luZ1R5cGVTcGVsbGluZywgcmVzdWx0cyk7CisgICAgCisgICAgdW5zaWduZWQgc2l6ZSA9IHJl c3VsdHMuc2l6ZSgpOworICAgIGZvciAodW5zaWduZWQgaSA9IDA7IGkgPCBzaXplOyBpKyspIHsK KyAgICAgICAgY29uc3QgVGV4dENoZWNraW5nUmVzdWx0KiByZXN1bHQgPSAmcmVzdWx0c1tpXTsK KyAgICAgICAgQVhBdHRyaWJ1dGVTdHJpbmdTZXROdW1iZXIoYXR0clN0cmluZywgTlNBY2Nlc3Np YmlsaXR5TWlzc3BlbGxlZFRleHRBdHRyaWJ1dGUsIFtOU051bWJlciBudW1iZXJXaXRoQm9vbDpZ RVNdLCBOU01ha2VSYW5nZShyZXN1bHQtPmxvY2F0aW9uICsgcmFuZ2UubG9jYXRpb24sIHJlc3Vs dC0+bGVuZ3RoKSk7CiAgICAgfQogfQogCg==