58296 2011-04-11 20:04:07 -0700 new-run-webkit-tests: configure logging in child processes properly 2011-04-13 14:01:18 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 55163 1 dpranke dpranke abarth eric mihaip ojan tony oldest_to_newest 383780 0 dpranke 2011-04-11 20:04:07 -0700 new-run-webkit-tests: configure logging in child processes properly 383782 1 89148 dpranke 2011-04-11 20:05:03 -0700 Created attachment 89148 Patch 384160 2 89148 eric 2011-04-12 10:59:24 -0700 Comment on attachment 89148 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=89148&action=review I don't really understand what this chagne does. > Tools/Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker.py:322 > + # FIXME: this won't work if the calling process is logging nit: "This" since it starts the sentence. 384179 3 dpranke 2011-04-12 11:26:31 -0700 (In reply to comment #2) > (From update of attachment 89148 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=89148&action=review > > I don't really understand what this chagne does. > This change is modifying the code that runs in the child processes when NRWT is running in multi-process mode. Specifically, it is modifying the logging configuration to match the configuration in the master/parent process. This wasn't needed on Unix since the configuration is cloned through fork(), but the windows code doesn't fork(), so we have to explicitly reconfigure it. > > Tools/Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker.py:322 > > + # FIXME: this won't work if the calling process is logging > > nit: "This" since it starts the sentence. Will fix when I land or in the next patch if other changes are needed. 385199 4 dpranke 2011-04-13 14:01:18 -0700 Committed r83760: <http://trac.webkit.org/changeset/83760> 89148 2011-04-11 20:05:03 -0700 2011-04-13 10:12:37 -0700 Patch bug-58296-20110411200502.patch text/plain 3981 dpranke U3VidmVyc2lvbiBSZXZpc2lvbjogODM0NzcKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBi L1Rvb2xzL0NoYW5nZUxvZwppbmRleCA3OTdmZWRhNWFiOWZlODU4MjFlMGM0NzI3NjcwNTE2YjMx ZDNjMzg1Li44NDYxNDBjNGJhMjIyMzM0ODMxZDQzOTBmMTY2NzVlODRkZTA2ZjQyIDEwMDY0NAot LS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTgg QEAKIDIwMTEtMDQtMTEgIERpcmsgUHJhbmtlICA8ZHByYW5rZUBjaHJvbWl1bS5vcmc+CiAKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgbmV3LXJ1bi13ZWJr aXQtdGVzdHM6IGNvbmZpZ3VyZSBsb2dnaW5nIGluIGNoaWxkIHByb2Nlc3NlcyBwcm9wZXJseQor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTgyOTYKKwor ICAgICAgICBMb2dnaW5nIHByb3BhZ2F0ZWQgcHJvcGVybHkgZnJvbSBtYW5hZ2VyIHRvIHdvcmtl ciBwcm9jZXNzZXMgb24KKyAgICAgICAgVW5peCBidXQgbm90IG9uIFdpbmRvd3M7IHRoaXMgZml4 ZXMgdGhhdC4KKworICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL2xheW91 dF9wYWNrYWdlL21hbmFnZXJfd29ya2VyX2Jyb2tlci5weToKKyAgICAgICAgKiBTY3JpcHRzL3dl YmtpdHB5L2xheW91dF90ZXN0cy9sYXlvdXRfcGFja2FnZS9tYW5hZ2VyX3dvcmtlcl9icm9rZXJf dW5pdHRlc3QucHk6CisKKzIwMTEtMDQtMTEgIERpcmsgUHJhbmtlICA8ZHByYW5rZUBjaHJvbWl1 bS5vcmc+CisKICAgICAgICAgUmV2aWV3ZWQgYnkgQWRhbSBSb2Jlbi4KIAogICAgICAgICBuZXct cnVuLXdlYmtpdC10ZXN0czogZml4IGNyYXNoIHdoZW4gcnVubmluZyB1bmRlciB3aW5kb3dzIGNt ZC5leGUKZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL2xh eW91dF9wYWNrYWdlL21hbmFnZXJfd29ya2VyX2Jyb2tlci5weSBiL1Rvb2xzL1NjcmlwdHMvd2Vi a2l0cHkvbGF5b3V0X3Rlc3RzL2xheW91dF9wYWNrYWdlL21hbmFnZXJfd29ya2VyX2Jyb2tlci5w eQpvbGQgbW9kZSAxMDA2NDQKbmV3IG1vZGUgMTAwNzU1CmluZGV4IDQ4ODZjMzA0MTFhMGFmMjI0 YjY3NWU1ZGMyNzZlOGFiN2M0N2FhOGMuLjdlYWQ0ODMwOTFlNjZmOWNkYzc5OTA2ZGZkOTllZWJj MDJmMzZkYzkKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvbGF5b3V0 X3BhY2thZ2UvbWFuYWdlcl93b3JrZXJfYnJva2VyLnB5CisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Vi a2l0cHkvbGF5b3V0X3Rlc3RzL2xheW91dF9wYWNrYWdlL21hbmFnZXJfd29ya2VyX2Jyb2tlci5w eQpAQCAtNDUsNyArNDUsOSBAQCBUZXN0UnVubmVyMiAgLS0+IF9JbmxpbmVNYW5hZ2VyIC0tLT4g X0lubGluZVdvcmtlciA8LT4gV29ya2VyCiAKIGltcG9ydCBsb2dnaW5nCiBpbXBvcnQgb3B0cGFy c2UKK2ltcG9ydCBwcmludGluZwogaW1wb3J0IFF1ZXVlCitpbXBvcnQgc3lzCiBpbXBvcnQgdGhy ZWFkCiBpbXBvcnQgdGhyZWFkaW5nCiBpbXBvcnQgdGltZQpAQCAtMzE1LDkgKzMxNywxNSBAQCBp ZiBtdWx0aXByb2Nlc3Npbmc6CiAgICAgICAgICAgICBfbG9nLmVycm9yKCIlcyAocGlkICVkKSBp cyB3ZWRnZWQgb24gdGVzdCAlcyIgJSAoc2VsZi5uYW1lLCBzZWxmLnBpZCwgdGVzdF9uYW1lKSkK IAogICAgICAgICBkZWYgcnVuKHNlbGYpOgotICAgICAgICAgICAgbG9nZ2luZy5iYXNpY0NvbmZp ZygpCi0gICAgICAgICAgICBwb3J0X29iaiA9IHBvcnQuZ2V0KHNlbGYuX3BsYXRmb3JtX25hbWUs IHNlbGYuX29wdGlvbnMpCisgICAgICAgICAgICBvcHRpb25zID0gc2VsZi5fb3B0aW9ucworICAg ICAgICAgICAgcG9ydF9vYmogPSBwb3J0LmdldChzZWxmLl9wbGF0Zm9ybV9uYW1lLCBvcHRpb25z KQorICAgICAgICAgICAgIyBGSVhNRTogdGhpcyB3b24ndCB3b3JrIGlmIHRoZSBjYWxsaW5nIHBy b2Nlc3MgaXMgbG9nZ2luZworICAgICAgICAgICAgIyBzb21ld2hlcmUgb3RoZXIgdGhhbiBzeXMu c3RkZXJyIGFuZCBzeXMuc3Rkb3V0LCBidXQgSSdtIG5vdCBzdXJlCisgICAgICAgICAgICAjIGlm IHRoaXMgd2lsbCBiZSBhbiBpc3N1ZSBpbiBwcmFjdGljZS4KKyAgICAgICAgICAgIHByaW50ZXIg PSBwcmludGluZy5QcmludGVyKHBvcnRfb2JqLCBvcHRpb25zLCBzeXMuc3RkZXJyLCBzeXMuc3Rk b3V0LAorICAgICAgICAgICAgICAgIGludChvcHRpb25zLmNoaWxkX3Byb2Nlc3NlcyksIG9wdGlv bnMuZXhwZXJpbWVudGFsX2Z1bGx5X3BhcmFsbGVsKQogICAgICAgICAgICAgc2VsZi5fY2xpZW50 LnJ1bihwb3J0X29iaikKKyAgICAgICAgICAgIHByaW50ZXIuY2xlYW51cCgpCiAKIAogY2xhc3Mg X011bHRpUHJvY2Vzc1dvcmtlckNvbm5lY3Rpb24oX1dvcmtlckNvbm5lY3Rpb24pOgpkaWZmIC0t Z2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvbGF5b3V0X3BhY2thZ2Uv bWFuYWdlcl93b3JrZXJfYnJva2VyX3VuaXR0ZXN0LnB5IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRw eS9sYXlvdXRfdGVzdHMvbGF5b3V0X3BhY2thZ2UvbWFuYWdlcl93b3JrZXJfYnJva2VyX3VuaXR0 ZXN0LnB5CmluZGV4IGMzMmY4ODAzOWY0YjgwOTI4MTE0ZGJjMjgxNTg4OTJmMDIzN2NlMGYuLjY5 MTkyMjU0MjczNDZlZjE5ZWUzMDg5Yjc1NTkzNDQxNmI5ZGFjN2QgMTAwNjQ0Ci0tLSBhL1Rvb2xz L1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL2xheW91dF9wYWNrYWdlL21hbmFnZXJfd29y a2VyX2Jyb2tlcl91bml0dGVzdC5weQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91 dF90ZXN0cy9sYXlvdXRfcGFja2FnZS9tYW5hZ2VyX3dvcmtlcl9icm9rZXJfdW5pdHRlc3QucHkK QEAgLTQyLDYgKzQyLDcgQEAgZnJvbSB3ZWJraXRweS5jb21tb24uc3lzdGVtIGltcG9ydCBvdXRw dXRjYXB0dXJlCiBmcm9tIHdlYmtpdHB5LmxheW91dF90ZXN0cyBpbXBvcnQgcG9ydAogZnJvbSB3 ZWJraXRweS5sYXlvdXRfdGVzdHMubGF5b3V0X3BhY2thZ2UgaW1wb3J0IG1hbmFnZXJfd29ya2Vy X2Jyb2tlcgogZnJvbSB3ZWJraXRweS5sYXlvdXRfdGVzdHMubGF5b3V0X3BhY2thZ2UgaW1wb3J0 IG1lc3NhZ2VfYnJva2VyMgorZnJvbSB3ZWJraXRweS5sYXlvdXRfdGVzdHMubGF5b3V0X3BhY2th Z2UgaW1wb3J0IHByaW50aW5nCiAKICMgSW4gb3JkZXIgdG8gcmVsaWFibHkgY29udHJvbCB3aGVu IGNoaWxkIHdvcmtlcnMgYXJlIHN0YXJ0aW5nIGFuZCBzdG9wcGluZywKICMgd2UgdXNlIGEgcGFp ciBvZiBnbG9iYWwgdmFyaWFibGVzIHRvIGhvbGQgcXVldWVzIHVzZWQgZm9yIG1lc3NhZ2luZy4g SWRlYWxseQpAQCAtMTA0LDcgKzEwNSwxMCBAQCBjbGFzcyBfVGVzdFdvcmtlcihtYW5hZ2VyX3dv cmtlcl9icm9rZXIuQWJzdHJhY3RXb3JrZXIpOgogCiAKIGRlZiBnZXRfb3B0aW9ucyh3b3JrZXJf bW9kZWwpOgotICAgIG9wdGlvbl9saXN0ID0gbWFuYWdlcl93b3JrZXJfYnJva2VyLnJ1bnRpbWVf b3B0aW9ucygpCisgICAgb3B0aW9uX2xpc3QgPSAobWFuYWdlcl93b3JrZXJfYnJva2VyLnJ1bnRp bWVfb3B0aW9ucygpICsKKyAgICAgICAgICAgICAgICAgICBwcmludGluZy5wcmludF9vcHRpb25z KCkgKworICAgICAgICAgICAgICAgICAgIFtvcHRwYXJzZS5tYWtlX29wdGlvbigiLS1leHBlcmlt ZW50YWwtZnVsbHktcGFyYWxsZWwiLCBkZWZhdWx0PUZhbHNlKSwKKyAgICAgICAgICAgICAgICAg ICAgb3B0cGFyc2UubWFrZV9vcHRpb24oIi0tY2hpbGQtcHJvY2Vzc2VzIiwgZGVmYXVsdD0nMicp XSkKICAgICBwYXJzZXIgPSBvcHRwYXJzZS5PcHRpb25QYXJzZXIob3B0aW9uX2xpc3Q9b3B0aW9u X2xpc3QpCiAgICAgb3B0aW9ucywgYXJncyA9IHBhcnNlci5wYXJzZV9hcmdzKGFyZ3M9WyctLXdv cmtlci1tb2RlbCcsIHdvcmtlcl9tb2RlbF0pCiAgICAgcmV0dXJuIG9wdGlvbnMK