5829 2005-11-25 14:31:52 -0800 REGRESSION: cursor tracking and hit testing in scrollable block don't take borders into account 2005-12-18 08:26:02 -0800 1 1 1 Unclassified WebKit Layout and Rendering 420+ Mac OS X 10.4 VERIFIED FIXED P1 Normal --- 1 mitz bdakin bdakin vicki oldest_to_newest 24546 0 mitz 2005-11-25 14:31:52 -0800 Summary: cursor tracking and hit-testing for controls seem to be off by the width of the left/bottom border of a block that has overflow:auto or scroll. To reproduce: open the testcase. Things to note: 1) the end of the scrollbar near the red square does not respond to clicking or dragging 2) clicking in the green rect near the edge of the scroll bar results in the following error in the console (if running a debug build): ERROR: KHTML says we hit a RenderWidget, but AppKit doesn't agree we hit the corresponding NSView 3) places where the cursor changes between arrow and I-beam along the line "Choose one: <option> from the pop-up" 4) places where the pop-up responds to clicks and places where clicking results in the above error 24547 1 4800 mitz 2005-11-25 14:32:51 -0800 Created attachment 4800 testcase 24549 2 mitz 2005-11-25 15:10:26 -0800 I suspect that this is a regression from the fix for <rdar://problem/3885711> (bug 4047). In particular, the changes to RenderLayer::hitTestLayer which introduced borderLeft() and borderBottom() there. 24556 3 4801 mitz 2005-11-25 15:21:43 -0800 Created attachment 4801 don't add left and bottom borders when hit-testing 24557 4 4801 mitz 2005-11-25 15:28:04 -0800 Comment on attachment 4801 don't add left and bottom borders when hit-testing I checked that this doesn't affect the testcase for bug 4047. 24561 5 4801 mjs 2005-11-25 22:27:57 -0800 Comment on attachment 4801 don't add left and bottom borders when hit-testing r=me 24593 6 eric 2005-11-26 16:47:39 -0800 Is there any way we could make a test case for this? 24594 7 eric 2005-11-26 16:49:21 -0800 A DumpRenderTree test case, that is. We have support for moving the mouse... There is probably a way to get the current cursor from JavaScript, if not, we could add that functionality to DumpRenderTree's layoutTestController 24876 8 darin 2005-11-29 09:39:07 -0800 I don't think it's easy to add querying the cursor to DumpRenderTree -- the OS doesn't even have a good way to inspect the current cursor. But we can make a test that relies on hit testing rather than the cursor. 24878 9 vicki 2005-11-29 11:49:21 -0800 I committed this change. I added the attached test case to the manual tests directory until we can find a better solution. 26108 10 mitz 2005-12-18 08:26:02 -0800 I should have made a more extensive testcase -- this is still (or has become) broken in certain conditions. I am going to file a new bug. 4800 2005-11-25 14:32:51 -0800 2005-11-25 14:32:51 -0800 testcase scrollBarHitTesting.html text/html 893 mitz PGh0bWw+CjxoZWFkPgo8dGl0bGU+U2Nyb2xsIGJhciBoaXQtdGVzdGluZzwvdGl0bGU+CjwvaGVh ZD4KPGJvZHk+CiAgICA8cD4KICAgICAgICBUaGUgbGVmdCBlbmQgb2YgdGhlIHNjcm9sbCBiYXIg ZG9lcyBub3QgcmVzcG9uZCB0byBjbGlja2luZyBvciBkcmFnZ2luZy4KICAgICAgICBDbGlja2lu ZyBpbiB0aGUgZ3JlZW4gcmVjdGFuZ2xlIHRvIHRoZSByaWdodCBvZiB0aGUgc2Nyb2xsIGJhciBy ZXN1bHRzCiAgICAgICAgaW4gYW4gZXJyb3IgbWVzc2FnZS4KICAgIDwvcD4KICAgIDxkaXYgc3R5 bGU9Im92ZXJmbG93OiBhdXRvOyBoZWlnaHQ6NTBweDsgd2lkdGg6MzAwcHg7IGJvcmRlci1sZWZ0 OiBzb2xpZCByZWQgNTBweDsgYm9yZGVyLXJpZ2h0OiBzb2xpZCBncmVlbiAyMHB4OyI+CiAgICAg ICAgPGRpdiBzdHlsZT0id2lkdGg6NDAwcHg7Ij5DaG9vc2Ugb25lOiA8c2VsZWN0PjxvcHRpb24+ b3B0aW9uPC9vcHRpb24+PC9zZWxlY3Q+IGZyb20gdGhlIHBvcC11cDwvZGl2PgogICAgPC9kaXY+ CiAgICA8cD4KICAgICAgICBUaGUgYm90dG9tIGVuZCBvZiB0aGUgc2Nyb2xsIGJhciBkb2VzIG5v dCByZXNwb25kIHRvIGNsaWNraW5nIG9yIGRyYWdnaW5nLgogICAgICAgIENsaWNraW5nIGluIHRo ZSBncmVlbiByZWN0YW5nbGUgYWJvdmUgdGhlIHNjcm9sbCBiYXIgcmVzdWx0cwogICAgICAgIGlu IGFuIGVycm9yIG1lc3NhZ2UuCiAgICA8L3A+CiAgICA8ZGl2IHN0eWxlPSJvdmVyZmxvdzogYXV0 bzsgaGVpZ2h0OjMwMHB4OyB3aWR0aDo1MHB4OyBib3JkZXItYm90dG9tOiBzb2xpZCByZWQgNTBw eDsgYm9yZGVyLXRvcDogc29saWQgZ3JlZW4gMjBweDsiPgogICAgICAgIDxkaXYgc3R5bGU9Imhl aWdodDo0MDBweDsiPjwvZGl2PgogICAgPC9kaXY+CjwvYm9keT4= 4801 2005-11-25 15:21:43 -0800 2005-11-25 22:27:57 -0800 don't add left and bottom borders when hit-testing 5829_guess1.patch text/plain 2036 mitz SW5kZXg6IFdlYkNvcmUva2h0bWwvcmVuZGVyaW5nL3JlbmRlcl9sYXllci5jcHAKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQpSQ1MgZmlsZTogL2N2cy9yb290L1dlYkNvcmUva2h0bWwvcmVuZGVyaW5nL3JlbmRlcl9sYXll ci5jcHAsdgpyZXRyaWV2aW5nIHJldmlzaW9uIDEuMTI1CmRpZmYgLXAgLXUgLXIxLjEyNSBXZWJD b3JlL2todG1sL3JlbmRlcmluZy9yZW5kZXJfbGF5ZXIuY3BwCi0tLSBXZWJDb3JlL2todG1sL3Jl bmRlcmluZy9yZW5kZXJfbGF5ZXIuY3BwCTIxIE5vdiAyMDA1IDAxOjIwOjI1IC0wMDAwCTEuMTI1 CisrKyBXZWJDb3JlL2todG1sL3JlbmRlcmluZy9yZW5kZXJfbGF5ZXIuY3BwCTI1IE5vdiAyMDA1 IDIzOjIzOjE2IC0wMDAwCkBAIC0xMTE0LDggKzExMTQsOCBAQCBSZW5kZXJMYXllcjo6aGl0VGVz dExheWVyKFJlbmRlckxheWVyKiByCiAgICAgLy8gTmV4dCB3ZSB3YW50IHRvIHNlZSBpZiB0aGUg bW91c2UgcG9zIGlzIGluc2lkZSB0aGUgY2hpbGQgUmVuZGVyT2JqZWN0cyBvZiB0aGUgbGF5ZXIu CiAgICAgaWYgKGNvbnRhaW5zUG9pbnQoeE1vdXNlUG9zLCB5TW91c2VQb3MsIGZnUmVjdCkgJiYg CiAgICAgICAgIHJlbmRlcmVyKCktPmhpdFRlc3QoaW5mbywgeE1vdXNlUG9zLCB5TW91c2VQb3Ms Ci0gICAgICAgICAgICAgICAgICAgICAgICAgICAgbGF5ZXJCb3VuZHMueCgpIC0gcmVuZGVyZXIo KS0+eFBvcygpICsgbV9vYmplY3QtPmJvcmRlckxlZnQoKSwKLSAgICAgICAgICAgICAgICAgICAg ICAgICAgICBsYXllckJvdW5kcy55KCkgLSByZW5kZXJlcigpLT55UG9zKCkgKyBtX29iamVjdC0+ Ym9yZGVyVG9wRXh0cmEoKSAtIG1fb2JqZWN0LT5ib3JkZXJCb3R0b20oKSwgSGl0VGVzdERlc2Nl bmRhbnRzKSkgeworICAgICAgICAgICAgICAgICAgICAgICAgICAgIGxheWVyQm91bmRzLngoKSAt IHJlbmRlcmVyKCktPnhQb3MoKSwKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICBsYXllckJv dW5kcy55KCkgLSByZW5kZXJlcigpLT55UG9zKCkgKyBtX29iamVjdC0+Ym9yZGVyVG9wRXh0cmEo KSwgSGl0VGVzdERlc2NlbmRhbnRzKSkgewogICAgICAgICAvLyBmb3IgcG9zaXRpb25lZCBnZW5l cmF0ZWQgY29udGVudCwgd2UgbWlnaHQgc3RpbGwgbm90IGhhdmUgYQogICAgICAgICAvLyBub2Rl IGJ5IHRoZSB0aW1lIHdlIGdldCB0byB0aGUgbGF5ZXIgbGV2ZWwsIHNpbmNlIG5vbmUgb2YKICAg ICAgICAgLy8gdGhlIGNvbnRlbnQgaW4gdGhlIGxheWVyIGhhcyBhbiBlbGVtZW50LiBTbyBqdXN0 IHdhbGsgdXAKQEAgLTExNTQsOCArMTE1NCw4IEBAIFJlbmRlckxheWVyOjpoaXRUZXN0TGF5ZXIo UmVuZGVyTGF5ZXIqIHIKICAgICAvLyBOZXh0IHdlIHdhbnQgdG8gc2VlIGlmIHRoZSBtb3VzZSBw b3MgaXMgaW5zaWRlIHRoaXMgbGF5ZXIgYnV0IG5vdCBhbnkgb2YgaXRzIGNoaWxkcmVuLgogICAg IGlmIChjb250YWluc1BvaW50KHhNb3VzZVBvcywgeU1vdXNlUG9zLCBiZ1JlY3QpICYmCiAgICAg ICAgIHJlbmRlcmVyKCktPmhpdFRlc3QoaW5mbywgeE1vdXNlUG9zLCB5TW91c2VQb3MsCi0gICAg ICAgICAgICAgICAgICAgICAgICAgICAgbGF5ZXJCb3VuZHMueCgpIC0gcmVuZGVyZXIoKS0+eFBv cygpICsgbV9vYmplY3QtPmJvcmRlckxlZnQoKSwKLSAgICAgICAgICAgICAgICAgICAgICAgICAg ICBsYXllckJvdW5kcy55KCkgLSByZW5kZXJlcigpLT55UG9zKCkgKyBtX29iamVjdC0+Ym9yZGVy VG9wRXh0cmEoKSAtIG1fb2JqZWN0LT5ib3JkZXJCb3R0b20oKSwKKyAgICAgICAgICAgICAgICAg ICAgICAgICAgICBsYXllckJvdW5kcy54KCkgLSByZW5kZXJlcigpLT54UG9zKCksCisgICAgICAg ICAgICAgICAgICAgICAgICAgICAgbGF5ZXJCb3VuZHMueSgpIC0gcmVuZGVyZXIoKS0+eVBvcygp ICsgbV9vYmplY3QtPmJvcmRlclRvcEV4dHJhKCksCiAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgSGl0VGVzdFNlbGYpKQogICAgICAgICByZXR1cm4gdGhpczsKIAo=