58283 2011-04-11 16:16:55 -0700 LayerChromium/CCLayerImpl ownership fix 2011-04-11 19:22:29 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 amarinichev amarinichev commit-queue enne jamesr oldest_to_newest 383648 0 amarinichev 2011-04-11 16:16:55 -0700 LayerChromium/CCLayerImpl ownership fix 383654 1 89116 amarinichev 2011-04-11 16:20:57 -0700 Created attachment 89116 Patch 383663 2 89116 jamesr 2011-04-11 16:25:34 -0700 Comment on attachment 89116 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=89116&action=review OK > Source/WebCore/platform/graphics/chromium/cc/CCLayerImpl.cpp:154 > + // m_owner is reset by LayerChromium's destructor. comment isn't really helpful here, i would just delete 383666 3 89119 amarinichev 2011-04-11 16:27:29 -0700 Created attachment 89119 Patch 383770 4 89119 commit-queue 2011-04-11 19:22:24 -0700 Comment on attachment 89119 Patch Clearing flags on attachment: 89119 Committed r83551: <http://trac.webkit.org/changeset/83551> 383771 5 commit-queue 2011-04-11 19:22:29 -0700 All reviewed patches have been landed. Closing bug. 89116 2011-04-11 16:20:57 -0700 2011-04-11 16:27:27 -0700 Patch bug-58283-20110411162056.patch text/plain 3006 amarinichev U3VidmVyc2lvbiBSZXZpc2lvbjogODM0MzIKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBlMmZjYTVjYzQ3NWQ0NGRi ZWM1ZmZlZGFkZWY0NmJiMDEzMDIyOTE4Li44YjgxODE1YTk5NzI5OGUyYzkwMGM1Zjg3MThiY2U2 MGJhM2M0YWNhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjMgQEAKKzIwMTEtMDQtMTEgIEFsZXhl eSBNYXJpbmljaGV2ICA8YW1hcmluaWNoZXZAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIExheWVyQ2hyb21pdW0vQ0NMYXllcklt cGwgb3duZXJzaGlwIGZpeAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9NTgyODMKKworICAgICAgICBDQ0xheWVySW1wbCdzIG1fb3duZXIgZmllbGQgbGlm ZXRpbWUgc2hvdWxkIG1hdGNoIHRoZSBsaWZldGltZSBvZiB0aGUKKyAgICAgICAgY29ycmVzcG9u ZGluZyBMYXllckNocm9taXVtLiAgVGhpcyBjaGFuZ2UgbW92ZXMgcmVzZXR0aW5nIG9mIG1fb3du ZXIKKyAgICAgICAgaW50byBMYXllckNocm9taXVtJ3MgZGVzdHJ1Y3Rvci4KKworICAgICAgICBU ZXN0ZWQgc2ltaWxhcmx5IHRvIGJ1ZyA1NzU3Ny4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBo aWNzL2Nocm9taXVtL0xheWVyQ2hyb21pdW0uY3BwOgorICAgICAgICAoV2ViQ29yZTo6TGF5ZXJD aHJvbWl1bTo6fkxheWVyQ2hyb21pdW0pOgorICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2No cm9taXVtL2NjL0NDTGF5ZXJJbXBsLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkNDTGF5ZXJJbXBs OjpjbGVhbnVwUmVzb3VyY2VzKToKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1 bS9jYy9DQ0xheWVySW1wbC5oOgorICAgICAgICAoV2ViQ29yZTo6Q0NMYXllckltcGw6OnJlc2V0 T3duZXIpOgorCiAyMDExLTA0LTEwICBDaGFuZ1Nlb2sgT2ggIDxzaGl2YW1pZG93QGdtYWlsLmNv bT4KIAogICAgICAgICBSZXZpZXdlZCBieSBFcmljIFNlaWRlbC4KZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL0xheWVyQ2hyb21pdW0uY3BwIGIv U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vTGF5ZXJDaHJvbWl1bS5j cHAKaW5kZXggYmMyODIzOTg5NWIzZWMwYzRlMzFjMzUwNDFlZGI1ZjU2YzFiYzk2Yy4uZmJhMWRj NTI0N2JmN2JhYmQyMzZhMTUyZWM0NDk3ZDQ1N2ZkZjVkYiAxMDA2NDQKLS0tIGEvU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vTGF5ZXJDaHJvbWl1bS5jcHAKKysrIGIv U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vTGF5ZXJDaHJvbWl1bS5j cHAKQEAgLTg5LDYgKzg5LDkgQEAgTGF5ZXJDaHJvbWl1bTo6fkxheWVyQ2hyb21pdW0oKQogICAg IC8vIHdheSBmb3IgdXMgdG8gYmUgZGVzdHJveWVkIHdoaWxlIHdlIHN0aWxsIGhhdmUgYSBzdXBl cmxheWVyLgogICAgIEFTU0VSVCghc3VwZXJsYXllcigpKTsKIAorICAgIGlmIChtX2NjTGF5ZXJJ bXBsKQorICAgICAgICBtX2NjTGF5ZXJJbXBsLT5yZXNldE93bmVyKCk7CisKICAgICAvLyBSZW1v dmUgdGhlIHN1cGVybGF5ZXIgcmVmZXJlbmNlIGZyb20gYWxsIHN1YmxheWVycy4KICAgICByZW1v dmVBbGxTdWJsYXllcnMoKTsKIH0KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L2dyYXBoaWNzL2Nocm9taXVtL2NjL0NDTGF5ZXJJbXBsLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL2NjL0NDTGF5ZXJJbXBsLmNwcAppbmRleCA0YTkxM2Rm MWRiZTIzMjQxYjY2MDU2NTY5MGU2ZjgxNDVhM2ZkMjgyLi5iZDJjYTcwYTRmMWE3Njk1MjAwNmZj MDI3MThkODljODczMTA4MzJhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9n cmFwaGljcy9jaHJvbWl1bS9jYy9DQ0xheWVySW1wbC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vY2MvQ0NMYXllckltcGwuY3BwCkBAIC0xNTEsNyAr MTUxLDcgQEAgdm9pZCBDQ0xheWVySW1wbDo6YmluZENvbnRlbnRzVGV4dHVyZSgpCiAKIHZvaWQg Q0NMYXllckltcGw6OmNsZWFudXBSZXNvdXJjZXMoKQogewotICAgIG1fb3duZXIgPSAwOworICAg IC8vIG1fb3duZXIgaXMgcmVzZXQgYnkgTGF5ZXJDaHJvbWl1bSdzIGRlc3RydWN0b3IuCiAgICAg aWYgKHJlbmRlclN1cmZhY2UoKSkKICAgICAgICAgcmVuZGVyU3VyZmFjZSgpLT5jbGVhbnVwUmVz b3VyY2VzKCk7CiB9CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGlj cy9jaHJvbWl1bS9jYy9DQ0xheWVySW1wbC5oIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3Jh cGhpY3MvY2hyb21pdW0vY2MvQ0NMYXllckltcGwuaAppbmRleCA5NmM0ZjFiOWIzZDQ2YjJlMGVk NDg4NjhiOTY5NTBiMmUwMjVjNTE2Li41MDA1MTI3YzNmN2VjMGM1Yjg0MDQ0MzFiNWM0NjVmZTRi NTFmODViIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJv bWl1bS9jYy9DQ0xheWVySW1wbC5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBo aWNzL2Nocm9taXVtL2NjL0NDTGF5ZXJJbXBsLmgKQEAgLTUwLDYgKzUwLDcgQEAgcHVibGljOgog ICAgIH0KICAgICAvLyBXaGVuIHRoaXMgY2xhc3MgZ2V0cyBzdWJjbGFzc2VzLCByZW1lbWJlciB0 byBhZGQgJ3ZpcnR1YWwnIGhlcmUuCiAgICAgdmlydHVhbCB+Q0NMYXllckltcGwoKTsKKyAgICB2 b2lkIHJlc2V0T3duZXIoKSB7IG1fb3duZXIgPSAwOyB9CiAKICNpZm5kZWYgTkRFQlVHCiAgICAg aW50IGRlYnVnSUQoKSBjb25zdCB7IHJldHVybiBtX2RlYnVnSUQ7IH0K 89119 2011-04-11 16:27:29 -0700 2011-04-11 19:22:24 -0700 Patch bug-58283-20110411162728.patch text/plain 2950 amarinichev U3VidmVyc2lvbiBSZXZpc2lvbjogODM0MzIKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBlMmZjYTVjYzQ3NWQ0NGRi ZWM1ZmZlZGFkZWY0NmJiMDEzMDIyOTE4Li44YjgxODE1YTk5NzI5OGUyYzkwMGM1Zjg3MThiY2U2 MGJhM2M0YWNhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjMgQEAKKzIwMTEtMDQtMTEgIEFsZXhl eSBNYXJpbmljaGV2ICA8YW1hcmluaWNoZXZAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIExheWVyQ2hyb21pdW0vQ0NMYXllcklt cGwgb3duZXJzaGlwIGZpeAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9NTgyODMKKworICAgICAgICBDQ0xheWVySW1wbCdzIG1fb3duZXIgZmllbGQgbGlm ZXRpbWUgc2hvdWxkIG1hdGNoIHRoZSBsaWZldGltZSBvZiB0aGUKKyAgICAgICAgY29ycmVzcG9u ZGluZyBMYXllckNocm9taXVtLiAgVGhpcyBjaGFuZ2UgbW92ZXMgcmVzZXR0aW5nIG9mIG1fb3du ZXIKKyAgICAgICAgaW50byBMYXllckNocm9taXVtJ3MgZGVzdHJ1Y3Rvci4KKworICAgICAgICBU ZXN0ZWQgc2ltaWxhcmx5IHRvIGJ1ZyA1NzU3Ny4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBo aWNzL2Nocm9taXVtL0xheWVyQ2hyb21pdW0uY3BwOgorICAgICAgICAoV2ViQ29yZTo6TGF5ZXJD aHJvbWl1bTo6fkxheWVyQ2hyb21pdW0pOgorICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2No cm9taXVtL2NjL0NDTGF5ZXJJbXBsLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkNDTGF5ZXJJbXBs OjpjbGVhbnVwUmVzb3VyY2VzKToKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1 bS9jYy9DQ0xheWVySW1wbC5oOgorICAgICAgICAoV2ViQ29yZTo6Q0NMYXllckltcGw6OnJlc2V0 T3duZXIpOgorCiAyMDExLTA0LTEwICBDaGFuZ1Nlb2sgT2ggIDxzaGl2YW1pZG93QGdtYWlsLmNv bT4KIAogICAgICAgICBSZXZpZXdlZCBieSBFcmljIFNlaWRlbC4KZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL0xheWVyQ2hyb21pdW0uY3BwIGIv U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vTGF5ZXJDaHJvbWl1bS5j cHAKaW5kZXggYmMyODIzOTg5NWIzZWMwYzRlMzFjMzUwNDFlZGI1ZjU2YzFiYzk2Yy4uZmJhMWRj NTI0N2JmN2JhYmQyMzZhMTUyZWM0NDk3ZDQ1N2ZkZjVkYiAxMDA2NDQKLS0tIGEvU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vTGF5ZXJDaHJvbWl1bS5jcHAKKysrIGIv U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vTGF5ZXJDaHJvbWl1bS5j cHAKQEAgLTg5LDYgKzg5LDkgQEAgTGF5ZXJDaHJvbWl1bTo6fkxheWVyQ2hyb21pdW0oKQogICAg IC8vIHdheSBmb3IgdXMgdG8gYmUgZGVzdHJveWVkIHdoaWxlIHdlIHN0aWxsIGhhdmUgYSBzdXBl cmxheWVyLgogICAgIEFTU0VSVCghc3VwZXJsYXllcigpKTsKIAorICAgIGlmIChtX2NjTGF5ZXJJ bXBsKQorICAgICAgICBtX2NjTGF5ZXJJbXBsLT5yZXNldE93bmVyKCk7CisKICAgICAvLyBSZW1v dmUgdGhlIHN1cGVybGF5ZXIgcmVmZXJlbmNlIGZyb20gYWxsIHN1YmxheWVycy4KICAgICByZW1v dmVBbGxTdWJsYXllcnMoKTsKIH0KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L2dyYXBoaWNzL2Nocm9taXVtL2NjL0NDTGF5ZXJJbXBsLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL2NjL0NDTGF5ZXJJbXBsLmNwcAppbmRleCA0YTkxM2Rm MWRiZTIzMjQxYjY2MDU2NTY5MGU2ZjgxNDVhM2ZkMjgyLi40OTVkMWM3NGQ0MjY4ZDc5YmRlM2Ez MTA3ZGQxMmI2NmVmMmQ5YTIxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9n cmFwaGljcy9jaHJvbWl1bS9jYy9DQ0xheWVySW1wbC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vY2MvQ0NMYXllckltcGwuY3BwCkBAIC0xNTEsNyAr MTUxLDYgQEAgdm9pZCBDQ0xheWVySW1wbDo6YmluZENvbnRlbnRzVGV4dHVyZSgpCiAKIHZvaWQg Q0NMYXllckltcGw6OmNsZWFudXBSZXNvdXJjZXMoKQogewotICAgIG1fb3duZXIgPSAwOwogICAg IGlmIChyZW5kZXJTdXJmYWNlKCkpCiAgICAgICAgIHJlbmRlclN1cmZhY2UoKS0+Y2xlYW51cFJl c291cmNlcygpOwogfQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhp Y3MvY2hyb21pdW0vY2MvQ0NMYXllckltcGwuaCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dy YXBoaWNzL2Nocm9taXVtL2NjL0NDTGF5ZXJJbXBsLmgKaW5kZXggOTZjNGYxYjliM2Q0NmIyZTBl ZDQ4ODY4Yjk2OTUwYjJlMDI1YzUxNi4uNTAwNTEyN2MzZjdlYzBjNWI4NDA0NDMxYjVjNDY1ZmU0 YjUxZjg1YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hy b21pdW0vY2MvQ0NMYXllckltcGwuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFw aGljcy9jaHJvbWl1bS9jYy9DQ0xheWVySW1wbC5oCkBAIC01MCw2ICs1MCw3IEBAIHB1YmxpYzoK ICAgICB9CiAgICAgLy8gV2hlbiB0aGlzIGNsYXNzIGdldHMgc3ViY2xhc3NlcywgcmVtZW1iZXIg dG8gYWRkICd2aXJ0dWFsJyBoZXJlLgogICAgIHZpcnR1YWwgfkNDTGF5ZXJJbXBsKCk7CisgICAg dm9pZCByZXNldE93bmVyKCkgeyBtX293bmVyID0gMDsgfQogCiAjaWZuZGVmIE5ERUJVRwogICAg IGludCBkZWJ1Z0lEKCkgY29uc3QgeyByZXR1cm4gbV9kZWJ1Z0lEOyB9Cg==