58269 2011-04-11 14:27:57 -0700 [chromium] Crash in WebViewImpl::caretOrSelectionBounds 2011-04-11 18:33:52 -0700 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) All All RESOLVED FIXED P1 Normal --- 58286 1 rniwa webkit-unassigned dglazkov fishd ojan simonjam tkent tony oldest_to_newest 383526 0 rniwa 2011-04-11 14:27:57 -0700 Chromium crashes when extending selection over input[type="file"]. 383543 1 89093 rniwa 2011-04-11 14:39:16 -0700 Created attachment 89093 fixes the bug 383548 2 rniwa 2011-04-11 14:41:31 -0700 I've submitted a Chromium try job for this. Hopefully, they won't take forever. 383555 3 89093 tony 2011-04-11 14:48:53 -0700 Comment on attachment 89093 fixes the bug View in context: https://bugs.webkit.org/attachment.cgi?id=89093&action=review > LayoutTests/editing/selection/extend-over-file-input-by-drag-crash.html:7 > +WebKit should not crash. > +In </p> Were you going to write another sentence here or did you mean to remove "In"? > LayoutTests/ChangeLog:9 > + While the bug was specific to Chromium port, the test will be ran on all ports because "will be ran" -> "will be run" 383749 4 rniwa 2011-04-11 18:33:52 -0700 Committed r83548: <http://trac.webkit.org/changeset/83548> 89093 2011-04-11 14:39:16 -0700 2011-04-11 14:48:53 -0700 fixes the bug fix58269 text/plain 5272 rniwa SW5kZXg6IFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYlZpZXdJbXBsLmNwcAo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBTb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJWaWV3SW1wbC5jcHAJKHJldmlz aW9uIDgzNDMyKQorKysgU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViVmlld0ltcGwuY3Bw CSh3b3JraW5nIGNvcHkpCkBAIC0xNDM4LDE3ICsxNDM4LDE3IEBACiAgICAgaWYgKCF2aWV3KQog ICAgICAgICByZXR1cm4gcmVjdDsKIAotICAgIGNvbnN0IE5vZGUqIG5vZGUgPSBjb250cm9sbGVy LT5zdGFydCgpLmRlcHJlY2F0ZWROb2RlKCk7CisgICAgY29uc3QgTm9kZSogbm9kZSA9IGNvbnRy b2xsZXItPmJhc2UoKS5jb250YWluZXJOb2RlKCk7CiAgICAgaWYgKCFub2RlIHx8ICFub2RlLT5y ZW5kZXJlcigpKQogICAgICAgICByZXR1cm4gcmVjdDsKIAogICAgIGlmIChjb250cm9sbGVyLT5p c0NhcmV0KCkpCiAgICAgICAgIHJlY3QgPSB2aWV3LT5jb250ZW50c1RvV2luZG93KGNvbnRyb2xs ZXItPmFic29sdXRlQ2FyZXRCb3VuZHMoKSk7CiAgICAgZWxzZSBpZiAoY29udHJvbGxlci0+aXNS YW5nZSgpKSB7Ci0gICAgICAgIG5vZGUgPSBjb250cm9sbGVyLT5lbmQoKS5kZXByZWNhdGVkTm9k ZSgpOwotICAgICAgICBpZiAoIW5vZGUgfHwgIW5vZGUtPnJlbmRlcmVyKCkpCisgICAgICAgIG5v ZGUgPSBjb250cm9sbGVyLT5leHRlbnQoKS5jb250YWluZXJOb2RlKCk7CisgICAgICAgIFJlZlB0 cjxSYW5nZT4gcmFuZ2UgPSBjb250cm9sbGVyLT50b05vcm1hbGl6ZWRSYW5nZSgpOworICAgICAg ICBpZiAoIW5vZGUgfHwgIW5vZGUtPnJlbmRlcmVyKCkgfHwgIXJhbmdlKQogICAgICAgICAgICAg cmV0dXJuIHJlY3Q7Ci0gICAgICAgIFJlZlB0cjxSYW5nZT4gcmFuZ2UgPSBjb250cm9sbGVyLT50 b05vcm1hbGl6ZWRSYW5nZSgpOwogICAgICAgICByZWN0ID0gdmlldy0+Y29udGVudHNUb1dpbmRv dyhmb2N1c2VkLT5lZGl0b3IoKS0+Zmlyc3RSZWN0Rm9yUmFuZ2UocmFuZ2UuZ2V0KCkpKTsKICAg ICB9CiAgICAgcmV0dXJuIHJlY3Q7CkluZGV4OiBTb3VyY2UvV2ViS2l0L2Nocm9taXVtL0NoYW5n ZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwkocmV2 aXNpb24gODM1MDApCisrKyBTb3VyY2UvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwkod29ya2lu ZyBjb3B5KQpAQCAtMSwzICsxLDIzIEBACisyMDExLTA0LTExICBSeW9zdWtlIE5pd2EgIDxybml3 YUB3ZWJraXQub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIFtjaHJvbWl1bV0gQ3Jhc2ggaW4gV2ViVmlld0ltcGw6OmNhcmV0T3JTZWxlY3Rpb25C b3VuZHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTU4 MjY5CisKKyAgICAgICAgVGhlIGJ1ZyB3YXMgY2F1c2VkIGJ5IGNhcmV0T3JTZWxlY3Rpb25Cb3Vu ZHMncyBpbmNvcnJlY3RseSBhc3N1bWluZworICAgICAgICBTZWxlY3Rpb25Db250cm9sbGVyOjp0 b05vcm1hbGl6ZWRSYW5nZSB0byBhbHdheXMgcmV0dXJuIGEgbm9uLW51bGwgUmFuZ2UuCisKKyAg ICAgICAgRml4ZWQgdGhlIGJ1ZyBieSBhZGRpbmcgYSBudWxsIHBvaW50ZXIgY2hlY2suIEFsc28g cmVwbGFjZWQgY2FsbHMgdG8gZGVwcmVjYXRlZE5vZGUKKyAgICAgICAgYnkgY29udGFpbmVyTm9k ZSgpIGFuZCBjYWxscyB0byBTZWxlY3Rpb25Db250cm9sbGVyOjpzdGFydCgpIGFuZCBTZWxlY3Rp b25Db250cm9sbGVyOjplbmQoKQorICAgICAgICBieSBjYWxscyB0byBTZWxlY3Rpb25Db250cm9s bGVyOjpiYXNlKCkgYW5kIFNlbGVjdGlvbkNvbnRyb2xsZXI6OmV4dGVudCgpIGJlY2F1c2UKKyAg ICAgICAgc2VsZWN0aW9uIGV4dGVuZHMgZnJvbSBiYXNlIHRvIGV4dGVudCwgbm90IGZyb20gc3Rh cnQgdG8gZW5kLgorCisgICAgICAgIFRlc3Q6IGVkaXRpbmcvc2VsZWN0aW9uL2V4dGVuZC1vdmVy LWZpbGUtaW5wdXQtYnktZHJhZy1jcmFzaC5odG1sCisKKyAgICAgICAgKiBzcmMvV2ViVmlld0lt cGwuY3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJWaWV3SW1wbDo6Y2FyZXRPclNlbGVjdGlvbkJv dW5kcyk6CisKIDIwMTEtMDQtMTEgIERhbmllbCBDaGVuZyAgPGRjaGVuZ0BjaHJvbWl1bS5vcmc+ CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRG1pdHJ5IFRpdG92LgpJbmRleDogTGF5b3V0VGVzdHMv ZWRpdGluZy9zZWxlY3Rpb24vZXh0ZW5kLW92ZXItZmlsZS1pbnB1dC1ieS1kcmFnLWNyYXNoLWV4 cGVjdGVkLnR4dAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9lZGl0aW5nL3NlbGVjdGlvbi9l eHRlbmQtb3Zlci1maWxlLWlucHV0LWJ5LWRyYWctY3Jhc2gtZXhwZWN0ZWQudHh0CShyZXZpc2lv biAwKQorKysgTGF5b3V0VGVzdHMvZWRpdGluZy9zZWxlY3Rpb24vZXh0ZW5kLW92ZXItZmlsZS1p bnB1dC1ieS1kcmFnLWNyYXNoLWV4cGVjdGVkLnR4dAkocmV2aXNpb24gMCkKQEAgLTAsMCArMSwz IEBACitUaGlzIHRlc3QgZW5zdXJlcyBXZWJLaXQgZG9lcyBub3QgY3Jhc2ggd2hlbiBzZWxlY3Rp bmcgdGV4dCBhY3Jvc3MgYW4gZWxlbWVudCB3aXRoIHR5cGU9ZmlsZS4gVG8gbWFudWFsbHkgdGVz dCwgc3RhcnQgc2VsZWN0aW9uIGluICJzdGFydCIgYW5kIGV4dGVuZCB0aGUgc2VsZWN0aW9uIGJ5 IGRyYWdnaW5nIHRvICJlbmQiIG1vdmluZyBhY3Jvc3MgdGhlIGlucHV0IGVsZW1lbnQuIFdlYktp dCBzaG91bGQgbm90IGNyYXNoLiBJbgorCitQQVNTCkluZGV4OiBMYXlvdXRUZXN0cy9lZGl0aW5n L3NlbGVjdGlvbi9leHRlbmQtb3Zlci1maWxlLWlucHV0LWJ5LWRyYWctY3Jhc2guaHRtbAo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9lZGl0aW5nL3NlbGVjdGlvbi9leHRlbmQtb3Zlci1maWxl LWlucHV0LWJ5LWRyYWctY3Jhc2guaHRtbAkocmV2aXNpb24gMCkKKysrIExheW91dFRlc3RzL2Vk aXRpbmcvc2VsZWN0aW9uL2V4dGVuZC1vdmVyLWZpbGUtaW5wdXQtYnktZHJhZy1jcmFzaC5odG1s CShyZXZpc2lvbiAwKQpAQCAtMCwwICsxLDM1IEBACis8IURPQ1RZUEU+DQorPGh0bWw+DQorPGJv ZHk+DQorPHA+VGhpcyB0ZXN0IGVuc3VyZXMgV2ViS2l0IGRvZXMgbm90IGNyYXNoIHdoZW4gc2Vs ZWN0aW5nIHRleHQgYWNyb3NzIGFuIGVsZW1lbnQgd2l0aCB0eXBlPWZpbGUuDQorVG8gbWFudWFs bHkgdGVzdCwgc3RhcnQgc2VsZWN0aW9uIGluICJzdGFydCIgYW5kIGV4dGVuZCB0aGUgc2VsZWN0 aW9uIGJ5IGRyYWdnaW5nIHRvICJlbmQiIG1vdmluZyBhY3Jvc3MgdGhlIGlucHV0IGVsZW1lbnQu DQorV2ViS2l0IHNob3VsZCBub3QgY3Jhc2guDQorSW4gPC9wPg0KKzxzcGFuIGlkPSJ0ZXN0Ij5z dGFydDxpbnB1dCB0eXBlPWZpbGU+ZW5kPC9zcGFuPg0KKzxzY3JpcHQ+DQorDQoraWYgKHdpbmRv dy5sYXlvdXRUZXN0Q29udHJvbGxlciAmJiB3aW5kb3cuZXZlbnRTZW5kZXIpIHsNCisgICAgbGF5 b3V0VGVzdENvbnRyb2xsZXIuZHVtcEFzVGV4dCgpOw0KKw0KKyAgICB2YXIgdGVzdCA9IGRvY3Vt ZW50LmdldEVsZW1lbnRCeUlkKCd0ZXN0Jyk7DQorICAgIHZhciBpbnB1dCA9IHRlc3QuZ2V0RWxl bWVudHNCeVRhZ05hbWUoJ2lucHV0JylbMF07DQorDQorICAgIHZhciB5ID0gdGVzdC5vZmZzZXRU b3AgKyB0ZXN0Lm9mZnNldEhlaWdodCAvIDI7DQorICAgIGV2ZW50U2VuZGVyLm1vdXNlTW92ZVRv KHRlc3Qub2Zmc2V0TGVmdCArIDUsIHkpOw0KKyAgICBldmVudFNlbmRlci5tb3VzZURvd24oKTsN CisNCisgICAgZXZlbnRTZW5kZXIubGVhcEZvcndhcmQoMjAwKTsNCisgICAgZXZlbnRTZW5kZXIu bW91c2VNb3ZlVG8oaW5wdXQub2Zmc2V0TGVmdCArIGlucHV0Lm9mZnNldFdpZHRoIC8gMiwgeSk7 DQorICAgIGV2ZW50U2VuZGVyLmxlYXBGb3J3YXJkKDIwMCk7DQorDQorICAgIGV2ZW50U2VuZGVy Lm1vdXNlTW92ZVRvKHRlc3Qub2Zmc2V0TGVmdCArIHRlc3Qub2Zmc2V0V2lkdGggLSA1LCB5KTsN CisgICAgZXZlbnRTZW5kZXIubW91c2VEb3duKCk7DQorDQorICAgIHRlc3QucGFyZW50Tm9kZS5y ZW1vdmVDaGlsZCh0ZXN0KTsNCisNCisgICAgZG9jdW1lbnQud3JpdGUoJ1BBU1MnKTsNCit9DQor DQorPC9zY3JpcHQ+DQorPC9ib2R5Pg0KKzwvaHRtbD4NCkluZGV4OiBMYXlvdXRUZXN0cy9DaGFu Z2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCShyZXZpc2lvbiA4MzUw MCkKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3 IEBACisyMDExLTA0LTExICBSeW9zdWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtjaHJvbWl1bV0gQ3Jh c2ggaW4gV2ViVmlld0ltcGw6OmNhcmV0T3JTZWxlY3Rpb25Cb3VuZHMKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTU4MjY5CisKKyAgICAgICAgQWRkZWQg YSB0ZXN0IHRvIGVuc3VyZSBXZWJLaXQgZG9lcyBub3QgY3Jhc2ggd2hlbiBzZWxlY3Rpbmcgb3Zl ciBhIGZpbGUgaW5wdXQgZWxlbWVudC4KKyAgICAgICAgV2hpbGUgdGhlIGJ1ZyB3YXMgc3BlY2lm aWMgdG8gQ2hyb21pdW0gcG9ydCwgdGhlIHRlc3Qgd2lsbCBiZSByYW4gb24gYWxsIHBvcnRzIGJl Y2F1c2UKKyAgICAgICAgYWxsIG90aGVyIHBvcnRzIHNob3VsZCBub3QgY3Jhc2ggZWl0aGVyLgor CisgICAgICAgICogZWRpdGluZy9zZWxlY3Rpb24vZXh0ZW5kLW92ZXItZmlsZS1pbnB1dC1ieS1k cmFnLWNyYXNoLWV4cGVjdGVkLnR4dDogQWRkZWQuCisgICAgICAgICogZWRpdGluZy9zZWxlY3Rp b24vZXh0ZW5kLW92ZXItZmlsZS1pbnB1dC1ieS1kcmFnLWNyYXNoLmh0bWw6IEFkZGVkLgorCiAy MDExLTAzLTI1ICBBZHJpZW5uZSBXYWxrZXIgIDxlbm5lQGdvb2dsZS5jb20+CiAKICAgICAgICAg UmV2aWV3ZWQgYnkgSmFtZXMgUm9iaW5zb24uCg==