58260 2011-04-11 13:12:23 -0700 [chromium]: Get the list of misspelled words in the WebKit code insetad of in chromium's RenderView 2011-04-12 11:46:08 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 jam jam fishd oldest_to_newest 383414 0 jam 2011-04-11 13:12:23 -0700 [chromium]: Get the list of misspelled words in the WebKit code insetad of in chromium's RenderView 383416 1 89062 jam 2011-04-11 13:12:51 -0700 Created attachment 89062 Patch 383420 2 jam 2011-04-11 13:15:55 -0700 The Chrome side change is http://codereview.chromium.org/6813090/. The motivation is to get rid of the remaining code in render_view.cc which deals with spellchecking. Since all the code that uses it is in WebKit, with Chrome providing the implementation backend, I moved the little remaining code out to WebKit. 384063 3 89062 fishd 2011-04-12 09:30:01 -0700 Comment on attachment 89062 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=89062&action=review > Source/WebKit/chromium/src/ContextMenuClientImpl.cpp:269 > + nit: kill this extra new line 384206 4 jam 2011-04-12 11:46:08 -0700 Committed r83617: <http://trac.webkit.org/changeset/83617> 89062 2011-04-11 13:12:51 -0700 2011-04-12 09:30:01 -0700 Patch bug-58260-20110411131220.patch text/plain 5775 jam SW5kZXg6IFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNv dXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCShyZXZpc2lvbiA4MzQ4NCkKKysrIFNvdXJj ZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTgg QEAKKzIwMTEtMDQtMTEgIEpvaG4gQWJkLUVsLU1hbGVrICA8amFtQGNocm9taXVtLm9yZz4KKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbY2hyb21pdW1d OiBHZXQgdGhlIGxpc3Qgb2YgbWlzc3BlbGxlZCB3b3JkcyBpbiB0aGUgV2ViS2l0IGNvZGUgaW5z ZXRhZCBvZiBpbiBjaHJvbWl1bSdzIFJlbmRlclZpZXcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTU4MjYwCisKKyAgICAgICAgKiBwdWJsaWMvV2ViQ29u dGV4dE1lbnVEYXRhLmg6CisgICAgICAgICogcHVibGljL1dlYlNwZWxsQ2hlY2tDbGllbnQuaDoK KyAgICAgICAgKFdlYktpdDo6V2ViU3BlbGxDaGVja0NsaWVudDo6c3BlbGxDaGVjayk6CisgICAg ICAgICogc3JjL0NvbnRleHRNZW51Q2xpZW50SW1wbC5jcHA6CisgICAgICAgIChXZWJLaXQ6OkNv bnRleHRNZW51Q2xpZW50SW1wbDo6Z2V0Q3VzdG9tTWVudUZyb21EZWZhdWx0SXRlbXMpOgorICAg ICAgICAqIHNyYy9FZGl0b3JDbGllbnRJbXBsLmNwcDoKKyAgICAgICAgKFdlYktpdDo6RWRpdG9y Q2xpZW50SW1wbDo6Y2hlY2tTcGVsbGluZ09mU3RyaW5nKToKKwogMjAxMS0wNC0wNSAgSGFucyBX ZW5uYm9yZyAgPGhhbnNAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IFN0ZXZl IEJsb2NrLgpJbmRleDogU291cmNlL1dlYktpdC9jaHJvbWl1bS9ERVBTCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vREVQUwkocmV2aXNpb24gODM0NTApCisrKyBTb3VyY2Uv V2ViS2l0L2Nocm9taXVtL0RFUFMJKHdvcmtpbmcgY29weSkKQEAgLTMyLDcgKzMyLDcgQEAKIAog dmFycyA9IHsKICAgJ2Nocm9taXVtX3N2bic6ICdodHRwOi8vc3JjLmNocm9taXVtLm9yZy9zdm4v dHJ1bmsvc3JjJywKLSAgJ2Nocm9taXVtX3Jldic6ICc4MDc2NycKKyAgJ2Nocm9taXVtX3Jldic6 ICc4MTExOCcKIH0KIAogZGVwcyA9IHsKSW5kZXg6IFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vcHVi bGljL1dlYkNvbnRleHRNZW51RGF0YS5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQvY2hy b21pdW0vcHVibGljL1dlYkNvbnRleHRNZW51RGF0YS5oCShyZXZpc2lvbiA4MzQ1MCkKKysrIFNv dXJjZS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYkNvbnRleHRNZW51RGF0YS5oCSh3b3JraW5n IGNvcHkpCkBAIC0xMTEsNiArMTExLDkgQEAgc3RydWN0IFdlYkNvbnRleHRNZW51RGF0YSB7CiAg ICAgLy8gVGhlIGVkaXRhYmxlIChwb3NzaWJpbHkpIG1pc3NwZWxsZWQgd29yZC4KICAgICBXZWJT dHJpbmcgbWlzc3BlbGxlZFdvcmQ7CiAKKyAgICAvLyBJZiBtaXNzcGVsbGVkV29yZCBpcyBub3Qg ZW1wdHksIGhvbGRzIHN1Z2dlc3Rpb25zIGZyb20gdGhlIGRpY3Rpb25hcnkuCisgICAgV2ViVmVj dG9yPFdlYlN0cmluZz4gZGljdGlvbmFyeVN1Z2dlc3Rpb25zOworCiAgICAgLy8gV2hldGhlciBj b250ZXh0IGlzIGVkaXRhYmxlLgogICAgIGJvb2wgaXNFZGl0YWJsZTsKIApJbmRleDogU291cmNl L1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViU3BlbGxDaGVja0NsaWVudC5oCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYlNwZWxsQ2hlY2tDbGllbnQuaAko cmV2aXNpb24gODM0NTApCisrKyBTb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJTcGVs bENoZWNrQ2xpZW50LmgJKHdvcmtpbmcgY29weSkKQEAgLTMyLDIxICszMiwyNyBAQAogI2RlZmlu ZSBXZWJTcGVsbENoZWNrQ2xpZW50X2gKIAogI2luY2x1ZGUgIldlYlN0cmluZy5oIgorI2luY2x1 ZGUgIldlYlZlY3Rvci5oIgogCiBuYW1lc3BhY2UgV2ViS2l0IHsKIAogY2xhc3MgV2ViU3RyaW5n OwogY2xhc3MgV2ViVGV4dENoZWNraW5nQ29tcGxldGlvbjsKIAorI2RlZmluZSBXRUJTUEVMTENI RUNLQ0xJRU5UX0hBU19TVUdHRVNUSU9OUworCiBjbGFzcyBXZWJTcGVsbENoZWNrQ2xpZW50IHsK IHB1YmxpYzoKICAgICAvLyBUaGUgY2xpZW50IHNob3VsZCBwZXJmb3JtIHNwZWxsLWNoZWNraW5n IG9uIHRoZSBnaXZlbiB0ZXh0LiBJZiB0aGUKICAgICAvLyB0ZXh0IGNvbnRhaW5zIGEgbWlzc3Bl bGxlZCB3b3JkLCB0aGVuIHVwb24gcmV0dXJuIG1pc3NwZWxsZWRPZmZzZXQKICAgICAvLyB3aWxs IHBvaW50IHRvIHRoZSBzdGFydCBvZiB0aGUgbWlzc3BlbGxlZCB3b3JkLCBhbmQgbWlzc3BlbGxl ZExlbmd0aAogICAgIC8vIHdpbGwgaW5kaWNhdGVzIGl0cyBsZW5ndGguIE90aGVyd2lzZSwgaWYg dGhlcmUgd2FzIG5vdCBhIHNwZWxsaW5nCi0gICAgLy8gZXJyb3IsIHRoZW4gdXBvbiByZXR1cm4g bWlzc3BlbGxlZExlbmd0aCBpcyAwLgotICAgIHZpcnR1YWwgdm9pZCBzcGVsbENoZWNrKAotICAg ICAgICBjb25zdCBXZWJTdHJpbmcmIHRleHQsIGludCYgbWlzc3BlbGxlZE9mZnNldCwgaW50JiBt aXNzcGVsbGVkTGVuZ3RoKSB7IH0KKyAgICAvLyBlcnJvciwgdGhlbiB1cG9uIHJldHVybiBtaXNz cGVsbGVkTGVuZ3RoIGlzIDAuIElmIG9wdGlvbmFsX3N1Z2dlc3Rpb25zCisgICAgLy8gaXMgZ2l2 ZW4sIHRoZW4gaXQgd2lsbCBiZSBmaWxsZWQgd2l0aCBzdWdnZXN0ZWQgd29yZHMgKG5vdCBhIGNo ZWFwIHN0ZXApLgorICAgIHZpcnR1YWwgdm9pZCBzcGVsbENoZWNrKGNvbnN0IFdlYlN0cmluZyYg dGV4dCwKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICBpbnQmIG1pc3NwZWxsZWRPZmZzZXQs CisgICAgICAgICAgICAgICAgICAgICAgICAgICAgaW50JiBtaXNzcGVsbGVkTGVuZ3RoLAorICAg ICAgICAgICAgICAgICAgICAgICAgICAgIFdlYlZlY3RvcjxXZWJTdHJpbmc+KiBvcHRpb25hbFN1 Z2dlc3Rpb25zKSB7IH0KICAgICAvLyBSZXF1ZXN0cyBhc3luY2hyb25vdXMgc3BlbGxpbmcgYW5k IGdyYW1tYXIgY2hlY2tpbmcsIHdob3NlIHJlc3VsdCBzaG91bGQgYmUKICAgICAvLyByZXR1cm5l ZCBieSBwYXNzZWQgY29tcGxldGlvbiBvYmplY3QuCiAgICAgdmlydHVhbCB2b2lkIHJlcXVlc3RD aGVja2luZ09mVGV4dChjb25zdCBXZWJTdHJpbmcmLCBXZWJUZXh0Q2hlY2tpbmdDb21wbGV0aW9u KikgeyB9CkluZGV4OiBTb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9Db250ZXh0TWVudUNsaWVu dEltcGwuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL0NvbnRl eHRNZW51Q2xpZW50SW1wbC5jcHAJKHJldmlzaW9uIDgzNDUwKQorKysgU291cmNlL1dlYktpdC9j aHJvbWl1bS9zcmMvQ29udGV4dE1lbnVDbGllbnRJbXBsLmNwcAkod29ya2luZyBjb3B5KQpAQCAt NjEsNiArNjEsNyBAQAogI2luY2x1ZGUgIldlYlBsdWdpbi5oIgogI2luY2x1ZGUgIldlYlBsdWdp bkNvbnRhaW5lckltcGwuaCIKICNpbmNsdWRlICJXZWJQb2ludC5oIgorI2luY2x1ZGUgIldlYlNw ZWxsQ2hlY2tDbGllbnQuaCIKICNpbmNsdWRlICJXZWJTdHJpbmcuaCIKICNpbmNsdWRlICJXZWJV UkwuaCIKICNpbmNsdWRlICJXZWJVUkxSZXNwb25zZS5oIgpAQCAtMjU2LDggKzI1NywxOCBAQCBQ bGF0Zm9ybU1lbnVEZXNjcmlwdGlvbiBDb250ZXh0TWVudUNsaWVuCiAgICAgICAgIGlmIChtX3dl YlZpZXctPmZvY3VzZWRXZWJDb3JlRnJhbWUoKS0+ZWRpdG9yKCktPmlzQ29udGludW91c1NwZWxs Q2hlY2tpbmdFbmFibGVkKCkpIHsKICAgICAgICAgICAgIGRhdGEuaXNTcGVsbENoZWNraW5nRW5h YmxlZCA9IHRydWU7CiAgICAgICAgICAgICAvLyBTcGVsbGNoZWNraW5nIG1pZ2h0IGJlIGVuYWJs ZWQgZm9yIHRoZSBmaWVsZCwgYnV0IGNvdWxkIGJlIGRpc2FibGVkIG9uIHRoZSBub2RlLgotICAg ICAgICAgICAgaWYgKG1fd2ViVmlldy0+Zm9jdXNlZFdlYkNvcmVGcmFtZSgpLT5lZGl0b3IoKS0+ aXNTcGVsbENoZWNraW5nRW5hYmxlZEluRm9jdXNlZE5vZGUoKSkKKyAgICAgICAgICAgIGlmICht X3dlYlZpZXctPmZvY3VzZWRXZWJDb3JlRnJhbWUoKS0+ZWRpdG9yKCktPmlzU3BlbGxDaGVja2lu Z0VuYWJsZWRJbkZvY3VzZWROb2RlKCkpIHsKICAgICAgICAgICAgICAgICBkYXRhLm1pc3NwZWxs ZWRXb3JkID0gc2VsZWN0TWlzc3BlbGxlZFdvcmQoZGVmYXVsdE1lbnUsIHNlbGVjdGVkRnJhbWUp OworICAgICAgICAgICAgICAgIGlmIChtX3dlYlZpZXctPnNwZWxsQ2hlY2tDbGllbnQoKSkgewor ICAgICAgICAgICAgICAgICAgICBpbnQgbWlzc3BlbGxlZE9mZnNldCwgbWlzc3BlbGxlZExlbmd0 aDsKKyAgICAgICAgICAgICAgICAgICAgbV93ZWJWaWV3LT5zcGVsbENoZWNrQ2xpZW50KCktPnNw ZWxsQ2hlY2soCisgICAgICAgICAgICAgICAgICAgICAgICBkYXRhLm1pc3NwZWxsZWRXb3JkLCBt aXNzcGVsbGVkT2Zmc2V0LCBtaXNzcGVsbGVkTGVuZ3RoLAorICAgICAgICAgICAgICAgICAgICAg ICAgJmRhdGEuZGljdGlvbmFyeVN1Z2dlc3Rpb25zKTsKKyAgICAgICAgICAgICAgICAgICAgaWYg KCFtaXNzcGVsbGVkT2Zmc2V0KQorICAgICAgICAgICAgICAgICAgICAgICAgZGF0YS5taXNzcGVs bGVkV29yZC5yZXNldCgpOworCisgICAgICAgICAgICAgICAgfQorICAgICAgICAgICAgfQogICAg ICAgICB9CiAgICAgfQogCkluZGV4OiBTb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9FZGl0b3JD bGllbnRJbXBsLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9F ZGl0b3JDbGllbnRJbXBsLmNwcAkocmV2aXNpb24gODM0NTApCisrKyBTb3VyY2UvV2ViS2l0L2No cm9taXVtL3NyYy9FZGl0b3JDbGllbnRJbXBsLmNwcAkod29ya2luZyBjb3B5KQpAQCAtODU4LDcg Kzg1OCw3IEBAIHZvaWQgRWRpdG9yQ2xpZW50SW1wbDo6Y2hlY2tTcGVsbGluZ09mU3QKIAogICAg IC8vIENoZWNrIHRvIHNlZSBpZiB0aGUgcHJvdmlkZWQgdGV4dCBpcyBzcGVsbGVkIGNvcnJlY3Rs eS4KICAgICBpZiAoaXNDb250aW51b3VzU3BlbGxDaGVja2luZ0VuYWJsZWQoKSAmJiBtX3dlYlZp ZXctPnNwZWxsQ2hlY2tDbGllbnQoKSkKLSAgICAgICAgbV93ZWJWaWV3LT5zcGVsbENoZWNrQ2xp ZW50KCktPnNwZWxsQ2hlY2soV2ViU3RyaW5nKHRleHQsIGxlbmd0aCksIHNwZWxsTG9jYXRpb24s IHNwZWxsTGVuZ3RoKTsKKyAgICAgICAgbV93ZWJWaWV3LT5zcGVsbENoZWNrQ2xpZW50KCktPnNw ZWxsQ2hlY2soV2ViU3RyaW5nKHRleHQsIGxlbmd0aCksIHNwZWxsTG9jYXRpb24sIHNwZWxsTGVu Z3RoLCAwKTsKICAgICBlbHNlIHsKICAgICAgICAgc3BlbGxMb2NhdGlvbiA9IDA7CiAgICAgICAg IHNwZWxsTGVuZ3RoID0gMDsK