58258 2011-04-11 13:00:39 -0700 [Chromium] after a non-accelerated call, accelerated canvas-to-canvas draws are incorrect 2011-04-13 11:26:57 -0700 1 1 1 Unclassified WebKit Canvas 528+ (Nightly build) PC All RESOLVED FIXED P2 Normal --- 1 senorblanco senorblanco jamesr kbr mdelaney7 mixxster oldest_to_newest 383403 0 senorblanco 2011-04-11 13:00:39 -0700 If a non-accelerated canvas2D call is made (e.g., strokeRect) followed by a call to drawImage() of that canvas to another canvas context, the results will be incorrect (the stroke is not shown). This can be seen on sites such as http://canvasrider.com/tracks/695376, although there doesn't seem to be a layout test that covers it. 383409 1 89061 senorblanco 2011-04-11 13:06:09 -0700 Created attachment 89061 Patch 383445 2 89061 jamesr 2011-04-11 13:39:07 -0700 Comment on attachment 89061 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=89061&action=review Aha! > LayoutTests/fast/canvas/canvas-to-canvas.html:1 > +<!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML//EN"> just <!DOCTYPE html> should suffice 385038 3 senorblanco 2011-04-13 11:26:57 -0700 Landed as http://trac.webkit.org/changeset/83582. 89061 2011-04-11 13:06:09 -0700 2011-04-11 13:39:07 -0700 Patch bug-58258-20110411160607.patch text/plain 5397 senorblanco SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDgzNDgxKQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjAgQEAKKzIwMTEtMDQtMTEgIFN0ZXBoZW4g V2hpdGUgIDxzZW5vcmJsYW5jb0BjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW2Nocm9taXVtXSBHUFUtYWNjZWxlcmF0ZWQgY2Fu dmFzLXRvLWNhbnZhcyBkcmF3SW1hZ2UgaXMgaW5jb3JyZWN0LgorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTgyNTgKKworICAgICAgICBXaGVuIG9uZSBh Y2NlbGVyYXRlZCBjYW52YXMgaXMgZHJhd24gdG8gYW5vdGhlciB2aWEgZHJhd0ltYWdlKCksIGlm IHRoZQorICAgICAgICBwcmlvciBjYWxsIGluIHRoZSBzb3VyY2UgY2FudmFzIHdhcyBub24tYWNj ZWxlcmF0ZWQsIHRoZSAKKyAgICAgICAgaGFyZHdhcmUgY2FudmFzIGlzIG5vdCB1cC10by1kYXRl LCBhbmQgdGhlIHJlc3VsdHMgd2lsbCBiZSBpbmNvcnJlY3QuCisgICAgICAgIEZpeGVkIGJ5IGNh bGxpbmcgcHJlcGFyZUZvckhhcmR3YXJlRHJhdygpIG9uIHRoZSBzb3VyY2UgY29udGV4dC4KKwor ICAgICAgICBUZXN0OiBmYXN0L2NhbnZhcy9jYW52YXMtdG8tY2FudmFzLmh0bWwKKworICAgICAg ICAqIHBsYXRmb3JtL2dyYXBoaWNzL3NraWEvSW1hZ2VCdWZmZXJTa2lhLmNwcDoKKyAgICAgICAg KFdlYkNvcmU6OkltYWdlQnVmZmVyOjpkcmF3KToKKwogMjAxMS0wNC0xMSAgTWFyaW8gU2FuY2hl eiBQcmFkYSAgPG1zYW5jaGV6QGlnYWxpYS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgQ2hy aXMgRmxlaXphY2guCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9za2lh L0ltYWdlQnVmZmVyU2tpYS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vZ3JhcGhpY3Mvc2tpYS9JbWFnZUJ1ZmZlclNraWEuY3BwCShyZXZpc2lvbiA4MzQ4MSkKKysr IFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3NraWEvSW1hZ2VCdWZmZXJTa2lhLmNw cAkod29ya2luZyBjb3B5KQpAQCAtMTE3LDYgKzExNyw3IEBAIHZvaWQgSW1hZ2VCdWZmZXI6OmRy YXcoR3JhcGhpY3NDb250ZXh0KiAKIHsKICAgICBpZiAobV9kYXRhLm1fcGxhdGZvcm1Db250ZXh0 LnVzZUdQVSgpICYmIGNvbnRleHQtPnBsYXRmb3JtQ29udGV4dCgpLT51c2VHUFUoKSkgewogICAg ICAgICBpZiAoY29udGV4dC0+cGxhdGZvcm1Db250ZXh0KCktPmNhbkFjY2VsZXJhdGUoKSkgewor ICAgICAgICAgICAgbV9kYXRhLm1fcGxhdGZvcm1Db250ZXh0LnByZXBhcmVGb3JIYXJkd2FyZURy YXcoKTsKICAgICAgICAgICAgIERyYXdpbmdCdWZmZXIqIHNvdXJjZURyYXdpbmdCdWZmZXIgPSBt X2RhdGEubV9wbGF0Zm9ybUNvbnRleHQuZ3B1Q2FudmFzKCktPmRyYXdpbmdCdWZmZXIoKTsKICAg ICAgICAgICAgIHVuc2lnbmVkIHNvdXJjZVRleHR1cmUgPSBzdGF0aWNfY2FzdDx1bnNpZ25lZD4o c291cmNlRHJhd2luZ0J1ZmZlci0+cGxhdGZvcm1Db2xvckJ1ZmZlcigpKTsKICAgICAgICAgICAg IEZsb2F0UmVjdCBkZXN0UmVjdE5vcm1hbGl6ZWQobm9ybWFsaXplUmVjdChkZXN0UmVjdCkpOwpJ bmRleDogTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL0No YW5nZUxvZwkocmV2aXNpb24gODM0ODEpCisrKyBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHdvcmtp bmcgY29weSkKQEAgLTEsMyArMSwxNyBAQAorMjAxMS0wNC0xMSAgU3RlcGhlbiBXaGl0ZSAgPHNl bm9yYmxhbmNvQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBbY2hyb21pdW1dIEFjY2VsZXJhdGVkIGNhbnZhcy10by1jYW52YXMg ZHJhd0ltYWdlKCkgaXMgaW5jb3JyZWN0LgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9NTgyNTgKKworICAgICAgICBBZGQgYSBuZXcgdGVzdCB0byBjb3Zl ciBjYW52YXMtdG8tY2FudmFzIGRyYXdJbWFnZSgpIGFmdGVyIGEKKyAgICAgICAgbm9uLWFjY2Vs ZXJhdGVkIChzdHJva2VSZWN0KCkpIGNhbGwuCisKKyAgICAgICAgKiBmYXN0L2NhbnZhcy9jYW52 YXMtdG8tY2FudmFzLWV4cGVjdGVkLnR4dDogQWRkZWQuCisgICAgICAgICogZmFzdC9jYW52YXMv Y2FudmFzLXRvLWNhbnZhcy5odG1sOiBBZGRlZC4KKyAgICAgICAgKiBmYXN0L2NhbnZhcy9zY3Jp cHQtdGVzdHMvY2FudmFzLXRvLWNhbnZhcy5qczogQWRkZWQuCisKIDIwMTEtMDQtMTEgIEplc3Np ZSBCZXJsaW4gIDxqYmVybGluQGFwcGxlLmNvbT4KIAogICAgICAgICBbU25vdyBMZW9wYXJkIFdl YktpdDIgUmVsZWFzZSBUZXN0c10gaW5zcGVjdG9yL3N0eWxlcy9zdHlsZXMtYWRkLWJsYW5rLXBy b3BlcnR5Lmh0bWwgZmxha2V5LgpJbmRleDogTGF5b3V0VGVzdHMvZmFzdC9jYW52YXMvY2FudmFz LXRvLWNhbnZhcy1leHBlY3RlZC50eHQKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvZmFzdC9j YW52YXMvY2FudmFzLXRvLWNhbnZhcy1leHBlY3RlZC50eHQJKHJldmlzaW9uIDApCisrKyBMYXlv dXRUZXN0cy9mYXN0L2NhbnZhcy9jYW52YXMtdG8tY2FudmFzLWV4cGVjdGVkLnR4dAkocmV2aXNp b24gMCkKQEAgLTAsMCArMSwxMiBAQAorVGVzdCB0byBlbnN1cmUgdGhhdCBjYW52YXMtdG8tY2Fu dmFzIGRyYXdJbWFnZSBhZnRlciBhIHN0cm9rZWQgcmVjdCB3b3JrcyBjb3JyZWN0bHkuCisKK09u IHN1Y2Nlc3MsIHlvdSB3aWxsIHNlZSBhIHNlcmllcyBvZiAiUEFTUyIgbWVzc2FnZXMsIGZvbGxv d2VkIGJ5ICJURVNUIENPTVBMRVRFIi4KKworCitQQVNTIGltZ2RhdGFbMF0gaXMgMAorUEFTUyBp bWdkYXRhWzFdIGlzIDEyOAorUEFTUyBpbWdkYXRhWzJdIGlzIDAKK1BBU1Mgc3VjY2Vzc2Z1bGx5 UGFyc2VkIGlzIHRydWUKKworVEVTVCBDT01QTEVURQorCgpQcm9wZXJ0eSBjaGFuZ2VzIG9uOiBM YXlvdXRUZXN0cy9mYXN0L2NhbnZhcy9jYW52YXMtdG8tY2FudmFzLWV4cGVjdGVkLnR4dApfX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fCkFkZGVkOiBzdm46ZW9sLXN0eWxlCiAgICsgTEYKCkluZGV4OiBMYXlvdXRUZXN0cy9m YXN0L2NhbnZhcy9jYW52YXMtdG8tY2FudmFzLmh0bWwKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVz dHMvZmFzdC9jYW52YXMvY2FudmFzLXRvLWNhbnZhcy5odG1sCShyZXZpc2lvbiAwKQorKysgTGF5 b3V0VGVzdHMvZmFzdC9jYW52YXMvY2FudmFzLXRvLWNhbnZhcy5odG1sCShyZXZpc2lvbiAwKQpA QCAtMCwwICsxLDEzIEBACis8IURPQ1RZUEUgSFRNTCBQVUJMSUMgIi0vL0lFVEYvL0RURCBIVE1M Ly9FTiI+Cis8aHRtbD4KKzxoZWFkPgorPGxpbmsgcmVsPSJzdHlsZXNoZWV0IiBocmVmPSIuLi9q cy9yZXNvdXJjZXMvanMtdGVzdC1zdHlsZS5jc3MiPgorPHNjcmlwdCBzcmM9Ii4uL2pzL3Jlc291 cmNlcy9qcy10ZXN0LXByZS5qcyI+PC9zY3JpcHQ+Cis8L2hlYWQ+Cis8Ym9keT4KKzxwIGlkPSJk ZXNjcmlwdGlvbiI+PC9wPgorPGRpdiBpZD0iY29uc29sZSI+PC9kaXY+Cis8c2NyaXB0IHNyYz0i c2NyaXB0LXRlc3RzL2NhbnZhcy10by1jYW52YXMuanMiPjwvc2NyaXB0PgorPHNjcmlwdCBzcmM9 Ii4uL2pzL3Jlc291cmNlcy9qcy10ZXN0LXBvc3QuanMiPjwvc2NyaXB0PgorPC9ib2R5PgorPC9o dG1sPgoKUHJvcGVydHkgY2hhbmdlcyBvbjogTGF5b3V0VGVzdHMvZmFzdC9jYW52YXMvY2FudmFz LXRvLWNhbnZhcy5odG1sCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX18KQWRkZWQ6IHN2bjplb2wtc3R5bGUKICAgKyBMRgoK SW5kZXg6IExheW91dFRlc3RzL2Zhc3QvY2FudmFzL3NjcmlwdC10ZXN0cy9jYW52YXMtdG8tY2Fu dmFzLmpzCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2Zhc3QvY2FudmFzL3NjcmlwdC10ZXN0 cy9jYW52YXMtdG8tY2FudmFzLmpzCShyZXZpc2lvbiAwKQorKysgTGF5b3V0VGVzdHMvZmFzdC9j YW52YXMvc2NyaXB0LXRlc3RzL2NhbnZhcy10by1jYW52YXMuanMJKHJldmlzaW9uIDApCkBAIC0w LDAgKzEsMjEgQEAKK2Rlc2NyaXB0aW9uKCJUZXN0IHRvIGVuc3VyZSB0aGF0IGNhbnZhcy10by1j YW52YXMgZHJhd0ltYWdlIGFmdGVyIGEgc3Ryb2tlZCByZWN0IHdvcmtzIGNvcnJlY3RseS4iKTsK K3ZhciBjYW52YXMgPSBkb2N1bWVudC5jcmVhdGVFbGVtZW50KCdjYW52YXMnKTsKK3ZhciBjdHgg PSBjYW52YXMuZ2V0Q29udGV4dCgnMmQnKTsKKworY3R4LmxpbmVXaWR0aCA9IDEwOworY3R4LmJl Z2luUGF0aCgpOworY3R4LnN0cm9rZVN0eWxlID0gJ2dyZWVuJzsKK2N0eC5zdHJva2VSZWN0KDAs IDAsIDEwMCwgMTAwKTsKKwordmFyIGN0eDIgPSBkb2N1bWVudC5jcmVhdGVFbGVtZW50KCdjYW52 YXMnKS5nZXRDb250ZXh0KCcyZCcpOworCitjdHgyLmZpbGxTdHlsZSA9ICdyZWQnOworY3R4Mi5m aWxsUmVjdCgwLCAwLCAxMDAsIDEwMCk7CitjdHgyLmRyYXdJbWFnZShjYW52YXMsIDAsIDApOwor dmFyIGltYWdlRGF0YSA9IGN0eDIuZ2V0SW1hZ2VEYXRhKDAsIDAsIDEsIDEpOwordmFyIGltZ2Rh dGEgPSBpbWFnZURhdGEuZGF0YTsKK3Nob3VsZEJlKCJpbWdkYXRhWzBdIiwgIjAiKTsKK3Nob3Vs ZEJlKCJpbWdkYXRhWzFdIiwgIjEyOCIpOworc2hvdWxkQmUoImltZ2RhdGFbMl0iLCAiMCIpOwor Cit2YXIgc3VjY2Vzc2Z1bGx5UGFyc2VkID0gdHJ1ZTsKClByb3BlcnR5IGNoYW5nZXMgb246IExh eW91dFRlc3RzL2Zhc3QvY2FudmFzL3NjcmlwdC10ZXN0cy9jYW52YXMtdG8tY2FudmFzLmpzCl9f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX18KQWRkZWQ6IHN2bjplb2wtc3R5bGUKICAgKyBMRgoK