58256 2011-04-11 12:16:00 -0700 Ignore context change callbacks when not on the main thread 2011-04-11 15:03:51 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) All Windows 7 RESOLVED FIXED P2 Normal --- 1 eric.carlson eric.carlson aroben oldest_to_newest 383361 0 eric.carlson 2011-04-11 12:16:00 -0700 WKQCA::CAView::contextDidChangeCallback should do nothing when called on a background thread because it triggers WebCore rendering. 383368 1 89051 eric.carlson 2011-04-11 12:26:00 -0700 Created attachment 89051 Proposed patch 383427 2 aroben 2011-04-11 13:22:23 -0700 It would be nice to have a little more information in the bug and ChangeLog about when this could happen and why it's OK to ignore the callback in that case. 383502 3 eric.carlson 2011-04-11 14:11:22 -0700 It is safe to ignore the contextDidChangeCallback callback from background threads because in that case no changes have actually been committed to the context, so there is no chance animations will have started, etc. 383507 4 aroben 2011-04-11 14:14:26 -0700 Thanks, Eric. To be even more specific, IIRC, we expect to receive this notification on a background thread due to a CAImageQueue being modified. But in that case, as Eric said, there are no real changes to the context; we just need to render again (which WKCACFView will take care of on its own). 383510 5 aroben 2011-04-11 14:15:35 -0700 Eric, I think WebKit2 needs the same fix applied in LayerTreeHostCAWin. 383542 6 eric.carlson 2011-04-11 14:38:33 -0700 http://trac.webkit.org/changeset/83497 for the WK1 part. 383571 7 eric.carlson 2011-04-11 15:03:26 -0700 http://trac.webkit.org/changeset/83508 for the WK2 portion. 89051 2011-04-11 12:26:00 -0700 2011-04-11 13:14:54 -0700 Proposed patch patch_1.txt text/plain 1516 eric.carlson SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDgzNDc0KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTEtMDQtMTEgIEVyaWMgQ2Fy bHNvbiAgPGVyaWMuY2FybHNvbkBhcHBsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgSWdub3JlIGNvbnRleHQgY2hhbmdlIGNhbGxiYWNrcyB3 aGVuIG5vdCBvbiB0aGUgbWFpbiB0aHJlYWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTU4MjU2CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS85MjY2MDkw PgorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvY2Evd2luL1dLQ0FDRlZpZXdMYXllclRy ZWVIb3N0LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OldLQ0FDRlZpZXdMYXllclRyZWVIb3N0Ojpj b250ZXh0RGlkQ2hhbmdlKTogRG8gbm90aGluZyB3aGVuIG5vdCBjYWxsZWQKKyAgICAgICAgICAg IG9uIHRoZSBtYWluIHRocmVhZC4KKwogMjAxMS0wNC0xMSAgU2ltb24gRnJhc2VyICA8c2ltb24u ZnJhc2VyQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBEYW4gQmVybnN0ZWluLgpJ bmRleDogU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2Evd2luL1dLQ0FDRlZpZXdM YXllclRyZWVIb3N0LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9n cmFwaGljcy9jYS93aW4vV0tDQUNGVmlld0xheWVyVHJlZUhvc3QuY3BwCShyZXZpc2lvbiA4MzQ1 MSkKKysrIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2NhL3dpbi9XS0NBQ0ZWaWV3 TGF5ZXJUcmVlSG9zdC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTMxLDYgKzMxLDcgQEAKICNpbmNs dWRlICJQbGF0Zm9ybUNBTGF5ZXIuaCIKICNpbmNsdWRlICJTb2Z0TGlua2luZy5oIgogI2luY2x1 ZGUgPHd0Zi9DdXJyZW50VGltZS5oPgorI2luY2x1ZGUgPHd0Zi9UaHJlYWRpbmcuaD4KIAogdHlw ZWRlZiBzdHJ1Y3QgX0NBQ0ZMYXllciogQ0FDRkxheWVyUmVmOwogCkBAIC0xMDQsNiArMTA1LDkg QEAgdm9pZCBXS0NBQ0ZWaWV3TGF5ZXJUcmVlSG9zdDo6Y29udGV4dERpZAogCiB2b2lkIFdLQ0FD RlZpZXdMYXllclRyZWVIb3N0Ojpjb250ZXh0RGlkQ2hhbmdlKCkKIHsKKyAgICBpZiAoIWlzTWFp blRocmVhZCgpKQorICAgICAgICByZXR1cm47CisKICAgICAvLyBUZWxsIHRoZSBXS0NBQ0ZWaWV3 IHRvIHN0YXJ0IHJlbmRlcmluZyBub3cgdGhhdCB3ZSBoYXZlIHNvbWUgY29udGVudHMgdG8gcmVu ZGVyLgogICAgIHVwZGF0ZVZpZXdJZk5lZWRlZCgpOwogCg==