58252 2011-04-11 11:53:43 -0700 WebKit2: links don’t update to look visited 2011-04-11 12:13:45 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 sam sam oldest_to_newest 383330 0 sam 2011-04-11 11:53:43 -0700 WebKit2: links don’t update to look visited 383337 1 89043 sam 2011-04-11 12:00:24 -0700 Created attachment 89043 Patch 383339 2 89043 andersca 2011-04-11 12:02:15 -0700 Comment on attachment 89043 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=89043&action=review > Source/WebKit2/WebProcess/WebProcess.cpp:281 > + for (size_t i = 0; i < linkHashes.size(); ++i) { > + HashMap<uint64_t, RefPtr<WebPageGroupProxy> >::const_iterator it = m_pageGroupMap.begin(); > + HashMap<uint64_t, RefPtr<WebPageGroupProxy> >::const_iterator end = m_pageGroupMap.end(); > + for (; it != end; ++it) > + Page::visitedStateChanged(PageGroup::pageGroup(it->second->identifier()), linkHashes[i]); > + } Could you add a FIXME here specifying that we might not want to track visited links per context but per page group? > Source/WebKit2/WebProcess/WebProcess.cpp:289 > - Page::allVisitedStateChanged(sharedPageGroup()); > + HashMap<uint64_t, RefPtr<WebPageGroupProxy> >::const_iterator it = m_pageGroupMap.begin(); > + HashMap<uint64_t, RefPtr<WebPageGroupProxy> >::const_iterator end = m_pageGroupMap.end(); > + for (; it != end; ++it) > + Page::allVisitedStateChanged(PageGroup::pageGroup(it->second->identifier())); Ditto. 383355 3 sam 2011-04-11 12:13:45 -0700 Fixed in r83472. 89043 2011-04-11 12:00:24 -0700 2011-04-11 12:02:15 -0700 Patch bug-58252-20110411120023.patch text/plain 2935 sam SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDgzNDY2KQorKysgU291cmNlL1dlYktpdDIvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTggQEAKKzIwMTEtMDQtMTEgIFNhbSBXZWlu aWcgIDxzYW1Ad2Via2l0Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBXZWJLaXQyOiBsaW5rcyBkb27igJl0IHVwZGF0ZSB0byBsb29rIHZpc2l0 ZWQKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzg4MDYyNTQ+CisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01ODI1MgorCisgICAgICAgICogV2ViUHJvY2Vz cy9XZWJQcm9jZXNzLmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2ViUHJvY2Vzczo6dmlzaXRlZExp bmtTdGF0ZUNoYW5nZWQpOgorICAgICAgICAoV2ViS2l0OjpXZWJQcm9jZXNzOjphbGxWaXNpdGVk TGlua1N0YXRlQ2hhbmdlZCk6CisgICAgICAgICogV2ViUHJvY2Vzcy9XZWJQcm9jZXNzLmg6Cisg ICAgICAgIFJlbW92ZSB1c2Ugb2YgdmVzdGlnaWFsIHNoYXJlZFBhZ2VHcm91cCBhbmQgaW5zdGVh ZCBpdGVyYXRlIHNldCBvZgorICAgICAgICBwYWdlIGdyb3VwcyBpbiB1c2UgYnkgdGhlIHByb2Nl c3MuCisKIDIwMTEtMDQtMTEgIEJyaWFuIFdlaW5zdGVpbiAgPGJ3ZWluc3RlaW5AYXBwbGUuY29t PgogCiAgICAgICAgIFJldmlld2VkIGJ5IEFkYW0gUm9iZW4uCkluZGV4OiBTb3VyY2UvV2ViS2l0 Mi9XZWJQcm9jZXNzL1dlYlByb2Nlc3MuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQy L1dlYlByb2Nlc3MvV2ViUHJvY2Vzcy5jcHAJKHJldmlzaW9uIDgzNDQ1KQorKysgU291cmNlL1dl YktpdDIvV2ViUHJvY2Vzcy9XZWJQcm9jZXNzLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMjcxLDIw ICsyNzEsMjIgQEAgdm9pZCBXZWJQcm9jZXNzOjpzZXRWaXNpdGVkTGlua1RhYmxlKGNvbgogICAg IG1fdmlzaXRlZExpbmtUYWJsZS5zZXRTaGFyZWRNZW1vcnkoc2hhcmVkTWVtb3J5LnJlbGVhc2Uo KSk7CiB9CiAKLVBhZ2VHcm91cCogV2ViUHJvY2Vzczo6c2hhcmVkUGFnZUdyb3VwKCkKLXsKLSAg ICByZXR1cm4gUGFnZUdyb3VwOjpwYWdlR3JvdXAoIldlYktpdDJHcm91cCIpOwotfQotCiB2b2lk IFdlYlByb2Nlc3M6OnZpc2l0ZWRMaW5rU3RhdGVDaGFuZ2VkKGNvbnN0IFZlY3RvcjxXZWJDb3Jl OjpMaW5rSGFzaD4mIGxpbmtIYXNoZXMpCiB7Ci0gICAgZm9yIChzaXplX3QgaSA9IDA7IGkgPCBs aW5rSGFzaGVzLnNpemUoKTsgKytpKQotICAgICAgICBQYWdlOjp2aXNpdGVkU3RhdGVDaGFuZ2Vk KHNoYXJlZFBhZ2VHcm91cCgpLCBsaW5rSGFzaGVzW2ldKTsKKyAgICBmb3IgKHNpemVfdCBpID0g MDsgaSA8IGxpbmtIYXNoZXMuc2l6ZSgpOyArK2kpIHsKKyAgICAgICAgSGFzaE1hcDx1aW50NjRf dCwgUmVmUHRyPFdlYlBhZ2VHcm91cFByb3h5PiA+Ojpjb25zdF9pdGVyYXRvciBpdCA9IG1fcGFn ZUdyb3VwTWFwLmJlZ2luKCk7CisgICAgICAgIEhhc2hNYXA8dWludDY0X3QsIFJlZlB0cjxXZWJQ YWdlR3JvdXBQcm94eT4gPjo6Y29uc3RfaXRlcmF0b3IgZW5kID0gbV9wYWdlR3JvdXBNYXAuZW5k KCk7CisgICAgICAgIGZvciAoOyBpdCAhPSBlbmQ7ICsraXQpCisgICAgICAgICAgICBQYWdlOjp2 aXNpdGVkU3RhdGVDaGFuZ2VkKFBhZ2VHcm91cDo6cGFnZUdyb3VwKGl0LT5zZWNvbmQtPmlkZW50 aWZpZXIoKSksIGxpbmtIYXNoZXNbaV0pOworICAgIH0KIH0KIAogdm9pZCBXZWJQcm9jZXNzOjph bGxWaXNpdGVkTGlua1N0YXRlQ2hhbmdlZCgpCiB7Ci0gICAgUGFnZTo6YWxsVmlzaXRlZFN0YXRl Q2hhbmdlZChzaGFyZWRQYWdlR3JvdXAoKSk7CisgICAgSGFzaE1hcDx1aW50NjRfdCwgUmVmUHRy PFdlYlBhZ2VHcm91cFByb3h5PiA+Ojpjb25zdF9pdGVyYXRvciBpdCA9IG1fcGFnZUdyb3VwTWFw LmJlZ2luKCk7CisgICAgSGFzaE1hcDx1aW50NjRfdCwgUmVmUHRyPFdlYlBhZ2VHcm91cFByb3h5 PiA+Ojpjb25zdF9pdGVyYXRvciBlbmQgPSBtX3BhZ2VHcm91cE1hcC5lbmQoKTsKKyAgICBmb3Ig KDsgaXQgIT0gZW5kOyArK2l0KQorICAgICAgICBQYWdlOjphbGxWaXNpdGVkU3RhdGVDaGFuZ2Vk KFBhZ2VHcm91cDo6cGFnZUdyb3VwKGl0LT5zZWNvbmQtPmlkZW50aWZpZXIoKSkpOwogfQogCiBi b29sIFdlYlByb2Nlc3M6OmlzTGlua1Zpc2l0ZWQoTGlua0hhc2ggbGlua0hhc2gpIGNvbnN0Cklu ZGV4OiBTb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlByb2Nlc3MuaAo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBTb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlByb2Nlc3MuaAkocmV2aXNpb24gODM0NDUp CisrKyBTb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlByb2Nlc3MuaAkod29ya2luZyBjb3B5 KQpAQCAtOTksNyArOTksNiBAQCBwdWJsaWM6CiAKICAgICBXZWJQYWdlR3JvdXBQcm94eSogd2Vi UGFnZUdyb3VwKHVpbnQ2NF90IHBhZ2VHcm91cElEKTsKICAgICBXZWJQYWdlR3JvdXBQcm94eSog d2ViUGFnZUdyb3VwKGNvbnN0IFdlYlBhZ2VHcm91cERhdGEmKTsKLSAgICBzdGF0aWMgV2ViQ29y ZTo6UGFnZUdyb3VwKiBzaGFyZWRQYWdlR3JvdXAoKTsKICNpZiBQTEFURk9STShNQUMpCiAgICAg cGlkX3QgcHJlc2VudGVyQXBwbGljYXRpb25QaWQoKSBjb25zdCB7IHJldHVybiBtX3ByZXNlbnRl ckFwcGxpY2F0aW9uUGlkOyB9CiAjZW5kaWYgCg==