58243 2011-04-11 09:51:53 -0700 fix crc computation on 64 bit machines 2011-04-11 16:24:59 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 58173 1 tony tony abarth eric oldest_to_newest 383228 0 tony 2011-04-11 09:51:53 -0700 fix crc computation on 64 bit machines 383229 1 89019 tony 2011-04-11 09:53:43 -0700 Created attachment 89019 Patch 383304 2 89019 eric 2011-04-11 11:25:35 -0700 Comment on attachment 89019 Patch I like this change. No way to test it? 383314 3 tony 2011-04-11 11:36:37 -0700 Committed r83461: <http://trac.webkit.org/changeset/83461> 383316 4 tony 2011-04-11 11:37:40 -0700 (In reply to comment #2) > (From update of attachment 89019 [details]) > No way to test it? AFAIK, there's no way to write tests for DRT code. 383573 5 ap 2011-04-11 15:05:43 -0700 Why not uint32_t? Unlike unsigned, it's actually really always 32 bit. 383661 6 tony 2011-04-11 16:24:59 -0700 (In reply to comment #5) > Why not uint32_t? Unlike unsigned, it's actually really always 32 bit. It looks like stdint.h isn't included with MSVC, but there's a copy in Source/JavaScriptCore/os-win32 that has uint32_t defined. It seems like I could either change the include path on win and win-cairo or just #if COMPILER(MSVC) the typedef. Does one of these sound like the preferred way to you, Alexey? 89019 2011-04-11 09:53:43 -0700 2011-04-11 11:25:35 -0700 Patch bug-58243-20110411095342.patch text/plain 3845 tony U3VidmVyc2lvbiBSZXZpc2lvbjogODMyMTkKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBi L1Rvb2xzL0NoYW5nZUxvZwppbmRleCAxYWYyODVkNDI1MDcyMjE3OWQ5ZDk5ZGFhMTUwY2RiMzk0 NTg4MTA0Li42MzYxYTNkYWYzNjFlOTdhYTdmZGU3NzBkYjcwNThiMzE5ZWI5MWIwIDEwMDY0NAot LS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAg QEAKKzIwMTEtMDQtMTEgIFRvbnkgQ2hhbmcgIDx0b255QGNocm9taXVtLm9yZz4KKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBmaXggY3JjIGNvbXB1dGF0 aW9uIG9uIDY0IGJpdCBtYWNoaW5lcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9NTgyNDMKKworICAgICAgICB1bnNpZ25lZCBsb25nIGlzIGRlcGVuZGVu Y3Qgb24gQ1BVIGFyY2hpdGVjdHVyZSwgc28gdXNlIHVuc2lnbmVkIHdoaWNoIGlzIGFsd2F5cyAz MiBiaXRzCisKKyAgICAgICAgKiBEdW1wUmVuZGVyVHJlZS9DeWNsaWNSZWR1bmRhbmN5Q2hlY2su Y3BwOgorICAgICAgICAobWFrZUNyY1RhYmxlKToKKyAgICAgICAgKGNvbXB1dGVDcmMpOgorICAg ICAgICAqIER1bXBSZW5kZXJUcmVlL0N5Y2xpY1JlZHVuZGFuY3lDaGVjay5oOgorICAgICAgICAq IER1bXBSZW5kZXJUcmVlL1BpeGVsRHVtcFN1cHBvcnQuY3BwOgorICAgICAgICAoYXBwZW5kSW50 VG9WZWN0b3IpOgorICAgICAgICAoY29udmVydENoZWNrc3VtVG9QTkdDb21tZW50KToKKwogMjAx MS0wNC0wNyAgVG9ueSBDaGFuZyAgPHRvbnlAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmll d2VkIGJ5IEVyaWMgU2VpZGVsLgpkaWZmIC0tZ2l0IGEvVG9vbHMvRHVtcFJlbmRlclRyZWUvQ3lj bGljUmVkdW5kYW5jeUNoZWNrLmNwcCBiL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL0N5Y2xpY1JlZHVu ZGFuY3lDaGVjay5jcHAKaW5kZXggYjkyOTFlOWE3NTgxOWJlMDU3ZWYzYjY2NzRjMjVlYWNmODE0 YTRlYi4uMzYxZWEwZjc5ZWExOGYyMDIyODI5YjM2YjczYTFjMDM0MzAzNmM5MCAxMDA2NDQKLS0t IGEvVG9vbHMvRHVtcFJlbmRlclRyZWUvQ3ljbGljUmVkdW5kYW5jeUNoZWNrLmNwcAorKysgYi9U b29scy9EdW1wUmVuZGVyVHJlZS9DeWNsaWNSZWR1bmRhbmN5Q2hlY2suY3BwCkBAIC0zMywxMCAr MzMsMTAgQEAKIAogI2luY2x1ZGUgPHd0Zi9WZWN0b3IuaD4KIAotc3RhdGljIHZvaWQgbWFrZUNy Y1RhYmxlKHVuc2lnbmVkIGxvbmcgY3JjVGFibGVbMjU2XSkKK3N0YXRpYyB2b2lkIG1ha2VDcmNU YWJsZSh1bnNpZ25lZCBjcmNUYWJsZVsyNTZdKQogewotICAgIGZvciAodW5zaWduZWQgbG9uZyBp ID0gMDsgaSA8IDI1NjsgaSsrKSB7Ci0gICAgICAgIHVuc2lnbmVkIGxvbmcgYyA9IGk7CisgICAg Zm9yICh1bnNpZ25lZCBpID0gMDsgaSA8IDI1NjsgaSsrKSB7CisgICAgICAgIHVuc2lnbmVkIGMg PSBpOwogICAgICAgICBmb3IgKGludCBrID0gMDsgayA8IDg7IGsrKykgewogICAgICAgICAgICAg aWYgKGMgJiAxKQogICAgICAgICAgICAgICAgIGMgPSAtMzA2Njc0OTEyIF4gKChjID4+IDEpICYg MHg3ZmZmZmZmZik7CkBAIC00NywxNiArNDcsMTYgQEAgc3RhdGljIHZvaWQgbWFrZUNyY1RhYmxl KHVuc2lnbmVkIGxvbmcgY3JjVGFibGVbMjU2XSkKICAgICB9CiB9CiAKLXVuc2lnbmVkIGxvbmcg Y29tcHV0ZUNyYyhjb25zdCBWZWN0b3I8dW5zaWduZWQgY2hhcj4mIGJ1ZmZlcikKK3Vuc2lnbmVk IGNvbXB1dGVDcmMoY29uc3QgVmVjdG9yPHVuc2lnbmVkIGNoYXI+JiBidWZmZXIpCiB7Ci0gICAg c3RhdGljIHVuc2lnbmVkIGxvbmcgY3JjVGFibGVbMjU2XTsKKyAgICBzdGF0aWMgdW5zaWduZWQg Y3JjVGFibGVbMjU2XTsKICAgICBzdGF0aWMgYm9vbCBjcmNUYWJsZUNvbXB1dGVkID0gZmFsc2U7 CiAgICAgaWYgKCFjcmNUYWJsZUNvbXB1dGVkKSB7CiAgICAgICAgIG1ha2VDcmNUYWJsZShjcmNU YWJsZSk7CiAgICAgICAgIGNyY1RhYmxlQ29tcHV0ZWQgPSB0cnVlOwogICAgIH0KIAotICAgIHVu c2lnbmVkIGxvbmcgY3JjID0gMHhmZmZmZmZmZkw7CisgICAgdW5zaWduZWQgY3JjID0gMHhmZmZm ZmZmZkw7CiAgICAgZm9yIChzaXplX3QgaSA9IDA7IGkgPCBidWZmZXIuc2l6ZSgpOyArK2kpCiAg ICAgICAgIGNyYyA9IGNyY1RhYmxlWyhjcmMgXiBidWZmZXJbaV0pICYgMHhmZl0gXiAoKGNyYyA+ PiA4KSAmIDB4MDBmZmZmZmZMKTsKICAgICByZXR1cm4gY3JjIF4gMHhmZmZmZmZmZkw7CmRpZmYg LS1naXQgYS9Ub29scy9EdW1wUmVuZGVyVHJlZS9DeWNsaWNSZWR1bmRhbmN5Q2hlY2suaCBiL1Rv b2xzL0R1bXBSZW5kZXJUcmVlL0N5Y2xpY1JlZHVuZGFuY3lDaGVjay5oCmluZGV4IGMzYTczOWRj NzU5MmE5ZDg5NWJhN2VkNGY2Mjc2YzBkM2EzNjllMzAuLmVmMWQ3OGU4NmMzNWViNzllYzE4M2Zl MWQ2ZDJiMjU2MjNmOGFkZWQgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL0N5Y2xp Y1JlZHVuZGFuY3lDaGVjay5oCisrKyBiL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL0N5Y2xpY1JlZHVu ZGFuY3lDaGVjay5oCkBAIC0zMyw2ICszMyw2IEBACiAKICNpbmNsdWRlIDx3dGYvVmVjdG9yLmg+ CiAKLXVuc2lnbmVkIGxvbmcgY29tcHV0ZUNyYyhjb25zdCBWZWN0b3I8dW5zaWduZWQgY2hhcj4m KTsKK3Vuc2lnbmVkIGNvbXB1dGVDcmMoY29uc3QgVmVjdG9yPHVuc2lnbmVkIGNoYXI+Jik7CiAK ICNlbmRpZgpkaWZmIC0tZ2l0IGEvVG9vbHMvRHVtcFJlbmRlclRyZWUvUGl4ZWxEdW1wU3VwcG9y dC5jcHAgYi9Ub29scy9EdW1wUmVuZGVyVHJlZS9QaXhlbER1bXBTdXBwb3J0LmNwcAppbmRleCBh MGMyNzI5YTYxMGIwMzZiMGExMmRmZmM5M2Q1ZDA5YzQ1YTcxY2U5Li5lMjc0ODM5YmJiYzkwYzky NDJkMTU3M2RkZGQ1Y2FjNWFkOGUyYjdmIDEwMDY0NAotLS0gYS9Ub29scy9EdW1wUmVuZGVyVHJl ZS9QaXhlbER1bXBTdXBwb3J0LmNwcAorKysgYi9Ub29scy9EdW1wUmVuZGVyVHJlZS9QaXhlbER1 bXBTdXBwb3J0LmNwcApAQCAtNzQsNyArNzQsNyBAQCB2b2lkIGR1bXBXZWJWaWV3QXNQaXhlbHNB bmRDb21wYXJlV2l0aEV4cGVjdGVkKGNvbnN0IHN0ZDo6c3RyaW5nJiBleHBlY3RlZEhhc2gpCiAg ICAgICBkdW1wQml0bWFwKGNvbnRleHQuZ2V0KCksIGFjdHVhbEhhc2gpOwogfQogCi1zdGF0aWMg dm9pZCBhcHBlbmRJbnRUb1ZlY3RvcihpbnQgbnVtYmVyLCBWZWN0b3I8dW5zaWduZWQgY2hhcj4m IHZlY3RvcikKK3N0YXRpYyB2b2lkIGFwcGVuZEludFRvVmVjdG9yKHVuc2lnbmVkIG51bWJlciwg VmVjdG9yPHVuc2lnbmVkIGNoYXI+JiB2ZWN0b3IpCiB7CiAgICAgc2l6ZV90IG9mZnNldCA9IHZl Y3Rvci5zaXplKCk7CiAgICAgdmVjdG9yLmdyb3cob2Zmc2V0ICsgNCk7CkBAIC05Nyw3ICs5Nyw3 IEBAIHN0YXRpYyB2b2lkIGNvbnZlcnRDaGVja3N1bVRvUE5HQ29tbWVudChjb25zdCBjaGFyKiBj aGVja3N1bSwgVmVjdG9yPHVuc2lnbmVkIGNoCiAgICAgVmVjdG9yPHVuc2lnbmVkIGNoYXI+IGRh dGFUb0NyYzsKICAgICBkYXRhVG9DcmMuYXBwZW5kKHRleHRDb21tZW50UHJlZml4ICsgNCwgcHJl Zml4TGVuZ3RoIC0gNCk7IC8vIERvbid0IGluY2x1ZGUgdGhlIGNodW5rIGxlbmd0aCBpbiB0aGUg Y3JjLgogICAgIGRhdGFUb0NyYy5hcHBlbmQoY2hlY2tzdW0sIGNoZWNrc3VtTGVuZ3RoKTsKLSAg ICB1bnNpZ25lZCBsb25nIGNyYzMyID0gY29tcHV0ZUNyYyhkYXRhVG9DcmMpOworICAgIHVuc2ln bmVkIGNyYzMyID0gY29tcHV0ZUNyYyhkYXRhVG9DcmMpOwogCiAgICAgYXBwZW5kSW50VG9WZWN0 b3IoY3JjMzIsIGJ5dGVzVG9BZGQpOwogfQo=