58233 2011-04-11 07:19:05 -0700 fast/css/dashboard-regions-attr-crash.html asserts 2011-04-12 09:00:20 -0700 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) PC All RESOLVED FIXED P2 Normal --- 53488 1 ossy webkit-unassigned abecsi kling oldest_to_newest 383153 0 ossy 2011-04-11 07:19:05 -0700 fast/css/dashboard-regions-attr-crash.html asserts on the Qt debug bots. It is is a very very old assertion. stdout for r83435: ------------------- ASSERTION FAILED: unimplemented propertyID: 1287 ../../../Source/WebCore/css/SVGCSSParser.cpp(294) : bool WebCore::CSSParser::parseSVGValue(int, bool) 383184 1 abecsi 2011-04-11 08:48:10 -0700 (In reply to comment #0) > fast/css/dashboard-regions-attr-crash.html asserts on the Qt debug bots. > It is is a very very old assertion. > > stdout for r83435: > ------------------- > ASSERTION FAILED: unimplemented propertyID: 1287 > ../../../Source/WebCore/css/SVGCSSParser.cpp(294) : bool WebCore::CSSParser::parseSVGValue(int, bool) AFAIK dashboard region is Mac-specific, and in CSSParser::parseValue the CSSPropertyWebkitDashboardRegion case is guarded by ENABLE(DASHBOARD_SUPPORT). Since Qt does not support it, it falls though further to parseSVGValue where in the default case there is this ASSERT_WITH_MESSAGE. I think the test should either be skipped permanently or there should be an elif define with a break in parseValue to catch the CSSPropertyWebkitDashboardRegion property. I vote for the first approach ot make the debug bot happy. 384006 2 89205 ossy 2011-04-12 08:18:18 -0700 Created attachment 89205 proposed fix 384011 3 abecsi 2011-04-12 08:30:20 -0700 (In reply to comment #2) > Created an attachment (id=89205) [details] > proposed fix LGTM! Even better! For features.pri having -= lines is simply wrong, maybe even check-webkit-style could shout for it. 384020 4 ossy 2011-04-12 08:42:25 -0700 (In reply to comment #3) > (In reply to comment #2) > > Created an attachment (id=89205) [details] [details] > > proposed fix > > LGTM! > > Even better! > > For features.pri having -= lines is simply wrong, maybe even check-webkit-style could shout for it. It was good long time ago, because the initialization of DASHBOARDSUPPORTCSSPROPERTIES was before this -= hack. (When there aren't any WebCore.pri, DerivedSources.pro, CodeGenerators.pri, but a monumental and ugly WebCore.pro) 384037 5 89205 benjamin 2011-04-12 08:55:00 -0700 Comment on attachment 89205 proposed fix Look sane, trust you 384041 6 89205 ossy 2011-04-12 08:59:53 -0700 Comment on attachment 89205 proposed fix Landed in http://trac.webkit.org/changeset/83593 89205 2011-04-12 08:18:18 -0700 2011-04-12 08:59:52 -0700 proposed fix 1.patch text/plain 2146 ossy ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCAzYWEzMGYxLi5lZWE4NzcxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYg QEAKKzIwMTEtMDQtMTIgIENzYWJhIE9zenRyb2dvbsOhYyAgPG9zc3lAd2Via2l0Lm9yZz4KKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBmYXN0L2Nzcy9k YXNoYm9hcmQtcmVnaW9ucy1hdHRyLWNyYXNoLmh0bWwgYXNzZXJ0cworICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTgyMzMKKworICAgICAgICBNb3ZlIERB U0hCT0FSRF9TVVBQT1JUIGZlYXR1cmUgZGV0ZWN0aW9uIGZyb20gZmVhdHVyZXMucHJpIHRvIENv ZGVHZW5lcmF0b3JzLnByaQorICAgICAgICBub3QgdG8gZ2VuZXJhdGUgaW5jb3JyZWN0IHByb3Bl cnRpZXMgaW50byBDU1NQcm9wZXJ0eU5hbWVzLmguCisKKyAgICAgICAgKiBDb2RlR2VuZXJhdG9y cy5wcmk6CisgICAgICAgICogZmVhdHVyZXMucHJpOgorCiAyMDExLTA0LTEyICBBbmRyZXkgQWRh aWtpbiAgPGFhbmRyZXlAZ29vZ2xlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBZdXJ5IFNl bWlraGF0c2t5LgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvQ29kZUdlbmVyYXRvcnMucHJp IGIvU291cmNlL1dlYkNvcmUvQ29kZUdlbmVyYXRvcnMucHJpCmluZGV4IDI0N2IwYjYuLjViMWU4 NjQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL0NvZGVHZW5lcmF0b3JzLnByaQorKysgYi9T b3VyY2UvV2ViQ29yZS9Db2RlR2VuZXJhdG9ycy5wcmkKQEAgLTM4LDcgKzM4LDcgQEAgV0FMRE9D U1NQUk9QUyA9ICQkUFdEL2Nzcy9DU1NQcm9wZXJ0eU5hbWVzLmluCiAKIFdBTERPQ1NTVkFMVUVT ID0gJCRQV0QvY3NzL0NTU1ZhbHVlS2V5d29yZHMuaW4KIAotREFTSEJPQVJEU1VQUE9SVENTU1BS T1BFUlRJRVMgPSAkJFBXRC9jc3MvRGFzaGJvYXJkU3VwcG9ydENTU1Byb3BlcnR5TmFtZXMuaW4K K2NvbnRhaW5zKERFRklORVMsIEVOQUJMRV9EQVNIQk9BUkRfU1VQUE9SVD0xKTogREFTSEJPQVJE U1VQUE9SVENTU1BST1BFUlRJRVMgPSAkJFBXRC9jc3MvRGFzaGJvYXJkU3VwcG9ydENTU1Byb3Bl cnR5TmFtZXMuaW4KIAogWFBBVEhCSVNPTiA9ICQkUFdEL3htbC9YUGF0aEdyYW1tYXIueQogCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9mZWF0dXJlcy5wcmkgYi9Tb3VyY2UvV2ViQ29yZS9m ZWF0dXJlcy5wcmkKaW5kZXggMzM2Mjc4ZC4uNmQzZGY2ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dl YkNvcmUvZmVhdHVyZXMucHJpCisrKyBiL1NvdXJjZS9XZWJDb3JlL2ZlYXR1cmVzLnByaQpAQCAt MTk4LDcgKzE5OCw2IEBAIEZFQVRVUkVfREVGSU5FU19KQVZBU0NSSVBUID0gTEFOR1VBR0VfSkFW QVNDUklQVD0xCiB2ODogRkVBVFVSRV9ERUZJTkVTX0pBVkFTQ1JJUFQgKz0gVjhfQklORElORz0x CiBjb250YWlucyhERUZJTkVTLCBFTkFCTEVfQ0hBTk5FTF9NRVNTQUdJTkc9MSk6IEZFQVRVUkVf REVGSU5FU19KQVZBU0NSSVBUICs9IEVOQUJMRV9DSEFOTkVMX01FU1NBR0lORz0xCiBjb250YWlu cyhERUZJTkVTLCBFTkFCTEVfT1JJRU5UQVRJT05fRVZFTlRTPTEpOiBGRUFUVVJFX0RFRklORVNf SkFWQVNDUklQVCArPSBFTkFCTEVfT1JJRU5UQVRJT05fRVZFTlRTPTEKLWNvbnRhaW5zKERFRklO RVMsIEVOQUJMRV9EQVNIQk9BUkRfU1VQUE9SVD0wKTogREFTSEJPQVJEU1VQUE9SVENTU1BST1BF UlRJRVMgLT0gJCRQV0QvY3NzL0Rhc2hib2FyZFN1cHBvcnRDU1NQcm9wZXJ0eU5hbWVzLmluCiBj b250YWlucyhERUZJTkVTLCBFTkFCTEVfREFUQUdSSUQ9MSk6IEZFQVRVUkVfREVGSU5FU19KQVZB U0NSSVBUICs9IEVOQUJMRV9EQVRBR1JJRD0xCiBjb250YWlucyhERUZJTkVTLCBFTkFCTEVfRVZF TlRTT1VSQ0U9MSk6IEZFQVRVUkVfREVGSU5FU19KQVZBU0NSSVBUICs9IEVOQUJMRV9FVkVOVFNP VVJDRT0xCiBjb250YWlucyhERUZJTkVTLCBFTkFCTEVfREFUQUJBU0U9MSk6IEZFQVRVUkVfREVG SU5FU19KQVZBU0NSSVBUICs9IEVOQUJMRV9EQVRBQkFTRT0xCg==