58201 2011-04-10 08:41:13 -0700 REGRESSION(r83384): Change to chromium.py is resulting in failures of the test framework on linux. 2011-04-10 14:28:08 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 58202 1 levin levin dglazkov dpranke oldest_to_newest 382884 0 levin 2011-04-10 08:41:13 -0700 As can be seen here: http://build.chromium.org/p/chromium.webkit/builders/Webkit%20Linux/builds/5724/steps/webkit_tests/logs/stdio 382886 1 88950 levin 2011-04-10 08:53:53 -0700 Created attachment 88950 Patch 382887 2 levin 2011-04-10 08:55:00 -0700 See dependent bug for the follow up to remove the fixme (and do a better fix). 382888 3 88950 dglazkov 2011-04-10 08:58:20 -0700 Comment on attachment 88950 Patch ok. 382890 4 levin 2011-04-10 09:01:45 -0700 Committed as http://trac.webkit.org/changeset/83398 382934 5 dpranke 2011-04-10 14:28:08 -0700 From looking at the python code implementing subprocess, it looks like either os.waitpid() could be returning something weird, or it could be raising os.error. So, something's definitely wrong, but having NRWT fall over at that point isn't all that useful, so your change is good. I will see if I can follow-up and reproduce it in bug 58202. 88950 2011-04-10 08:53:53 -0700 2011-04-10 08:58:20 -0700 Patch bug-58201-20110410085352.patch text/plain 1560 levin U3VidmVyc2lvbiBSZXZpc2lvbjogODMzOTcKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBi L1Rvb2xzL0NoYW5nZUxvZwppbmRleCA4YTg2MDA2ZDY2N2I0ZGJiMDgzNWE0NThkOThhMjBiMzc1 ZjM1YzU5Li41MDBjMWFjYWIyYTQ5MGI3ZjAwOTdkYzBiYzAyNTEwOTRkM2ExYjNlIDEwMDY0NAot LS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMg QEAKKzIwMTEtMDQtMTAgIERhdmlkIExldmluICA8bGV2aW5AY2hyb21pdW0ub3JnPgorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFJFR1JFU1NJT04ocjgz Mzg0KTogQ2hhbmdlIHRvIGNocm9taXVtLnB5IGlzIHJlc3VsdGluZyBpbiBmYWlsdXJlcyBvZiB0 aGUgdGVzdCBmcmFtZXdvcmsgb24gbGludXguCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD01ODIwMQorCisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS9s YXlvdXRfdGVzdHMvcG9ydC9jaHJvbWl1bS5weTogQ29tbWVudGVkIG91dCB0aGUgYXNzZXJ0IGZv ciBub3csCisgICAgICAgIGFuZCBmaWxlZCBidWcgNTgyMDIuCisKIDIwMTEtMDQtMDkgIERhdmlk IExldmluICA8bGV2aW5AY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFVucmV2aWV3ZWQsIHJvbGxp bmcgb3V0IHI4MzM5NC4KZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0 X3Rlc3RzL3BvcnQvY2hyb21pdW0ucHkgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90 ZXN0cy9wb3J0L2Nocm9taXVtLnB5CmluZGV4IGIwMDQ3YzYyYzIxYmE5NmNhNjZjMTFkMmFlMmIx ZDIxYmI4NTcxZWQuLjMyZGExNmZkNGQ2NmNlYmRiNjhiMjA4ZDcyOTM3ZGM2NTc0MzQ3N2QgMTAw NjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvY2hyb21p dW0ucHkKKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9jaHJv bWl1bS5weQpAQCAtNTI1LDYgKzUyNSw3IEBAIGNsYXNzIENocm9taXVtRHJpdmVyKGJhc2UuRHJp dmVyKToKICAgICAgICAgICAgICAgICBfbG9nLndhcm5pbmcoJ3N0b3BwaW5nIHRlc3QgZHJpdmVy IHRpbWVkIG91dCwgJwogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAna2lsbGluZyBp dCcpCiAgICAgICAgICAgICAgICAgc2VsZi5fcG9ydC5fZXhlY3V0aXZlLmtpbGxfcHJvY2Vzcyhz ZWxmLl9wcm9jLnBpZCkKLSAgICAgICAgICAgIGFzc2VydCBzZWxmLl9wcm9jLnBvbGwoKSBpcyBu b3QgTm9uZQotICAgICAgICAgICAgc2VsZi5fcHJvYy53YWl0KCkKKyAgICAgICAgICAgICMgRklY TUU6IFRoaXMgaXMgc29tZXRpbWUgbm9uZS4gV2hhdCBpcyB3cm9uZz8gYXNzZXJ0IHNlbGYuX3By b2MucG9sbCgpIGlzIG5vdCBOb25lCisgICAgICAgICAgICBpZiBzZWxmLl9wcm9jLnBvbGwoKSBp cyBub3QgTm9uZToKKyAgICAgICAgICAgICAgICBzZWxmLl9wcm9jLndhaXQoKQogICAgICAgICAg ICAgc2VsZi5fcHJvYyA9IE5vbmUK