5820 2005-11-24 11:00:17 -0800 Table cells with width:auto should use width from their <col> 2005-12-02 00:55:09 -0800 1 1 1 Unclassified WebKit Tables 420+ Mac OS X 10.4 VERIFIED FIXED http://www.ynet.co.il/articles/0,7340,L-3174419,00.html P2 Normal --- 1 mitz hyatt oldest_to_newest 24506 0 mitz 2005-11-24 11:00:17 -0800 A table cell whose width is 'auto' should use the width property of the corresponding col element if there is one. WinIE renders the testcase as expected. 24507 1 4790 mitz 2005-11-24 11:01:30 -0800 Created attachment 4790 testcase 24508 2 4791 mitz 2005-11-24 11:26:02 -0800 Created attachment 4791 Use <col> width during layout when necessary I am not sure that this is the right approach (rather than doing some crazy CSS "inheritance"). Also, for table cells with colspan > 1, it falls back on "auto", which didn't seem worse than any other option I tried or what I saw in Firefox. 24545 3 4791 darin 2005-11-25 13:54:42 -0800 Comment on attachment 4791 Use <col> width during layout when necessary This looks just right to me. r=me If it was me, I would have used a return rather than "w=" in RenderTableCell::styleOrColWidth, but there are arguments that go both ways on this very minor coding style issue. It would be slightly better if RenderTableCell::calcMinMaxWidth() was written so that it did not call styleOrColWidth() unless nowrap is set, but worrying about this smacks of premature optimization. 4790 2005-11-24 11:01:30 -0800 2005-11-24 11:01:30 -0800 testcase colWidth.html text/html 1222 mitz PCFET0NUWVBFIEhUTUwgUFVCTElDICItLy9XM0MvL0RURCBIVE1MIDQuMDEgVHJhbnNpdGlvbmFs Ly9FTiIgCiJodHRwOi8vd3d3LnczLm9yZy9UUi9odG1sNC9sb29zZS5kdGQiPgo8aHRtbD4KPGhl YWQ+Cjx0aXRsZT53aWR0aCBpbiAmbHQ7Q09MJmd0OzwvdGl0bGU+DQo8L2hlYWQ+Cjxib2R5Pgo8 ZGl2IHN0eWxlPSJ3aWR0aDogNjAwcHg7Ij4KPHA+VGhlIGZvbGxvd2luZyB0d28gdGFibGVzIHNo b3VsZCBiZSB0aGUgc2FtZS48L3A+DQo8cD5UYWJsZSAxOiB3aWR0aCBpbiAmbHQ7Q09MJmd0Ozwv cD4KPHRhYmxlIHN0eWxlPSJ0YWJsZS1sYXlvdXQ6YXV0bzsiPg0KICAgIDxjb2wgc3R5bGU9Indp ZHRoOiAxNTBweDsiPgogICAgPGNvbCBzdHlsZT0id2lkdGg6IDEwMHB4OyI+CiAgICA8dHI+DQog ICAgICAgIDx0ZCBzdHlsZT0iYmFja2dyb3VuZDogeWVsbG93OyI+CiAgICAgICAgICAgIENyYXMg dGluY2lkdW50IGJpYmVuZHVtIG51bmMuIE1vcmJpIGNvbmRpbWVudHVtIGFsaXF1ZXQgZGlhbS4g UGhhc2VsbHVzIHB1bHZpbmFyLCBuaXNsIGF0IHRlbXBvciBhdWN0b3IsIGRvbG9yIHBlZGUgdmVz dGlidWx1bSByaXN1cywgcGxhY2VyYXQgbWFsZXN1YWRhIGR1aSBlbmltIG5lYyBlc3QuIE51bGxh IGxlby4KICAgICAgICA8L3RkPgogICAgICAgIDx0ZCBzdHlsZT0iYmFja2dyb3VuZDogZ3JlZW47 Ij4KICAgICAgICAgICAgTG9yZW0gaXBzdW0KICAgICAgICA8L3RkPgogICAgPC90cj4KPC90YWJs ZT4KPHA+VGFibGUgMjogd2lkdGggaW4gJmx0O1REJmd0OzwvcD4KPHRhYmxlIHN0eWxlPSJ0YWJs ZS1sYXlvdXQ6YXV0bzsiPg0KICAgIDx0cj4NCiAgICAgICAgPHRkIHN0eWxlPSJ3aWR0aDogMTUw cHg7IGJhY2tncm91bmQ6IHllbGxvdzsiPgogICAgICAgICAgICBDcmFzIHRpbmNpZHVudCBiaWJl bmR1bSBudW5jLiBNb3JiaSBjb25kaW1lbnR1bSBhbGlxdWV0IGRpYW0uIFBoYXNlbGx1cyBwdWx2 aW5hciwgbmlzbCBhdCB0ZW1wb3IgYXVjdG9yLCBkb2xvciBwZWRlIHZlc3RpYnVsdW0gcmlzdXMs IHBsYWNlcmF0IG1hbGVzdWFkYSBkdWkgZW5pbSBuZWMgZXN0LiBOdWxsYSBsZW8uCiAgICAgICAg PC90ZD4KICAgICAgICA8dGQgc3R5bGU9IndpZHRoOiAxMDBweDsgYmFja2dyb3VuZDogZ3JlZW47 Ij4KICAgICAgICAgICAgTG9yZW0gaXBzdW0KICAgICAgICA8L3RkPgogICAgPC90cj4KPC90YWJs ZT4KPC9kaXY+CjwvYm9keT4KPC9odG1sPg== 4791 2005-11-24 11:26:02 -0800 2005-11-25 13:54:42 -0800 Use <col> width during layout when necessary 5820_r1.patch text/plain 5026 mitz SW5kZXg6IFdlYkNvcmUva2h0bWwvcmVuZGVyaW5nL3JlbmRlcl9ibG9jay5jcHAKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQpSQ1MgZmlsZTogL2N2cy9yb290L1dlYkNvcmUva2h0bWwvcmVuZGVyaW5nL3JlbmRlcl9ibG9j ay5jcHAsdgpyZXRyaWV2aW5nIHJldmlzaW9uIDEuMjE1CmRpZmYgLXAgLXUgLXIxLjIxNSBXZWJD b3JlL2todG1sL3JlbmRlcmluZy9yZW5kZXJfYmxvY2suY3BwCi0tLSBXZWJDb3JlL2todG1sL3Jl bmRlcmluZy9yZW5kZXJfYmxvY2suY3BwCTUgTm92IDIwMDUgMDA6MjA6MjggLTAwMDAJMS4yMTUK KysrIFdlYkNvcmUva2h0bWwvcmVuZGVyaW5nL3JlbmRlcl9ibG9jay5jcHAJMjQgTm92IDIwMDUg MTk6MTE6MzAgLTAwMDAKQEAgLTI2NzQsMTIgKzI2NzQsMTIgQEAgdm9pZCBSZW5kZXJCbG9jazo6 Y2FsY01pbk1heFdpZHRoKCkKICAgICAgICAgICAgIG1fbWluV2lkdGggPSAwOwogICAgIH0KIAot ICAgIGlmIChzdHlsZSgpLT53aWR0aCgpLmlzRml4ZWQoKSAmJiBzdHlsZSgpLT53aWR0aCgpLnZh bHVlID4gMCkgewotICAgICAgICBpZiAoaXNUYWJsZUNlbGwoKSkKLSAgICAgICAgICAgIG1fbWF4 V2lkdGggPSBrTWF4KG1fbWluV2lkdGgsIGNhbGNDb250ZW50Qm94V2lkdGgoc3R5bGUoKS0+d2lk dGgoKS52YWx1ZSkpOwotICAgICAgICBlbHNlCi0gICAgICAgICAgICBtX21pbldpZHRoID0gbV9t YXhXaWR0aCA9IGNhbGNDb250ZW50Qm94V2lkdGgoc3R5bGUoKS0+d2lkdGgoKS52YWx1ZSk7Ci0g ICAgfQorICAgIGlmIChpc1RhYmxlQ2VsbCgpKSB7CisgICAgICAgIExlbmd0aCB3ID0gc3RhdGlj X2Nhc3Q8UmVuZGVyVGFibGVDZWxsKj4odGhpcyktPnN0eWxlT3JDb2xXaWR0aCgpOworICAgICAg ICBpZiAody5pc0ZpeGVkKCkgJiYgdy52YWx1ZSA+IDApCisgICAgICAgICAgICBtX21heFdpZHRo ID0ga01heChtX21pbldpZHRoLCBjYWxjQ29udGVudEJveFdpZHRoKHcudmFsdWUpKTsKKyAgICB9 IGVsc2UgaWYgKHN0eWxlKCktPndpZHRoKCkuaXNGaXhlZCgpICYmIHN0eWxlKCktPndpZHRoKCku dmFsdWUgPiAwKQorICAgICAgICBtX21pbldpZHRoID0gbV9tYXhXaWR0aCA9IGNhbGNDb250ZW50 Qm94V2lkdGgoc3R5bGUoKS0+d2lkdGgoKS52YWx1ZSk7CiAgICAgCiAgICAgaWYgKHN0eWxlKCkt Pm1pbldpZHRoKCkuaXNGaXhlZCgpICYmIHN0eWxlKCktPm1pbldpZHRoKCkudmFsdWUgPiAwKSB7 CiAgICAgICAgIG1fbWF4V2lkdGggPSBrTWF4KG1fbWF4V2lkdGgsIGNhbGNDb250ZW50Qm94V2lk dGgoc3R5bGUoKS0+bWluV2lkdGgoKS52YWx1ZSkpOwpJbmRleDogV2ViQ29yZS9raHRtbC9yZW5k ZXJpbmcvcmVuZGVyX3RhYmxlLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09ClJDUyBmaWxlOiAvY3ZzL3Jvb3QvV2Vi Q29yZS9raHRtbC9yZW5kZXJpbmcvcmVuZGVyX3RhYmxlLmNwcCx2CnJldHJpZXZpbmcgcmV2aXNp b24gMS4xNDAKZGlmZiAtcCAtdSAtcjEuMTQwIFdlYkNvcmUva2h0bWwvcmVuZGVyaW5nL3JlbmRl cl90YWJsZS5jcHAKLS0tIFdlYkNvcmUva2h0bWwvcmVuZGVyaW5nL3JlbmRlcl90YWJsZS5jcHAJ MTggTm92IDIwMDUgMjM6NDI6MDYgLTAwMDAJMS4xNDAKKysrIFdlYkNvcmUva2h0bWwvcmVuZGVy aW5nL3JlbmRlcl90YWJsZS5jcHAJMjQgTm92IDIwMDUgMTk6MTE6NDEgLTAwMDAKQEAgLTE1MDMs MjAgKzE1MDMsMzIgQEAgdm9pZCBSZW5kZXJUYWJsZUNlbGw6OnVwZGF0ZUZyb21FbGVtZW50KAog ICAgICAgICBzZXROZWVkc0xheW91dEFuZE1pbk1heFJlY2FsYygpOwogfQogICAgIAorTGVuZ3Ro IFJlbmRlclRhYmxlQ2VsbDo6c3R5bGVPckNvbFdpZHRoKCkKK3sKKyAgICBMZW5ndGggdyA9IHN0 eWxlKCktPndpZHRoKCk7CisgICAgaWYgKGNvbFNwYW4oKSA+IDEgfHwgIXcuaXNBdXRvKCkpCisg ICAgICAgIHJldHVybiB3OworICAgIFJlbmRlclRhYmxlQ29sKiBjb2wgPSB0YWJsZSgpLT5jb2xF bGVtZW50KF9jb2wpOworICAgIGlmIChjb2wpCisgICAgICAgIHcgPSBjb2wtPnN0eWxlKCktPndp ZHRoKCk7CisgICAgcmV0dXJuIHc7Cit9CisKIHZvaWQgUmVuZGVyVGFibGVDZWxsOjpjYWxjTWlu TWF4V2lkdGgoKQogewogICAgIFJlbmRlckJsb2NrOjpjYWxjTWluTWF4V2lkdGgoKTsKICAgICBp ZiAoZWxlbWVudCgpICYmIHN0eWxlKCktPmF1dG9XcmFwKCkpIHsKICAgICAgICAgLy8gU2VlIGlm IG5vd3JhcCB3YXMgc2V0LgorICAgICAgICBMZW5ndGggdyA9IHN0eWxlT3JDb2xXaWR0aCgpOwog ICAgICAgICBET01TdHJpbmcgbm93cmFwID0gc3RhdGljX2Nhc3Q8RWxlbWVudEltcGwqPihlbGVt ZW50KCkpLT5nZXRBdHRyaWJ1dGUobm93cmFwQXR0cik7Ci0gICAgICAgIGlmICghbm93cmFwLmlz TnVsbCgpICYmIHN0eWxlKCktPndpZHRoKCkuaXNGaXhlZCgpKQorICAgICAgICBpZiAoIW5vd3Jh cC5pc051bGwoKSAmJiB3LmlzRml4ZWQoKSkKICAgICAgICAgICAgIC8vIE5vd3JhcCBpcyBzZXQs IGJ1dCB3ZSBkaWRuJ3QgYWN0dWFsbHkgdXNlIGl0IGJlY2F1c2Ugb2YgdGhlCiAgICAgICAgICAg ICAvLyBmaXhlZCB3aWR0aCBzZXQgb24gdGhlIGNlbGwuICBFdmVuIHNvLCBpdCBpcyBhIFdpbklF L01veiB0cmFpdAogICAgICAgICAgICAgLy8gdG8gbWFrZSB0aGUgbWlud2lkdGggb2YgdGhlIGNl bGwgaW50byB0aGUgZml4ZWQgd2lkdGguICBUaGV5IGRvIHRoaXMKICAgICAgICAgICAgIC8vIGV2 ZW4gaW4gc3RyaWN0IG1vZGUsIHNvIGRvIG5vdCBtYWtlIHRoaXMgYSBxdWlyay4gIEFmZmVjdGVk IHRoZSB0b3AKICAgICAgICAgICAgIC8vIG9mIGhpcHRvcC5jb20uCi0gICAgICAgICAgICBpZiAo bV9taW5XaWR0aCA8IHN0eWxlKCktPndpZHRoKCkudmFsdWUpCi0gICAgICAgICAgICAgICAgbV9t aW5XaWR0aCA9IHN0eWxlKCktPndpZHRoKCkudmFsdWU7CisgICAgICAgICAgICBpZiAobV9taW5X aWR0aCA8IHcudmFsdWUpCisgICAgICAgICAgICAgICAgbV9taW5XaWR0aCA9IHcudmFsdWU7CiAg ICAgfQogfQogCkluZGV4OiBXZWJDb3JlL2todG1sL3JlbmRlcmluZy9yZW5kZXJfdGFibGUuaAo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09ClJDUyBmaWxlOiAvY3ZzL3Jvb3QvV2ViQ29yZS9raHRtbC9yZW5kZXJpbmcvcmVu ZGVyX3RhYmxlLmgsdgpyZXRyaWV2aW5nIHJldmlzaW9uIDEuNTAKZGlmZiAtcCAtdSAtcjEuNTAg V2ViQ29yZS9raHRtbC9yZW5kZXJpbmcvcmVuZGVyX3RhYmxlLmgKLS0tIFdlYkNvcmUva2h0bWwv cmVuZGVyaW5nL3JlbmRlcl90YWJsZS5oCTE3IE5vdiAyMDA1IDIzOjQwOjAxIC0wMDAwCTEuNTAK KysrIFdlYkNvcmUva2h0bWwvcmVuZGVyaW5nL3JlbmRlcl90YWJsZS5oCTI0IE5vdiAyMDA1IDE5 OjExOjQ2IC0wMDAwCkBAIC0zMzcsNiArMzM3LDggQEAgcHVibGljOgogICAgIGludCByb3coKSBj b25zdCB7IHJldHVybiBfcm93OyB9CiAgICAgdm9pZCBzZXRSb3coaW50IHIpIHsgX3JvdyA9IHI7 IH0KIAorICAgIExlbmd0aCBzdHlsZU9yQ29sV2lkdGgoKTsKKwogICAgIC8vIG92ZXJyaWRlcwog ICAgIHZpcnR1YWwgdm9pZCBjYWxjTWluTWF4V2lkdGgoKTsKICAgICB2aXJ0dWFsIHZvaWQgY2Fs Y1dpZHRoKCk7CkluZGV4OiBXZWJDb3JlL2todG1sL3JlbmRlcmluZy90YWJsZV9sYXlvdXQuY3Bw Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KUkNTIGZpbGU6IC9jdnMvcm9vdC9XZWJDb3JlL2todG1sL3JlbmRlcmluZy90 YWJsZV9sYXlvdXQuY3BwLHYKcmV0cmlldmluZyByZXZpc2lvbiAxLjI2CmRpZmYgLXAgLXUgLXIx LjI2IFdlYkNvcmUva2h0bWwvcmVuZGVyaW5nL3RhYmxlX2xheW91dC5jcHAKLS0tIFdlYkNvcmUv a2h0bWwvcmVuZGVyaW5nL3RhYmxlX2xheW91dC5jcHAJMTcgTm92IDIwMDUgMTg6NDQ6NTQgLTAw MDAJMS4yNgorKysgV2ViQ29yZS9raHRtbC9yZW5kZXJpbmcvdGFibGVfbGF5b3V0LmNwcAkyNCBO b3YgMjAwNSAxOToxMTo1NCAtMDAwMApAQCAtMTgxLDcgKzE4MSw3IEBAIGludCBGaXhlZFRhYmxl TGF5b3V0OjpjYWxjV2lkdGhBcnJheShpbnQKIAl3aGlsZSAoIGNoaWxkICkgewogCSAgICBpZiAo IGNoaWxkLT5pc1RhYmxlQ2VsbCgpICkgewogCQlSZW5kZXJUYWJsZUNlbGwgKmNlbGwgPSBzdGF0 aWNfY2FzdDxSZW5kZXJUYWJsZUNlbGwgKj4oY2hpbGQpOwotCQlMZW5ndGggdyA9IGNlbGwtPnN0 eWxlKCktPndpZHRoKCk7CisJCUxlbmd0aCB3ID0gY2VsbC0+c3R5bGVPckNvbFdpZHRoKCk7CiAJ CWludCBzcGFuID0gY2VsbC0+Y29sU3BhbigpOwogCQlpbnQgZWZmV2lkdGggPSAwOwogCQlpZiAo ICh3LnR5cGUgPT0gRml4ZWQgfHwgdy50eXBlID09IFBlcmNlbnQpICYmIHcudmFsdWUgPiAwICkK QEAgLTM5NSw3ICszOTUsNyBAQCB2b2lkIEF1dG9UYWJsZUxheW91dDo6cmVjYWxjQ29sdW1uKCBp bnQgCiAJCQltYXhDb250cmlidXRvciA9IGNlbGw7CiAJCSAgICB9CiAKLQkJICAgIExlbmd0aCB3 ID0gY2VsbC0+c3R5bGUoKS0+d2lkdGgoKTsKKwkJICAgIExlbmd0aCB3ID0gY2VsbC0+c3R5bGVP ckNvbFdpZHRoKCk7CiAJCSAgICBpZiAody52YWx1ZSA+IDMyNzYwKQogCQkJdy52YWx1ZSA9IDMy NzYwOwogCQkgICAgaWYgKHcudmFsdWUgPCAwKQpAQCAtNjMyLDcgKzYzMiw3IEBAIGludCBBdXRv VGFibGVMYXlvdXQ6OmNhbGNFZmZlY3RpdmVXaWR0aCgKIAkgICAgYnJlYWs7CiAJaW50IHNwYW4g PSBjZWxsLT5jb2xTcGFuKCk7CiAKLQlMZW5ndGggdyA9IGNlbGwtPnN0eWxlKCktPndpZHRoKCk7 CisJTGVuZ3RoIHcgPSBjZWxsLT5zdHlsZU9yQ29sV2lkdGgoKTsKIAlpZiAoICEody50eXBlID09 IFJlbGF0aXZlKSAmJiB3LnZhbHVlID09IDAgKQogCSAgICB3ID0gTGVuZ3RoKCk7IC8vIG1ha2Ug aXQgQXV0bwogCg==