58197 2011-04-09 20:03:48 -0700 new-run-webkit-tests: fix crash when running under windows cmd.exe 2011-04-15 15:13:49 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 dpranke dpranke abarth aroben eric mihaip ojan tony oldest_to_newest 382835 0 dpranke 2011-04-09 20:03:48 -0700 new-run-webkit-tests: fix crash when running under windows cmd.exe 382836 1 88943 dpranke 2011-04-09 20:05:02 -0700 Created attachment 88943 Patch 382848 2 88943 aroben 2011-04-09 22:13:57 -0700 Comment on attachment 88943 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=88943&action=review > Tools/Scripts/webkitpy/layout_tests/port/http_server.py:217 > + self._process = subprocess.Popen(start_cmd, env=env, stdin=subprocess.PIPE) Would it be better to use devnull? 383370 3 dpranke 2011-04-11 12:27:43 -0700 (In reply to comment #2) > (From update of attachment 88943 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=88943&action=review > > > Tools/Scripts/webkitpy/layout_tests/port/http_server.py:217 > > + self._process = subprocess.Popen(start_cmd, env=env, stdin=subprocess.PIPE) > > Would it be better to use devnull? In limited testing, that does appear to work as well; An advantage to subprocess.PIPE, is that it gets cleaned up automatically when I close the process, which keeps the code slightly cleaner. 383374 4 dpranke 2011-04-11 12:32:06 -0700 Committed r83477: <http://trac.webkit.org/changeset/83477> 386974 5 dpranke 2011-04-15 15:13:49 -0700 *** Bug 54513 has been marked as a duplicate of this bug. *** 88943 2011-04-09 20:05:02 -0700 2011-04-09 22:13:57 -0700 Patch bug-58197-20110409200501.patch text/plain 1822 dpranke U3VidmVyc2lvbiBSZXZpc2lvbjogODMzODQKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBi L1Rvb2xzL0NoYW5nZUxvZwppbmRleCBhMmY4NzczOTkzM2JkMmI1NjgxMjE4NzA5NTI4ODlkZTI0 ZThmM2I0Li4wN2Q3YWIwZDczNmM0NDI1YjU4ZWMyNjUyYWY1MGZmZDllMDMxNjU5IDEwMDY0NAot LS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMjAg QEAKIDIwMTEtMDQtMDkgIERpcmsgUHJhbmtlICA8ZHByYW5rZUBjaHJvbWl1bS5vcmc+CiAKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgbmV3LXJ1bi13ZWJr aXQtdGVzdHM6IGZpeCBjcmFzaCB3aGVuIHJ1bm5pbmcgdW5kZXIgd2luZG93cyBjbWQuZXhlCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01ODE5NworCisg ICAgICAgIFdlIHdvdWxkIGludGVybWl0dGVudGx5IGNyYXNoIHdoZW4gcnVubmluZyBOUldUIGRp cmVjdGx5IHVuZGVyCisgICAgICAgIGNtZC5leGUgb24gd2luZG93cyBiZWNhdXNlIHdlIHdlcmUg c2hhcmluZyB0aGUgc3RkaW4gZmlsZQorICAgICAgICBkZXNjcmlwdG9yIGJldHdlZW4gdGhlIHB5 dGhvbiBwcm9jZXNzIGFuZCB0aGUgaHR0cCBzZXJ2ZXIuCisgICAgICAgIGNtZC5leGUgcmVhbGx5 IGRpZG4ndCBsaWtlIHRoYXQsIGFuZCB0aGVyZSB3YXMgbm8gcmVhc29uIHRvCisgICAgICAgIHNo YXJlIHRoZSBkZXNjcmlwdG9yLCBzbyB3ZSBub3cgdXNlIGEgUElQRSBpbnN0ZWFkLgorCisgICAg ICAgICogU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9odHRwX3NlcnZlci5weToK KworMjAxMS0wNC0wOSAgRGlyayBQcmFua2UgIDxkcHJhbmtlQGNocm9taXVtLm9yZz4KKwogICAg ICAgICBSZXZpZXdlZCBieSBUb255IENoYW5nLgogCiAgICAgICAgIEl0IGxvb2tzIGxpa2UgTlJX VCBoYXMgbm90IGJlZW4gc3RvcHBpbmcgRFJUL1Rlc3RTaGVsbApkaWZmIC0tZ2l0IGEvVG9vbHMv U2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9odHRwX3NlcnZlci5weSBiL1Rvb2xz L1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvaHR0cF9zZXJ2ZXIucHkKaW5kZXgg MTc1M2FlZTcxZDJlYWJkNmQwMGQyNGI0NDA3YWRjYjg4ZGEyZmQ2MS4uNWJhNzY3ZmFlODVhYTg3 NTU0ODQ3MzIzM2JjNjAyMDVhYmE4ZWE5OCAxMDA3NTUKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJr aXRweS9sYXlvdXRfdGVzdHMvcG9ydC9odHRwX3NlcnZlci5weQorKysgYi9Ub29scy9TY3JpcHRz L3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L2h0dHBfc2VydmVyLnB5CkBAIC0yMTQsNyArMjE0 LDcgQEAgY2xhc3MgTGlnaHR0cGQoaHR0cF9zZXJ2ZXJfYmFzZS5IdHRwU2VydmVyQmFzZSk6CiAg ICAgICAgIGVudiA9IHNlbGYuX3BvcnRfb2JqLnNldHVwX2Vudmlyb25fZm9yX3NlcnZlcigpCiAg ICAgICAgIF9sb2cuZGVidWcoJ1N0YXJ0aW5nIGh0dHAgc2VydmVyLCBjbWQ9IiVzIicgJSBzdHIo c3RhcnRfY21kKSkKICAgICAgICAgIyBGSVhNRTogU2hvdWxkIHVzZSBFeGVjdXRpdmUucnVuX2Nv bW1hbmQKLSAgICAgICAgc2VsZi5fcHJvY2VzcyA9IHN1YnByb2Nlc3MuUG9wZW4oc3RhcnRfY21k LCBlbnY9ZW52KQorICAgICAgICBzZWxmLl9wcm9jZXNzID0gc3VicHJvY2Vzcy5Qb3BlbihzdGFy dF9jbWQsIGVudj1lbnYsIHN0ZGluPXN1YnByb2Nlc3MuUElQRSkKIAogICAgICAgICAjIFdhaXQg Zm9yIHNlcnZlciB0byBzdGFydC4KICAgICAgICAgc2VsZi5tYXBwaW5ncyA9IG1hcHBpbmdzCg==