58164 2011-04-08 14:07:48 -0700 prepare-ChangeLog support email input but -h did not show the option 2011-04-11 18:27:00 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 1 george.guo george.guo commit-queue eric george.guo webkit.review.bot oldest_to_newest 382554 0 george.guo 2011-04-08 14:07:48 -0700 It's nice to be able to enter email address at command line by prepare-ChangeLog --email= option. However when you do the commandline prepare-ChangeLog --help, it did not mention the email option. I think it would be nice to let user know the email option when user use --help. This will improve the usability of prepare-ChangeLog 382557 1 88874 george.guo 2011-04-08 14:15:38 -0700 Created attachment 88874 A patch for review 382559 2 webkit.review.bot 2011-04-08 14:18:28 -0700 Attachment 88874 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Tools/ChangeLog', u'Tools/Scripts/prepare-..." exit_code: 1 Tools/ChangeLog:8: Line contains tab character. [whitespace/tab] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 382760 3 88874 eric 2011-04-09 01:52:48 -0700 Comment on attachment 88874 A patch for review LGTM except the tab. 382773 4 george.guo 2011-04-09 07:48:33 -0700 I'll try to find tab in the file, BTW, is there any good tool find it? Thanks 382774 5 eric 2011-04-09 08:13:18 -0700 (In reply to comment #2) > Attachment 88874 [details] did not pass style-queue: > > Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Tools/ChangeLog', u'Tools/Scripts/prepare-..." exit_code: 1 > > Tools/ChangeLog:8: Line contains tab character. [whitespace/tab] [5] The style-bot knows all. :) 383382 6 89056 george.guo 2011-04-11 12:40:26 -0700 Created attachment 89056 A new patch that follows the style and without tab 383411 7 89056 eric 2011-04-11 13:07:14 -0700 Comment on attachment 89056 A new patch that follows the style and without tab Thank you very much. 383412 8 88874 eric 2011-04-11 13:07:49 -0700 Comment on attachment 88874 A patch for review FYI: webkit-patch upload will automatically obsolete previous patches when uploading new ones. (If you chose to use webkit-patch.) 383732 9 89056 commit-queue 2011-04-11 18:13:33 -0700 Comment on attachment 89056 A new patch that follows the style and without tab Clearing flags on attachment: 89056 Committed r83546: <http://trac.webkit.org/changeset/83546> 383733 10 commit-queue 2011-04-11 18:13:38 -0700 All reviewed patches have been landed. Closing bug. 383743 11 george.guo 2011-04-11 18:27:00 -0700 Thanks Eric, it's good learning for me for the process 88874 2011-04-08 14:15:38 -0700 2011-04-11 13:07:48 -0700 A patch for review 58164.patch text/plain 1276 george.guo SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDgzMzQzKQorKysgVG9vbHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMg KzEsMTQgQEAKKzIwMTEtMDQtMDggIEdlb3JnZSBHdW8gIDxHZW9yZ2UuR3VvQG5va2lhLmNvbT4K KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBwcmVwYXJl LUNoYW5nZUxvZyBzdXBwb3J0IGVtYWlsIGlucHV0IGJ1dCAtaCBkaWQgbm90IHNob3cgdGhlIG9w dGlvbiAKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTU4 MTY0CisKKwlBZGQgZW1haWwgb3B0aW9uIHRvIC1oIHRvIGltcHJvdmUgdGhlIHVzYWJpbGl0eS4g CisKKyAgICAgICAgKiBTY3JpcHRzL3ByZXBhcmUtQ2hhbmdlTG9nOgorCiAyMDExLTA0LTA4ICBB bHBoYSBMYW0gIDxoY2xhbUBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgVW5yZXZpZXdlZCwgcm9s bGluZyBvdXQgcjgzMzM1LgpJbmRleDogVG9vbHMvU2NyaXB0cy9wcmVwYXJlLUNoYW5nZUxvZwo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBUb29scy9TY3JpcHRzL3ByZXBhcmUtQ2hhbmdlTG9nCShyZXZpc2lvbiA4 MzI5MikKKysrIFRvb2xzL1NjcmlwdHMvcHJlcGFyZS1DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkK QEAgLTE0MCw2ICsxNDAsNyBAQCBpZiAoISRwYXJzZU9wdGlvbnNSZXN1bHQgfHwgJHNob3dIZWxw KSB7CiAgICAgcHJpbnQgU1RERVJSICIgIC1vfC0tb3BlbiAgICAgICBPcGVuIENoYW5nZUxvZ3Mg aW4gYW4gZWRpdG9yIHdoZW4gZG9uZVxuIjsKICAgICBwcmludCBTVERFUlIgIiAgLS1bbm8tXXVw ZGF0ZSAgIFVwZGF0ZSBDaGFuZ2VMb2dzIGZyb20gc3ZuIGJlZm9yZSBhZGRpbmcgZW50cnkgKGRl ZmF1bHQ6IHVwZGF0ZSlcbiI7CiAgICAgcHJpbnQgU1RERVJSICIgIC0tW25vLV13cml0ZSAgICBX cml0ZSBDaGFuZ2VMb2dzIHRvIGRpc2sgKG90aGVyd2lzZSBzZW5kIG5ldyBlbnRyaWVzIHRvIHN0 ZG91dCkgKGRlZmF1bHQ6IHdyaXRlKVxuIjsKKyAgICBwcmludCBTVERFUlIgIiAgLS1lbWFpbD0g ICAgICAgIFNwZWNpZnkgdGhlIGVtYWlsIGFkZHJlc3MgdG8gYmUgdXNlZCBpbiB0aGUgcGF0Y2hc biI7CiAgICAgZXhpdCAxOwogfQogCg== 89056 2011-04-11 12:40:26 -0700 2011-04-11 18:13:33 -0700 A new patch that follows the style and without tab 58164-1.patch text/plain 1276 george.guo SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDgzNDc1KQorKysgVG9vbHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMg KzEsMTQgQEAKKzIwMTEtMDQtMTEgIEdlb3JnZSBHdW8gIDxHZW9yZ2UuR3VvQG5va2lhLmNvbT4K KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBwcmVwYXJl LUNoYW5nZUxvZyBzdXBwb3J0IGVtYWlsIGlucHV0IGJ1dCAtaCBkaWQgbm90IHNob3cgdGhlIG9w dGlvbgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTgx NjQKKworICAgICAgICBBZGQgZW1haWwgb3B0aW9uIHRvIC1oIHRvIGltcHJvdmUgdGhlIHVzYWJp bGl0eQorCisgICAgICAgICogU2NyaXB0cy9wcmVwYXJlLUNoYW5nZUxvZzoKKwogMjAxMS0wNC0x MSAgRGlyayBQcmFua2UgIDxkcHJhbmtlQGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdl ZCBieSBUb255IENoYW5nLgpJbmRleDogVG9vbHMvU2NyaXB0cy9wcmVwYXJlLUNoYW5nZUxvZwo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBUb29scy9TY3JpcHRzL3ByZXBhcmUtQ2hhbmdlTG9nCShyZXZpc2lvbiA4 MzQ3MCkKKysrIFRvb2xzL1NjcmlwdHMvcHJlcGFyZS1DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkK QEAgLTE0MCw2ICsxNDAsNyBAQCBpZiAoISRwYXJzZU9wdGlvbnNSZXN1bHQgfHwgJHNob3dIZWxw KSB7CiAgICAgcHJpbnQgU1RERVJSICIgIC1vfC0tb3BlbiAgICAgICBPcGVuIENoYW5nZUxvZ3Mg aW4gYW4gZWRpdG9yIHdoZW4gZG9uZVxuIjsKICAgICBwcmludCBTVERFUlIgIiAgLS1bbm8tXXVw ZGF0ZSAgIFVwZGF0ZSBDaGFuZ2VMb2dzIGZyb20gc3ZuIGJlZm9yZSBhZGRpbmcgZW50cnkgKGRl ZmF1bHQ6IHVwZGF0ZSlcbiI7CiAgICAgcHJpbnQgU1RERVJSICIgIC0tW25vLV13cml0ZSAgICBX cml0ZSBDaGFuZ2VMb2dzIHRvIGRpc2sgKG90aGVyd2lzZSBzZW5kIG5ldyBlbnRyaWVzIHRvIHN0 ZG91dCkgKGRlZmF1bHQ6IHdyaXRlKVxuIjsKKyAgICBwcmludCBTVERFUlIgIiAgLS1lbWFpbD0g ICAgICAgIFNwZWNpZnkgdGhlIGVtYWlsIGFkZHJlc3MgdG8gYmUgdXNlZCBpbiB0aGUgcGF0Y2hc biI7CiAgICAgZXhpdCAxOwogfQogCg==