58160 2011-04-08 13:42:28 -0700 MediaControlTimelineElement is adjusting time 3 times per click 2012-05-24 13:41:08 -0700 1 1 1 Unclassified WebKit Media 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED InRadar P2 Normal --- 1 dglazkov jer.noble arun.patole eric.carlson feature-media-reviews jer.noble webkit.review.bot oldest_to_newest 382522 0 dglazkov 2011-04-08 13:42:28 -0700 The defaultEventHandler of the class does not distinguish between mouseup/down/click, thus setting currentTime thrice on each click. This seems suboptimal. 476809 1 arun.patole 2011-10-02 23:21:09 -0700 (In reply to comment #0) > The defaultEventHandler of the class does not distinguish between mouseup/down/click, thus setting currentTime thrice on each click. This seems suboptimal. just had a look at the code, looks like once currentime is set first time, condition "if (time != mediaElement()->currentTime())" will fail next time as time is already adjusted so won't adjust the time again?? 633078 2 jer.noble 2012-05-24 12:54:16 -0700 (In reply to comment #1) > just had a look at the code, looks like once currentime is set first time, condition "if (time != mediaElement()->currentTime())" will fail next time as time is already adjusted so won't adjust the time again?? Not necessarily. For some media engines, a seek is asynchronous, and the end result of a seek may not be exactly the time requested. Three calls in a row to seek() could definitely occur. Sounds like setCurrentTime() should only occur for mousedown and mousemove events. 633079 3 jer.noble 2012-05-24 12:54:34 -0700 Dimitri, I'll take this one. 633100 4 143874 jer.noble 2012-05-24 13:11:35 -0700 Created attachment 143874 Patch 633103 5 143874 jer.noble 2012-05-24 13:14:18 -0700 Comment on attachment 143874 Patch Nope, this patch breaks dragging the timeline slider. 633116 6 jer.noble 2012-05-24 13:27:31 -0700 Hey, whaddaya know. There's already an "input" message which is fired on input elements during mousedown and mousemove events. 633119 7 jer.noble 2012-05-24 13:28:28 -0700 <rdar://problem/11350416> 633120 8 143879 jer.noble 2012-05-24 13:28:48 -0700 Created attachment 143879 Patch 633161 9 jer.noble 2012-05-24 13:41:08 -0700 Committed r118411: <http://trac.webkit.org/changeset/118411> 143874 2012-05-24 13:11:35 -0700 2012-05-24 13:14:18 -0700 Patch bug-58160-20120524131134.patch text/plain 1854 jer.noble U3VidmVyc2lvbiBSZXZpc2lvbjogMTE4MzgyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYTBjMWYzODQ1ZTE5MDg5 MTcxNzM0YWI4ODMyNzVkMDBmOTA1Nzk1NS4uYWE4NjFhYzg2MWE1NTc0ZThmNTZiN2VlNjI1MzI3 MzVlOTRkNDhhZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEyLTA1LTI0ICBKZXIg Tm9ibGUgIDxqZXIubm9ibGVAYXBwbGUuY29tPgorCisgICAgICAgIE1lZGlhQ29udHJvbFRpbWVs aW5lRWxlbWVudCBpcyBhZGp1c3RpbmcgdGltZSAzIHRpbWVzIHBlciBjbGljaworICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTgxNjAKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBObyBuZXcgdGVzdHM7IHdlIGlu dGVudGlvbmFsbHkgdGhyb3R0bGUgdGltZXVwZGF0ZSBldmVudHMgZm9yIHRoZSBzYW1lCisgICAg ICAgIG1vdmllIHRpbWUsIHNvIHRoZXJlIGlzIG5vIHdheSB0byB3cml0ZSBhIGxheW91dCB0ZXN0 IGZvciB0aGlzIGNhc2UuCisKKyAgICAgICAgT25seSBjYWxsIHNldEN1cnJlbnRUaW1lKCkgb24g bW91c2Vkb3duIG9yIG1vdXNlbW92ZSBldmVudHMuCisKKyAgICAgICAgKiBodG1sL3NoYWRvdy9N ZWRpYUNvbnRyb2xFbGVtZW50cy5jcHA6CisgICAgICAgIChXZWJDb3JlOjpNZWRpYUNvbnRyb2xU aW1lbGluZUVsZW1lbnQ6OmRlZmF1bHRFdmVudEhhbmRsZXIpOgorCiAyMDEyLTA1LTIzICBKZXIg Tm9ibGUgIDxqZXIubm9ibGVAYXBwbGUuY29tPgogCiAgICAgICAgIFJFR1JFU1NJT046IGNvbXBv c2l0aW5nL3ZpZGVvL3ZpZGVvLXBvc3Rlci5odG1sIGZhaWxzIG9uIE1hYwpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYkNvcmUvaHRtbC9zaGFkb3cvTWVkaWFDb250cm9sRWxlbWVudHMuY3BwIGIvU291 cmNlL1dlYkNvcmUvaHRtbC9zaGFkb3cvTWVkaWFDb250cm9sRWxlbWVudHMuY3BwCmluZGV4IGY2 MmNmOWU5ODk5Mzc1ZGYyOGUwM2Q3ZmFiNzdhMDdjMjFhNmJkMGMuLjQ2YTVjMDQwYmEyNzcxZGQz OTJjODFhZTEwNWJmYjYyYTM4N2ZlYzQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2h0bWwv c2hhZG93L01lZGlhQ29udHJvbEVsZW1lbnRzLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9odG1s L3NoYWRvdy9NZWRpYUNvbnRyb2xFbGVtZW50cy5jcHAKQEAgLTg2OSw3ICs4NjksNyBAQCB2b2lk IE1lZGlhQ29udHJvbFRpbWVsaW5lRWxlbWVudDo6ZGVmYXVsdEV2ZW50SGFuZGxlcihFdmVudCog ZXZlbnQpCiAgICAgICAgIHJldHVybjsKIAogICAgIGZsb2F0IHRpbWUgPSBuYXJyb3dQcmVjaXNp b25Ub0Zsb2F0KHZhbHVlKCkudG9Eb3VibGUoKSk7Ci0gICAgaWYgKHRpbWUgIT0gbWVkaWFDb250 cm9sbGVyKCktPmN1cnJlbnRUaW1lKCkpIHsKKyAgICBpZiAodGltZSAhPSBtZWRpYUNvbnRyb2xs ZXIoKS0+Y3VycmVudFRpbWUoKSAmJiAoZXZlbnQtPnR5cGUoKSA9PSBldmVudE5hbWVzKCkubW91 c2Vkb3duRXZlbnQgfHwgZXZlbnQtPnR5cGUoKSA9PSBldmVudE5hbWVzKCkubW91c2Vtb3ZlRXZl bnQpKSB7CiAgICAgICAgIC8vIEZJWE1FOiBUaGlzIGlzIGZpcmVkIDMgdGltZXMgb24gZXZlcnkg Y2xpY2suIFdlIHNob3VsZCBub3QgYmUgZG9pbmcgdGhhdCA8aHR0cDovd2Via2l0Lm9yZy9iLzU4 MTYwPi4KICAgICAgICAgRXhjZXB0aW9uQ29kZSBlYzsKICAgICAgICAgbWVkaWFDb250cm9sbGVy KCktPnNldEN1cnJlbnRUaW1lKHRpbWUsIGVjKTsK 143879 2012-05-24 13:28:48 -0700 2012-05-24 13:37:33 -0700 Patch bug-58160-20120524132847.patch text/plain 1807 jer.noble U3VidmVyc2lvbiBSZXZpc2lvbjogMTE4MzgyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYTBjMWYzODQ1ZTE5MDg5 MTcxNzM0YWI4ODMyNzVkMDBmOTA1Nzk1NS4uYWE4NjFhYzg2MWE1NTc0ZThmNTZiN2VlNjI1MzI3 MzVlOTRkNDhhZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEyLTA1LTI0ICBKZXIg Tm9ibGUgIDxqZXIubm9ibGVAYXBwbGUuY29tPgorCisgICAgICAgIE1lZGlhQ29udHJvbFRpbWVs aW5lRWxlbWVudCBpcyBhZGp1c3RpbmcgdGltZSAzIHRpbWVzIHBlciBjbGljaworICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTgxNjAKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBObyBuZXcgdGVzdHM7IHdlIGlu dGVudGlvbmFsbHkgdGhyb3R0bGUgdGltZXVwZGF0ZSBldmVudHMgZm9yIHRoZSBzYW1lCisgICAg ICAgIG1vdmllIHRpbWUsIHNvIHRoZXJlIGlzIG5vIHdheSB0byB3cml0ZSBhIGxheW91dCB0ZXN0 IGZvciB0aGlzIGNhc2UuCisKKyAgICAgICAgT25seSBjYWxsIHNldEN1cnJlbnRUaW1lKCkgb24g bW91c2Vkb3duIG9yIG1vdXNlbW92ZSBldmVudHMuCisKKyAgICAgICAgKiBodG1sL3NoYWRvdy9N ZWRpYUNvbnRyb2xFbGVtZW50cy5jcHA6CisgICAgICAgIChXZWJDb3JlOjpNZWRpYUNvbnRyb2xU aW1lbGluZUVsZW1lbnQ6OmRlZmF1bHRFdmVudEhhbmRsZXIpOgorCiAyMDEyLTA1LTIzICBKZXIg Tm9ibGUgIDxqZXIubm9ibGVAYXBwbGUuY29tPgogCiAgICAgICAgIFJFR1JFU1NJT046IGNvbXBv c2l0aW5nL3ZpZGVvL3ZpZGVvLXBvc3Rlci5odG1sIGZhaWxzIG9uIE1hYwpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYkNvcmUvaHRtbC9zaGFkb3cvTWVkaWFDb250cm9sRWxlbWVudHMuY3BwIGIvU291 cmNlL1dlYkNvcmUvaHRtbC9zaGFkb3cvTWVkaWFDb250cm9sRWxlbWVudHMuY3BwCmluZGV4IGY2 MmNmOWU5ODk5Mzc1ZGYyOGUwM2Q3ZmFiNzdhMDdjMjFhNmJkMGMuLmI1NmIxZDI2NTQ5ZjFkNDA2 YzhiNGI5ZmRkMWY0MzRiNzZjODYwZWQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2h0bWwv c2hhZG93L01lZGlhQ29udHJvbEVsZW1lbnRzLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9odG1s L3NoYWRvdy9NZWRpYUNvbnRyb2xFbGVtZW50cy5jcHAKQEAgLTg2OSw4ICs4NjksNyBAQCB2b2lk IE1lZGlhQ29udHJvbFRpbWVsaW5lRWxlbWVudDo6ZGVmYXVsdEV2ZW50SGFuZGxlcihFdmVudCog ZXZlbnQpCiAgICAgICAgIHJldHVybjsKIAogICAgIGZsb2F0IHRpbWUgPSBuYXJyb3dQcmVjaXNp b25Ub0Zsb2F0KHZhbHVlKCkudG9Eb3VibGUoKSk7Ci0gICAgaWYgKHRpbWUgIT0gbWVkaWFDb250 cm9sbGVyKCktPmN1cnJlbnRUaW1lKCkpIHsKLSAgICAgICAgLy8gRklYTUU6IFRoaXMgaXMgZmly ZWQgMyB0aW1lcyBvbiBldmVyeSBjbGljay4gV2Ugc2hvdWxkIG5vdCBiZSBkb2luZyB0aGF0IDxo dHRwOi93ZWJraXQub3JnL2IvNTgxNjA+LgorICAgIGlmIChldmVudC0+dHlwZSgpID09IGV2ZW50 TmFtZXMoKS5pbnB1dEV2ZW50ICYmIHRpbWUgIT0gbWVkaWFDb250cm9sbGVyKCktPmN1cnJlbnRU aW1lKCkpIHsKICAgICAgICAgRXhjZXB0aW9uQ29kZSBlYzsKICAgICAgICAgbWVkaWFDb250cm9s bGVyKCktPnNldEN1cnJlbnRUaW1lKHRpbWUsIGVjKTsKICAgICB9Cg==