58151 2011-04-08 12:04:55 -0700 Crash after closing a Webview, in WebKit!WebCore::WindowMessageBroadcaster::SubclassedWndProc 2011-04-08 16:51:41 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) PC Windows Vista RESOLVED FIXED InRadar P2 Normal --- 1 alice.barraclough alice.barraclough webkit.review.bot oldest_to_newest 382443 0 alice.barraclough 2011-04-08 12:04:55 -0700 On windows, after closing a WebKit2 WebView we can crash in WebKit!WebCore::WindowMessageBroadcaster::SubclassedWndProc. This is happening because when WebKit2 WebViews close, we aren't removing that webview from the list of WindowMessageBroadcaster listeners. <rdar://problem/8779099> 382444 1 88855 alice.barraclough 2011-04-08 12:07:25 -0700 Created attachment 88855 patch 382445 2 webkit.review.bot 2011-04-08 12:08:14 -0700 Attachment 88855 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit..." exit_code: 1 Source/WebKit2/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 382447 3 88856 alice.barraclough 2011-04-08 12:11:45 -0700 Created attachment 88856 patch with correct changelog 382474 4 88856 aroben 2011-04-08 12:55:12 -0700 Comment on attachment 88856 patch with correct changelog Is it possible to make a test for this using TestWebKitAPI? If you know the sequence of events that lead to the crash it should be pretty easy to simulate them in TestWebKitAPI. 382655 5 alice.barraclough 2011-04-08 16:50:25 -0700 (In reply to comment #4) I'm unsure if it's possible. The crash wasn't always reproducible even with the application-specific webview that it was happening with. And my guess is that it's not guaranteed that we'll be able to replicate the situational prerequisites for the crash with TestWebKitAPI, especially if i don't know what they are at the moment. 382656 6 alice.barraclough 2011-04-08 16:51:41 -0700 http://trac.webkit.org/changeset/83357 88855 2011-04-08 12:07:25 -0700 2011-04-08 12:11:45 -0700 patch patch-8779099.txt text/plain 1389 alice.barraclough SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDgzMzIwKQorKysgU291cmNlL1dlYktpdDIvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTEtMDQtMDggIEFsaWNlIExp dSAgPGFsaWNlLmxpdUBhcHBsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgTmVlZCBhIHNob3J0IGRlc2NyaXB0aW9uIGFuZCBidWcgVVJMIChP T1BTISkKKworICAgICAgICAqIFVJUHJvY2Vzcy93aW4vV2ViVmlldy5jcHA6CisgICAgICAgIChX ZWJLaXQ6OldlYlZpZXc6OmNsb3NlKToKKwogMjAxMS0wNC0wOCAgTWFydGluIFJvYmluc29uICA8 bXJvYmluc29uQGlnYWxpYS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgWGFuIExvcGV6LgpJ bmRleDogU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL3dpbi9XZWJWaWV3LmNwcAo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3Mvd2luL1dlYlZpZXcuY3BwCShyZXZpc2lvbiA4 MzIyNSkKKysrIFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy93aW4vV2ViVmlldy5jcHAJKHdvcmtp bmcgY29weSkKQEAgLTg4Miw2ICs4ODIsMTUgQEAgdm9pZCBXZWJWaWV3OjpjbG9zZSgpCiB7CiAg ICAgbV91bmRvQ2xpZW50LmluaXRpYWxpemUoMCk7CiAgICAgOjpSZXZva2VEcmFnRHJvcChtX3dp bmRvdyk7CisgICAgaWYgKG1fd2luZG93KSB7CisgICAgICAgIC8vIFdlIGNhbid0IGNoZWNrIElz V2luZG93KG1fd2luZG93KSBoZXJlLCBiZWNhdXNlIHRoYXQgd2lsbCByZXR1cm4gdHJ1ZSBldmVu IHdoaWxlCisgICAgICAgIC8vIHdlJ3JlIGFscmVhZHkgaGFuZGxpbmcgV01fREVTVFJPWS4gU28g d2UgY2hlY2sgIW1faXNCZWluZ0Rlc3Ryb3llZCBpbnN0ZWFkLgorICAgICAgICBpZiAoIW1faXNC ZWluZ0Rlc3Ryb3llZCkKKyAgICAgICAgICAgIERlc3Ryb3lXaW5kb3cobV93aW5kb3cpOworICAg ICAgICAvLyBFaXRoZXIgd2UganVzdCBkZXN0cm95ZWQgbV93aW5kb3csIG9yIGl0J3MgaW4gdGhl IHByb2Nlc3Mgb2YgYmVpbmcgZGVzdHJveWVkLiBFaXRoZXIKKyAgICAgICAgLy8gd2F5LCB3ZSBj bGVhciBpdCBvdXQgdG8gbWFrZSBzdXJlIHdlIGRvbid0IHRyeSB0byB1c2UgaXQgbGF0ZXIuCisg ICAgICAgIG1fd2luZG93ID0gMDsKKyAgICB9CiAgICAgc2V0UGFyZW50V2luZG93KDApOwogICAg IG1fcGFnZS0+Y2xvc2UoKTsKIH0K 88856 2011-04-08 12:11:45 -0700 2011-04-08 12:55:12 -0700 patch with correct changelog patch-8779099.txt text/plain 1859 alice.barraclough SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDgzMzIwKQorKysgU291cmNlL1dlYktpdDIvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTEtMDQtMDggIEFsaWNlIExp dSAgPGFsaWNlLmxpdUBhcHBsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTU4MTUxCisgICAgICAgIENyYXNoIGFmdGVyIGNsb3NpbmcgYSBXZWJ2aWV3LCBpbiBXZWJLaXQh V2ViQ29yZTo6V2luZG93TWVzc2FnZUJyb2FkY2FzdGVyOjpTdWJjbGFzc2VkV25kUHJvYworCisg ICAgICAgICogVUlQcm9jZXNzL3dpbi9XZWJWaWV3LmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2Vi Vmlldzo6Y2xvc2UpOgorICAgICAgICBSZXNvbHZlIGEgZGlmZmVyZW5jZSBiZXR3ZWVuIG9sZCBX ZWJLaXQgV2ViVmlldyBhbmQgV2ViS2l0MiBXZWJWaWV3IGJ5IGRlc3Ryb3lpbmcgYW5kIGNsZWFy aW5nCisgICAgICAgIG91dCBXZWJLaXQyIFdlYlZpZXcncyBIV05EIHdoZW4gY2xvc2luZy4gTm90 IGRvaW5nIHNvIHdhcyBjYXVzaW5nIHRoZSBXZWJWaWV3IHRvIHJlbWFpbiBpbiB0aGUKKyAgICAg ICAgbGlzdCBvZiBXaW5kb3dNZXNzYWdlQnJvYWRjYXN0ZXIgbGlzdGVuZXJzLCBhbmQgYWZ0ZXIg Y2xvc2luZyB0aGUgV2ViVmlldywgV2luZG93TWVzc2FnZUJyb2FkY2FzdGVyCisgICAgICAgIHdv dWxkIG1lc3NhZ2UgYSBkZWFkIFdlYlZpZXcgYW5kIGNyYXNoLgorCiAyMDExLTA0LTA4ICBNYXJ0 aW4gUm9iaW5zb24gIDxtcm9iaW5zb25AaWdhbGlhLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBi eSBYYW4gTG9wZXouCkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3Mvd2luL1dlYlZpZXcu Y3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy93aW4vV2ViVmlldy5j cHAJKHJldmlzaW9uIDgzMjI1KQorKysgU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL3dpbi9XZWJW aWV3LmNwcAkod29ya2luZyBjb3B5KQpAQCAtODgyLDYgKzg4MiwxNSBAQCB2b2lkIFdlYlZpZXc6 OmNsb3NlKCkKIHsKICAgICBtX3VuZG9DbGllbnQuaW5pdGlhbGl6ZSgwKTsKICAgICA6OlJldm9r ZURyYWdEcm9wKG1fd2luZG93KTsKKyAgICBpZiAobV93aW5kb3cpIHsKKyAgICAgICAgLy8gV2Ug Y2FuJ3QgY2hlY2sgSXNXaW5kb3cobV93aW5kb3cpIGhlcmUsIGJlY2F1c2UgdGhhdCB3aWxsIHJl dHVybiB0cnVlIGV2ZW4gd2hpbGUKKyAgICAgICAgLy8gd2UncmUgYWxyZWFkeSBoYW5kbGluZyBX TV9ERVNUUk9ZLiBTbyB3ZSBjaGVjayAhbV9pc0JlaW5nRGVzdHJveWVkIGluc3RlYWQuCisgICAg ICAgIGlmICghbV9pc0JlaW5nRGVzdHJveWVkKQorICAgICAgICAgICAgRGVzdHJveVdpbmRvdyht X3dpbmRvdyk7CisgICAgICAgIC8vIEVpdGhlciB3ZSBqdXN0IGRlc3Ryb3llZCBtX3dpbmRvdywg b3IgaXQncyBpbiB0aGUgcHJvY2VzcyBvZiBiZWluZyBkZXN0cm95ZWQuIEVpdGhlcgorICAgICAg ICAvLyB3YXksIHdlIGNsZWFyIGl0IG91dCB0byBtYWtlIHN1cmUgd2UgZG9uJ3QgdHJ5IHRvIHVz ZSBpdCBsYXRlci4KKyAgICAgICAgbV93aW5kb3cgPSAwOworICAgIH0KICAgICBzZXRQYXJlbnRX aW5kb3coMCk7CiAgICAgbV9wYWdlLT5jbG9zZSgpOwogfQo=