58131 2011-04-08 03:19:11 -0700 Fix compilation with Solaris 10/Sun Studio 12: moving elements in a vector requires source not to be const 2011-04-13 03:07:14 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) PC Other RESOLVED FIXED P2 Normal --- 0 bentaylor.solx86 webkit-unassigned ap commit-queue oldest_to_newest 382119 0 bentaylor.solx86 2011-04-08 03:19:11 -0700 I don't know why the compiler couldn't call src->~T() on a const T *src, but fact is it couldn't. In any case, since move is copying the source and deleting it, formally the argument shouldn't be const anyway. 382153 1 88801 bentaylor.solx86 2011-04-08 04:52:27 -0700 Created attachment 88801 Fixing a compile issue on Solaris 10 with Sun Studio 12 C++, fix a modified src parameter to not be const Patch to fix the compile issue on Solaris 10 with Sun Studio 12, originally created by Thiago Macieria as part of patch11/17 from bug https://bugs.webkit.org/show_bug.cgi?id=24932 382412 2 ap 2011-04-08 11:41:30 -0700 + Fix compile issue on Solaris 10/Sun Studio 12, since the move is copying + the source and deleting it, formally the argument shouldn't be const anyway. This is a questionable explanation. The ability to delete an object via a const pointer is a normal C++ behavior, and playing against C++ is not safe. Wouldn't it be better to do a const_cast when destructing as a workaround? Besides, if src should be non-const, why doesn't the same apply to srcEnd? 384630 3 89328 bentaylor.solx86 2011-04-12 19:38:31 -0700 Created attachment 89328 Updated patch per recommendation of reviewer. This makes it very clear why we fix what we do. This patch is to work around an obscure compiler bug in Sun Studio 12 (fixed in SS12.1 and SS12.2) where the compiler couldn't call src->~T() on a const T *src 384656 4 89328 ap 2011-04-12 21:35:55 -0700 Comment on attachment 89328 Updated patch per recommendation of reviewer. This makes it very clear why we fix what we do. Do you know how long we'll have to support these old versions of the compiler? Why are they still important? 384705 5 89328 commit-queue 2011-04-12 23:45:48 -0700 Comment on attachment 89328 Updated patch per recommendation of reviewer. This makes it very clear why we fix what we do. Clearing flags on attachment: 89328 Committed r83704: <http://trac.webkit.org/changeset/83704> 384706 6 commit-queue 2011-04-12 23:45:54 -0700 All reviewed patches have been landed. Closing bug. 384767 7 bentaylor.solx86 2011-04-13 03:07:14 -0700 (In reply to comment #4) > (From update of attachment 89328 [details]) > Do you know how long we'll have to support these old versions of the compiler? Why are they still important? SS12 is important as it can still build QT/webkit on Solaris 10. SS12.1/12.2 is a new compiler engine, and specificially SS12.2 has bugs that *fail* the compiler with an internal error. Additionally, Even if that bug is fixed, you have to now have a support contract to get the fix. 88801 2011-04-08 04:52:27 -0700 2011-04-12 19:38:31 -0700 Fixing a compile issue on Solaris 10 with Sun Studio 12 C++, fix a modified src parameter to not be const webkit-bug-58131-FixConst-nessOfAManipulatedParameter.diff text/plain 2942 bentaylor.solx86 SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gODMyODEpCisrKyBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAK KzIwMTEtMDQtMDggIEJlbiBUYXlsb3IgIDxiZW50YXlsb3Iuc29seDg2QGdtYWlsLmNvbT4KKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTgxMzEKKworICAgICAgICBGaXggY29tcGls ZSBpc3N1ZSBvbiBTb2xhcmlzIDEwL1N1biBTdHVkaW8gMTIsIHNpbmNlIHRoZSBtb3ZlIGlzIGNv cHlpbmcgCisgICAgICAgIHRoZSBzb3VyY2UgYW5kIGRlbGV0aW5nIGl0LCBmb3JtYWxseSB0aGUg YXJndW1lbnQgc2hvdWxkbid0IGJlIGNvbnN0IGFueXdheS4KKworICAgICAgICAqIHd0Zi9WZWN0 b3IuaDoKKyAgICAgICAgKFdURjo6VmVjdG9yVHlwZU9wZXJhdGlvbnM6Om1vdmUpOgorICAgICAg ICAoV1RGOjpWZWN0b3JUeXBlT3BlcmF0aW9uczo6bW92ZU92ZXJsYXBwaW5nKToKKwogMjAxMS0w NC0wNyAgR2VvZmZyZXkgR2FyZW4gIDxnZ2FyZW5AYXBwbGUuY29tPgogCiAgICAgICAgIFJldmll d2VkIGJ5IE1hY2llaiBTdGFjaG93aWFrLgpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL3d0 Zi9WZWN0b3IuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvd3RmL1ZlY3Rv ci5oCShyZXZpc2lvbiA4Mjc5MikKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS93dGYvVmVjdG9y LmgJKHdvcmtpbmcgY29weSkKQEAgLTEyNSw3ICsxMjUsNyBAQCBuYW1lc3BhY2UgV1RGIHsKICAg ICB0ZW1wbGF0ZTx0eXBlbmFtZSBUPgogICAgIHN0cnVjdCBWZWN0b3JNb3ZlcjxmYWxzZSwgVD4K ICAgICB7Ci0gICAgICAgIHN0YXRpYyB2b2lkIG1vdmUoY29uc3QgVCogc3JjLCBjb25zdCBUKiBz cmNFbmQsIFQqIGRzdCkKKyAgICAgICAgc3RhdGljIHZvaWQgbW92ZShUKiBzcmMsIGNvbnN0IFQq IHNyY0VuZCwgVCogZHN0KQogICAgICAgICB7CiAgICAgICAgICAgICB3aGlsZSAoc3JjICE9IHNy Y0VuZCkgewogICAgICAgICAgICAgICAgIG5ldyAoZHN0KSBUKCpzcmMpOwpAQCAtMTM0LDcgKzEz NCw3IEBAIG5hbWVzcGFjZSBXVEYgewogICAgICAgICAgICAgICAgICsrc3JjOwogICAgICAgICAg ICAgfQogICAgICAgICB9Ci0gICAgICAgIHN0YXRpYyB2b2lkIG1vdmVPdmVybGFwcGluZyhjb25z dCBUKiBzcmMsIGNvbnN0IFQqIHNyY0VuZCwgVCogZHN0KQorICAgICAgICBzdGF0aWMgdm9pZCBt b3ZlT3ZlcmxhcHBpbmcoVCogc3JjLCBjb25zdCBUKiBzcmNFbmQsIFQqIGRzdCkKICAgICAgICAg ewogICAgICAgICAgICAgaWYgKHNyYyA+IGRzdCkKICAgICAgICAgICAgICAgICBtb3ZlKHNyYywg c3JjRW5kLCBkc3QpOwpAQCAtMTUzLDExICsxNTMsMTEgQEAgbmFtZXNwYWNlIFdURiB7CiAgICAg dGVtcGxhdGU8dHlwZW5hbWUgVD4KICAgICBzdHJ1Y3QgVmVjdG9yTW92ZXI8dHJ1ZSwgVD4KICAg ICB7Ci0gICAgICAgIHN0YXRpYyB2b2lkIG1vdmUoY29uc3QgVCogc3JjLCBjb25zdCBUKiBzcmNF bmQsIFQqIGRzdCkgCisgICAgICAgIHN0YXRpYyB2b2lkIG1vdmUoVCogc3JjLCBjb25zdCBUKiBz cmNFbmQsIFQqIGRzdCkgCiAgICAgICAgIHsKICAgICAgICAgICAgIG1lbWNweShkc3QsIHNyYywg cmVpbnRlcnByZXRfY2FzdDxjb25zdCBjaGFyKj4oc3JjRW5kKSAtIHJlaW50ZXJwcmV0X2Nhc3Q8 Y29uc3QgY2hhcio+KHNyYykpOwogICAgICAgICB9Ci0gICAgICAgIHN0YXRpYyB2b2lkIG1vdmVP dmVybGFwcGluZyhjb25zdCBUKiBzcmMsIGNvbnN0IFQqIHNyY0VuZCwgVCogZHN0KSAKKyAgICAg ICAgc3RhdGljIHZvaWQgbW92ZU92ZXJsYXBwaW5nKFQqIHNyYywgY29uc3QgVCogc3JjRW5kLCBU KiBkc3QpIAogICAgICAgICB7CiAgICAgICAgICAgICBtZW1tb3ZlKGRzdCwgc3JjLCByZWludGVy cHJldF9jYXN0PGNvbnN0IGNoYXIqPihzcmNFbmQpIC0gcmVpbnRlcnByZXRfY2FzdDxjb25zdCBj aGFyKj4oc3JjKSk7CiAgICAgICAgIH0KQEAgLTI1MCwxMiArMjUwLDEyIEBAIG5hbWVzcGFjZSBX VEYgewogICAgICAgICAgICAgVmVjdG9ySW5pdGlhbGl6ZXI8VmVjdG9yVHJhaXRzPFQ+OjpuZWVk c0luaXRpYWxpemF0aW9uLCBWZWN0b3JUcmFpdHM8VD46OmNhbkluaXRpYWxpemVXaXRoTWVtc2V0 LCBUPjo6aW5pdGlhbGl6ZShiZWdpbiwgZW5kKTsKICAgICAgICAgfQogCi0gICAgICAgIHN0YXRp YyB2b2lkIG1vdmUoY29uc3QgVCogc3JjLCBjb25zdCBUKiBzcmNFbmQsIFQqIGRzdCkKKyAgICAg ICAgc3RhdGljIHZvaWQgbW92ZShUKiBzcmMsIGNvbnN0IFQqIHNyY0VuZCwgVCogZHN0KQogICAg ICAgICB7CiAgICAgICAgICAgICBWZWN0b3JNb3ZlcjxWZWN0b3JUcmFpdHM8VD46OmNhbk1vdmVX aXRoTWVtY3B5LCBUPjo6bW92ZShzcmMsIHNyY0VuZCwgZHN0KTsKICAgICAgICAgfQogCi0gICAg ICAgIHN0YXRpYyB2b2lkIG1vdmVPdmVybGFwcGluZyhjb25zdCBUKiBzcmMsIGNvbnN0IFQqIHNy Y0VuZCwgVCogZHN0KQorICAgICAgICBzdGF0aWMgdm9pZCBtb3ZlT3ZlcmxhcHBpbmcoVCogc3Jj LCBjb25zdCBUKiBzcmNFbmQsIFQqIGRzdCkKICAgICAgICAgewogICAgICAgICAgICAgVmVjdG9y TW92ZXI8VmVjdG9yVHJhaXRzPFQ+OjpjYW5Nb3ZlV2l0aE1lbWNweSwgVD46Om1vdmVPdmVybGFw cGluZyhzcmMsIHNyY0VuZCwgZHN0KTsKICAgICAgICAgfQo= 89328 2011-04-12 19:38:31 -0700 2011-04-12 23:45:48 -0700 Updated patch per recommendation of reviewer. This makes it very clear why we fix what we do. webkit-bug-58131-Workaround-SS12-compiler-bug.diff text/plain 1210 bentaylor.solx86 SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gODM2ODIpCisrKyBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAK KzIwMTEtMDQtMTIgIEJlbiBUYXlsb3IgIDxiZW50YXlsb3Iuc29seDg2QGdtYWlsLmNvbT4KKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTgxMzEKKworICAgICAgICBQcm92aWRlIGEg d29ya2Fyb3VuZCBmb3IgYW4gb2JzY3VyZSBTdHVkaW8gMTIgY29tcGlsZXIgYnVnLCB3aGljaAor ICAgICAgICBjb3VsZG4ndCBjYWxsIHNyYy0+flQoKSBvbiBhIGNvbnN0IFQgKnNyYy4KKworICAg ICAgICAqIHd0Zi9WZWN0b3IuaDoKKwogMjAxMS0wNC0xMiAgR2F2aW4gQmFycmFjbG91Z2ggIDxi YXJyYWNsb3VnaEBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgT2xpdmVyIEh1bnQu CkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvd3RmL1ZlY3Rvci5oCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS93dGYvVmVjdG9yLmgJKHJldmlzaW9uIDgzNjgyKQorKysg U291cmNlL0phdmFTY3JpcHRDb3JlL3d0Zi9WZWN0b3IuaAkod29ya2luZyBjb3B5KQpAQCAtMTI5 LDcgKzEyOSwxMSBAQCBuYW1lc3BhY2UgV1RGIHsKICAgICAgICAgewogICAgICAgICAgICAgd2hp bGUgKHNyYyAhPSBzcmNFbmQpIHsKICAgICAgICAgICAgICAgICBuZXcgKGRzdCkgVCgqc3JjKTsK KyNpZiBDT01QSUxFUihTVU5DQykgJiYgX19TVU5QUk9fQ0MgPD0gMHg1OTAKKyAgICAgICAgICAg ICAgICBjb25zdF9jYXN0PFQqPihzcmMpLT5+VCgpOyAvLyBXb3JrIGFyb3VuZCBvYnNjdXJlIFN1 bkNDIDEyIGNvbXBpbGVyIGJ1Zy4KKyNlbHNlCiAgICAgICAgICAgICAgICAgc3JjLT5+VCgpOwor I2VuZGlmCiAgICAgICAgICAgICAgICAgKytkc3Q7CiAgICAgICAgICAgICAgICAgKytzcmM7CiAg ICAgICAgICAgICB9Cg==