58119 2011-04-08 00:09:01 -0700 [GTK] layoutTestController.shadowRoot should return undefined if its argument is not an element 2011-04-08 03:21:00 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 0 dominicc webkit-unassigned abarth commit-queue eric webkit.review.bot oldest_to_newest 382043 0 dominicc 2011-04-08 00:09:01 -0700 For consistency with other ports' DRT, layoutTestController.shadowRoot should return undefined, not null, if its argument is not an element. 382044 1 88776 dominicc 2011-04-08 00:11:10 -0700 Created attachment 88776 Patch 382092 2 commit-queue 2011-04-08 02:24:03 -0700 The commit-queue encountered the following flaky tests while processing attachment 88776: http/tests/inspector/console-xhr-logging.html bug 58125 (authors: caseq@chromium.org, darin@apple.com, loislo@chromium.org, and pfeldman@chromium.org) The commit-queue is continuing to process your patch. 382093 3 88776 commit-queue 2011-04-08 02:26:18 -0700 Comment on attachment 88776 Patch Clearing flags on attachment: 88776 Committed r83272: <http://trac.webkit.org/changeset/83272> 382094 4 commit-queue 2011-04-08 02:26:24 -0700 All reviewed patches have been landed. Closing bug. 382121 5 webkit.review.bot 2011-04-08 03:21:00 -0700 http://trac.webkit.org/changeset/83272 might have broken SnowLeopard Intel Release (Tests) The following tests are not passing: http/tests/inspector/resource-har-conversion.html http/tests/inspector/resource-parameters.html 88776 2011-04-08 00:11:10 -0700 2011-04-08 02:26:18 -0700 Patch bug-58119-20110408001109.patch text/plain 1476 dominicc U3VidmVyc2lvbiBSZXZpc2lvbjogODMyNTYKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZ3Rr L0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvZ3RrL0NoYW5nZUxvZwppbmRleCA0ZWYzNDg2MzU2 NGE4NzkyNGEzODZjOTcwMWI5M2ZiOTFmNjI5OTQxLi43YzFkNTYxMWU1OGY4ODRjNmYxZmRmYzk4 ZTVmOWJjZmJmZTc5MmQ1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2d0ay9DaGFuZ2VMb2cK KysrIGIvU291cmNlL1dlYktpdC9ndGsvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTEt MDQtMDggIERvbWluaWMgQ29vbmV5ICA8ZG9taW5pY2NAZ29vZ2xlLmNvbT4KKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBsYXlvdXRUZXN0Q29udHJvbGxl ci5zaGFkb3dSb290IHNob3VsZCByZXR1cm4gdW5kZWZpbmVkIGlmIGl0cworICAgICAgICBhcmd1 bWVudCBpcyBub3QgYW4gZWxlbWVudC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTU4MTE5CisKKyAgICAgICAgKiBXZWJDb3JlU3VwcG9ydC9EdW1wUmVu ZGVyVHJlZVN1cHBvcnRHdGsuY3BwOgorICAgICAgICAoRHVtcFJlbmRlclRyZWVTdXBwb3J0R3Rr OjpzaGFkb3dSb290KToKKwogMjAxMS0wNC0wNiAgR3VzdGF2byBOb3JvbmhhIFNpbHZhICA8Z25z QGdub21lLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBNYXJ0aW4gUm9iaW5zb24uCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViS2l0L2d0ay9XZWJDb3JlU3VwcG9ydC9EdW1wUmVuZGVyVHJlZVN1 cHBvcnRHdGsuY3BwIGIvU291cmNlL1dlYktpdC9ndGsvV2ViQ29yZVN1cHBvcnQvRHVtcFJlbmRl clRyZWVTdXBwb3J0R3RrLmNwcAppbmRleCA4MTc0OWVjMTlkOTMwNzJkMzNjMDBmNWE4ZTU1ZjNl MDRjMTM4NDc1Li45MzI4MGIyZmI0NmY3NGZhYzcyNjFhMzExZTUwNjI4MjcyOWM0ZWIzIDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2d0ay9XZWJDb3JlU3VwcG9ydC9EdW1wUmVuZGVyVHJlZVN1 cHBvcnRHdGsuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvZ3RrL1dlYkNvcmVTdXBwb3J0L0R1bXBS ZW5kZXJUcmVlU3VwcG9ydEd0ay5jcHAKQEAgLTY0Myw3ICs2NDMsNyBAQCBKU1ZhbHVlUmVmIER1 bXBSZW5kZXJUcmVlU3VwcG9ydEd0azo6c2hhZG93Um9vdChKU0NvbnRleHRSZWYgY29udGV4dCwg SlNWYWx1ZVJlZgogICAgIEpTQzo6RXhlY1N0YXRlKiBleGVjID0gdG9KUyhjb250ZXh0KTsKICAg ICBFbGVtZW50KiBlbGVtZW50ID0gdG9FbGVtZW50KHRvSlMoZXhlYywgdmFsdWUpKTsKICAgICBp ZiAoIWVsZW1lbnQpCi0gICAgICByZXR1cm4gSlNWYWx1ZU1ha2VOdWxsKGNvbnRleHQpOworICAg ICAgICByZXR1cm4gSlNWYWx1ZU1ha2VVbmRlZmluZWQoY29udGV4dCk7CiAKICAgICByZXR1cm4g dG9SZWYoZXhlYywgdG9KUyhleGVjLCBlbGVtZW50LT5zaGFkb3dSb290KCkpKTsKIH0K