58117 2011-04-07 23:18:43 -0700 Incoming source should be preload scanned when the parser is blocked 2011-04-12 11:30:29 -0700 1 1 1 Unclassified WebKit Page Loading 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 58352 1 koivisto webkit-unassigned abarth eric simonjam tonyg webkit.review.bot oldest_to_newest 382021 0 koivisto 2011-04-07 23:18:43 -0700 Currently we append to the scanner but don't actually scan. 382062 1 88781 koivisto 2011-04-08 00:46:14 -0700 Created attachment 88781 patch 382064 2 88781 abarth 2011-04-08 00:59:38 -0700 Comment on attachment 88781 patch View in context: https://bugs.webkit.org/attachment.cgi?id=88781&action=review > LayoutTests/ChangeLog:-9650 > ->>>>>>> .r82178 This change looks suspicious. :) > LayoutTests/http/tests/loading/preload-append-scan.php:18 > +usleep(200000); Does this test really take 20 seconds to run? 382065 3 abarth 2011-04-08 01:00:11 -0700 tonyg, would you be willing to review this patch? 382069 4 koivisto 2011-04-08 01:14:40 -0700 (In reply to comment #2) > > +usleep(200000); > > Does this test really take 20 seconds to run? 200ms 382070 5 abarth 2011-04-08 01:15:28 -0700 > 200ms I'm really too tired to be commenting in bugs. :) 382270 6 88781 tonyg 2011-04-08 09:04:05 -0700 Comment on attachment 88781 patch View in context: https://bugs.webkit.org/attachment.cgi?id=88781&action=review This looks good, but we are starting to get a lot of entry points for scanning. I'm wondering if we shouldn't fix bug 57376, then always kick off the preload scanner first thing in insert() and append() (and nowhere else). > LayoutTests/http/tests/resources/slow-script.pl:1 > +#!/usr/bin/perl -w Is it possible to avoid adding a new resource and instead reuse misc/resources/script-slow1.pl? 382433 7 koivisto 2011-04-08 11:57:32 -0700 http://trac.webkit.org/changeset/83321 382464 8 webkit.review.bot 2011-04-08 12:47:29 -0700 http://trac.webkit.org/changeset/83321 might have broken Qt Linux Release The following tests are not passing: http/tests/loading/preload-append-scan.php 88781 2011-04-08 00:46:14 -0700 2011-04-08 09:04:05 -0700 patch preload-append-blocked.patch text/plain 5004 koivisto SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDgzMjY2KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTEtMDQtMDggIEFudHRpIEtv aXZpc3RvICA8YW50dGlAYXBwbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIEluY29taW5nIHNvdXJjZSBzaG91bGQgYmUgcHJlbG9hZCBzY2Fu bmVkIHdoZW4gdGhlIHBhcnNlciBpcyBibG9ja2VkIAorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTgxMTcKKworICAgICAgICBTY2FuIHRoZSBhcHBlbmRl ZCBzb3VyY2UgaWYgcGFyc2VyIGlzIGJsb2NrZWQuCisKKyAgICAgICAgVGVzdDogaHR0cC90ZXN0 cy9sb2FkaW5nL3ByZWxvYWQtYXBwZW5kLXNjYW4ucGhwCisKKyAgICAgICAgKiBodG1sL3BhcnNl ci9IVE1MRG9jdW1lbnRQYXJzZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6SFRNTERvY3VtZW50 UGFyc2VyOjphcHBlbmQpOgorCiAyMDExLTA0LTA4ICBBZGFtIEJhcnRoICA8YWJhcnRoQHdlYmtp dC5vcmc+CiAKICAgICAgICAgQXR0ZW1wdCB0byBmaXggdGhlIFF0IGJ1aWxkLgpJbmRleDogU291 cmNlL1dlYkNvcmUvaHRtbC9wYXJzZXIvSFRNTERvY3VtZW50UGFyc2VyLmNwcAo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBTb3VyY2UvV2ViQ29yZS9odG1sL3BhcnNlci9IVE1MRG9jdW1lbnRQYXJzZXIuY3BwCShy ZXZpc2lvbiA4MzAxNikKKysrIFNvdXJjZS9XZWJDb3JlL2h0bWwvcGFyc2VyL0hUTUxEb2N1bWVu dFBhcnNlci5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTM0NSw4ICszNDUsMTEgQEAgdm9pZCBIVE1M RG9jdW1lbnRQYXJzZXI6OmFwcGVuZChjb25zdCBTZQogICAgIFJlZlB0cjxIVE1MRG9jdW1lbnRQ YXJzZXI+IHByb3RlY3QodGhpcyk7CiAKICAgICBtX2lucHV0LmFwcGVuZFRvRW5kKHNvdXJjZSk7 Ci0gICAgaWYgKG1fcHJlbG9hZFNjYW5uZXIpCisgICAgaWYgKG1fcHJlbG9hZFNjYW5uZXIpIHsK ICAgICAgICAgbV9wcmVsb2FkU2Nhbm5lci0+YXBwZW5kVG9FbmQoc291cmNlKTsKKyAgICAgICAg aWYgKG1fdHJlZUJ1aWxkZXItPmlzUGF1c2VkKCkpCisgICAgICAgICAgICBtX3ByZWxvYWRTY2Fu bmVyLT5zY2FuKCk7CisgICAgfQogCiAgICAgaWYgKGluUHVtcFNlc3Npb24oKSkgewogICAgICAg ICAvLyBXZSd2ZSBnb3R0ZW4gZGF0YSBvZmYgdGhlIG5ldHdvcmsgaW4gYSBuZXN0ZWQgd3JpdGUu CkluZGV4OiBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMv Q2hhbmdlTG9nCShyZXZpc2lvbiA4MzI2NikKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29y a2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBACisyMDExLTA0LTA4ICBBbnR0aSBLb2l2aXN0byAg PGFudHRpQGFwcGxlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBJbmNvbWluZyBzb3VyY2Ugc2hvdWxkIGJlIHByZWxvYWQgc2Nhbm5lZCB3aGVu IHRoZSBwYXJzZXIgaXMgYmxvY2tlZCAKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTU4MTE3CisKKyAgICAgICAgKiBodHRwL3Rlc3RzL2xvYWRpbmcvcHJl bG9hZC1hcHBlbmQtc2Nhbi1leHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAqIGh0dHAvdGVz dHMvbG9hZGluZy9wcmVsb2FkLWFwcGVuZC1zY2FuLnBocDogQWRkZWQuCisgICAgICAgICogaHR0 cC90ZXN0cy9yZXNvdXJjZXMvc2xvdy1zY3JpcHQucGw6IEFkZGVkLgorCiAyMDExLTA0LTA4ICBL ZW50IFRhbXVyYSAgPHRrZW50QGNocm9taXVtLm9yZz4KIAogICAgICAgICBbQ2hyb21pdW1dIFVw ZGF0ZSBleHBlY3RhdGlvbnMgZm9yIHI4Mjg5OSBhbmQgcjgzMjUzLgpAQCAtOTY0Nyw3ICs5NjU4 LDYgQEAKICAgICAgICAgKiBwbGF0Zm9ybS9tYWMvZmFzdC9yZXBhaW50L2xheW91dC1zdGF0ZS1z Y3JvbGxvZmZzZXQzLWV4cGVjdGVkLnR4dDoKICAgICAgICAgKiBwbGF0Zm9ybS9tYWMvdGFibGVz L21vemlsbGEvYnVncy9idWc1MTE0MC1leHBlY3RlZC50eHQ6CiAKLT4+Pj4+Pj4gLnI4MjE3OAog MjAxMS0wMy0yNSAgR2VvZmZyZXkgR2FyZW4gIDxnZ2FyZW5AYXBwbGUuY29tPgogCiAgICAgICAg IFJldmlld2VkIGJ5IE9saXZlciBIdW50LgpJbmRleDogTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9s b2FkaW5nL3ByZWxvYWQtYXBwZW5kLXNjYW4tZXhwZWN0ZWQudHh0Cj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExh eW91dFRlc3RzL2h0dHAvdGVzdHMvbG9hZGluZy9wcmVsb2FkLWFwcGVuZC1zY2FuLWV4cGVjdGVk LnR4dAkocmV2aXNpb24gMCkKKysrIExheW91dFRlc3RzL2h0dHAvdGVzdHMvbG9hZGluZy9wcmVs b2FkLWFwcGVuZC1zY2FuLWV4cGVjdGVkLnR4dAkocmV2aXNpb24gMCkKQEAgLTAsMCArMSwxMSBA QAorbWFpbiBmcmFtZSAtIGRpZFN0YXJ0UHJvdmlzaW9uYWxMb2FkRm9yRnJhbWUKK21haW4gZnJh bWUgLSBkaWRDb21taXRMb2FkRm9yRnJhbWUKK3Nsb3ctc2NyaXB0LnBsIGhhcyBNSU1FIHR5cGUg YXBwbGljYXRpb24vamF2YXNjcmlwdAorbWFpbiBmcmFtZSAtIGRpZEZpbmlzaERvY3VtZW50TG9h ZEZvckZyYW1lCittYWluIGZyYW1lIC0gZGlkSGFuZGxlT25sb2FkRXZlbnRzRm9yRnJhbWUKK3By ZWxvYWQtdGVzdC5qcGcgaGFzIE1JTUUgdHlwZSBpbWFnZS9qcGVnCittYWluIGZyYW1lIC0gZGlk RmluaXNoTG9hZEZvckZyYW1lCisKK1RoaXMgdGVzdCBuZWVkcyB0byBiZSBydW4gaW4gRFJULiBQ cmVsb2FkIHNjYW5uZXIgc2hvdWxkIHNlZSB0aGUgaW1hZ2UgcmVzb3VyY2UuCis8aW1nIHNyYz0i cmVzb3VyY2VzL3ByZWxvYWQtdGVzdC5qcGciPgorCkluZGV4OiBMYXlvdXRUZXN0cy9odHRwL3Rl c3RzL2xvYWRpbmcvcHJlbG9hZC1hcHBlbmQtc2Nhbi5waHAKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0 VGVzdHMvaHR0cC90ZXN0cy9sb2FkaW5nL3ByZWxvYWQtYXBwZW5kLXNjYW4ucGhwCShyZXZpc2lv biAwKQorKysgTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9sb2FkaW5nL3ByZWxvYWQtYXBwZW5kLXNj YW4ucGhwCShyZXZpc2lvbiAwKQpAQCAtMCwwICsxLDI0IEBACis8PworaGVhZGVyKCJDb250ZW50 LVR5cGU6IHRleHQvaHRtbDsgY2hhcnNldD11dGYtOCIpOworPz4KKzwhLS0gPD9waHAKKyMgU3Bh bSBhIGJ1bmNoIG9mIEFzIHRvIG1ha2Ugc3VyZSB3ZSBibG93IHBhc3QgYW55IGJ1ZmZlcnMuCitw cmludCBzdHJfcmVwZWF0KCJBIiwgMjA0OCk7Cis/PiAtLT4KKzxzY3JpcHQ+CitpZiAod2luZG93 LmxheW91dFRlc3RDb250cm9sbGVyKSB7CisgICAgbGF5b3V0VGVzdENvbnRyb2xsZXIuZHVtcEFz VGV4dCgpOworICAgIGxheW91dFRlc3RDb250cm9sbGVyLmR1bXBSZXNvdXJjZVJlc3BvbnNlTUlN RVR5cGVzKCk7Cit9CitmdW5jdGlvbiBkZWJ1Zyh4KSB7fQorPC9zY3JpcHQ+Cis8c2NyaXB0IHNy Yz0iaHR0cDovLzEyNy4wLjAuMTo4MDAwL3Jlc291cmNlcy9zbG93LXNjcmlwdC5wbD9kZWxheT0x MDAwIj48L3NjcmlwdD4KKzw/cGhwCitmbHVzaCgpOwordXNsZWVwKDIwMDAwMCk7Cis/PgorPHNj cmlwdD4KK2RvY3VtZW50LndyaXRlKCI8cGxhaW50ZXh0PiIpOworPC9zY3JpcHQ+CitUaGlzIHRl c3QgbmVlZHMgdG8gYmUgcnVuIGluIERSVC4gUHJlbG9hZCBzY2FubmVyIHNob3VsZCBzZWUgdGhl IGltYWdlIHJlc291cmNlLgorPGltZyBzcmM9InJlc291cmNlcy9wcmVsb2FkLXRlc3QuanBnIj4K SW5kZXg6IExheW91dFRlc3RzL2h0dHAvdGVzdHMvcmVzb3VyY2VzL3Nsb3ctc2NyaXB0LnBsCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIExheW91dFRlc3RzL2h0dHAvdGVzdHMvcmVzb3VyY2VzL3Nsb3ctc2NyaXB0 LnBsCShyZXZpc2lvbiAwKQorKysgTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9yZXNvdXJjZXMvc2xv dy1zY3JpcHQucGwJKHJldmlzaW9uIDApCkBAIC0wLDAgKzEsMjMgQEAKKyMhL3Vzci9iaW4vcGVy bCAtdworCit1c2Ugc3RyaWN0OwordXNlIENHSTsKK3VzZSBUaW1lOjpIaVJlcyBxdyhzbGVlcCk7 CisKK215ICRjZ2kgPSBuZXcgQ0dJOworbXkgJGRlbGF5ID0gJGNnaS0+cGFyYW0oJ2RlbGF5Jyk7 CiskZGVsYXkgPSA1MDAwIHVubGVzcyAkZGVsYXk7CisKKyMgZmx1c2ggdGhlIGJ1ZmZlcnMgYWZ0 ZXIgZWFjaCBwcmludAorc2VsZWN0IChTVERPVVQpOworJHwgPSAxOworCitwcmludCAiQ29udGVu dC1UeXBlOiBhcHBsaWNhdGlvbi9qYXZhc2NyaXB0XG4iOworcHJpbnQgIkV4cGlyZXM6IFRodSwg MDEgRGVjIDIwMDMgMTY6MDA6MDAgR01UXG4iOworcHJpbnQgIkNhY2hlLUNvbnRyb2w6IG5vLXN0 b3JlLCBuby1jYWNoZSwgbXVzdC1yZXZhbGlkYXRlXG4iOworcHJpbnQgIlByYWdtYTogbm8tY2Fj aGVcbiI7CitwcmludCAiXG4iOworCitzbGVlcCAkZGVsYXkgLyAxMDAwOworCisKClByb3BlcnR5 IGNoYW5nZXMgb246IExheW91dFRlc3RzL2h0dHAvdGVzdHMvcmVzb3VyY2VzL3Nsb3ctc2NyaXB0 LnBsCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX18KQWRkZWQ6IHN2bjpleGVjdXRhYmxlCiAgICsgKgoK