58110 2011-04-07 18:24:28 -0700 [Chromium] Remove unneeded usage of V8::Lockers in IDB tests. 2011-04-08 13:11:23 -0700 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 dimich webkit-unassigned aa abarth bulach oldest_to_newest 381917 0 dimich 2011-04-07 18:24:28 -0700 Since webkit_unit_tests are not running v8 on multiple threads, there is no need to use v8::Locker class. The problem with using it once is that every other test that runs late in the same process has to acquire a v8 lock too. Tests normally do not do that so they fail, especially on randomized runs. This will make the patch in bug 58096 not needed. 381921 1 88751 dimich 2011-04-07 18:31:13 -0700 Created attachment 88751 Patch. 382494 2 dimich 2011-04-08 13:11:23 -0700 Landed: http://trac.webkit.org/changeset/83331 88751 2011-04-07 18:31:13 -0700 2011-04-07 21:26:54 -0700 Patch. patch.txt text/plain 1273 dimich ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nIGIvU291cmNlL1dl YktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKaW5kZXggOWJkOTUzNC4uNGYxMDI2ZCAxMDA2NDQKLS0t IGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9j aHJvbWl1bS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxMS0wNC0wNyAgRG1pdHJ5IFRp dG92ICA8ZGltaWNoQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBbQ2hyb21pdW1dIFJlbW92ZSB1bm5lZWRlZCB1c2FnZSBvZiBW ODo6TG9ja2VycyBpbiBJREIgdGVzdHMuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD01ODExMAorICAgICAgICBTaW5jZSB0aGV5IGFyZSBzaW1wbGUgb25l LXRocmVhZCB0ZXN0cy4KKyAgICAgICAgVGhpcyBjb2RlIHBhcmFsbGVscyB0aGUgY29kZSBpbiBD aHJvbWl1bSdzIGlkYiBiaW5kaW5ncyB0aGF0IHVzZXMgdjggTG9ja2VycyBpbiB1dGlsaXR5IHBy b2Nlc3MsCisgICAgICAgIHdoaWNoIGlzIGVxdWFsbHkgbm90IG5lZWRlZCBzaW5jZSB0aGVyZSBp cyBvbmx5IG9uZSB0aHJlYWQgcnVubmluZyB2OCBpbiB0aGF0IHByb2Nlc3MuCisKKyAgICAgICAg KiB0ZXN0cy9JREJCaW5kaW5nVXRpbGl0aWVzVGVzdC5jcHA6CisKIDIwMTEtMDQtMDcgIEFuZHJl dyBTY2hlcmt1cyAgPHNjaGVya3VzQGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZlcnQgRU5B QkxFX1RSQUNLIHBhdGNoIGR1ZSB0byBjb21waWxlIGZhaWx1cmVzLgpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYktpdC9jaHJvbWl1bS90ZXN0cy9JREJCaW5kaW5nVXRpbGl0aWVzVGVzdC5jcHAgYi9T b3VyY2UvV2ViS2l0L2Nocm9taXVtL3Rlc3RzL0lEQkJpbmRpbmdVdGlsaXRpZXNUZXN0LmNwcApp bmRleCAwNDU0ZWE5Li5hYzQyODJiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVt L3Rlc3RzL0lEQkJpbmRpbmdVdGlsaXRpZXNUZXN0LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL3Rlc3RzL0lEQkJpbmRpbmdVdGlsaXRpZXNUZXN0LmNwcApAQCAtNTMsNyArNTMsNiBA QCBwdWJsaWM6CiAgICAgfQogCiBwcml2YXRlOgotICAgIHY4OjpMb2NrZXIgbV9sb2NrZXI7CiAg ICAgdjg6OkhhbmRsZVNjb3BlIG1fc2NvcGU7CiAgICAgdjg6OlBlcnNpc3RlbnQ8djg6OkNvbnRl eHQ+IG1fY29udGV4dDsKIH07Cg==