58104 2011-04-07 17:48:37 -0700 [Qt] Don't link against fontconfig or X11 if embedded 2011-04-09 11:04:02 -0700 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) Other Linux RESOLVED FIXED Qt, QtTriaged P3 Normal --- 0 kamaji webkit-unassigned abecsi benjamin commit-queue kbalazs laszlo.gombos ossy yael oldest_to_newest 381886 0 kamaji 2011-04-07 17:48:37 -0700 Don't link against fontconfig or x11 environments if in CONFIG += embedded environments. These environments do not have fontconfig nor x11. 382265 1 88828 kamaji 2011-04-08 09:02:27 -0700 Created attachment 88828 Patch 382472 2 88828 laszlo.gombos 2011-04-08 12:53:26 -0700 Comment on attachment 88828 Patch r=me. 382683 3 88828 commit-queue 2011-04-08 17:59:00 -0700 Comment on attachment 88828 Patch Rejecting attachment 88828 from commit-queue. Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=cr-jail-3', 'land-a..." exit_code: 2 Last 500 characters of output: m/tests/WebFrameTest.cpp M Source/WebKit/chromium/WebKit.gyp M Source/WebKit/chromium/ChangeLog M Source/WebKit/chromium/src/WebFrameImpl.cpp M Source/WebKit/chromium/WebKit.gypi M Source/WebKit/chromium/public/WebFrame.h r83366 = cb515feb73a489b0e3d7d0469739e4dadcd813b9 (refs/remotes/trunk) M Source/WebCore/ChangeLog r83367 = 98f07a0f2641d491b2f2d947d4a2b74273eddb07 (refs/remotes/trunk) First, rewinding head to replay your work on top of it... Fast-forwarded master to refs/remotes/trunk. Full output: http://queues.webkit.org/results/8380129 382775 4 kamaji 2011-04-09 08:51:57 -0700 I'm not clear why the commit bot reported error -- it seems unrelated. (?) 382778 5 kbalazs 2011-04-09 10:44:16 -0700 (In reply to comment #4) > I'm not clear why the commit bot reported error -- it seems unrelated. (?) It is. I'm going to commit the patch. 382780 6 kbalazs 2011-04-09 10:59:08 -0700 Committed r83380: <http://trac.webkit.org/changeset/83380> 382781 7 kbalazs 2011-04-09 11:03:15 -0700 The reason of the commit error is that you left the "No new tests. (Oops!)" text in WebCore/ChangeLog. 382782 8 88828 kbalazs 2011-04-09 11:04:02 -0700 Comment on attachment 88828 Patch Clearing flags. 88828 2011-04-08 09:02:27 -0700 2011-04-09 11:04:02 -0700 Patch bug-58104-20110408120340.patch text/plain 5486 kamaji U3VidmVyc2lvbiBSZXZpc2lvbjogODMxNzkKZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5n ZUxvZwppbmRleCA4MTUyNmE3MTE1NWI1OGNiYjBhNjExZDE3YjdkZWQ3Y2E1YmQ3ZGZhLi5hMzE1 NGE0Y2ZjMzczMDBlYzIzNzczYTAwYTM4ZDlhYzA1ZTU0MmYwIDEwMDY0NAotLS0gYS9DaGFuZ2VM b2cKKysrIGIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTEtMDQtMDcgIEtlaXRoIEt5 eml2YXQgIDxrZWl0aC5reXppdmF0QG5va2lhLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbUXRdIERvbid0IGxpbmsgYWdhaW5zdCBmb250Y29u ZmlnIG9yIFgxMSBpZiBlbWJlZGRlZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9NTgxMDQKKworICAgICAgICAqIFNvdXJjZS9XZWJLaXQucHJpOiBBZGQg cXBhPT5lbWJlZGRlZCBhcyBpdCBzaG91bGQgYmUgYWNyb3NzIGFsbCBidWlsZHMuCisKIDIwMTEt MDQtMDYgIERhaSBNaWt1cnViZSAgPGRtaWt1cnViZUBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAg UmV2aWV3ZWQgYnkgRGF2aWQgTGV2aW4uCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9DaGFu Z2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMzZiNzM5OGMyMTA5ZGYyYTA5 MDQyYTI0MWYyNDYzMjlmNzMyYzQwNi4uZDkyNmZiNzk0YTZlYmIwMDU0ZTE1Yjc0YzJlOWM0M2U1 YTg0YTdhYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDExLTA0LTA3ICBLZWl0aCBL eXppdmF0ICA8a2VpdGgua3l6aXZhdEBub2tpYS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW1F0XSBEb24ndCBsaW5rIGFnYWluc3QgZm9udGNv bmZpZyBvciBYMTEgaWYgZW1iZWRkZWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTU4MTA0CisKKyAgICAgICAgTm8gbmV3IHRlc3RzLiAoT09QUyEpCisK KyAgICAgICAgKiBXZWJDb3JlLnByaTogcXBhPT5lbWJlZGRlZCBzaG91bGQgYmUgZG9uZSB2ZXJ5 IGVhcmx5IHNvIGFsbCBjYXNlcyBvZiBlbWJlZGRlZCBhcmUgdW5pZm9ybS4KKwogMjAxMS0wNC0w NiAgS2VpdGggS3l6aXZhdCAgPGtlaXRoLmt5eml2YXRAbm9raWEuY29tPgogCiAgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvV2Vi Q29yZS5wcmkgYi9Tb3VyY2UvV2ViQ29yZS9XZWJDb3JlLnByaQppbmRleCAzY2FlNGU0Yjk4N2M4 MzM0MDMwNzQ2ZTBkODBhNzM4YjI1MmU3NTAyLi45NmMyNzYyOTViN2RiZTc2YzhkMTMzMjhjMTQ4 Njc2NWFlNWM3YTk2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9XZWJDb3JlLnByaQorKysg Yi9Tb3VyY2UvV2ViQ29yZS9XZWJDb3JlLnByaQpAQCAtMTAsNiArMTAsOCBAQCBRVCAqPSBuZXR3 b3JrCiAKIFNPVVJDRV9ESVIgPSAkJHJlcGxhY2UoUFdELCAvV2ViQ29yZSwgIiIpCiAKK2NvbnRh aW5zKFFUX0NPTkZJRywgcXBhKTpDT05GSUcgKz0gZW1iZWRkZWQKKwogIyBVc2UgYSBjb25maWct c3BlY2lmaWMgdGFyZ2V0IHRvIHByZXZlbnQgcGFyYWxsZWwgYnVpbGRzIGZpbGUgY2xhc2hlcyBv biBNYWMKIG1hYzogQ09ORklHKGRlYnVnLCBkZWJ1Z3xyZWxlYXNlKTogV0VCQ09SRV9UQVJHRVQg PSB3ZWJjb3JlZAogZWxzZTogV0VCQ09SRV9UQVJHRVQgPSB3ZWJjb3JlCkBAIC0yODIsOCArMjg0 LDYgQEAgY29udGFpbnMoREVGSU5FUywgRU5BQkxFX1NZTUJJQU5fRElBTE9HX1BST1ZJREVSUykg ewogICAgIH0KIH0KIAotY29udGFpbnMoUVRfQ09ORklHLCBxcGEpOkNPTkZJRyArPSBlbWJlZGRl ZAotCiAhQ09ORklHKHdlYmtpdC1kZWJ1Zyk6Q09ORklHKFFURElSX2J1aWxkKSB7CiAgICAgIyBS ZW1vdmUgdGhlIGZvbGxvd2luZyAyIGxpbmVzIGlmIHlvdSB3YW50IGRlYnVnIGluZm9ybWF0aW9u IGluIFdlYkNvcmUKICAgICBDT05GSUcgLT0gc2VwYXJhdGVfZGVidWdfaW5mbwpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYktpdC5wcmkgYi9Tb3VyY2UvV2ViS2l0LnByaQppbmRleCAxNWY4M2NhZDRj Yzg2MzBmOGY3NjkwNTMyY2ZlMGIzYTkxNmQ3ODlkLi41NGUwYWNkYWNiNzU5YTliY2VhYmRiMzBi NDhhOThjNGJmYjQzNmNiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0LnByaQorKysgYi9Tb3Vy Y2UvV2ViS2l0LnByaQpAQCAtMSw1ICsxLDcgQEAKICMgSW5jbHVkZSBmaWxlIHRvIG1ha2UgaXQg ZWFzeSB0byBpbmNsdWRlIFdlYktpdCBpbnRvIFF0IHByb2plY3RzCiAKK2NvbnRhaW5zKFFUX0NP TkZJRywgcXBhKTpDT05GSUcgKz0gZW1iZWRkZWQKKwogIyBEZXRlY3QgdGhhdCB3ZSBhcmUgYnVp bGRpbmcgYXMgYSBzdGFuZGFsb25lIHBhY2thZ2UgYnkgdGhlIHByZXNlbmNlIG9mCiAjIGVpdGhl ciB0aGUgZ2VuZXJhdGVkIGZpbGVzIGRpcmVjdG9yeSBvciBhcyBwYXJ0IG9mIHRoZSBRdCBwYWNr YWdlIHRocm91Z2gKICMgUVRESVJfYnVpbGQKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBi L1Rvb2xzL0NoYW5nZUxvZwppbmRleCAwYjZlMWE3ZTMxNTRjZmYzYjMxYmQ4YmIyZjNkOTk2MjQ3 OTVhZjM5Li5mMmFhNDkyNTUzZGY5OTE4MDhkODA0MDNjM2Q1NWJiZWEwNGZiZDgxIDEwMDY0NAot LS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUg QEAKKzIwMTEtMDQtMDcgIEtlaXRoIEt5eml2YXQgIDxrZWl0aC5reXppdmF0QG5va2lhLmNvbT4K KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbUXRdIERv bid0IGxpbmsgYWdhaW5zdCBmb250Y29uZmlnIG9yIFgxMSBpZiBlbWJlZGRlZAorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTgxMDQKKworICAgICAgICAq IER1bXBSZW5kZXJUcmVlL3F0L0R1bXBSZW5kZXJUcmVlLnBybzogZm9udGNvbmZpZyAhaW5jbHVk ZWQgaW4gZW1iZWRkZWQKKyAgICAgICAgKiBRdFRlc3RCcm93c2VyL1F0VGVzdEJyb3dzZXIucHJv OiBkaXR0bworICAgICAgICAqIFdlYktpdFRlc3RSdW5uZXIvSW5qZWN0ZWRCdW5kbGUvcXQvSW5q ZWN0ZWRCdW5kbGUucHJvOiBkaXR0bworICAgICAgICAqIFdlYktpdFRlc3RSdW5uZXIvcXQvV2Vi S2l0VGVzdFJ1bm5lci5wcm86IGRpdHRvCisKIDIwMTEtMDQtMDYgIEtlaXRoIEt5eml2YXQgIDxr ZWl0aC5reXppdmF0QG5va2lhLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KZGlmZiAtLWdpdCBhL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL3F0L0R1bXBSZW5kZXJUcmVl LnBybyBiL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL3F0L0R1bXBSZW5kZXJUcmVlLnBybwppbmRleCBh NzZiODg2ZWZhYjk2NmYxNDhiYTg1YTRmNGM5MDQzNzJkNTAwOWI2Li5jNTMyYzMyMDA2ODBhOTUz ZGM0NDI2YjIzZjg1M2Y2NzM2ZWEyMWIyIDEwMDY0NAotLS0gYS9Ub29scy9EdW1wUmVuZGVyVHJl ZS9xdC9EdW1wUmVuZGVyVHJlZS5wcm8KKysrIGIvVG9vbHMvRHVtcFJlbmRlclRyZWUvcXQvRHVt cFJlbmRlclRyZWUucHJvCkBAIC0xMyw3ICsxMyw3IEBAIElOQ0xVREVQQVRIICs9IC4uLy4uLy4u L1NvdXJjZS9XZWJLaXQvcXQvV2ViQ29yZVN1cHBvcnQKIElOQ0xVREVQQVRIICs9ICQkQkFTRURJ UgogREVTVERJUiA9IC4uLy4uL2JpbgogCi11bml4OiFtYWM6IXN5bWJpYW4gewordW5peDohbWFj OiFzeW1iaWFuOiFlbWJlZGRlZCB7CiAgICAgQ09ORklHICs9IGxpbmtfcGtnY29uZmlnCiAgICAg UEtHQ09ORklHICs9IGZvbnRjb25maWcKIH0KZGlmZiAtLWdpdCBhL1Rvb2xzL1F0VGVzdEJyb3dz ZXIvUXRUZXN0QnJvd3Nlci5wcm8gYi9Ub29scy9RdFRlc3RCcm93c2VyL1F0VGVzdEJyb3dzZXIu cHJvCmluZGV4IDRjZDdlY2I5ZDE3NDk3MDlkZGRjOGIyMWViYTRiZTRmZDFiOWYwMWUuLjNlMjli ODkzMjA5ZGNlNzkwY2U2ZWE3MTQ1NTQ0MDMxNDRhODU4Y2UgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1F0 VGVzdEJyb3dzZXIvUXRUZXN0QnJvd3Nlci5wcm8KKysrIGIvVG9vbHMvUXRUZXN0QnJvd3Nlci9R dFRlc3RCcm93c2VyLnBybwpAQCAtMzQsNyArMzQsNyBAQCBERVNURElSID0gJCRPVVRQVVRfRElS L2JpbgogUVQgKz0gbmV0d29yawogbWFjeDpRVCs9eG1sCiAKLXVuaXg6IW1hYzohc3ltYmlhbiB7 Cit1bml4OiFtYWM6IXN5bWJpYW46IWVtYmVkZGVkIHsKICAgICBDT05GSUcgKz0gbGlua19wa2dj b25maWcKICAgICBQS0dDT05GSUcgKz0gZm9udGNvbmZpZwogfQpkaWZmIC0tZ2l0IGEvVG9vbHMv V2ViS2l0VGVzdFJ1bm5lci9JbmplY3RlZEJ1bmRsZS9xdC9JbmplY3RlZEJ1bmRsZS5wcm8gYi9U b29scy9XZWJLaXRUZXN0UnVubmVyL0luamVjdGVkQnVuZGxlL3F0L0luamVjdGVkQnVuZGxlLnBy bwppbmRleCA2ODM4MjA1YjRjMTNmZTM2OWU4N2VmNjlmOGMzZDVjMmUxMmM3ZDk5Li4wNzg1OWI0 N2M1MTg3ZWZhZjQ0ZDg2MDkwYTYyZGUxNzQyZjc5ZjUyIDEwMDY0NAotLS0gYS9Ub29scy9XZWJL aXRUZXN0UnVubmVyL0luamVjdGVkQnVuZGxlL3F0L0luamVjdGVkQnVuZGxlLnBybworKysgYi9U b29scy9XZWJLaXRUZXN0UnVubmVyL0luamVjdGVkQnVuZGxlL3F0L0luamVjdGVkQnVuZGxlLnBy bwpAQCAtNzIsNyArNzIsNyBAQCBJTkNMVURFUEFUSCA9IFwKIFBSRUZJWF9IRUFERVIgPSAkJFBX RC8uLi8uLi9XZWJLaXRUZXN0UnVubmVyUHJlZml4LmgKICotZysrKjpRTUFLRV9DWFhGTEFHUyAr PSAiLWluY2x1ZGUgJCRQUkVGSVhfSEVBREVSIgogCi11bml4OiFtYWM6IXN5bWJpYW4gewordW5p eDohbWFjOiFzeW1iaWFuOiFlbWJlZGRlZCB7CiAgICAgQ09ORklHICs9IGxpbmtfcGtnY29uZmln CiAgICAgUEtHQ09ORklHICs9IGZvbnRjb25maWcKIH0KZGlmZiAtLWdpdCBhL1Rvb2xzL1dlYktp dFRlc3RSdW5uZXIvcXQvV2ViS2l0VGVzdFJ1bm5lci5wcm8gYi9Ub29scy9XZWJLaXRUZXN0UnVu bmVyL3F0L1dlYktpdFRlc3RSdW5uZXIucHJvCmluZGV4IDY4NGExNGE4N2RmYTZhYTllNTk0ZDYz ZmM0M2ZjYzRiNjc2N2M4NjMuLmUzMGJmZDk0YjcxNTcwODE1NDQ4NzdmZGIzNzYwMjIwMDliMGZl NDggMTAwNjQ0Ci0tLSBhL1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIvcXQvV2ViS2l0VGVzdFJ1bm5l ci5wcm8KKysrIGIvVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9xdC9XZWJLaXRUZXN0UnVubmVyLnBy bwpAQCAtMjYsNyArMjYsNyBAQCBJTkNMVURFUEFUSCArPSBcCiAKIERFU1RESVIgPSAkJE9VVFBV VF9ESVIvYmluCiAKLXVuaXg6IW1hYzohc3ltYmlhbiB7Cit1bml4OiFtYWM6IXN5bWJpYW46IWVt YmVkZGVkIHsKICAgICBDT05GSUcgKz0gbGlua19wa2djb25maWcKICAgICBQS0dDT05GSUcgKz0g Zm9udGNvbmZpZwogfQo=