58098 2011-04-07 16:52:28 -0700 Optimize filling rounded rects that are actually ellipses 2011-06-01 14:49:16 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Mac (Intel) OS X 10.6 RESOLVED FIXED P2 Normal --- 0 ian webkit-unassigned commit-queue eric simon.fraser oldest_to_newest 381849 0 ian 2011-04-07 16:52:28 -0700 In CG, drawing an ellipse directly is faster than constructing and filling a rounded rect path. We should optimize fillRoundedRect in the case that it's just drawing an ellipse. 381850 1 88734 ian 2011-04-07 16:53:57 -0700 Created attachment 88734 proposed patch 382005 2 commit-queue 2011-04-07 22:37:32 -0700 The commit-queue encountered the following flaky tests while processing attachment 88734: http/tests/inspector/console-websocket-error.html bug 57392 (authors: pfeldman@chromium.org and yutak@chromium.org) The commit-queue is continuing to process your patch. 382006 3 88734 commit-queue 2011-04-07 22:39:10 -0700 Comment on attachment 88734 proposed patch Clearing flags on attachment: 88734 Committed r83253: <http://trac.webkit.org/changeset/83253> 382007 4 commit-queue 2011-04-07 22:39:16 -0700 All reviewed patches have been landed. Closing bug. 382013 5 commit-queue 2011-04-07 22:59:18 -0700 The commit-queue encountered the following flaky tests while processing attachment 88734: animations/suspend-resume-animation.html bug 48161 (author: cmarrin@apple.com) The commit-queue is continuing to process your patch. 413613 6 simon.fraser 2011-06-01 13:20:59 -0700 I think this change broke filling circles in canvas when there is a gradient pattern, since the code no longer goes through the fillPath() logic 413623 7 eric 2011-06-01 13:36:14 -0700 Why is fillRoundedRect ever drawing an ellipse? 413663 8 simon.fraser 2011-06-01 14:20:52 -0700 border-radius: 50% 413673 9 eric 2011-06-01 14:31:04 -0700 (In reply to comment #8) > border-radius: 50% Is that really the case we're optimizing for? I can see how it would be *much* faster to let CG do the elipse, but seems like an odd motivation for this change. 413679 10 simon.fraser 2011-06-01 14:42:38 -0700 Drawing circles with css border-radius is fairly common, and some benchmarks to it. I think it's worth the optimization. 413684 11 eric 2011-06-01 14:49:16 -0700 OK. I'll have to trust you on this one. :) Does seem like an easy way to draw a circle in CSS. 88734 2011-04-07 16:53:57 -0700 2011-04-07 22:39:10 -0700 proposed patch 58098-1.patch text/plain 2499 ian SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDgzMjI4KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTEtMDQtMDcgIElhbiBIZW5k ZXJzb24gIDxpYW5oQGFwcGxlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBPcHRpbWl6ZSBmaWxsaW5nIHJvdW5kZWQgcmVjdHMgdGhhdCBhcmUg YWN0dWFsbHkgZWxsaXBzZXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTU4MDk4CisKKyAgICAgICAgSW4gQ0csIGRyYXdpbmcgYW4gZWxsaXBzZSBkaXJl Y3RseSBpcyBmYXN0ZXIgdGhhbiBjb25zdHJ1Y3RpbmcgYW5kCisgICAgICAgIGZpbGxpbmcgYSBy b3VuZGVkIHJlY3QgcGF0aC4gIERldGVjdCB3aGVuIHRoZSBnaXZlbiByb3VuZGVkIHJlY3QgaXMK KyAgICAgICAgYWN0dWFsbHkgYW4gZWxsaXBzZSBhbmQgZHJhdyBpdCBkaXJlY3RseSBpbiB0aGlz IGNhc2UuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9jZy9HcmFwaGljc0NvbnRleHRD Ry5jcHA6CisgICAgICAgIChXZWJDb3JlOjpHcmFwaGljc0NvbnRleHQ6OmZpbGxSb3VuZGVkUmVj dCk6CisKIDIwMTEtMDQtMDcgIERhbiBCZXJuc3RlaW4gIDxtaXR6QGFwcGxlLmNvbT4KIAogICAg ICAgICBCdWlsZCBmaXguCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9j Zy9HcmFwaGljc0NvbnRleHRDRy5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vZ3JhcGhpY3MvY2cvR3JhcGhpY3NDb250ZXh0Q0cuY3BwCShyZXZpc2lvbiA4MzA3NSkK KysrIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2NnL0dyYXBoaWNzQ29udGV4dENH LmNwcAkod29ya2luZyBjb3B5KQpAQCAtNzU2LDkgKzc1Niw2IEBACiAgICAgaWYgKG9sZEZpbGxD b2xvciAhPSBjb2xvciB8fCBvbGRDb2xvclNwYWNlICE9IGNvbG9yU3BhY2UpCiAgICAgICAgIHNl dENHRmlsbENvbG9yKGNvbnRleHQsIGNvbG9yLCBjb2xvclNwYWNlKTsKIAotICAgIFBhdGggcGF0 aDsKLSAgICBwYXRoLmFkZFJvdW5kZWRSZWN0KHJlY3QsIHRvcExlZnQsIHRvcFJpZ2h0LCBib3R0 b21MZWZ0LCBib3R0b21SaWdodCk7Ci0KICAgICBib29sIGRyYXdPd25TaGFkb3cgPSAhaXNBY2Nl bGVyYXRlZENvbnRleHQoKSAmJiBoYXNCbHVycmVkU2hhZG93KG1fc3RhdGUpICYmICFtX3N0YXRl LnNoYWRvd3NJZ25vcmVUcmFuc2Zvcm1zOyAvLyBEb24ndCB1c2UgU2hhZG93Qmx1ciBmb3IgY2Fu dmFzIHlldC4KICAgICBpZiAoZHJhd093blNoYWRvdykgewogICAgICAgICBmbG9hdCBzaGFkb3dC bHVyID0gbV9zdGF0ZS5zaGFkb3dzVXNlTGVnYWN5UmFkaXVzID8gcmFkaXVzVG9MZWdhY3lSYWRp dXMobV9zdGF0ZS5zaGFkb3dCbHVyKSA6IG1fc3RhdGUuc2hhZG93Qmx1cjsKQEAgLTc3MSw3ICs3 NjgsMTUgQEAKICAgICAgICAgY29udGV4dFNoYWRvdy5kcmF3UmVjdFNoYWRvdyh0aGlzLCByZWN0 LCBSb3VuZGVkSW50UmVjdDo6UmFkaWkodG9wTGVmdCwgdG9wUmlnaHQsIGJvdHRvbUxlZnQsIGJv dHRvbVJpZ2h0KSk7CiAgICAgfQogCi0gICAgZmlsbFBhdGgocGF0aCk7CisgICAgYm9vbCBlcXVh bFdpZHRocyA9ICh0b3BMZWZ0LndpZHRoKCkgPT0gdG9wUmlnaHQud2lkdGgoKSAmJiB0b3BSaWdo dC53aWR0aCgpID09IGJvdHRvbUxlZnQud2lkdGgoKSAmJiBib3R0b21MZWZ0LndpZHRoKCkgPT0g Ym90dG9tUmlnaHQud2lkdGgoKSk7CisgICAgYm9vbCBlcXVhbEhlaWdodHMgPSAodG9wTGVmdC5o ZWlnaHQoKSA9PSBib3R0b21MZWZ0LmhlaWdodCgpICYmIGJvdHRvbUxlZnQuaGVpZ2h0KCkgPT0g dG9wUmlnaHQuaGVpZ2h0KCkgJiYgdG9wUmlnaHQuaGVpZ2h0KCkgPT0gYm90dG9tUmlnaHQuaGVp Z2h0KCkpOworICAgIGlmIChlcXVhbFdpZHRocyAmJiBlcXVhbEhlaWdodHMgJiYgdG9wTGVmdC53 aWR0aCgpICogMiA9PSByZWN0LndpZHRoKCkgJiYgdG9wTGVmdC5oZWlnaHQoKSAqIDIgPT0gcmVj dC5oZWlnaHQoKSkKKyAgICAgICAgQ0dDb250ZXh0RmlsbEVsbGlwc2VJblJlY3QoY29udGV4dCwg cmVjdCk7CisgICAgZWxzZSB7CisgICAgICAgIFBhdGggcGF0aDsKKyAgICAgICAgcGF0aC5hZGRS b3VuZGVkUmVjdChyZWN0LCB0b3BMZWZ0LCB0b3BSaWdodCwgYm90dG9tTGVmdCwgYm90dG9tUmln aHQpOworICAgICAgICBmaWxsUGF0aChwYXRoKTsKKyAgICB9CiAKICAgICBpZiAoZHJhd093blNo YWRvdykKICAgICAgICAgQ0dDb250ZXh0UmVzdG9yZUdTdGF0ZShjb250ZXh0KTsK