58095 2011-04-07 15:56:43 -0700 [GTK] Fix the WebKit2 build for older versions of GTK+ 2011-04-08 12:47:20 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC Linux RESOLVED FIXED Gtk P3 Normal --- 1 mrobinson webkit-unassigned abarth alex eric webkit.review.bot xan.lopez oldest_to_newest 381805 0 mrobinson 2011-04-07 15:56:43 -0700 WebKit2 uses gdk_window_create_similar_surface which is only availabe in GTK+ >= 2.22. 382404 1 88845 mrobinson 2011-04-08 11:35:36 -0700 Created attachment 88845 Patch 382405 2 88845 xan.lopez 2011-04-08 11:38:11 -0700 Comment on attachment 88845 Patch r=me 382407 3 webkit.review.bot 2011-04-08 11:39:00 -0700 Attachment 88845 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/platform/gtk/GtkVersioning.h:50: The parameter name "window" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WebCore/platform/gtk/GtkVersioning.h:50: The parameter name "content" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WebCore/platform/gtk/GtkVersioning.h:50: gdk_window_create_similar_surface is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Total errors found: 3 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style. 382423 4 mrobinson 2011-04-08 11:48:09 -0700 Committed r83319: <http://trac.webkit.org/changeset/83319> 382462 5 webkit.review.bot 2011-04-08 12:47:20 -0700 http://trac.webkit.org/changeset/83319 might have broken Qt Linux Release The following tests are not passing: http/tests/loading/preload-append-scan.php 88845 2011-04-08 11:35:36 -0700 2011-04-08 11:38:11 -0700 Patch bug-58095-20110408113535.patch text/plain 3800 mrobinson U3VidmVyc2lvbiBSZXZpc2lvbjogODMyMjYKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBjNmZlYjNhOWZkZDFmMGM1 ZmViMWNhYjcxZWRhMDkzMWNhODQyNDgwLi5lY2NmMGZiYzMwY2RhNWY1NDkyZDUyYTZiN2EyZGE3 ZDM2NzYyZTBiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTEtMDQtMDggIE1hcnRp biBSb2JpbnNvbiAgPG1yb2JpbnNvbkBpZ2FsaWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtHVEtdIEZpeCB0aGUgV2ViS2l0MiBidWlsZCBm b3Igb2xkZXIgdmVyc2lvbnMgb2YgR1RLKworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9NTgwOTUKKworICAgICAgICBObyBuZXcgdGVzdHMuIFRoaXMgaXMg anVzdCBhIGJ1aWxkIGZpeC4KKworICAgICAgICAqIHBsYXRmb3JtL2d0ay9HdGtWZXJzaW9uaW5n LmM6CisgICAgICAgIChnZGtfd2luZG93X2NyZWF0ZV9zaW1pbGFyX3N1cmZhY2UpOiBSZWltcGxl bWVudCB0aGlzIG1ldGhvZCBmb3Igb2xkZXIgdmVyc2lvbnMgb2YgR0RLLgorICAgICAgICAqIHBs YXRmb3JtL2d0ay9HdGtWZXJzaW9uaW5nLmg6IEFkZCB0aGUgbmV3IG1ldGhvZCB0byB0aGUgaGVh ZGVyLgorCiAyMDExLTA0LTA3ICBEYW4gQmVybnN0ZWluICA8bWl0ekBhcHBsZS5jb20+CiAKICAg ICAgICAgQnVpbGQgZml4LgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3Rr L0d0a1ZlcnNpb25pbmcuYyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2d0ay9HdGtWZXJzaW9u aW5nLmMKaW5kZXggYzM0MDdlYWExMThkZjFiZTY0NjEzMGQyYmVhMjUxOTExNGQxMDRkNi4uMTEz OGQ1NjIwNWIwMWE1ZWYyM2MxZDEzYjQ4YzAyMTM2ZTAwNmM0OSAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vZ3RrL0d0a1ZlcnNpb25pbmcuYworKysgYi9Tb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9ndGsvR3RrVmVyc2lvbmluZy5jCkBAIC0yNzEsMyArMjcxLDEzIEBAIGdib29s ZWFuIGdfc2lnbmFsX2FjY3VtdWxhdG9yX2ZpcnN0X3dpbnMoR1NpZ25hbEludm9jYXRpb25IaW50 ICppbnZvY2F0aW9uSGludCwKIH0KICNlbmRpZgogCisjaWYgIUdUS19DSEVDS19WRVJTSU9OKDIs IDIyLCAwKQorY2Fpcm9fc3VyZmFjZV90ICpnZGtfd2luZG93X2NyZWF0ZV9zaW1pbGFyX3N1cmZh Y2UoR2RrV2luZG93ICp3aW5kb3csIGNhaXJvX2NvbnRlbnRfdCBjb250ZW50LCBpbnQgd2lkdGgs IGludCBoZWlnaHQpCit7CisgICAgY2Fpcm9fdCAqY2Fpcm9Db250ZXh0ID0gZ2RrX2NhaXJvX2Ny ZWF0ZSh3aW5kb3cpOworICAgIGNhaXJvX3N1cmZhY2VfdCAqY2Fpcm9TdXJmYWNlID0gY2Fpcm9f Z2V0X3RhcmdldChjYWlyb0NvbnRleHQpOworICAgIGNhaXJvX3N1cmZhY2VfdCAqbmV3U3VyZmFj ZSA9IGNhaXJvX3N1cmZhY2VfY3JlYXRlX3NpbWlsYXIoY2Fpcm9TdXJmYWNlLCBjb250ZW50LCB3 aWR0aCwgaGVpZ2h0KTsKKyAgICBjYWlyb19kZXN0cm95KGNhaXJvQ29udGV4dCk7CisgICAgcmV0 dXJuIG5ld1N1cmZhY2U7Cit9CisjZW5kaWYgLy8gR1RLX0NIRUNLX1ZFUlNJT04oMiwgMjIsIDAp CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ndGsvR3RrVmVyc2lvbmluZy5o IGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3RrL0d0a1ZlcnNpb25pbmcuaAppbmRleCA3MGUx YmJlYjgzMjI5ZGM5NTBjZjU5M2YxMTlhODliMGRmNjcyZjA3Li5iNDRmYzM4MzkyNjI2NTZjMzAw MzE0YWY4OTU2YmRmYzIxMzFhNTcyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9ndGsvR3RrVmVyc2lvbmluZy5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2d0ay9H dGtWZXJzaW9uaW5nLmgKQEAgLTQ2LDYgKzQ2LDEwIEBAIEdka1BpeGJ1ZiogZ2RrX3BpeGJ1Zl9n ZXRfZnJvbV9zdXJmYWNlKGNhaXJvX3N1cmZhY2VfdCogc3VyZmFjZSwgaW50IHNyY1gsIGludCBz CiAjZGVmaW5lIGdka193aW5kb3dfZ2V0X3Zpc3VhbCBnZGtfZHJhd2FibGVfZ2V0X3Zpc3VhbAog I2VuZGlmIC8vIEdUS19DSEVDS19WRVJTSU9OKDIsIDIzLCAwKQogCisjaWYgIUdUS19DSEVDS19W RVJTSU9OKDIsIDIyLCAwKQorY2Fpcm9fc3VyZmFjZV90KiBnZGtfd2luZG93X2NyZWF0ZV9zaW1p bGFyX3N1cmZhY2UoR2RrV2luZG93KiB3aW5kb3csIGNhaXJvX2NvbnRlbnRfdCBjb250ZW50LCBp bnQgd2lkdGgsIGludCBoZWlnaHQpOworI2VuZGlmIC8vIEdUS19DSEVDS19WRVJTSU9OKDIsIDIy LCAwKQorCiAjaWYgIUdUS19DSEVDS19WRVJTSU9OKDIsIDIxLCAyKQogI2RlZmluZSBnZGtfdmlz dWFsX2dldF9kZXB0aCh2aXN1YWwpICh2aXN1YWwpLT5kZXB0aAogI2RlZmluZSBnZGtfdmlzdWFs X2dldF9iaXRzX3Blcl9yZ2IodmlzdWFsKSAodmlzdWFsKS0+Yml0c19wZXJfcmdiCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cK aW5kZXggODY1MzJiYTczMTNlZGVkYTg2MjVkOGVlN2M4NGFiMjg2OTIzZmQyOC4uNDZiNzdjMTBk YmQzM2VlZjI1MDRjMDkyZGVjMTM5ZDcwMjdjYTllOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktp dDIvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEy IEBACisyMDExLTA0LTA4ICBNYXJ0aW4gUm9iaW5zb24gIDxtcm9iaW5zb25AaWdhbGlhLmNvbT4K KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbR1RLXSBG aXggdGhlIFdlYktpdDIgYnVpbGQgZm9yIG9sZGVyIHZlcnNpb25zIG9mIEdUSysKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTU4MDk1CisKKyAgICAgICAg KiBVSVByb2Nlc3MvZ3RrL0NodW5rZWRVcGRhdGVEcmF3aW5nQXJlYVByb3h5R3RrLmNwcDogSW5j bHVkZSB0aGUgR3RrVmVyc2lvbmluZy5oIGhlYWRlci4KKwogMjAxMS0wNC0wNyAgQW5kcmV3IFNj aGVya3VzICA8c2NoZXJrdXNAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmVydCBFTkFCTEVf VFJBQ0sgcGF0Y2ggZHVlIHRvIGNvbXBpbGUgZmFpbHVyZXMuCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViS2l0Mi9VSVByb2Nlc3MvZ3RrL0NodW5rZWRVcGRhdGVEcmF3aW5nQXJlYVByb3h5R3RrLmNw cCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9ndGsvQ2h1bmtlZFVwZGF0ZURyYXdpbmdBcmVh UHJveHlHdGsuY3BwCmluZGV4IGE1YzcwOGYzNGRiMmE4NDgxNzhiN2Q4NzA4Yzg5ZGU2NWNhMzE0 ZjAuLjg5YTllZjc0MjFkZTBlMjgxNzJmOGM4MWY3OTYzYzZjN2UzNDE0ZmMgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9ndGsvQ2h1bmtlZFVwZGF0ZURyYXdpbmdBcmVhUHJv eHlHdGsuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9ndGsvQ2h1bmtlZFVwZGF0 ZURyYXdpbmdBcmVhUHJveHlHdGsuY3BwCkBAIC0zMiw3ICszMiw3IEBACiAjaW5jbHVkZSAiVXBk YXRlQ2h1bmsuaCIKICNpbmNsdWRlICJXZWJQcm9jZXNzUHJveHkuaCIKICNpbmNsdWRlICJXZWJW aWV3LmgiCi0KKyNpbmNsdWRlIDxXZWJDb3JlL0d0a1ZlcnNpb25pbmcuaD4KICNpbmNsdWRlIDxn ZGsvZ2RrLmg+CiAKIHVzaW5nIG5hbWVzcGFjZSBXZWJDb3JlOwo=