<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>58093</bug_id>
          
          <creation_ts>2011-04-07 15:39:00 -0700</creation_ts>
          <short_desc>CStringBuffer should have thread safety checks turned on.</short_desc>
          <delta_ts>2011-08-04 17:55:35 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Web Template Framework</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>All</rep_platform>
          <op_sys>All</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          <dependson>31639</dependson>
          <blocked>58174</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="David Levin">levin</reporter>
          <assigned_to name="David Levin">levin</assigned_to>
          <cc>dimich</cc>
    
    <cc>webkit.review.bot</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>381793</commentid>
    <comment_count>0</comment_count>
    <who name="David Levin">levin</who>
    <bug_when>2011-04-07 15:39:00 -0700</bug_when>
    <thetext>This is awaiting a fix in chromium. Specifically http://code.google.com/p/chromium/issues/detail?id=78208</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>390443</commentid>
    <comment_count>1</comment_count>
    <who name="David Levin">levin</who>
    <bug_when>2011-04-21 16:29:49 -0700</bug_when>
    <thetext>These checks will be turned on when the initial check in is done (since the chromium issue has been fixed).</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>391849</commentid>
    <comment_count>2</comment_count>
    <who name="David Levin">levin</who>
    <bug_when>2011-04-25 12:30:33 -0700</bug_when>
    <thetext>This will remain for the moment.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>445046</commentid>
    <comment_count>3</comment_count>
    <who name="David Levin">levin</who>
    <bug_when>2011-08-01 17:54:24 -0700</bug_when>
    <thetext>Removed in the original patch now.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>445652</commentid>
    <comment_count>4</comment_count>
    <who name="David Levin">levin</who>
    <bug_when>2011-08-02 18:03:16 -0700</bug_when>
    <thetext>There were other problems in Chromium so this bug must remain open for now.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>446896</commentid>
    <comment_count>5</comment_count>
      <attachid>103005</attachid>
    <who name="David Levin">levin</who>
    <bug_when>2011-08-04 16:51:09 -0700</bug_when>
    <thetext>Created attachment 103005
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>446938</commentid>
    <comment_count>6</comment_count>
      <attachid>103005</attachid>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2011-08-04 17:55:31 -0700</bug_when>
    <thetext>Comment on attachment 103005
Patch

Clearing flags on attachment: 103005

Committed r92437: &lt;http://trac.webkit.org/changeset/92437&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>446939</commentid>
    <comment_count>7</comment_count>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2011-08-04 17:55:35 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>103005</attachid>
            <date>2011-08-04 16:51:09 -0700</date>
            <delta_ts>2011-08-04 17:55:31 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-58093-20110804165108.patch</filename>
            <type>text/plain</type>
            <size>2740</size>
            <attacher name="David Levin">levin</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogOTI0MjkKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0
Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IDA0
ODk1NmMzNzQxMWYyYTRmM2Y2MTEzNmNjZWNkOWRhOWJhNjZmYjEuLjVjMzYyOTMxODFiYzY3ZGRj
ZGRkNGMwODgwOTIxNzhmYTgzOTJlN2IgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29y
ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwpAQCAtMSwz
ICsxLDE0IEBACisyMDExLTA4LTA0ICBEYXZpZCBMZXZpbiAgPGxldmluQGNocm9taXVtLm9yZz4K
KworICAgICAgICBDU3RyaW5nQnVmZmVyIHNob3VsZCBoYXZlIHRocmVhZCBzYWZldHkgY2hlY2tz
IHR1cm5lZCBvbi4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp
P2lkPTU4MDkzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg
ICAgKiB3dGYvdGV4dC9DU3RyaW5nLmg6CisgICAgICAgIChXVEY6OkNTdHJpbmdCdWZmZXI6OkNT
dHJpbmdCdWZmZXIpOiBSZW1vdmVkIHRoZSBpZmRlZiB0aGF0CisgICAgICAgIHR1cm5lZCB0aGlz
IG9mZiBmb3IgQ2hyb21pdW0uCisKIDIwMTEtMDgtMDQgIE1hcmsgSGFobmVuYmVyZyAgPG1oYWhu
ZW5iZXJnQGFwcGxlLmNvbT4KIAogICAgICAgICBJbnRlcnByZXRlciBjYW4gcG90ZW50aWFsbHkg
R0MgaW4gdGhlIG1pZGRsZSBvZiBpbml0aWFsaXppbmcgYSBzdHJ1Y3R1cmUgY2hhaW4KZGlmZiAt
LWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS93dGYvdGV4dC9DU3RyaW5nLmggYi9Tb3VyY2Uv
SmF2YVNjcmlwdENvcmUvd3RmL3RleHQvQ1N0cmluZy5oCmluZGV4IGQ1MzZkYTA5NmZjM2E2YmRk
N2MzNDZkMTk5ZDg3YjRmNGVkMTI1NTEuLjM0M2E3YTUyNTIwNzQxZTJhZGNkYmQ4MTBlM2U5OTk1
YTM4MGQ0NjQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS93dGYvdGV4dC9DU3Ry
aW5nLmgKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3d0Zi90ZXh0L0NTdHJpbmcuaApAQCAt
NDEsMTQgKzQxLDcgQEAgcHJpdmF0ZToKICAgICBmcmllbmQgY2xhc3MgQ1N0cmluZzsKIAogICAg
IHN0YXRpYyBQYXNzUmVmUHRyPENTdHJpbmdCdWZmZXI+IGNyZWF0ZShzaXplX3QgbGVuZ3RoKSB7
IHJldHVybiBhZG9wdFJlZihuZXcgQ1N0cmluZ0J1ZmZlcihsZW5ndGgpKTsgfQotICAgIENTdHJp
bmdCdWZmZXIoc2l6ZV90IGxlbmd0aCkgOiBtX3ZlY3RvcihsZW5ndGgpCi0gICAgewotI2lmIFBM
QVRGT1JNKENIUk9NSVVNKQotICAgICAgICAvLyBGSVhNRTogTmVlZCB0byBmaXggc29tZSBzdGFy
dC11cCBjb2RlIGluIENocm9taXVtIExpbnV4IGFuZCBzb21lIHRlc3QgY29kZSBmb3IKLSAgICAg
ICAgLy8gQ2hyb21pdW0gT1MgWCBpbiBvcmRlciB0byByZW1vdmUgdGhpcy4KLSAgICAgICAgZGVw
cmVjYXRlZFR1cm5PZmZWZXJpZmllcigpOwotI2VuZGlmCi0gICAgfQorICAgIENTdHJpbmdCdWZm
ZXIoc2l6ZV90IGxlbmd0aCkgOiBtX3ZlY3RvcihsZW5ndGgpIHsgfQogICAgIGNoYXIqIG11dGFi
bGVEYXRhKCkgeyByZXR1cm4gbV92ZWN0b3IuZGF0YSgpOyB9CiAKICAgICBWZWN0b3I8Y2hhcj4g
bV92ZWN0b3I7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZyBi
L1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4IGRhMjZkZTdjNDMxYTlkYTUz
MmQ3ZDQ3M2ZmZTNmNTRiMDA1NzRmMGQuLjlhY2UzODExNTQ3ODQ4NWJhMzQyOGE3NzUwNDRjOWRm
NjZiYTdlNDkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCisr
KyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIw
MTEtMDgtMDQgIERhdmlkIExldmluICA8bGV2aW5AY2hyb21pdW0ub3JnPgorCisgICAgICAgIENT
dHJpbmdCdWZmZXIgc2hvdWxkIGhhdmUgdGhyZWFkIHNhZmV0eSBjaGVja3MgdHVybmVkIG9uLgor
ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTgwOTMKKwor
ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIERFUFM6IFJv
bGwgZmFyIGVub3VnaCB0byBwaWNrIHVwIHRoZSBsYXRlc3QgV2ViS2l0Ojppbml0aWFsaXplCisg
ICAgICAgIGZpeCBmb3IgTGludXguCisKIDIwMTEtMDgtMDQgIFNoZXJpZmYgQm90ICA8d2Via2l0
LnJldmlldy5ib3RAZ21haWwuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQsIHJvbGxpbmcgb3V0
IHI5MjQxNS4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vREVQUyBiL1NvdXJj
ZS9XZWJLaXQvY2hyb21pdW0vREVQUwppbmRleCA5ZWU1NGYzYzdjMjhlNjBkYWNmNTcwZjU0ZjQ1
NmYwOTYyOGUyZTIyLi5jM2Q4MjRhYjFlM2Q1YWUzMDQ5YThiODJmMTBmNWU5NTM1MjIwMGU3IDEw
MDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL0RFUFMKKysrIGIvU291cmNlL1dlYktp
dC9jaHJvbWl1bS9ERVBTCkBAIC0zMiw3ICszMiw3IEBACiAKIHZhcnMgPSB7CiAgICdjaHJvbWl1
bV9zdm4nOiAnaHR0cDovL3NyYy5jaHJvbWl1bS5vcmcvc3ZuL3RydW5rL3NyYycsCi0gICdjaHJv
bWl1bV9yZXYnOiAnOTQ4NTAnCisgICdjaHJvbWl1bV9yZXYnOiAnOTU1MzMnCiB9CiAKIGRlcHMg
PSB7Cg==
</data>

          </attachment>
      

    </bug>

</bugzilla>