58085 2011-04-07 14:55:27 -0700 Logic error in HTMLMediaElement::exitFullscreen() 2011-04-08 13:12:16 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED InRadar P2 Normal --- 1 jer.noble jer.noble dglazkov webkit.review.bot oldest_to_newest 381744 0 jer.noble 2011-04-07 14:55:27 -0700 If a script calls exitFullscreen() on an element which is not the current full screen element, it will hit the ASSERT in the legacy full screen media case. 381749 1 jer.noble 2011-04-07 14:58:45 -0700 <rdar://problem/9252557> 381757 2 88710 jer.noble 2011-04-07 15:03:31 -0700 Created attachment 88710 Patch 381815 3 webkit.review.bot 2011-04-07 16:09:39 -0700 Attachment 88710 did not build on chromium: Build output: http://queues.webkit.org/results/8342680 381844 4 88733 jer.noble 2011-04-07 16:44:29 -0700 Created attachment 88733 Patch Missing parenthesis reinserted. 382495 5 jer.noble 2011-04-08 13:12:16 -0700 Committed r83332: <http://trac.webkit.org/changeset/83332> 88710 2011-04-07 15:03:31 -0700 2011-04-07 16:44:26 -0700 Patch bug-58085-20110407150330.patch text/plain 2249 jer.noble U3VidmVyc2lvbiBSZXZpc2lvbjogODMyMTQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBkY2EwNWI4MDhmMjU0YmFl Yzc1ZWIzYjFjMTQ2ZWFmYWEzZTRkMDUxLi42ODU4NDM4ZWUxODUyOTJlYTQ0ZjY4MTAyNmJkZmNi MGIxODlkMzM1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMTEtMDQtMDcgIEplciBO b2JsZSAgPGplci5ub2JsZUBhcHBsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgTG9naWMgZXJyb3IgaW4gSFRNTE1lZGlhRWxlbWVudDo6ZXhp dEZ1bGxzY3JlZW4oKQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9NTgwODUKKworICAgICAgICBUaGUgbmV3IGZ1bGwgc2NyZWVuIEFQSSBjYXNlIGNvdWxk IGZhbGwgdGhyb3VnaCB0byB0aGUgbGVnYWN5IEFQSSBjYXNlCisgICAgICAgIHVuaW50ZW50aW9u YWxseSBpZiBhIHNjcmlwdCBjYWxscyBleGl0RnVsbHNjcmVlbiBvbiBhbiBlbGVtZW50IHdoaWNo IGlzCisgICAgICAgIG5vdCB0aGUgY3VycmVudCBmdWxsIHNjcmVlbiBlbGVtZW50LgorCisgICAg ICAgICogaHRtbC9IVE1MTWVkaWFFbGVtZW50LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkhUTUxN ZWRpYUVsZW1lbnQ6OmVudGVyRnVsbHNjcmVlbik6CisgICAgICAgIChXZWJDb3JlOjpIVE1MTWVk aWFFbGVtZW50OjpleGl0RnVsbHNjcmVlbik6CisKIDIwMTEtMDQtMDYgIFZpdGFseSBSZXBlc2hr byAgPHZpdGFseXJAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IE5hdGUgQ2hh cGluLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MTWVkaWFFbGVtZW50LmNw cCBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTE1lZGlhRWxlbWVudC5jcHAKaW5kZXggMWFiZTAy ODVmMDY3YzE5MDc3ZjQ1MjRiNGNiZmE3MDJiN2VhNmMyOC4uNjRmMjRiMzlkNzhhYjdmNmZjM2E2 ZWYyNzE5ODY1NmQ0ODZhOTYyMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1M TWVkaWFFbGVtZW50LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxNZWRpYUVsZW1l bnQuY3BwCkBAIC0yNDQ5LDcgKzI0NDksNyBAQCB2b2lkIEhUTUxNZWRpYUVsZW1lbnQ6OmVudGVy RnVsbHNjcmVlbigpCiB7CiAgICAgTE9HKE1lZGlhLCAiSFRNTE1lZGlhRWxlbWVudDo6ZW50ZXJG dWxsc2NyZWVuIik7CiAjaWYgRU5BQkxFKEZVTExTQ1JFRU5fQVBJKQotICAgIGlmIChkb2N1bWVu dCgpLT5zZXR0aW5ncygpICYmIGRvY3VtZW50KCktPnNldHRpbmdzKCktPmZ1bGxTY3JlZW5FbmFi bGVkKCkpIHsKKyAgICBpZiAoZG9jdW1lbnQoKSAmJiBkb2N1bWVudCgpLT5zZXR0aW5ncygpICYm IGRvY3VtZW50KCktPnNldHRpbmdzKCktPmZ1bGxTY3JlZW5FbmFibGVkKCkpIHsKICAgICAgICAg d2Via2l0UmVxdWVzdEZ1bGxTY3JlZW4oMCk7CiAgICAgICAgIHJldHVybjsKICAgICB9CkBAIC0y NDY2LDkgKzI0NjYsOSBAQCB2b2lkIEhUTUxNZWRpYUVsZW1lbnQ6OmV4aXRGdWxsc2NyZWVuKCkK IHsKICAgICBMT0coTWVkaWEsICJIVE1MTWVkaWFFbGVtZW50OjpleGl0RnVsbHNjcmVlbiIpOwog I2lmIEVOQUJMRShGVUxMU0NSRUVOX0FQSSkKLSAgICBpZiAoZG9jdW1lbnQoKS0+c2V0dGluZ3Mo KSAmJiBkb2N1bWVudCgpLT5zZXR0aW5ncygpLT5mdWxsU2NyZWVuRW5hYmxlZCgpIAotICAgICAg ICAmJiBkb2N1bWVudCgpLT53ZWJraXRJc0Z1bGxTY3JlZW4oKSAmJiBkb2N1bWVudCgpLT53ZWJr aXRDdXJyZW50RnVsbFNjcmVlbkVsZW1lbnQoKSA9PSB0aGlzKSB7Ci0gICAgICAgIGRvY3VtZW50 KCktPndlYmtpdENhbmNlbEZ1bGxTY3JlZW4oKTsKKyAgICBpZiAoZG9jdW1lbnQoKSAmJiBkb2N1 bWVudCgpLT5zZXR0aW5ncygpICYmIGRvY3VtZW50KCktPnNldHRpbmdzKCktPmZ1bGxTY3JlZW5F bmFibGVkKCkgeworICAgICAgICBpZiAoZG9jdW1lbnQoKS0+d2Via2l0SXNGdWxsU2NyZWVuKCkg JiYgZG9jdW1lbnQoKS0+d2Via2l0Q3VycmVudEZ1bGxTY3JlZW5FbGVtZW50KCkgPT0gdGhpcykK KyAgICAgICAgICAgIGRvY3VtZW50KCktPndlYmtpdENhbmNlbEZ1bGxTY3JlZW4oKTsKICAgICAg ICAgcmV0dXJuOwogICAgIH0KICNlbmRpZgo= 88733 2011-04-07 16:44:29 -0700 2011-04-08 12:21:37 -0700 Patch bug-58085-20110407164428.patch text/plain 2243 jer.noble U3VidmVyc2lvbiBSZXZpc2lvbjogODMyMjIKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBiNWRkMjg1MjQyMTViMTgw NTNmNzgzY2RmOWFhNWZkZDViMmM1YmE1Li40OTNkNjg2NDVjZGM2NDg1YmVlYmE5MmJiZmFkNzQ4 MjU5NjgwOTcyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMTEtMDQtMDcgIEplciBO b2JsZSAgPGplci5ub2JsZUBhcHBsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgTG9naWMgZXJyb3IgaW4gSFRNTE1lZGlhRWxlbWVudDo6ZXhp dEZ1bGxzY3JlZW4oKQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9NTgwODUKKworICAgICAgICBUaGUgbmV3IGZ1bGwgc2NyZWVuIEFQSSBjYXNlIGNvdWxk IGZhbGwgdGhyb3VnaCB0byB0aGUgbGVnYWN5IEFQSSBjYXNlCisgICAgICAgIHVuaW50ZW50aW9u YWxseSBpZiBhIHNjcmlwdCBjYWxscyBleGl0RnVsbHNjcmVlbiBvbiBhbiBlbGVtZW50IHdoaWNo IGlzCisgICAgICAgIG5vdCB0aGUgY3VycmVudCBmdWxsIHNjcmVlbiBlbGVtZW50LgorCisgICAg ICAgICogaHRtbC9IVE1MTWVkaWFFbGVtZW50LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkhUTUxN ZWRpYUVsZW1lbnQ6OmVudGVyRnVsbHNjcmVlbik6CisgICAgICAgIChXZWJDb3JlOjpIVE1MTWVk aWFFbGVtZW50OjpleGl0RnVsbHNjcmVlbik6CisKIDIwMTEtMDQtMDcgIERhdmlkIEh5YXR0ICA8 aHlhdHRAYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERhbiBCZXJuc3RlaW4uCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxNZWRpYUVsZW1lbnQuY3BwIGIvU291 cmNlL1dlYkNvcmUvaHRtbC9IVE1MTWVkaWFFbGVtZW50LmNwcAppbmRleCAxYWJlMDI4NWYwNjdj MTkwNzdmNDUyNGI0Y2JmYTcwMmI3ZWE2YzI4Li5lNGUwZWMwYmRmZmJiZGM1ZjljMDk3MmRlZGE3 NzBmNWM2MTZjNWQwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxNZWRpYUVs ZW1lbnQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTE1lZGlhRWxlbWVudC5jcHAK QEAgLTI0NDksNyArMjQ0OSw3IEBAIHZvaWQgSFRNTE1lZGlhRWxlbWVudDo6ZW50ZXJGdWxsc2Ny ZWVuKCkKIHsKICAgICBMT0coTWVkaWEsICJIVE1MTWVkaWFFbGVtZW50OjplbnRlckZ1bGxzY3Jl ZW4iKTsKICNpZiBFTkFCTEUoRlVMTFNDUkVFTl9BUEkpCi0gICAgaWYgKGRvY3VtZW50KCktPnNl dHRpbmdzKCkgJiYgZG9jdW1lbnQoKS0+c2V0dGluZ3MoKS0+ZnVsbFNjcmVlbkVuYWJsZWQoKSkg eworICAgIGlmIChkb2N1bWVudCgpICYmIGRvY3VtZW50KCktPnNldHRpbmdzKCkgJiYgZG9jdW1l bnQoKS0+c2V0dGluZ3MoKS0+ZnVsbFNjcmVlbkVuYWJsZWQoKSkgewogICAgICAgICB3ZWJraXRS ZXF1ZXN0RnVsbFNjcmVlbigwKTsKICAgICAgICAgcmV0dXJuOwogICAgIH0KQEAgLTI0NjYsOSAr MjQ2Niw5IEBAIHZvaWQgSFRNTE1lZGlhRWxlbWVudDo6ZXhpdEZ1bGxzY3JlZW4oKQogewogICAg IExPRyhNZWRpYSwgIkhUTUxNZWRpYUVsZW1lbnQ6OmV4aXRGdWxsc2NyZWVuIik7CiAjaWYgRU5B QkxFKEZVTExTQ1JFRU5fQVBJKQotICAgIGlmIChkb2N1bWVudCgpLT5zZXR0aW5ncygpICYmIGRv Y3VtZW50KCktPnNldHRpbmdzKCktPmZ1bGxTY3JlZW5FbmFibGVkKCkgCi0gICAgICAgICYmIGRv Y3VtZW50KCktPndlYmtpdElzRnVsbFNjcmVlbigpICYmIGRvY3VtZW50KCktPndlYmtpdEN1cnJl bnRGdWxsU2NyZWVuRWxlbWVudCgpID09IHRoaXMpIHsKLSAgICAgICAgZG9jdW1lbnQoKS0+d2Vi a2l0Q2FuY2VsRnVsbFNjcmVlbigpOworICAgIGlmIChkb2N1bWVudCgpICYmIGRvY3VtZW50KCkt PnNldHRpbmdzKCkgJiYgZG9jdW1lbnQoKS0+c2V0dGluZ3MoKS0+ZnVsbFNjcmVlbkVuYWJsZWQo KSkgeworICAgICAgICBpZiAoZG9jdW1lbnQoKS0+d2Via2l0SXNGdWxsU2NyZWVuKCkgJiYgZG9j dW1lbnQoKS0+d2Via2l0Q3VycmVudEZ1bGxTY3JlZW5FbGVtZW50KCkgPT0gdGhpcykKKyAgICAg ICAgICAgIGRvY3VtZW50KCktPndlYmtpdENhbmNlbEZ1bGxTY3JlZW4oKTsKICAgICAgICAgcmV0 dXJuOwogICAgIH0KICNlbmRpZgo=