58076 2011-04-07 13:43:42 -0700 [Qt] Regression : r83051 Oxygen's lineedits are not rendered properly 2011-05-04 12:59:48 -0700 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) PC Linux RESOLVED FIXED Qt, QtTriaged P1 Blocker --- 1 menard menard commit-queue diegohcg kenneth oldest_to_newest 381659 0 menard 2011-04-07 13:43:42 -0700 Go to bugs.webkit.org, all lineedits are invisible. This does not happen with Plastique style. Clicking on them make them appear. 382138 1 menard 2011-04-08 04:20:24 -0700 r83051 broke it. 382170 2 88804 menard 2011-04-08 05:35:18 -0700 Created attachment 88804 Proposed patch. I'm not sure how this patch align with the mobile theme but it fixes the bad issue with Oxygen. 382227 3 diegohcg 2011-04-08 07:41:46 -0700 (In reply to comment #2) > Created an attachment (id=88804) [details] > Proposed patch. > > I'm not sure how this patch align with the mobile theme but it fixes the bad issue with Oxygen. I think we will need a #ifdef :( 382392 4 88804 kling 2011-04-08 11:03:00 -0700 Comment on attachment 88804 Proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=88804&action=review > Source/WebCore/platform/qt/RenderThemeQt.cpp:676 > - if (isPressed(o)) > - panel.state |= QStyle::State_Sunken; > + panel.state |= QStyle::State_Sunken; Diego is right, this needs to go in an #if USE(QT_MOBILE_THEME) block ;( 383102 5 88989 menard 2011-04-11 04:54:45 -0700 Created attachment 88989 V2 with comments taken into account. 383106 6 88989 kling 2011-04-11 04:58:20 -0700 Comment on attachment 88989 V2 with comments taken into account. r=me, the Sunken state is a mess, but we can't get out of it for Qt4 anyway :/ 383143 7 88989 commit-queue 2011-04-11 06:38:15 -0700 Comment on attachment 88989 V2 with comments taken into account. Clearing flags on attachment: 88989 Committed r83437: <http://trac.webkit.org/changeset/83437> 383144 8 commit-queue 2011-04-11 06:38:22 -0700 All reviewed patches have been landed. Closing bug. 88804 2011-04-08 05:35:18 -0700 2011-04-11 04:54:45 -0700 Proposed patch. patch.diff text/plain 1472 menard ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCAwZTliYzY0Li5lMmMwYTRiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcg QEAKKzIwMTEtMDQtMDggIEFsZXhpcyBNZW5hcmQgIDxhbGV4aXMubWVuYXJkQG9wZW5ib3NzYS5v cmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW1F0 XSBSZWdyZXNzaW9uIDogcjgzMDUxIE94eWdlbidzIGxpbmVlZGl0cyBhcmUgbm90IHJlbmRlcmVk IHByb3Blcmx5CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD01ODA3NgorCisgICAgICAgIFN0YXRlX1N1bmtlbiBpcyBtb3JlIGdlbmVyaWMgdGhhbiBwcmVz c2VkLiBJdCBpcyB1c2VkIGJ5IGl0ZW1zIHN1Y2ggYXMgZnJhbWVzLgorICAgICAgICBMaW5lRWRp dCBhcmUgInN1bmtlbiIgZnJhbWVzLiBRTGluZUVkaXQgc2V0cyBpdCBmb3IgZXhhbXBsZS4gSXQg Y2FuIGJlIHJlcXVpcmVkCisgICAgICAgIGJ5IHNvbWUgc3R5bGUgbGlrZSBPeHlnZW4uCisKKyAg ICAgICAgKiBwbGF0Zm9ybS9xdC9SZW5kZXJUaGVtZVF0LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6 OlJlbmRlclRoZW1lUXQ6OnBhaW50VGV4dEZpZWxkKToKKwogMjAxMS0wNC0wOCAgQW5kcmV5IEFk YWlraW4gIDxhYW5kcmV5QGdvb2dsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgUGF2ZWwg RmVsZG1hbi4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL3F0L1JlbmRlclRo ZW1lUXQuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vcXQvUmVuZGVyVGhlbWVRdC5jcHAK aW5kZXggYzFiMWY5Yy4uY2JkMmY1MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vcXQvUmVuZGVyVGhlbWVRdC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vcXQv UmVuZGVyVGhlbWVRdC5jcHAKQEAgLTY3Myw4ICs2NzMsNyBAQCBib29sIFJlbmRlclRoZW1lUXQ6 OnBhaW50VGV4dEZpZWxkKFJlbmRlck9iamVjdCogbywgY29uc3QgUGFpbnRJbmZvJiBpLCBjb25z dCBJbgogICAgIGluaXRTdHlsZU9wdGlvbihwLndpZGdldCwgcGFuZWwpOwogICAgIHBhbmVsLnJl Y3QgPSByOwogICAgIHBhbmVsLmxpbmVXaWR0aCA9IGZpbmRGcmFtZUxpbmVXaWR0aChxU3R5bGUo KSk7Ci0gICAgaWYgKGlzUHJlc3NlZChvKSkKLSAgICAgICAgcGFuZWwuc3RhdGUgfD0gUVN0eWxl OjpTdGF0ZV9TdW5rZW47CisgICAgcGFuZWwuc3RhdGUgfD0gUVN0eWxlOjpTdGF0ZV9TdW5rZW47 CiAgICAgcGFuZWwuZmVhdHVyZXMgPSBRU3R5bGVPcHRpb25GcmFtZVYyOjpOb25lOwogCiAgICAg Ly8gR2V0IHRoZSBjb3JyZWN0IHRoZW1lIGRhdGEgZm9yIGEgdGV4dCBmaWVsZAo= 88989 2011-04-11 04:54:45 -0700 2011-04-11 06:38:15 -0700 V2 with comments taken into account. patch.diff text/plain 1601 menard ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBjNWQwN2ZlLi5mMjgwNmNmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTgg QEAKKzIwMTEtMDQtMTEgIEFsZXhpcyBNZW5hcmQgIDxhbGV4aXMubWVuYXJkQG9wZW5ib3NzYS5v cmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW1F0 XSBSZWdyZXNzaW9uIDogcjgzMDUxIE94eWdlbidzIGxpbmVlZGl0cyBhcmUgbm90IHJlbmRlcmVk IHByb3Blcmx5CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD01ODA3NgorCisgICAgICAgIFN0YXRlX1N1bmtlbiBpcyBtb3JlIGdlbmVyaWMgdGhhbiBwcmVz c2VkLiBJdCBpcyB1c2VkIGJ5IGl0ZW1zIHN1Y2ggYXMgZnJhbWVzIG9yCisgICAgICAgIGxpbmUg ZWRpdHMgYmVjYXVzZSB0aGV5IGFyZSAic3Vua2VuIiBmcmFtZXMgKGUuZy4gUUxpbmVFZGl0KS4g SXQgY2FuIGJlIHJlcXVpcmVkCisgICAgICAgIGJ5IHNvbWUgc3R5bGUgbGlrZSBPeHlnZW4uIFRo ZXJlZm9yZSBvbmx5IGluIHRoZSBtb2JpbGUgdGhlbWUgd2UgY2hlY2sgaWYgdGhlIG9iamVjdAor ICAgICAgICBpcyBwcmVzc2VkLgorCisgICAgICAgICogcGxhdGZvcm0vcXQvUmVuZGVyVGhlbWVR dC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJUaGVtZVF0OjpwYWludFRleHRGaWVsZCk6 CisKIDIwMTEtMDQtMTEgIFBhdmVsIEZlbGRtYW4gIDxwZmVsZG1hbkBjaHJvbWl1bS5vcmc+CiAK ICAgICAgICAgUmV2aWV3ZWQgYnkgWXVyeSBTZW1pa2hhdHNreS4KZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL3F0L1JlbmRlclRoZW1lUXQuY3BwIGIvU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vcXQvUmVuZGVyVGhlbWVRdC5jcHAKaW5kZXggYzFiMWY5Yy4uYTBhOTZiMyAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vcXQvUmVuZGVyVGhlbWVRdC5jcHAKKysr IGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vcXQvUmVuZGVyVGhlbWVRdC5jcHAKQEAgLTY3Myw4 ICs2NzMsMTIgQEAgYm9vbCBSZW5kZXJUaGVtZVF0OjpwYWludFRleHRGaWVsZChSZW5kZXJPYmpl Y3QqIG8sIGNvbnN0IFBhaW50SW5mbyYgaSwgY29uc3QgSW4KICAgICBpbml0U3R5bGVPcHRpb24o cC53aWRnZXQsIHBhbmVsKTsKICAgICBwYW5lbC5yZWN0ID0gcjsKICAgICBwYW5lbC5saW5lV2lk dGggPSBmaW5kRnJhbWVMaW5lV2lkdGgocVN0eWxlKCkpOworI2lmIFVTRShRVF9NT0JJTEVfVEhF TUUpCiAgICAgaWYgKGlzUHJlc3NlZChvKSkKICAgICAgICAgcGFuZWwuc3RhdGUgfD0gUVN0eWxl OjpTdGF0ZV9TdW5rZW47CisjZWxzZQorICAgIHBhbmVsLnN0YXRlIHw9IFFTdHlsZTo6U3RhdGVf U3Vua2VuOworI2VuZGlmCiAgICAgcGFuZWwuZmVhdHVyZXMgPSBRU3R5bGVPcHRpb25GcmFtZVYy OjpOb25lOwogCiAgICAgLy8gR2V0IHRoZSBjb3JyZWN0IHRoZW1lIGRhdGEgZm9yIGEgdGV4dCBm aWVsZAo=