58072 2011-04-07 13:16:13 -0700 URLs accessed as a result of pushState/replaceState should count as "visited" and be in the global history 2011-04-12 09:23:33 -0700 1 1 1 Unclassified WebKit History 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 beidson beidson kbalazs ossy sam zoltan oldest_to_newest 381613 0 beidson 2011-04-07 13:16:13 -0700 URLs accessed as a result of pushState/replaceState should count as "visited" and be in the global history See attached example, which works fine in Firefox 4 and Chrome. Chrome is likely managing it themselves, but this should be something WebKit handles internally. 381615 1 88678 beidson 2011-04-07 13:16:50 -0700 Created attachment 88678 Example showing bug (links should get visited, and should show up in Safari's history menu) 381619 2 beidson 2011-04-07 13:19:00 -0700 <rdar://problem/9251515> 383709 3 89131 beidson 2011-04-11 17:29:05 -0700 Created attachment 89131 Patch v1 383731 4 89131 mjs 2011-04-11 18:11:54 -0700 Comment on attachment 89131 Patch v1 r=me 383744 5 beidson 2011-04-11 18:28:24 -0700 http://trac.webkit.org/changeset/83547 383872 6 ossy 2011-04-12 01:17:16 -0700 The new fast/loader/stateobjects/state-url-sets-links-visited.html fails on WK2 bot: http://build.webkit.org/results/SnowLeopard%20Intel%20Release%20%28WebKit2%20Tests%29/r83558%20%2810595%29/fast/loader/stateobjects/state-url-sets-links-visited-pretty-diff.html 384019 7 beidson 2011-04-12 08:39:43 -0700 (In reply to comment #6) > The new fast/loader/stateobjects/state-url-sets-links-visited.html fails on WK2 bot: > http://build.webkit.org/results/SnowLeopard%20Intel%20Release%20%28WebKit2%20Tests%29/r83558%20%2810595%29/fast/loader/stateobjects/state-url-sets-links-visited-pretty-diff.html Interesting. Seems possible/likely that WK2 DRT doesn't do history tracking properly yet. 384043 8 beidson 2011-04-12 09:02:58 -0700 (In reply to comment #7) > (In reply to comment #6) > > The new fast/loader/stateobjects/state-url-sets-links-visited.html fails on WK2 bot: > > http://build.webkit.org/results/SnowLeopard%20Intel%20Release%20%28WebKit2%20Tests%29/r83558%20%2810595%29/fast/loader/stateobjects/state-url-sets-links-visited-pretty-diff.html > > Interesting. Seems possible/likely that WK2 DRT doesn't do history tracking properly yet. WKTR does implement all of the related APIs, but it's returning the green unvisited link style, if I throw some alerts in. I tested the patch and test manually in WK2, so I know there's nothing fundamentally wrong here. I wonder if visited links round trip through the UI process and therefore we're getting hurt by IPC? I don't know yet, still exploring. 384056 9 beidson 2011-04-12 09:23:33 -0700 (In reply to comment #8) > (In reply to comment #7) > > (In reply to comment #6) > > > The new fast/loader/stateobjects/state-url-sets-links-visited.html fails on WK2 bot: > > > http://build.webkit.org/results/SnowLeopard%20Intel%20Release%20%28WebKit2%20Tests%29/r83558%20%2810595%29/fast/loader/stateobjects/state-url-sets-links-visited-pretty-diff.html > > > > Interesting. Seems possible/likely that WK2 DRT doesn't do history tracking properly yet. > > WKTR does implement all of the related APIs, but it's returning the green unvisited link style, if I throw some alerts in. > > I tested the patch and test manually in WK2, so I know there's nothing fundamentally wrong here. I wonder if visited links round trip through the UI process and therefore we're getting hurt by IPC? I don't know yet, still exploring. Found 3 other tests that rely on the same layout test controller APIs that were already skipped. FIled https://bugs.webkit.org/show_bug.cgi?id=58334 and added this test to the skipped list. 88678 2011-04-07 13:16:50 -0700 2011-04-07 13:16:50 -0700 Example showing bug (links should get visited, and should show up in Safari's history menu) stateExample.html text/html 1133 beidson PHNjcmlwdD4KCnZhciBjb3VudGVyID0gMTsKZnVuY3Rpb24gcHVzaFN0YXRlUHJlc3NlZCgpCnsK ICAgIHdpbmRvdy5oaXN0b3J5LnB1c2hTdGF0ZShjb3VudGVyLCAiTmV3IHRpdGxlICIgKyBjb3Vu dGVyLCAibmV3VVJMIiArIGNvdW50ZXIpOwogICAgY291bnRlcisrOwp9CgpmdW5jdGlvbiByZXBs YWNlU3RhdGVQcmVzc2VkKCkKewogICAgd2luZG93Lmhpc3RvcnkucmVwbGFjZVN0YXRlKGNvdW50 ZXIsICJOZXcgdGl0bGUgIiArIGNvdW50ZXIsICJuZXdVUkwiICsgY291bnRlcik7CiAgICBjb3Vu dGVyKys7Cn0KCmZ1bmN0aW9uIHN0YXRlUG9wcGVkKGV2dCkKewogICAgYWxlcnQoIlBvcCBzdGF0 ZSBldmVudCBmaXJlZCAtICIgKyBldnQuc3RhdGUpOwp9Cgp3aW5kb3cub25wb3BzdGF0ZSA9IHN0 YXRlUG9wcGVkOwoKPC9zY3JpcHQ+Cgo8YnV0dG9uIG9uY2xpY2s9InB1c2hTdGF0ZVByZXNzZWQo KTsiPlByZXNzIHRvIHB1c2ggc3RhdGU8L2J1dHRvbj48YnI+CjxidXR0b24gb25jbGljaz0icmVw bGFjZVN0YXRlUHJlc3NlZCgpOyI+UHJlc3MgdG8gcmVwbGFjZSBzdGF0ZTwvYnV0dG9uPjxicj4K PGEgaHJlZj0iaHR0cDovL3d3dy53ZWJraXQub3JnLyI+Q2xpY2sgZm9yIHdlYmtpdCA8L2E+PGJy Pgo8YSBocmVmPSJuZXdVUkwxIj5UZXN0IHZpc2l0ZWQgVVJMPC9hPjxicj4KPGEgaHJlZj0ibmV3 VVJMMiI+VGVzdCB2aXNpdGVkIFVSTDwvYT48YnI+CjxhIGhyZWY9Im5ld1VSTDMiPlRlc3Qgdmlz aXRlZCBVUkw8L2E+PGJyPgo8YSBocmVmPSJuZXdVUkw0Ij5UZXN0IHZpc2l0ZWQgVVJMPC9hPjxi cj4KPGEgaHJlZj0ibmV3VVJMNSI+VGVzdCB2aXNpdGVkIFVSTDwvYT48YnI+CjxhIGhyZWY9Im5l d1VSTDYiPlRlc3QgdmlzaXRlZCBVUkw8L2E+PGJyPgo8YSBocmVmPSJuZXdVUkw3Ij5UZXN0IHZp c2l0ZWQgVVJMPC9hPjxicj4KPGEgaHJlZj0ibmV3VVJMOCI+VGVzdCB2aXNpdGVkIFVSTDwvYT48 YnI+CjxhIGhyZWY9Im5ld1VSTDkiPlRlc3QgdmlzaXRlZCBVUkw8L2E+PGJyPgo8YSBocmVmPSJu ZXdVUkwxMCI+VGVzdCB2aXNpdGVkIFVSTDwvYT48YnI+CjxhIGhyZWY9InN0YXRlRXhhbXBsZS5o dG1sIiBpZD0iIiB0aXRsZT0ic3RhdGVFeGFtcGxlIj5zdGF0ZUV4YW1wbGU8L2E+Cgo= 89131 2011-04-11 17:29:05 -0700 2011-04-11 18:11:54 -0700 Patch v1 patch.txt text/plain 5322 beidson SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDgzNTQwKQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTEtMDQtMTEgIEJyYWR5IEVp ZHNvbiAgPGJlaWRzb25AYXBwbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS85MjUxNTE1PiBhbmQgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTU4MDcyCisgICAgICAgIFVSTHMgYWNjZXNz ZWQgYXMgYSByZXN1bHQgb2YgcHVzaFN0YXRlL3JlcGxhY2VTdGF0ZSBzaG91bGQgY291bnQgYXMg InZpc2l0ZWQiIGFuZCBiZSBpbiB0aGUgZ2xvYmFsIGhpc3RvcnkKKworICAgICAgICBUZXN0OiBm YXN0L2xvYWRlci9zdGF0ZW9iamVjdHMvc3RhdGUtdXJsLXNldHMtbGlua3MtdmlzaXRlZC5odG1s CisKKyAgICAgICAgKiBsb2FkZXIvSGlzdG9yeUNvbnRyb2xsZXIuY3BwOgorICAgICAgICAoV2Vi Q29yZTo6SGlzdG9yeUNvbnRyb2xsZXI6OnB1c2hTdGF0ZSk6IE5vdGlmeSB0aGUgaGlzdG9yeSBj bGllbnQgYW5kIGFkZCB0aGUgdmlzaXRlZCBsaW5rLgorICAgICAgICAoV2ViQ29yZTo6SGlzdG9y eUNvbnRyb2xsZXI6OnJlcGxhY2VTdGF0ZSk6IERpdHRvLgorCiAyMDExLTA0LTExICBSeW9zdWtl IE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgogCiAgICAgICAgIFVucmV2aWV3ZWQsIHJvbGxpbmcg b3V0IHI4MzUxNS4KSW5kZXg6IFNvdXJjZS9XZWJDb3JlL2xvYWRlci9IaXN0b3J5Q29udHJvbGxl ci5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvbG9hZGVyL0hpc3RvcnlDb250cm9s bGVyLmNwcAkocmV2aXNpb24gODM1MzkpCisrKyBTb3VyY2UvV2ViQ29yZS9sb2FkZXIvSGlzdG9y eUNvbnRyb2xsZXIuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC03OTksNiArNzk5LDEwIEBAIHZvaWQg SGlzdG9yeUNvbnRyb2xsZXI6OnB1c2hTdGF0ZShQYXNzUmUKICAgICBtX2N1cnJlbnRJdGVtLT5z ZXRVUkxTdHJpbmcodXJsU3RyaW5nKTsKIAogICAgIHBhZ2UtPmJhY2tGb3J3YXJkKCktPmFkZEl0 ZW0odG9wSXRlbS5yZWxlYXNlKCkpOworCisgICAgYWRkVmlzaXRlZExpbmsocGFnZSwgS1VSTChQ YXJzZWRVUkxTdHJpbmcsIHVybFN0cmluZykpOworICAgIG1fZnJhbWUtPmxvYWRlcigpLT5jbGll bnQoKS0+dXBkYXRlR2xvYmFsSGlzdG9yeSgpOworCiB9CiAKIHZvaWQgSGlzdG9yeUNvbnRyb2xs ZXI6OnJlcGxhY2VTdGF0ZShQYXNzUmVmUHRyPFNlcmlhbGl6ZWRTY3JpcHRWYWx1ZT4gc3RhdGVP YmplY3QsIGNvbnN0IFN0cmluZyYgdGl0bGUsIGNvbnN0IFN0cmluZyYgdXJsU3RyaW5nKQpAQCAt ODEwLDYgKzgxNCwxMCBAQCB2b2lkIEhpc3RvcnlDb250cm9sbGVyOjpyZXBsYWNlU3RhdGUoUGFz CiAgICAgICAgIG1fY3VycmVudEl0ZW0tPnNldFVSTFN0cmluZyh1cmxTdHJpbmcpOwogICAgIG1f Y3VycmVudEl0ZW0tPnNldFRpdGxlKHRpdGxlKTsKICAgICBtX2N1cnJlbnRJdGVtLT5zZXRTdGF0 ZU9iamVjdChzdGF0ZU9iamVjdCk7CisKKyAgICBBU1NFUlQobV9mcmFtZS0+cGFnZSgpKTsKKyAg ICBhZGRWaXNpdGVkTGluayhtX2ZyYW1lLT5wYWdlKCksIEtVUkwoUGFyc2VkVVJMU3RyaW5nLCB1 cmxTdHJpbmcpKTsKKyAgICBtX2ZyYW1lLT5sb2FkZXIoKS0+Y2xpZW50KCktPnVwZGF0ZUdsb2Jh bEhpc3RvcnkoKTsKIH0KIAogfSAvLyBuYW1lc3BhY2UgV2ViQ29yZQpJbmRleDogTGF5b3V0VGVz dHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL0NoYW5nZUxvZwkocmV2aXNp b24gODM1NDApCisrKyBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEs MyArMSwxMyBAQAorMjAxMS0wNC0xMSAgQnJhZHkgRWlkc29uICA8YmVpZHNvbkBhcHBsZS5jb20+ CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgPHJkYXI6 Ly9wcm9ibGVtLzkyNTE1MTU+IGFuZCBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9NTgwNzIKKyAgICAgICAgVVJMcyBhY2Nlc3NlZCBhcyBhIHJlc3VsdCBvZiBwdXNoU3Rh dGUvcmVwbGFjZVN0YXRlIHNob3VsZCBjb3VudCBhcyAidmlzaXRlZCIgYW5kIGJlIGluIHRoZSBn bG9iYWwgaGlzdG9yeQorCisgICAgICAgICogZmFzdC9sb2FkZXIvc3RhdGVvYmplY3RzL3N0YXRl LXVybC1zZXRzLWxpbmtzLXZpc2l0ZWQtZXhwZWN0ZWQudHh0OiBBZGRlZC4KKyAgICAgICAgKiBm YXN0L2xvYWRlci9zdGF0ZW9iamVjdHMvc3RhdGUtdXJsLXNldHMtbGlua3MtdmlzaXRlZC5odG1s OiBBZGRlZC4KKwogMjAxMS0wNC0xMSAgSmlhbiBMaSAgPGppYW5saUBjaHJvbWl1bS5vcmc+CiAK ICAgICAgICAgVW5yZXZpZXdlZCwgdXBkYXRlIGNocm9taXVtIHRlc3QgZXhwZWN0YXRpb25zLgpJ bmRleDogTGF5b3V0VGVzdHMvZmFzdC9sb2FkZXIvc3RhdGVvYmplY3RzL3N0YXRlLXVybC1zZXRz LWxpbmtzLXZpc2l0ZWQtZXhwZWN0ZWQudHh0Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2Zh c3QvbG9hZGVyL3N0YXRlb2JqZWN0cy9zdGF0ZS11cmwtc2V0cy1saW5rcy12aXNpdGVkLWV4cGVj dGVkLnR4dAkocmV2aXNpb24gMCkKKysrIExheW91dFRlc3RzL2Zhc3QvbG9hZGVyL3N0YXRlb2Jq ZWN0cy9zdGF0ZS11cmwtc2V0cy1saW5rcy12aXNpdGVkLWV4cGVjdGVkLnR4dAkocmV2aXNpb24g MCkKQEAgLTAsMCArMSw1IEBACitUaGlzIGxpbmsgc2hvdWxkIGdldCBjb2xvcmVkIHZpc2l0ZWQg YXMgYSByZXN1bHQgb2YgcmVwbGFjZVN0YXRlKCkgc2V0dGluZyBpdCBhcyB0aGUgY3VycmVudCBV UkwKK1RoaXMgbGluayBzaG91bGQgZ2V0IGNvbG9yZWQgdmlzaXRlZCBhcyBhIHJlc3VsdCBvZiBw dXNoU3RhdGUoKSBhZGRpbmcgaXQgdG8gdGhlIGZvcndhcmQgbGlzdAorSWYgeW91J3JlIHJ1bm5p bmcgaW4gYSBicm93c2VyLCB0aGUgbGluayBzaG91bGQgYmUgb3JhbmdlLW9uLWJsYWNrIGFuZCB5 b3Ugc2hvdWxkIHNlZSAicmVwbGFjZWRVUkwuaHRtbCIgaW4geW91ciBnbG9iYWwgaGlzdG9yeS4K K0lmIHlvdSdyZSBydW5uaW5nIGluIERSVCwgdGhlIHRlc3Qgd2lsbCBhbHNvIGFwcGVuZCAiUEFT UyIgb3IgIkZBSUwiLgorUEFTUwpJbmRleDogTGF5b3V0VGVzdHMvZmFzdC9sb2FkZXIvc3RhdGVv YmplY3RzL3N0YXRlLXVybC1zZXRzLWxpbmtzLXZpc2l0ZWQuaHRtbAo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBM YXlvdXRUZXN0cy9mYXN0L2xvYWRlci9zdGF0ZW9iamVjdHMvc3RhdGUtdXJsLXNldHMtbGlua3Mt dmlzaXRlZC5odG1sCShyZXZpc2lvbiAwKQorKysgTGF5b3V0VGVzdHMvZmFzdC9sb2FkZXIvc3Rh dGVvYmplY3RzL3N0YXRlLXVybC1zZXRzLWxpbmtzLXZpc2l0ZWQuaHRtbAkocmV2aXNpb24gMCkK QEAgLTAsMCArMSwzNyBAQAorPHNjcmlwdD4KKworaWYgKHdpbmRvdy5sYXlvdXRUZXN0Q29udHJv bGxlcikgeworICAgIGxheW91dFRlc3RDb250cm9sbGVyLmtlZXBXZWJIaXN0b3J5KCk7CisgICAg bGF5b3V0VGVzdENvbnRyb2xsZXIuZHVtcEFzVGV4dCgpOworfQorCitmdW5jdGlvbiBsb2FkZWQo KQoreworICAgIHdpbmRvdy5oaXN0b3J5LnJlcGxhY2VTdGF0ZShudWxsLCAiVGl0bGUiLCAicmVw bGFjZWRVUkwuaHRtbCIpOworICAgIHdpbmRvdy5oaXN0b3J5LnB1c2hTdGF0ZShudWxsLCAiVGl0 bGUiLCAicHVzaGVkVVJMLmh0bWwiKTsKKworICAgIGlmICh3aW5kb3cubGF5b3V0VGVzdENvbnRy b2xsZXIpIHsKKyAgICAgICAgdmFyIHN0eWxlMSA9IHdpbmRvdy5sYXlvdXRUZXN0Q29udHJvbGxl ci5jb21wdXRlZFN0eWxlSW5jbHVkaW5nVmlzaXRlZEluZm8oZG9jdW1lbnQuZ2V0RWxlbWVudEJ5 SWQoJ2xpbmsxJykpOworICAgICAgICB2YXIgc3R5bGUyID0gd2luZG93LmxheW91dFRlc3RDb250 cm9sbGVyLmNvbXB1dGVkU3R5bGVJbmNsdWRpbmdWaXNpdGVkSW5mbyhkb2N1bWVudC5nZXRFbGVt ZW50QnlJZCgnbGluazInKSk7CisgICAgICAgIHZhciByZXN1bHQgPSBkb2N1bWVudC5jcmVhdGVF bGVtZW50KCJwIik7CisgICAgICAgIGlmIChzdHlsZTEuY29sb3IgIT0gInJnYigyNTUsIDE2NSwg MCkiIHx8IHN0eWxlMi5jb2xvciAhPSAicmdiKDI1NSwgMTY1LCAwKSIpCisgICAgICAgICAgICBy ZXN1bHQuaW5uZXJUZXh0ID0gIkZBSUwiOworICAgICAgICBlbHNlCisgICAgICAgICAgICByZXN1 bHQuaW5uZXJUZXh0ID0gIlBBU1MiOworICAgICAgICBkb2N1bWVudC5ib2R5LmFwcGVuZENoaWxk KHJlc3VsdCk7CisgICAgfQorfQorCis8L3NjcmlwdD4KKworPHN0eWxlPgorOmxpbmsgeyBjb2xv cjogcmdiKDAsIDI1NSwgMCk7IGJhY2tncm91bmQtY29sb3I6IHdoaXRlIH0KKzp2aXNpdGVkIHsg Y29sb3I6IHJnYigyNTUsIDE2NSwgMCk7IGJhY2tncm91bmQtY29sb3I6IGJsYWNrIH0KKzwvc3R5 bGU+CisKKzxib2R5IG9ubG9hZD0ibG9hZGVkKCk7Ij4KKzxhIGlkPSJsaW5rMSIgaHJlZj0icmVw bGFjZWRVUkwuaHRtbCI+VGhpcyBsaW5rIHNob3VsZCBnZXQgY29sb3JlZCB2aXNpdGVkIGFzIGEg cmVzdWx0IG9mIHJlcGxhY2VTdGF0ZSgpIHNldHRpbmcgaXQgYXMgdGhlIGN1cnJlbnQgVVJMPC9h Pjxicj4KKzxhIGlkPSJsaW5rMiIgaHJlZj0icHVzaGVkVVJMLmh0bWwiPlRoaXMgbGluayBzaG91 bGQgZ2V0IGNvbG9yZWQgdmlzaXRlZCBhcyBhIHJlc3VsdCBvZiBwdXNoU3RhdGUoKSBhZGRpbmcg aXQgdG8gdGhlIGZvcndhcmQgbGlzdDwvYT48YnI+CitJZiB5b3UncmUgcnVubmluZyBpbiBhIGJy b3dzZXIsIHRoZSBsaW5rIHNob3VsZCBiZSBvcmFuZ2Utb24tYmxhY2sgYW5kIHlvdSBzaG91bGQg c2VlICJyZXBsYWNlZFVSTC5odG1sIiBpbiB5b3VyIGdsb2JhbCBoaXN0b3J5Ljxicj4KK0lmIHlv dSdyZSBydW5uaW5nIGluIERSVCwgdGhlIHRlc3Qgd2lsbCBhbHNvIGFwcGVuZCAiUEFTUyIgb3Ig IkZBSUwiLjxicj4KKzwvYm9keT4K