58071 2011-04-07 13:06:02 -0700 WebKit2: Web Inspector's style sidebar fails to display when inspecting element 2011-04-25 16:36:49 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 eoconnor bweinstein apavlov bweinstein joepeck keishi loislo pfeldman pmuellr rik timothy webkit.review.bot yurys oldest_to_newest 381604 0 eoconnor 2011-04-07 13:06:02 -0700 Launch the Web Inspector via the "Inspect Element" context menu item. The element is correctly selected in the DOM tree displayed on the Elements tab, but the style sidebar is missing. Clicking on one of the other Web Inspector tabs (Resources, say), then return to the Elements tab, fixes the problem. 381605 1 eoconnor 2011-04-07 13:06:29 -0700 <rdar://problem/9243093> 382082 2 apavlov 2011-04-08 02:02:35 -0700 Thanks for the report, Edward, I'm having hard time reproducing the issue and thus need some clarification. - Was it a fresh installation of Safari (== there are no settings/preferences stored) where the issue occurred? - Was the console opened when the Web Inspector contents were constructed? - Did you by chance have the local store disabled in the browser? - Can you consistently reproduce the issue (you see no sidebar, fix the sidebar width to be non-zero, close and re-open the Web Inspector, and the issue is there again)? - Which platform(s) did you see the issue on? 386697 3 eoconnor 2011-04-15 09:58:43 -0700 Ahh, sorry, this looks like a WK2 regression. 391994 4 90978 bweinstein 2011-04-25 16:07:36 -0700 Created attachment 90978 [PATCH] Fix 391999 5 webkit.review.bot 2011-04-25 16:08:44 -0700 Attachment 90978 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit..." exit_code: 1 Source/WebKit2/UIProcess/win/WebInspectorProxyWin.cpp:190: Missing space after , [whitespace/comma] [3] Total errors found: 1 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style. 392016 6 bweinstein 2011-04-25 16:13:07 -0700 Landed in r84824. 392073 7 91008 bweinstein 2011-04-25 16:35:05 -0700 Created attachment 91008 [PATCH] Fix v2 90978 2011-04-25 16:07:36 -0700 2011-04-25 16:35:05 -0700 [PATCH] Fix inspector_sidebar.patch text/plain 2799 bweinstein SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDg0ODIwKQorKysgU291cmNlL1dlYktpdDIvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjEgQEAKKzIwMTEtMDQtMjUgIEJyaWFuIFdl aW5zdGVpbiAgPGJ3ZWluc3RlaW5AYXBwbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIFdlYktpdDI6IFdlYiBJbnNwZWN0b3IncyBzdHlsZSBz aWRlYmFyIGZhaWxzIHRvIGRpc3BsYXkgd2hlbiBpbnNwZWN0aW5nIGVsZW1lbnQKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTU4MDcxCisgICAgICAgIDxy ZGFyOi8vcHJvYmxlbS85MjQzMDkzPgorICAgICAgICAKKyAgICAgICAgV2hlbiBjcmVhdGluZyBv dXIgV2ViS2l0MiBpbnNwZWN0b3Igdmlld3MsIHdlIHdlcmUgY3JlYXRpbmcgdGhlbSBvbiBib3Ro IE1hYyBhbmQgV2luZG93cworICAgICAgICB3aXRoIHRoZSBlbXB0eSByZWN0IGZvciB0aGVpciBp bml0aWFsIHNpemUuIEJlZm9yZSB3ZSBzaXplZCB0aGVtIGNvcnJlY3RseSwgdGhlIGluc3BlY3Rv cgorICAgICAgICB3YXMgY2FsbGluZyB3aW5kb3cuaW5uZXJXaWR0aCBvbiB0aGVtLCB3aGljaCBy ZXR1cm5lZCAwLCBtYWtpbmcgdGhlIHNpZGViYXIgdGFrZSB1cCAwIHBpeGVscy4KKworICAgICAg ICAqIFVJUHJvY2Vzcy9tYWMvV2ViSW5zcGVjdG9yUHJveHlNYWMubW06CisgICAgICAgIChXZWJL aXQ6OldlYkluc3BlY3RvclByb3h5OjpwbGF0Zm9ybUNyZWF0ZUluc3BlY3RvclBhZ2UpOiBDcmVh dGUgdGhlIHdpbmRvdyB3aXRoIHRoZSBpbml0aWFsIHdpbmRvdyB3aWR0aAorICAgICAgICAgICAg YW5kIGhlaWdodC4KKyAgICAgICAgKiBVSVByb2Nlc3Mvd2luL1dlYkluc3BlY3RvclByb3h5V2lu LmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2ViSW5zcGVjdG9yUHJveHk6OnBsYXRmb3JtQ3JlYXRl SW5zcGVjdG9yUGFnZSk6IERpdHRvLgorCiAyMDExLTA0LTI1ICBCcmlhbiBXZWluc3RlaW4gIDxi d2VpbnN0ZWluQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBBZGFtIFJvYmVuLgpJ bmRleDogU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL21hYy9XZWJJbnNwZWN0b3JQcm94eU1hYy5t bQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvbWFjL1dlYkluc3BlY3Rv clByb3h5TWFjLm1tCShyZXZpc2lvbiA4NDc4NSkKKysrIFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vz cy9tYWMvV2ViSW5zcGVjdG9yUHJveHlNYWMubW0JKHdvcmtpbmcgY29weSkKQEAgLTgyLDcgKzgy LDcgQEAgV2ViUGFnZVByb3h5KiBXZWJJbnNwZWN0b3JQcm94eTo6cGxhdGZvcgogICAgIEFTU0VS VChtX3BhZ2UpOwogICAgIEFTU0VSVCghbV9pbnNwZWN0b3JWaWV3KTsKIAotICAgIG1faW5zcGVj dG9yVmlldy5hZG9wdE5TKFtbV0tWaWV3IGFsbG9jXSBpbml0V2l0aEZyYW1lOk5TWmVyb1JlY3Qg Y29udGV4dFJlZjp0b0FQSShwYWdlKCktPnByb2Nlc3MoKS0+Y29udGV4dCgpKSBwYWdlR3JvdXBS ZWY6dG9BUEkoaW5zcGVjdG9yUGFnZUdyb3VwKCkpXSk7CisgICAgbV9pbnNwZWN0b3JWaWV3LmFk b3B0TlMoW1tXS1ZpZXcgYWxsb2NdIGluaXRXaXRoRnJhbWU6TlNNYWtlUmVjdCgwLCAwLCBpbml0 aWFsV2luZG93V2lkdGgsIGluaXRpYWxXaW5kb3dIZWlnaHQpIGNvbnRleHRSZWY6dG9BUEkocGFn ZSgpLT5wcm9jZXNzKCktPmNvbnRleHQoKSkgcGFnZUdyb3VwUmVmOnRvQVBJKGluc3BlY3RvclBh Z2VHcm91cCgpKV0pOwogICAgIEFTU0VSVChtX2luc3BlY3RvclZpZXcpOwogCiAgICAgW21faW5z cGVjdG9yVmlldy5nZXQoKSBzZXREcmF3c0JhY2tncm91bmQ6Tk9dOwpJbmRleDogU291cmNlL1dl YktpdDIvVUlQcm9jZXNzL3dpbi9XZWJJbnNwZWN0b3JQcm94eVdpbi5jcHAKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL3dpbi9XZWJJbnNwZWN0b3JQcm94eVdpbi5jcHAJ KHJldmlzaW9uIDg0Nzg1KQorKysgU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL3dpbi9XZWJJbnNw ZWN0b3JQcm94eVdpbi5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTE4Nyw4ICsxODcsOCBAQCBXZWJQ YWdlUHJveHkqIFdlYkluc3BlY3RvclByb3h5OjpwbGF0Zm9yCiAgICAgQVNTRVJUKCFtX2luc3Bl Y3RvclZpZXcpOwogICAgIEFTU0VSVCghbV9pbnNwZWN0b3JXaW5kb3cpOwogCi0gICAgUkVDVCBl bXB0eVJlY3QgPSB7IDAgfTsKLSAgICBtX2luc3BlY3RvclZpZXcgPSBXZWJWaWV3OjpjcmVhdGUo ZW1wdHlSZWN0LCBtX3BhZ2UtPnByb2Nlc3MoKS0+Y29udGV4dCgpLCBpbnNwZWN0b3JQYWdlR3Jv dXAoKSwgMCk7CisgICAgUkVDVCBpbml0aWFsUmVjdCA9IHsgMCwgMCwgaW5pdGlhbFdpbmRvd1dp ZHRoLGluaXRpYWxXaW5kb3dIZWlnaHQgfTsKKyAgICBtX2luc3BlY3RvclZpZXcgPSBXZWJWaWV3 OjpjcmVhdGUoaW5pdGlhbFJlY3QsIG1fcGFnZS0+cHJvY2VzcygpLT5jb250ZXh0KCksIGluc3Bl Y3RvclBhZ2VHcm91cCgpLCAwKTsKIAogICAgIHJldHVybiBtX2luc3BlY3RvclZpZXctPnBhZ2Uo KTsKIH0K 91008 2011-04-25 16:35:05 -0700 2011-04-25 16:36:49 -0700 [PATCH] Fix v2 dev_extras_inspector.patch text/plain 1963 bweinstein SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDg0ODI0KQorKysgU291cmNlL1dlYktpdDIvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTEtMDQtMjUgIEJyaWFuIFdl aW5zdGVpbiAgPGJ3ZWluc3RlaW5AYXBwbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIFdlYktpdDI6IFNob3VsZCBiZSBhYmxlIHRvIGluc3Bl Y3QgV2ViIEluc3BlY3RvciBpbiBEZWJ1ZyBCdWlsZHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTU5Mzc4CisKKyAgICAgICAgKiBVSVByb2Nlc3MvV2Vi SW5zcGVjdG9yUHJveHkuY3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJJbnNwZWN0b3JQcm94eTo6 Y3JlYXRlSW5zcGVjdG9yUGFnZUdyb3VwKTogQ3JlYXRlcyBhbiBpbnNwZWN0b3IgcGFnZSBncm91 cCBhbmQgZW5hYmxlcworICAgICAgICAgICAgZGV2ZWxvcGVyIGV4dHJhcyBpbiBhIGRlYnVnIGJ1 aWxkLgorICAgICAgICAoV2ViS2l0OjpXZWJJbnNwZWN0b3JQcm94eTo6aW5zcGVjdG9yUGFnZUdy b3VwKTogQ2FsbHMgY3JlYXRlSW5zcGVjdG9yUGFnZUdyb3VwLgorCiAyMDExLTA0LTI1ICBCcmlh biBXZWluc3RlaW4gIDxid2VpbnN0ZWluQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBi eSBUaW1vdGh5IEhhdGNoZXIuCkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvV2ViSW5z cGVjdG9yUHJveHkuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9X ZWJJbnNwZWN0b3JQcm94eS5jcHAJKHJldmlzaW9uIDg0Nzg1KQorKysgU291cmNlL1dlYktpdDIv VUlQcm9jZXNzL1dlYkluc3BlY3RvclByb3h5LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMzEsNiAr MzEsNyBAQAogI2luY2x1ZGUgIldlYkluc3BlY3Rvck1lc3NhZ2VzLmgiCiAjaW5jbHVkZSAiV2Vi UGFnZVByb3h5LmgiCiAjaW5jbHVkZSAiV2ViUGFnZUNyZWF0aW9uUGFyYW1ldGVycy5oIgorI2lu Y2x1ZGUgIldlYlByZWZlcmVuY2VzLmgiCiAjaW5jbHVkZSAiV2ViUHJvY2Vzc1Byb3h5LmgiCiAj aW5jbHVkZSAiV2ViUGFnZUdyb3VwLmgiCiAKQEAgLTQ0LDkgKzQ1LDIxIEBAIHVzaW5nIG5hbWVz cGFjZSBXZWJDb3JlOwogCiBuYW1lc3BhY2UgV2ViS2l0IHsKIAorc3RhdGljIFdlYlBhZ2VHcm91 cCogY3JlYXRlSW5zcGVjdG9yUGFnZUdyb3VwKCkKK3sKKyAgICBXZWJQYWdlR3JvdXAqIHBhZ2VH cm91cCA9IFdlYlBhZ2VHcm91cDo6Y3JlYXRlKCJfX1dlYkluc3BlY3RvclBhZ2VHcm91cF9fIiwg ZmFsc2UsIGZhbHNlKS5sZWFrUmVmKCk7CisKKyNpZm5kZWYgTkRFQlVHCisgICAgLy8gQWxsb3cg ZGV2ZWxvcGVycyB0byBpbnNwZWN0IHRoZSBXZWIgSW5zcGVjdG9yIGluIGRlYnVnIGJ1aWxkcy4K KyAgICBwYWdlR3JvdXAtPnByZWZlcmVuY2VzKCktPnNldERldmVsb3BlckV4dHJhc0VuYWJsZWQo dHJ1ZSk7CisjZW5kaWYKKworICAgIHJldHVybiBwYWdlR3JvdXA7Cit9CisKIFdlYlBhZ2VHcm91 cCogV2ViSW5zcGVjdG9yUHJveHk6Omluc3BlY3RvclBhZ2VHcm91cCgpCiB7Ci0gICAgc3RhdGlj IFdlYlBhZ2VHcm91cCogcGFnZUdyb3VwID0gV2ViUGFnZUdyb3VwOjpjcmVhdGUoIl9fV2ViSW5z cGVjdG9yUGFnZUdyb3VwX18iLCBmYWxzZSwgZmFsc2UpLmxlYWtSZWYoKTsKKyAgICBzdGF0aWMg V2ViUGFnZUdyb3VwKiBwYWdlR3JvdXAgPSBjcmVhdGVJbnNwZWN0b3JQYWdlR3JvdXAoKTsKICAg ICByZXR1cm4gcGFnZUdyb3VwOwogfQogCg==