<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>58070</bug_id>
          
          <creation_ts>2011-04-07 12:40:26 -0700</creation_ts>
          <short_desc>HTMLVideoElement::webkitEnterFullscreen does not use new Full Screen API when available.</short_desc>
          <delta_ts>2011-04-07 15:38:51 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Media</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Other</rep_platform>
          <op_sys>OS X 10.5</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Jer Noble">jer.noble</reporter>
          <assigned_to name="Jer Noble">jer.noble</assigned_to>
          <cc>abarth</cc>
    
    <cc>dglazkov</cc>
    
    <cc>eric</cc>
    
    <cc>webkit.review.bot</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>381582</commentid>
    <comment_count>0</comment_count>
    <who name="Jer Noble">jer.noble</who>
    <bug_when>2011-04-07 12:40:26 -0700</bug_when>
    <thetext>HTMLVideoElement::webkitEnterFullscreen does not use new Full Screen API when available.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>381583</commentid>
    <comment_count>1</comment_count>
    <who name="Jer Noble">jer.noble</who>
    <bug_when>2011-04-07 12:41:09 -0700</bug_when>
    <thetext>&lt;rdar://problem/9251239&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>381587</commentid>
    <comment_count>2</comment_count>
      <attachid>88674</attachid>
    <who name="Jer Noble">jer.noble</who>
    <bug_when>2011-04-07 12:45:20 -0700</bug_when>
    <thetext>Created attachment 88674
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>381592</commentid>
    <comment_count>3</comment_count>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2011-04-07 12:53:12 -0700</bug_when>
    <thetext>Attachment 88674 did not build on chromium:
Build output: http://queues.webkit.org/results/8346689</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>381599</commentid>
    <comment_count>4</comment_count>
      <attachid>88674</attachid>
    <who name="Jer Noble">jer.noble</who>
    <bug_when>2011-04-07 13:01:17 -0700</bug_when>
    <thetext>Comment on attachment 88674
Patch

Patch seems to be missing bits and pieces.  Will re-upload.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>381609</commentid>
    <comment_count>5</comment_count>
      <attachid>88676</attachid>
    <who name="Jer Noble">jer.noble</who>
    <bug_when>2011-04-07 13:12:26 -0700</bug_when>
    <thetext>Created attachment 88676
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>381611</commentid>
    <comment_count>6</comment_count>
      <attachid>88676</attachid>
    <who name="Dimitri Glazkov (Google)">dglazkov</who>
    <bug_when>2011-04-07 13:14:14 -0700</bug_when>
    <thetext>Comment on attachment 88676
Patch

Why are these wired differently from the MediaControlFullscreenButton? Shouldn&apos;t we use the same codepaths?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>381618</commentid>
    <comment_count>7</comment_count>
    <who name="Jer Noble">jer.noble</who>
    <bug_when>2011-04-07 13:18:28 -0700</bug_when>
    <thetext>(In reply to comment #6)
&gt; (From update of attachment 88676 [details])
&gt; Why are these wired differently from the MediaControlFullscreenButton? Shouldn&apos;t we use the same code paths?

Good point.  I should check to make sure the settings are enabled first.  Thanks!</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>381628</commentid>
    <comment_count>8</comment_count>
    <who name="Dimitri Glazkov (Google)">dglazkov</who>
    <bug_when>2011-04-07 13:26:07 -0700</bug_when>
    <thetext>(In reply to comment #7)
&gt; (In reply to comment #6)
&gt; &gt; (From update of attachment 88676 [details] [details])
&gt; &gt; Why are these wired differently from the MediaControlFullscreenButton? Shouldn&apos;t we use the same code paths?
&gt; 
&gt; Good point.  I should check to make sure the settings are enabled first.  Thanks!

No worries -- I was just looking at this code :). Sounds like ideally, the code from here: http://codesearch.google.com/codesearch/p#OAMlx_jo-ck/src/third_party/WebKit/Source/WebCore/rendering/MediaControlElements.cpp&amp;l=950&amp;exact_package=chromium

should just migrate to enterFullScreen.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>381629</commentid>
    <comment_count>9</comment_count>
      <attachid>88681</attachid>
    <who name="Jer Noble">jer.noble</who>
    <bug_when>2011-04-07 13:26:30 -0700</bug_when>
    <thetext>Created attachment 88681
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>381632</commentid>
    <comment_count>10</comment_count>
      <attachid>88681</attachid>
    <who name="Dimitri Glazkov (Google)">dglazkov</who>
    <bug_when>2011-04-07 13:28:47 -0700</bug_when>
    <thetext>Comment on attachment 88681
Patch

Can we also eliminate the same code here: http://codesearch.google.com/codesearch/p#OAMlx_jo-ck/src/third_party/WebKit/Source/WebCore/rendering/MediaControlElements.cpp&amp;l=950&amp;exact_package=chromium</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>381640</commentid>
    <comment_count>11</comment_count>
    <who name="Jer Noble">jer.noble</who>
    <bug_when>2011-04-07 13:35:42 -0700</bug_when>
    <thetext>Indeed, that would be ideal.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>381683</commentid>
    <comment_count>12</comment_count>
      <attachid>88681</attachid>
    <who name="Eric Carlson">eric.carlson</who>
    <bug_when>2011-04-07 14:04:36 -0700</bug_when>
    <thetext>Comment on attachment 88681
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=88681&amp;action=review

&gt; Source/WebCore/html/HTMLMediaElement.cpp:2464
&gt; +#if ENABLE(FULLSCREEN_API)
&gt; +    if (document()-&gt;settings() &amp;&amp; document()-&gt;settings()-&gt;fullScreenEnabled()) {
&gt; +        webkitRequestFullScreen(0);
&gt; +        return;
&gt; +    }
&gt; +#else
&gt;      ASSERT(!m_isFullscreen);
&gt;      m_isFullscreen = true;
&gt;      if (document() &amp;&amp; document()-&gt;page()) {
&gt; +
&gt;          document()-&gt;page()-&gt;chrome()-&gt;client()-&gt;enterFullscreenForNode(this);
&gt;          scheduleEvent(eventNames().webkitbeginfullscreenEvent);
&gt;      }
&gt; +#endif

There isn&apos;t any need for the #else ... #endif, we want to continue to support the old API even when ENABLE_FULLSCREEN_API is defined.

&gt; Source/WebCore/html/HTMLMediaElement.cpp:2475
&gt; +#if ENABLE(FULLSCREEN_API)
&gt; +    if (document()-&gt;settings() &amp;&amp; document()-&gt;settings()-&gt;fullScreenEnabled()) {
&gt; +        document()-&gt;webkitCancelFullScreen();
&gt; +        return;
&gt; +    }
&gt; +#else

Same here.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>381690</commentid>
    <comment_count>13</comment_count>
    <who name="Jer Noble">jer.noble</who>
    <bug_when>2011-04-07 14:12:26 -0700</bug_when>
    <thetext>Committed r83208: &lt;http://trac.webkit.org/changeset/83208&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>381728</commentid>
    <comment_count>14</comment_count>
    <who name="Dimitri Glazkov (Google)">dglazkov</who>
    <bug_when>2011-04-07 14:44:43 -0700</bug_when>
    <thetext>(In reply to comment #13)
&gt; Committed r83208: &lt;http://trac.webkit.org/changeset/83208&gt;

Whoops. Don&apos;t you do this twice now, since MediaControlFullscreenButtonElement::defaultEventHandler calls enterFullScreen?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>381754</commentid>
    <comment_count>15</comment_count>
    <who name="Jer Noble">jer.noble</who>
    <bug_when>2011-04-07 15:01:06 -0700</bug_when>
    <thetext>(In reply to comment #14)
&gt; (In reply to comment #13)
&gt; &gt; Committed r83208: &lt;http://trac.webkit.org/changeset/83208&gt;
&gt; 
&gt; Whoops. Don&apos;t you do this twice now, since MediaControlFullscreenButtonElement::defaultEventHandler calls enterFullScreen?

I filed bug #58087 to get rid of the duplicated code.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>381792</commentid>
    <comment_count>16</comment_count>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2011-04-07 15:38:51 -0700</bug_when>
    <thetext>http://trac.webkit.org/changeset/83208 might have broken SnowLeopard Intel Release (Tests), GTK Linux 32-bit Release, and GTK Linux 64-bit Debug
The following tests are not passing:
media/context-menu-actions.html
media/media-fullscreen-inline.html
media/media-fullscreen-not-in-document.html</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>88674</attachid>
            <date>2011-04-07 12:45:20 -0700</date>
            <delta_ts>2011-04-07 13:01:17 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-58070-20110407124519.patch</filename>
            <type>text/plain</type>
            <size>2206</size>
            <attacher name="Jer Noble">jer.noble</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogODMxOTUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No
YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCA1OTdiM2U5ZTUxYmMyYWFk
OWU5ZGNmZThjZjE0NjI5MzcwYzhjMmVlLi40YjQxODA2YTk5MGQ4OTAyY2Y5ZTRmOTE5OWZkYjM5
ZTZjYTlhNDdiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291
cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTEtMDQtMDcgIEplciBO
b2JsZSAgPGplci5ub2JsZUBhcHBsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ
IChPT1BTISkuCisKKyAgICAgICAgSFRNTFZpZGVvRWxlbWVudDo6d2Via2l0RW50ZXJGdWxsc2Ny
ZWVuIGRvZXMgbm90IHVzZSBuZXcgRnVsbCBTY3JlZW4gQVBJIHdoZW4gYXZhaWxhYmxlLgorICAg
ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTgwNzAKKworICAg
ICAgICBNYWtlIHRoZSBIVE1MTWVkaWFFbGVtZW50IGZ1bGwgc2NyZWVuIGZ1bmN0aW9ucyBjYWxs
IGludG8gdGhlIG5ldyBGdWxsIFNjcmVlbiBBUEkgd2hlbgorICAgICAgICBGVUxMU0NSRUVOX0FQ
SSBpcyBlbmFibGVkLgorCisgICAgICAgICogaHRtbC9IVE1MTWVkaWFFbGVtZW50LmNwcDoKKyAg
ICAgICAgKFdlYkNvcmU6OkhUTUxNZWRpYUVsZW1lbnQ6OmVudGVyRnVsbHNjcmVlbik6CisgICAg
ICAgIChXZWJDb3JlOjpIVE1MTWVkaWFFbGVtZW50OjpleGl0RnVsbHNjcmVlbik6CisKIDIwMTEt
MDQtMDYgIEplciBOb2JsZSAgPGplci5ub2JsZUBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3
ZWQgYnkgTWFjaWVqIFN0YWNob3dpYWsuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9odG1s
L0hUTUxNZWRpYUVsZW1lbnQuY3BwIGIvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MTWVkaWFFbGVt
ZW50LmNwcAppbmRleCA2NDI3ZTQ3ODRiMjkxZmIxYjQyNDJkMmUzOGFjZjQwYzdiZTI1NDI4Li4x
ZmY2MmViNDYwNWVkNjE5NjQzOWJjMjhkMTZhNjU1NjQ1ZmUyZWE5IDEwMDY0NAotLS0gYS9Tb3Vy
Y2UvV2ViQ29yZS9odG1sL0hUTUxNZWRpYUVsZW1lbnQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3Jl
L2h0bWwvSFRNTE1lZGlhRWxlbWVudC5jcHAKQEAgLTI0NDgsMTkgKzI0NDgsMjUgQEAgYm9vbCBI
VE1MTWVkaWFFbGVtZW50Ojppc0Z1bGxzY3JlZW4oKSBjb25zdAogdm9pZCBIVE1MTWVkaWFFbGVt
ZW50OjplbnRlckZ1bGxzY3JlZW4oKQogewogICAgIExPRyhNZWRpYSwgIkhUTUxNZWRpYUVsZW1l
bnQ6OmVudGVyRnVsbHNjcmVlbiIpOwotCisjaWYgRU5BQkxFKEZVTExTQ1JFRU5fQVBJKQorICAg
IHdlYmtpdFJlcXVlc3RGdWxsU2NyZWVuKDApOworI2Vsc2UKICAgICBBU1NFUlQoIW1faXNGdWxs
c2NyZWVuKTsKICAgICBtX2lzRnVsbHNjcmVlbiA9IHRydWU7CiAgICAgaWYgKGRvY3VtZW50KCkg
JiYgZG9jdW1lbnQoKS0+cGFnZSgpKSB7CisKICAgICAgICAgZG9jdW1lbnQoKS0+cGFnZSgpLT5j
aHJvbWUoKS0+Y2xpZW50KCktPmVudGVyRnVsbHNjcmVlbkZvck5vZGUodGhpcyk7CiAgICAgICAg
IHNjaGVkdWxlRXZlbnQoZXZlbnROYW1lcygpLndlYmtpdGJlZ2luZnVsbHNjcmVlbkV2ZW50KTsK
ICAgICB9CisjZW5kaWYKIH0KIAogdm9pZCBIVE1MTWVkaWFFbGVtZW50OjpleGl0RnVsbHNjcmVl
bigpCiB7CiAgICAgTE9HKE1lZGlhLCAiSFRNTE1lZGlhRWxlbWVudDo6ZXhpdEZ1bGxzY3JlZW4i
KTsKLQorI2lmIEVOQUJMRShGVUxMU0NSRUVOX0FQSSkKKyAgICBkb2N1bWVudCgpLT4KKyNlbHNl
CiAgICAgQVNTRVJUKG1faXNGdWxsc2NyZWVuKTsKICAgICBtX2lzRnVsbHNjcmVlbiA9IGZhbHNl
OwogICAgIGlmIChkb2N1bWVudCgpICYmIGRvY3VtZW50KCktPnBhZ2UoKSkgewpAQCAtMjQ2OSw2
ICsyNDc1LDcgQEAgdm9pZCBIVE1MTWVkaWFFbGVtZW50OjpleGl0RnVsbHNjcmVlbigpCiAgICAg
ICAgIGRvY3VtZW50KCktPnBhZ2UoKS0+Y2hyb21lKCktPmNsaWVudCgpLT5leGl0RnVsbHNjcmVl
bkZvck5vZGUodGhpcyk7CiAgICAgICAgIHNjaGVkdWxlRXZlbnQoZXZlbnROYW1lcygpLndlYmtp
dGVuZGZ1bGxzY3JlZW5FdmVudCk7CiAgICAgfQorI2VuZGlmCiB9CiAKIFBsYXRmb3JtTWVkaWEg
SFRNTE1lZGlhRWxlbWVudDo6cGxhdGZvcm1NZWRpYSgpIGNvbnN0Cg==
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>88676</attachid>
            <date>2011-04-07 13:12:26 -0700</date>
            <delta_ts>2011-04-07 13:26:27 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-58070-20110407131225.patch</filename>
            <type>text/plain</type>
            <size>2231</size>
            <attacher name="Jer Noble">jer.noble</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogODMxOTkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No
YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCA1OTdiM2U5ZTUxYmMyYWFk
OWU5ZGNmZThjZjE0NjI5MzcwYzhjMmVlLi40YjQxODA2YTk5MGQ4OTAyY2Y5ZTRmOTE5OWZkYjM5
ZTZjYTlhNDdiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291
cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTEtMDQtMDcgIEplciBO
b2JsZSAgPGplci5ub2JsZUBhcHBsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ
IChPT1BTISkuCisKKyAgICAgICAgSFRNTFZpZGVvRWxlbWVudDo6d2Via2l0RW50ZXJGdWxsc2Ny
ZWVuIGRvZXMgbm90IHVzZSBuZXcgRnVsbCBTY3JlZW4gQVBJIHdoZW4gYXZhaWxhYmxlLgorICAg
ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTgwNzAKKworICAg
ICAgICBNYWtlIHRoZSBIVE1MTWVkaWFFbGVtZW50IGZ1bGwgc2NyZWVuIGZ1bmN0aW9ucyBjYWxs
IGludG8gdGhlIG5ldyBGdWxsIFNjcmVlbiBBUEkgd2hlbgorICAgICAgICBGVUxMU0NSRUVOX0FQ
SSBpcyBlbmFibGVkLgorCisgICAgICAgICogaHRtbC9IVE1MTWVkaWFFbGVtZW50LmNwcDoKKyAg
ICAgICAgKFdlYkNvcmU6OkhUTUxNZWRpYUVsZW1lbnQ6OmVudGVyRnVsbHNjcmVlbik6CisgICAg
ICAgIChXZWJDb3JlOjpIVE1MTWVkaWFFbGVtZW50OjpleGl0RnVsbHNjcmVlbik6CisKIDIwMTEt
MDQtMDYgIEplciBOb2JsZSAgPGplci5ub2JsZUBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3
ZWQgYnkgTWFjaWVqIFN0YWNob3dpYWsuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9odG1s
L0hUTUxNZWRpYUVsZW1lbnQuY3BwIGIvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MTWVkaWFFbGVt
ZW50LmNwcAppbmRleCA2NDI3ZTQ3ODRiMjkxZmIxYjQyNDJkMmUzOGFjZjQwYzdiZTI1NDI4Li5l
MWQ1ZjA0OWVhN2MzOGJiOTZkNjcwOWZmMGZkYWYyYjc0Nzg1MTE5IDEwMDY0NAotLS0gYS9Tb3Vy
Y2UvV2ViQ29yZS9odG1sL0hUTUxNZWRpYUVsZW1lbnQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3Jl
L2h0bWwvSFRNTE1lZGlhRWxlbWVudC5jcHAKQEAgLTI0NDgsMTkgKzI0NDgsMjUgQEAgYm9vbCBI
VE1MTWVkaWFFbGVtZW50Ojppc0Z1bGxzY3JlZW4oKSBjb25zdAogdm9pZCBIVE1MTWVkaWFFbGVt
ZW50OjplbnRlckZ1bGxzY3JlZW4oKQogewogICAgIExPRyhNZWRpYSwgIkhUTUxNZWRpYUVsZW1l
bnQ6OmVudGVyRnVsbHNjcmVlbiIpOwotCisjaWYgRU5BQkxFKEZVTExTQ1JFRU5fQVBJKQorICAg
IHdlYmtpdFJlcXVlc3RGdWxsU2NyZWVuKDApOworI2Vsc2UKICAgICBBU1NFUlQoIW1faXNGdWxs
c2NyZWVuKTsKICAgICBtX2lzRnVsbHNjcmVlbiA9IHRydWU7CiAgICAgaWYgKGRvY3VtZW50KCkg
JiYgZG9jdW1lbnQoKS0+cGFnZSgpKSB7CisKICAgICAgICAgZG9jdW1lbnQoKS0+cGFnZSgpLT5j
aHJvbWUoKS0+Y2xpZW50KCktPmVudGVyRnVsbHNjcmVlbkZvck5vZGUodGhpcyk7CiAgICAgICAg
IHNjaGVkdWxlRXZlbnQoZXZlbnROYW1lcygpLndlYmtpdGJlZ2luZnVsbHNjcmVlbkV2ZW50KTsK
ICAgICB9CisjZW5kaWYKIH0KIAogdm9pZCBIVE1MTWVkaWFFbGVtZW50OjpleGl0RnVsbHNjcmVl
bigpCiB7CiAgICAgTE9HKE1lZGlhLCAiSFRNTE1lZGlhRWxlbWVudDo6ZXhpdEZ1bGxzY3JlZW4i
KTsKLQorI2lmIEVOQUJMRShGVUxMU0NSRUVOX0FQSSkKKyAgICBkb2N1bWVudCgpLT53ZWJraXRD
YW5jZWxGdWxsU2NyZWVuKCk7CisjZWxzZQogICAgIEFTU0VSVChtX2lzRnVsbHNjcmVlbik7CiAg
ICAgbV9pc0Z1bGxzY3JlZW4gPSBmYWxzZTsKICAgICBpZiAoZG9jdW1lbnQoKSAmJiBkb2N1bWVu
dCgpLT5wYWdlKCkpIHsKQEAgLTI0NjksNiArMjQ3NSw3IEBAIHZvaWQgSFRNTE1lZGlhRWxlbWVu
dDo6ZXhpdEZ1bGxzY3JlZW4oKQogICAgICAgICBkb2N1bWVudCgpLT5wYWdlKCktPmNocm9tZSgp
LT5jbGllbnQoKS0+ZXhpdEZ1bGxzY3JlZW5Gb3JOb2RlKHRoaXMpOwogICAgICAgICBzY2hlZHVs
ZUV2ZW50KGV2ZW50TmFtZXMoKS53ZWJraXRlbmRmdWxsc2NyZWVuRXZlbnQpOwogICAgIH0KKyNl
bmRpZgogfQogCiBQbGF0Zm9ybU1lZGlhIEhUTUxNZWRpYUVsZW1lbnQ6OnBsYXRmb3JtTWVkaWEo
KSBjb25zdAo=
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>88681</attachid>
            <date>2011-04-07 13:26:30 -0700</date>
            <delta_ts>2011-04-07 14:04:36 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-58070-20110407132629.patch</filename>
            <type>text/plain</type>
            <size>2451</size>
            <attacher name="Jer Noble">jer.noble</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogODMxOTkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No
YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCA1OTdiM2U5ZTUxYmMyYWFk
OWU5ZGNmZThjZjE0NjI5MzcwYzhjMmVlLi40YjQxODA2YTk5MGQ4OTAyY2Y5ZTRmOTE5OWZkYjM5
ZTZjYTlhNDdiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291
cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTEtMDQtMDcgIEplciBO
b2JsZSAgPGplci5ub2JsZUBhcHBsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ
IChPT1BTISkuCisKKyAgICAgICAgSFRNTFZpZGVvRWxlbWVudDo6d2Via2l0RW50ZXJGdWxsc2Ny
ZWVuIGRvZXMgbm90IHVzZSBuZXcgRnVsbCBTY3JlZW4gQVBJIHdoZW4gYXZhaWxhYmxlLgorICAg
ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTgwNzAKKworICAg
ICAgICBNYWtlIHRoZSBIVE1MTWVkaWFFbGVtZW50IGZ1bGwgc2NyZWVuIGZ1bmN0aW9ucyBjYWxs
IGludG8gdGhlIG5ldyBGdWxsIFNjcmVlbiBBUEkgd2hlbgorICAgICAgICBGVUxMU0NSRUVOX0FQ
SSBpcyBlbmFibGVkLgorCisgICAgICAgICogaHRtbC9IVE1MTWVkaWFFbGVtZW50LmNwcDoKKyAg
ICAgICAgKFdlYkNvcmU6OkhUTUxNZWRpYUVsZW1lbnQ6OmVudGVyRnVsbHNjcmVlbik6CisgICAg
ICAgIChXZWJDb3JlOjpIVE1MTWVkaWFFbGVtZW50OjpleGl0RnVsbHNjcmVlbik6CisKIDIwMTEt
MDQtMDYgIEplciBOb2JsZSAgPGplci5ub2JsZUBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3
ZWQgYnkgTWFjaWVqIFN0YWNob3dpYWsuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9odG1s
L0hUTUxNZWRpYUVsZW1lbnQuY3BwIGIvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MTWVkaWFFbGVt
ZW50LmNwcAppbmRleCA2NDI3ZTQ3ODRiMjkxZmIxYjQyNDJkMmUzOGFjZjQwYzdiZTI1NDI4Li42
NzMzODE5ZTI0Y2ZhODU1MDU2NDcwYTBkM2NiYWI1YmFmM2YyYWI3IDEwMDY0NAotLS0gYS9Tb3Vy
Y2UvV2ViQ29yZS9odG1sL0hUTUxNZWRpYUVsZW1lbnQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3Jl
L2h0bWwvSFRNTE1lZGlhRWxlbWVudC5jcHAKQEAgLTI0NDgsMTkgKzI0NDgsMzEgQEAgYm9vbCBI
VE1MTWVkaWFFbGVtZW50Ojppc0Z1bGxzY3JlZW4oKSBjb25zdAogdm9pZCBIVE1MTWVkaWFFbGVt
ZW50OjplbnRlckZ1bGxzY3JlZW4oKQogewogICAgIExPRyhNZWRpYSwgIkhUTUxNZWRpYUVsZW1l
bnQ6OmVudGVyRnVsbHNjcmVlbiIpOwotCisjaWYgRU5BQkxFKEZVTExTQ1JFRU5fQVBJKQorICAg
IGlmIChkb2N1bWVudCgpLT5zZXR0aW5ncygpICYmIGRvY3VtZW50KCktPnNldHRpbmdzKCktPmZ1
bGxTY3JlZW5FbmFibGVkKCkpIHsKKyAgICAgICAgd2Via2l0UmVxdWVzdEZ1bGxTY3JlZW4oMCk7
CisgICAgICAgIHJldHVybjsKKyAgICB9CisjZWxzZQogICAgIEFTU0VSVCghbV9pc0Z1bGxzY3Jl
ZW4pOwogICAgIG1faXNGdWxsc2NyZWVuID0gdHJ1ZTsKICAgICBpZiAoZG9jdW1lbnQoKSAmJiBk
b2N1bWVudCgpLT5wYWdlKCkpIHsKKwogICAgICAgICBkb2N1bWVudCgpLT5wYWdlKCktPmNocm9t
ZSgpLT5jbGllbnQoKS0+ZW50ZXJGdWxsc2NyZWVuRm9yTm9kZSh0aGlzKTsKICAgICAgICAgc2No
ZWR1bGVFdmVudChldmVudE5hbWVzKCkud2Via2l0YmVnaW5mdWxsc2NyZWVuRXZlbnQpOwogICAg
IH0KKyNlbmRpZgogfQogCiB2b2lkIEhUTUxNZWRpYUVsZW1lbnQ6OmV4aXRGdWxsc2NyZWVuKCkK
IHsKICAgICBMT0coTWVkaWEsICJIVE1MTWVkaWFFbGVtZW50OjpleGl0RnVsbHNjcmVlbiIpOwot
CisjaWYgRU5BQkxFKEZVTExTQ1JFRU5fQVBJKQorICAgIGlmIChkb2N1bWVudCgpLT5zZXR0aW5n
cygpICYmIGRvY3VtZW50KCktPnNldHRpbmdzKCktPmZ1bGxTY3JlZW5FbmFibGVkKCkpIHsKKyAg
ICAgICAgZG9jdW1lbnQoKS0+d2Via2l0Q2FuY2VsRnVsbFNjcmVlbigpOworICAgICAgICByZXR1
cm47CisgICAgfQorI2Vsc2UKICAgICBBU1NFUlQobV9pc0Z1bGxzY3JlZW4pOwogICAgIG1faXNG
dWxsc2NyZWVuID0gZmFsc2U7CiAgICAgaWYgKGRvY3VtZW50KCkgJiYgZG9jdW1lbnQoKS0+cGFn
ZSgpKSB7CkBAIC0yNDY5LDYgKzI0ODEsNyBAQCB2b2lkIEhUTUxNZWRpYUVsZW1lbnQ6OmV4aXRG
dWxsc2NyZWVuKCkKICAgICAgICAgZG9jdW1lbnQoKS0+cGFnZSgpLT5jaHJvbWUoKS0+Y2xpZW50
KCktPmV4aXRGdWxsc2NyZWVuRm9yTm9kZSh0aGlzKTsKICAgICAgICAgc2NoZWR1bGVFdmVudChl
dmVudE5hbWVzKCkud2Via2l0ZW5kZnVsbHNjcmVlbkV2ZW50KTsKICAgICB9CisjZW5kaWYKIH0K
IAogUGxhdGZvcm1NZWRpYSBIVE1MTWVkaWFFbGVtZW50OjpwbGF0Zm9ybU1lZGlhKCkgY29uc3QK
</data>
<flag name="review"
          id="81224"
          type_id="1"
          status="+"
          setter="eric.carlson"
    />
          </attachment>
      

    </bug>

</bugzilla>