58056 2011-04-07 10:04:00 -0700 REGRESSION(WebKit2): execCommand('undo') doesn't work (Windows) 2011-04-07 16:49:54 -0700 1 1 1 Unclassified WebKit HTML Editing 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED InRadar, PlatformOnly P2 Normal --- 1 enrica enrica oliver oldest_to_newest 381440 0 enrica 2011-04-07 10:04:00 -0700 Undo does not seem to work via execCommand in WebKit2 windows. Steps to reproduce: 1) Load exec-command-undo.html tests Results: Text is bold because the undo failed. 381442 1 enrica 2011-04-07 10:04:17 -0700 <rdar://problem/8862023> 381760 2 88711 enrica 2011-04-07 15:04:54 -0700 Created attachment 88711 Patch 381814 3 88711 jberlin 2011-04-07 16:08:03 -0700 Comment on attachment 88711 Patch I am not yet a reviewer, but unofficial r=me! 381847 4 enrica 2011-04-07 16:49:54 -0700 http://trac.webkit.org/changeset/83194 88711 2011-04-07 15:04:54 -0700 2011-04-07 16:14:25 -0700 Patch execundo.txt text/plain 4670 enrica SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDgzMjE0KQorKysgU291cmNlL1dlYktpdDIvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjMgQEAKKzIwMTEtMDQtMDcgIEVucmljYSBD YXN1Y2NpICA8ZW5yaWNhQGFwcGxlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBSRUdSRVNTSU9OKFdlYktpdDIpOiBleGVjQ29tbWFuZCgndW5k bycpIGRvZXNuJ3Qgd29yayAoV2luZG93cykuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD01ODA1NgorICAgICAgICA8cmRhcjovL3Byb2JsZW0vODg2MjAy Mz4KKyAgICAgICAgCisgICAgICAgIEFkZGluZyBzdXBwb3J0IGZvciBleGVjQ29tbWFuZCgndW5k bycpIGFuZCBleGVjQ29tbWFuZCgncmVkbycpCisgICAgICAgIGluIFdlYktpdDIgZm9yIFdpbmRv d3MuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL0Mvd2luL1dLVmlldy5oOgorICAgICAgICAq IFVJUHJvY2Vzcy93aW4vV2ViVW5kb0NsaWVudC5jcHA6CisgICAgICAgIChXZWJLaXQ6OldlYlVu ZG9DbGllbnQ6OmNhblVuZG9SZWRvKToKKyAgICAgICAgKFdlYktpdDo6V2ViVW5kb0NsaWVudDo6 ZXhlY3V0ZVVuZG9SZWRvKToKKyAgICAgICAgKiBVSVByb2Nlc3Mvd2luL1dlYlVuZG9DbGllbnQu aDoKKyAgICAgICAgKiBVSVByb2Nlc3Mvd2luL1dlYlZpZXcuY3BwOgorICAgICAgICAoV2ViS2l0 OjpXZWJWaWV3OjpjYW5VbmRvUmVkbyk6CisgICAgICAgIChXZWJLaXQ6OldlYlZpZXc6OmV4ZWN1 dGVVbmRvUmVkbyk6CisKIDIwMTEtMDQtMDcgIEFsZXhleSBQcm9za3VyeWFrb3YgIDxhcEBhcHBs ZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgQnJpYW4gV2VpbnN0ZWluLgpJbmRleDogU291 cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9DL3dpbi9XS1ZpZXcuaAo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBT b3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL0Mvd2luL1dLVmlldy5oCShyZXZpc2lvbiA4MzE5 NCkKKysrIFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvQy93aW4vV0tWaWV3LmgJKHdvcmtp bmcgY29weSkKQEAgLTQzLDEyICs0MywxNiBAQCB0eXBlZGVmIHVpbnQzMl90IFdLVmlld1VuZG9U eXBlOwogCiB0eXBlZGVmIHZvaWQgKCpXS1ZpZXdSZWdpc3RlckVkaXRDb21tYW5kQ2FsbGJhY2sp KFdLVmlld1JlZiwgV0tFZGl0Q29tbWFuZFJlZiwgV0tWaWV3VW5kb1R5cGUgdW5kb09yUmVkbywg Y29uc3Qgdm9pZCAqY2xpZW50SW5mbyk7CiB0eXBlZGVmIHZvaWQgKCpXS1ZpZXdDbGVhckFsbEVk aXRDb21tYW5kc0NhbGxiYWNrKShXS1ZpZXdSZWYsIGNvbnN0IHZvaWQgKmNsaWVudEluZm8pOwor dHlwZWRlZiBib29sICgqV0tWaWV3Q2FuVW5kb1JlZG9DYWxsYmFjaykoV0tWaWV3UmVmLCBXS1Zp ZXdVbmRvVHlwZSB1bmRvT3JSZWRvLCBjb25zdCB2b2lkICpjbGllbnRJbmZvKTsKK3R5cGVkZWYg dm9pZCAoKldLVmlld0V4ZWN1dGVVbmRvUmVkb0NhbGxiYWNrKShXS1ZpZXdSZWYsIFdLVmlld1Vu ZG9UeXBlIHVuZG9PclJlZG8sIGNvbnN0IHZvaWQgKmNsaWVudEluZm8pOwogCiBzdHJ1Y3QgV0tW aWV3VW5kb0NsaWVudCB7CiAgICAgaW50ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB2ZXJzaW9uOwogICAgIGNvbnN0IHZvaWQg KiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg Y2xpZW50SW5mbzsKICAgICBXS1ZpZXdSZWdpc3RlckVkaXRDb21tYW5kQ2FsbGJhY2sgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgIHJlZ2lzdGVyRWRpdENvbW1hbmQ7CiAgICAgV0tW aWV3Q2xlYXJBbGxFZGl0Q29tbWFuZHNDYWxsYmFjayAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICBjbGVhckFsbEVkaXRDb21tYW5kczsKKyAgICBXS1ZpZXdDYW5VbmRvUmVkb0NhbGxi YWNrICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGNhblVuZG9SZWRv OworICAgIFdLVmlld0V4ZWN1dGVVbmRvUmVkb0NhbGxiYWNrICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgZXhlY3V0ZVVuZG9SZWRvOwogfTsKIHR5cGVkZWYgc3RydWN0IFdL Vmlld1VuZG9DbGllbnQgV0tWaWV3VW5kb0NsaWVudDsKIApJbmRleDogU291cmNlL1dlYktpdDIv VUlQcm9jZXNzL3dpbi9XZWJVbmRvQ2xpZW50LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9VSVByb2Nlc3Mvd2luL1dlYlVuZG9DbGllbnQuY3BwCShyZXZpc2lvbiA4MzE5NCkKKysr IFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy93aW4vV2ViVW5kb0NsaWVudC5jcHAJKHdvcmtpbmcg Y29weSkKQEAgLTQ5LDUgKzQ5LDIxIEBAIHZvaWQgV2ViVW5kb0NsaWVudDo6Y2xlYXJBbGxFZGl0 Q29tbWFuZHMKICAgICBtX2NsaWVudC5jbGVhckFsbEVkaXRDb21tYW5kcyh0b0FQSSh2aWV3KSwg bV9jbGllbnQuY2xpZW50SW5mbyk7CiB9CiAKK2Jvb2wgV2ViVW5kb0NsaWVudDo6Y2FuVW5kb1Jl ZG8oV2ViVmlldyogdmlldywgV2ViUGFnZVByb3h5OjpVbmRvT3JSZWRvIHVuZG9PclJlZG8pCit7 CisgICAgaWYgKCFtX2NsaWVudC5jYW5VbmRvUmVkbykKKyAgICAgICAgcmV0dXJuIGZhbHNlOwor ICAgIAorICAgIHJldHVybiBtX2NsaWVudC5jYW5VbmRvUmVkbyh0b0FQSSh2aWV3KSwgdW5kb09y UmVkbywgbV9jbGllbnQuY2xpZW50SW5mbyk7Cit9CisKK3ZvaWQgV2ViVW5kb0NsaWVudDo6ZXhl Y3V0ZVVuZG9SZWRvKFdlYlZpZXcqIHZpZXcsIFdlYlBhZ2VQcm94eTo6VW5kb09yUmVkbyB1bmRv T3JSZWRvKQoreworICAgIGlmICghbV9jbGllbnQuZXhlY3V0ZVVuZG9SZWRvKQorICAgICAgICBy ZXR1cm47CisgICAgCisgICAgbV9jbGllbnQuZXhlY3V0ZVVuZG9SZWRvKHRvQVBJKHZpZXcpLCB1 bmRvT3JSZWRvLCBtX2NsaWVudC5jbGllbnRJbmZvKTsKK30KKwogfSAvLyBuYW1lc3BhY2UgV2Vi S2l0CiAKSW5kZXg6IFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy93aW4vV2ViVW5kb0NsaWVudC5o Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy93aW4vV2ViVW5kb0NsaWVu dC5oCShyZXZpc2lvbiA4MzE5NCkKKysrIFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy93aW4vV2Vi VW5kb0NsaWVudC5oCSh3b3JraW5nIGNvcHkpCkBAIC0zOSw2ICszOSw4IEBAIGNsYXNzIFdlYlVu ZG9DbGllbnQgOiBwdWJsaWMgQVBJQ2xpZW50PFcKIHB1YmxpYzoKICAgICB2b2lkIHJlZ2lzdGVy RWRpdENvbW1hbmQoV2ViVmlldyosIFBhc3NSZWZQdHI8V2ViRWRpdENvbW1hbmRQcm94eT4sIFdl YlBhZ2VQcm94eTo6VW5kb09yUmVkbyk7CiAgICAgdm9pZCBjbGVhckFsbEVkaXRDb21tYW5kcyhX ZWJWaWV3Kik7CisgICAgYm9vbCBjYW5VbmRvUmVkbyhXZWJWaWV3KiwgV2ViUGFnZVByb3h5OjpV bmRvT3JSZWRvKTsKKyAgICB2b2lkIGV4ZWN1dGVVbmRvUmVkbyhXZWJWaWV3KiwgV2ViUGFnZVBy b3h5OjpVbmRvT3JSZWRvKTsKIH07CiAKIH0gLy8gbmFtZXNwYWNlIFdlYktpdApJbmRleDogU291 cmNlL1dlYktpdDIvVUlQcm9jZXNzL3dpbi9XZWJWaWV3LmNwcAo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3Vy Y2UvV2ViS2l0Mi9VSVByb2Nlc3Mvd2luL1dlYlZpZXcuY3BwCShyZXZpc2lvbiA4MzE5NCkKKysr IFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy93aW4vV2ViVmlldy5jcHAJKHdvcmtpbmcgY29weSkK QEAgLTEwMzAsMTMgKzEwMzAsMTQgQEAgdm9pZCBXZWJWaWV3OjpjbGVhckFsbEVkaXRDb21tYW5k cygpCiAgICAgbV91bmRvQ2xpZW50LmNsZWFyQWxsRWRpdENvbW1hbmRzKHRoaXMpOwogfQogCi1i b29sIFdlYlZpZXc6OmNhblVuZG9SZWRvKFdlYlBhZ2VQcm94eTo6VW5kb09yUmVkbykKK2Jvb2wg V2ViVmlldzo6Y2FuVW5kb1JlZG8oV2ViUGFnZVByb3h5OjpVbmRvT3JSZWRvIHVuZG9PclJlZG8p CiB7Ci0gICAgcmV0dXJuIGZhbHNlOworICAgIHJldHVybiBtX3VuZG9DbGllbnQuY2FuVW5kb1Jl ZG8odGhpcywgdW5kb09yUmVkbyk7CiB9CiAKLXZvaWQgV2ViVmlldzo6ZXhlY3V0ZVVuZG9SZWRv KFdlYlBhZ2VQcm94eTo6VW5kb09yUmVkbykKK3ZvaWQgV2ViVmlldzo6ZXhlY3V0ZVVuZG9SZWRv KFdlYlBhZ2VQcm94eTo6VW5kb09yUmVkbyB1bmRvT3JSZWRvKQogeworICAgIG1fdW5kb0NsaWVu dC5leGVjdXRlVW5kb1JlZG8odGhpcywgdW5kb09yUmVkbyk7CiB9CiAgICAgCiB2b2lkIFdlYlZp ZXc6OnJlYXBwbHlFZGl0Q29tbWFuZChXZWJFZGl0Q29tbWFuZFByb3h5KiBjb21tYW5kKQo=