58044 2011-04-07 07:50:36 -0700 [Qt][Symbian] Fix Api test failure -- tst_QGraphicsWebView::widgetsRenderingThroughCache 2011-05-17 06:16:43 -0700 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) S60 Hardware Other RESOLVED FIXED P2 Normal --- 38654 50925 1 max.hong.shen max.hong.shen ademar commit-queue laszlo.gombos oldest_to_newest 381336 0 max.hong.shen 2011-04-07 07:50:36 -0700 For this test, we should disable the scrollbars on the graphics view since QtWebKit handles scrolling and scrollbar automatically. Will provide a patch. 381342 1 88638 max.hong.shen 2011-04-07 07:56:55 -0700 Created attachment 88638 first try 381662 2 88638 kenneth 2011-04-07 13:48:44 -0700 Comment on attachment 88638 first try View in context: https://bugs.webkit.org/attachment.cgi?id=88638&action=review > Source/WebKit/qt/ChangeLog:5 > + [Qt][Symbian] Fix Api test failure -- tst_QGraphicsWebView::widgetsRenderingThroughCache So cache means tiling? If so that is quite confusing. 381682 3 max.hong.shen 2011-04-07 14:03:17 -0700 (In reply to comment #2) > (From update of attachment 88638 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=88638&action=review > > > Source/WebKit/qt/ChangeLog:5 > > + [Qt][Symbian] Fix Api test failure -- tst_QGraphicsWebView::widgetsRenderingThroughCache > > So cache means tiling? If so that is quite confusing. I think so ... see the comments for this test void tst_QGraphicsWebView::widgetsRenderingThroughCache() { // Widgets should be rendered the same way with and without // intermediate cache (tiling for example). // See bug https://bugs.webkit.org/show_bug.cgi?id=47767 where // widget are rendered as disabled when caching is using. 388203 4 88638 laszlo.gombos 2011-04-18 18:47:09 -0700 Comment on attachment 88638 first try View in context: https://bugs.webkit.org/attachment.cgi?id=88638&action=review > Source/WebKit/qt/tests/qgraphicswebview/tst_qgraphicswebview.cpp:-191 > - viewWithTiling.fill(); Can you explain why is this line removed ? 388445 5 max.hong.shen 2011-04-19 06:11:07 -0700 (In reply to comment #4) > (From update of attachment 88638 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=88638&action=review > > > Source/WebKit/qt/tests/qgraphicswebview/tst_qgraphicswebview.cpp:-191 > > - viewWithTiling.fill(); > > Can you explain why is this line removed ? This line is used here to fill the tiling image's background with the white color, which is not necessary in this case since all the tiles should get fully updated and set the background to white automatically. 388995 6 88638 laszlo.gombos 2011-04-19 18:49:10 -0700 Comment on attachment 88638 first try r=me. 389013 7 commit-queue 2011-04-19 19:53:26 -0700 The commit-queue encountered the following flaky tests while processing attachment 88638: http/tests/xmlhttprequest/basic-auth.html bug 51613 (author: ap@webkit.org) The commit-queue is continuing to process your patch. 389015 8 88638 commit-queue 2011-04-19 19:56:36 -0700 Comment on attachment 88638 first try Clearing flags on attachment: 88638 Committed r84332: <http://trac.webkit.org/changeset/84332> 389016 9 commit-queue 2011-04-19 19:56:39 -0700 All reviewed patches have been landed. Closing bug. 88638 2011-04-07 07:56:55 -0700 2011-04-19 19:56:35 -0700 first try 58044.patch text/plain 2098 max.hong.shen SW5kZXg6IFNvdXJjZS9XZWJLaXQvcXQvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9X ZWJLaXQvcXQvQ2hhbmdlTG9nCShyZXZpc2lvbiA4MzE3MykKKysrIFNvdXJjZS9XZWJLaXQvcXQv Q2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTEtMDQtMDcgIFlp IFNoZW4gIDx5aS40LnNoZW5Abm9raWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFtRdF1bU3ltYmlhbl0gRml4IEFwaSB0ZXN0IGZhaWx1cmUg LS0gdHN0X1FHcmFwaGljc1dlYlZpZXc6OndpZGdldHNSZW5kZXJpbmdUaHJvdWdoQ2FjaGUKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTU4MDQ0CisKKyAg ICAgICAgRml4aW5nIHRoaXMgdGVzdCBieSBkaXNhYmxpbmcgdGhlIHNjcm9sbGJhcnMgb24gdGhl IGdyYXBoaWNzIHZpZXcgCisgICAgICAgIHNpbmNlIFF0V2ViS2l0IGhhbmRsZXMgc2Nyb2xsaW5n IGFuZCBzY3JvbGxiYXIgYXV0b21hdGljYWxseSBhbmQgY29ycmVjdGx5LgorCisgICAgICAgICog dGVzdHMvcWdyYXBoaWNzd2Vidmlldy90c3RfcWdyYXBoaWNzd2Vidmlldy5jcHA6CisgICAgICAg ICh0c3RfUUdyYXBoaWNzV2ViVmlldzo6d2lkZ2V0c1JlbmRlcmluZ1Rocm91Z2hDYWNoZSk6CisK IDIwMTEtMDQtMDcgIEFsZXhpcyBNZW5hcmQgIDxhbGV4aXMubWVuYXJkQG9wZW5ib3NzYS5vcmc+ CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgS2VubmV0aCBSb2hkZSBDaHJpc3RpYW5zZW4uCkluZGV4 OiBTb3VyY2UvV2ViS2l0L3F0L3Rlc3RzL3FncmFwaGljc3dlYnZpZXcvdHN0X3FncmFwaGljc3dl YnZpZXcuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQvcXQvdGVzdHMvcWdyYXBoaWNz d2Vidmlldy90c3RfcWdyYXBoaWNzd2Vidmlldy5jcHAJKHJldmlzaW9uIDgzMTczKQorKysgU291 cmNlL1dlYktpdC9xdC90ZXN0cy9xZ3JhcGhpY3N3ZWJ2aWV3L3RzdF9xZ3JhcGhpY3N3ZWJ2aWV3 LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTcwLDYgKzE3MCw5IEBAIHZvaWQgdHN0X1FHcmFwaGlj c1dlYlZpZXc6OndpZGdldHNSZW5kZXIKICAgICB3ZWJWaWV3LT5zZXRIdG1sKFFMYXRpbjFTdHJp bmcoIjxib2R5IHN0eWxlPVwiYmFja2dyb3VuZC1jb2xvcjogd2hpdGVcIj48aW5wdXQgdHlwZT1y YW5nZT48L2lucHV0PjxpbnB1dCB0eXBlPWNoZWNrYm94PjwvaW5wdXQ+PGlucHV0IHR5cGU9cmFk aW8+PC9pbnB1dD48aW5wdXQgdHlwZT1maWxlPjwvaW5wdXQ+PC9ib2R5PiIpKTsKIAogICAgIFFH cmFwaGljc1ZpZXcgdmlldzsKKyAgICAvLyBEaXNhYmxlIHRoZSBzY3JvbGxiYXJzIG9uIHRoZSBn cmFwaGljcyB2aWV3IGJlY2F1c2UgUXRXZWJLaXQgaGFuZGxlcyBzY3JvbGxpbmcgYW5kIHNjcm9s bGJhciBhdXRvbWF0aWNhbGx5CisgICAgdmlldy5zZXRIb3Jpem9udGFsU2Nyb2xsQmFyUG9saWN5 KFF0OjpTY3JvbGxCYXJBbHdheXNPZmYpOworICAgIHZpZXcuc2V0VmVydGljYWxTY3JvbGxCYXJQ b2xpY3koUXQ6OlNjcm9sbEJhckFsd2F5c09mZik7CiAgICAgdmlldy5zaG93KCk7CiAgICAgUUdy YXBoaWNzU2NlbmUqIHNjZW5lID0gbmV3IFFHcmFwaGljc1NjZW5lKCZ2aWV3KTsKICAgICB2aWV3 LnNldFNjZW5lKHNjZW5lKTsKQEAgLTE4OCw3ICsxOTEsNiBAQCB2b2lkIHRzdF9RR3JhcGhpY3NX ZWJWaWV3Ojp3aWRnZXRzUmVuZGVyCiAgICAgUVBpeG1hcCB2aWV3V2l0aFRpbGluZyh2aWV3LnNp emUoKSk7CiAgICAgd2lkZ2V0LT5yZW5kZXIoJnZpZXdXaXRoVGlsaW5nKTsKICAgICBRQXBwbGlj YXRpb246OnByb2Nlc3NFdmVudHMoKTsKLSAgICB2aWV3V2l0aFRpbGluZy5maWxsKCk7CiAgICAg d2lkZ2V0LT5yZW5kZXIoJnZpZXdXaXRoVGlsaW5nKTsKIAogICAgIFFDT01QQVJFKHJlZmVyZW5j ZVBpeG1hcC50b0ltYWdlKCksIHZpZXdXaXRoVGlsaW5nLnRvSW1hZ2UoKSk7Cg==