58039 2011-04-07 06:35:58 -0700 [GTK] Implement increment() and decrement() functions in DRT's AccessibilityUIElement 2011-04-08 03:20:56 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 58040 1 mario mario abarth eric webkit.review.bot oldest_to_newest 381286 0 mario 2011-04-07 06:35:58 -0700 [GTK] Implement increment() and decrement() functions in DRT's AccessibilityUIElement 381289 1 88620 mario 2011-04-07 06:39:44 -0700 Created attachment 88620 Patch 381300 2 mario 2011-04-07 06:56:40 -0700 For additional info, the motivation behind this bug is fixing bug 58040, which is about skipping two accessibility tests. 381848 3 88620 mrobinson 2011-04-07 16:51:46 -0700 Comment on attachment 88620 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=88620&action=review > Tools/DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:32 > Please remove this extra newline. > Tools/DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:580 > + Ditto. > Tools/DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:590 > + Ditto. 382087 4 mario 2011-04-08 02:15:32 -0700 Committed r83271: <http://trac.webkit.org/changeset/83271> 382120 5 webkit.review.bot 2011-04-08 03:20:56 -0700 http://trac.webkit.org/changeset/83271 might have broken SnowLeopard Intel Release (Tests) The following tests are not passing: http/tests/inspector/resource-har-conversion.html http/tests/inspector/resource-parameters.html 88620 2011-04-07 06:39:44 -0700 2011-04-07 16:51:45 -0700 Patch bug-58039-20110407153904.patch text/plain 5288 mario U3VidmVyc2lvbiBSZXZpc2lvbjogODMwNjYKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZ3Rr L0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvZ3RrL0NoYW5nZUxvZwppbmRleCBjYTk0NGEwYTZj OTJjMjc4MThiMDliMjM4YWU1ZDZhNjJkYTQzM2NmLi45MzgyOWVmYzNlOGZkYjgzNjZmMjlkNWFm ODIxNWU1Nzc0MzM4OGZjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2d0ay9DaGFuZ2VMb2cK KysrIGIvU291cmNlL1dlYktpdC9ndGsvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAgQEAKKzIwMTEt MDQtMDcgIE1hcmlvIFNhbmNoZXogUHJhZGEgIDxtc2FuY2hlekBpZ2FsaWEuY29tPgorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtHVEtdIEltcGxlbWVu dCBpbmNyZW1lbnQoKSBhbmQgZGVjcmVtZW50KCkgZnVuY3Rpb25zIGluIERSVCdzIEFjY2Vzc2li aWxpdHlVSUVsZW1lbnQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTU4MDM5CisKKyAgICAgICAgSW1wbGVtZW50ZWQgbWlzc2luZyBmdW5jdGlvbnMgaW4g R1RLJ3MgRFJULgorCisgICAgICAgICogV2ViQ29yZVN1cHBvcnQvRHVtcFJlbmRlclRyZWVTdXBw b3J0R3RrLmg6CisgICAgICAgICogV2ViQ29yZVN1cHBvcnQvRHVtcFJlbmRlclRyZWVTdXBwb3J0 R3RrLmNwcDoKKyAgICAgICAgKG1vZGlmeUFjY2Vzc2liaWxpdHlWYWx1ZSk6IEhlbHBlciBmdW5j dGlvbiB0byBpbmNyZW1lbnQgb3IgZGVjcmVtZW50CisgICAgICAgIHRoZSBjdXJyZW50IHZhbHVl IGZvciBhbiBvYmplY3QgdGhyb3VnaCB0aGUgQWNjZXNzaWJpbGl0eU9iamVjdCdzIEFQSS4KKyAg ICAgICAgKER1bXBSZW5kZXJUcmVlU3VwcG9ydEd0azo6aW5jcmVtZW50QWNjZXNzaWJpbGl0eVZh bHVlKTogTmV3IGZ1bmN0aW9uLAorICAgICAgICB0byBiZSB1c2VkIGZyb20gR1RLJ3MgRFJULgor ICAgICAgICAoRHVtcFJlbmRlclRyZWVTdXBwb3J0R3RrOjpkZWNyZW1lbnRBY2Nlc3NpYmlsaXR5 VmFsdWUpOiBEaXR0by4KKwogMjAxMS0wNC0wNSAgTWFydGluIFJvYmluc29uICA8bXJvYmluc29u QGlnYWxpYS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRXJpYyBTZWlkZWwuCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViS2l0L2d0ay9XZWJDb3JlU3VwcG9ydC9EdW1wUmVuZGVyVHJlZVN1cHBv cnRHdGsuY3BwIGIvU291cmNlL1dlYktpdC9ndGsvV2ViQ29yZVN1cHBvcnQvRHVtcFJlbmRlclRy ZWVTdXBwb3J0R3RrLmNwcAppbmRleCA4MTc0OWVjMTlkOTMwNzJkMzNjMDBmNWE4ZTU1ZjNlMDRj MTM4NDc1Li4wZGNlZDY0MjEwN2QxZWFiM2Y3YjYxMTc1Mzc0OTdjNDZhYTE0MWZiIDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViS2l0L2d0ay9XZWJDb3JlU3VwcG9ydC9EdW1wUmVuZGVyVHJlZVN1cHBv cnRHdGsuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvZ3RrL1dlYkNvcmVTdXBwb3J0L0R1bXBSZW5k ZXJUcmVlU3VwcG9ydEd0ay5jcHAKQEAgLTY3OSw2ICs2NzksMzEgQEAgdm9pZCBEdW1wUmVuZGVy VHJlZVN1cHBvcnRHdGs6OnNldE1pbmltdW1UaW1lckludGVydmFsKFdlYktpdFdlYlZpZXcqIHdl YlZpZXcsIGQKICAgICBjb3JlKHdlYlZpZXcpLT5zZXR0aW5ncygpLT5zZXRNaW5ET01UaW1lcklu dGVydmFsKGludGVydmFsKTsKIH0KIAorc3RhdGljIHZvaWQgbW9kaWZ5QWNjZXNzaWJpbGl0eVZh bHVlKEF0a09iamVjdCogYXhPYmplY3QsIGJvb2wgaW5jcmVtZW50KQoreworICAgIGlmICghYXhP YmplY3QgfHwgIVdFQktJVF9JU19BQ0NFU1NJQkxFKGF4T2JqZWN0KSkKKyAgICAgICAgcmV0dXJu OworCisgICAgQWNjZXNzaWJpbGl0eU9iamVjdCogY29yZU9iamVjdCA9IHdlYmtpdF9hY2Nlc3Np YmxlX2dldF9hY2Nlc3NpYmlsaXR5X29iamVjdChXRUJLSVRfQUNDRVNTSUJMRShheE9iamVjdCkp OworICAgIGlmICghY29yZU9iamVjdCkKKyAgICAgICAgcmV0dXJuOworCisgICAgaWYgKGluY3Jl bWVudCkKKyAgICAgICAgY29yZU9iamVjdC0+aW5jcmVtZW50KCk7CisgICAgZWxzZQorICAgICAg ICBjb3JlT2JqZWN0LT5kZWNyZW1lbnQoKTsKK30KKwordm9pZCBEdW1wUmVuZGVyVHJlZVN1cHBv cnRHdGs6OmluY3JlbWVudEFjY2Vzc2liaWxpdHlWYWx1ZShBdGtPYmplY3QqIGF4T2JqZWN0KQor eworICAgIG1vZGlmeUFjY2Vzc2liaWxpdHlWYWx1ZShheE9iamVjdCwgdHJ1ZSk7Cit9CisKK3Zv aWQgRHVtcFJlbmRlclRyZWVTdXBwb3J0R3RrOjpkZWNyZW1lbnRBY2Nlc3NpYmlsaXR5VmFsdWUo QXRrT2JqZWN0KiBheE9iamVjdCkKK3sKKyAgICBtb2RpZnlBY2Nlc3NpYmlsaXR5VmFsdWUoYXhP YmplY3QsIGZhbHNlKTsKK30KKwogdm9pZCBEdW1wUmVuZGVyVHJlZVN1cHBvcnRHdGs6OnNldEF1 dG9maWxsZWQoSlNDb250ZXh0UmVmIGNvbnRleHQsIEpTVmFsdWVSZWYgbm9kZU9iamVjdCwgYm9v bCBhdXRvZmlsbGVkKQogewogICAgIEpTQzo6RXhlY1N0YXRlKiBleGVjID0gdG9KUyhjb250ZXh0 KTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZ3RrL1dlYkNvcmVTdXBwb3J0L0R1bXBSZW5k ZXJUcmVlU3VwcG9ydEd0ay5oIGIvU291cmNlL1dlYktpdC9ndGsvV2ViQ29yZVN1cHBvcnQvRHVt cFJlbmRlclRyZWVTdXBwb3J0R3RrLmgKaW5kZXggZDhkZDA5ZmY3YTQ4ZmVlZGJlYzc2Y2Y2ZWE1 OWUwNzkxZjJjNDQwYi4uOTA3YzQ1NzFmMTEzNzRhOTZiNTA0N2ZiZTE2MjUwZjQ5ODNjZGEyMiAx MDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9ndGsvV2ViQ29yZVN1cHBvcnQvRHVtcFJlbmRlclRy ZWVTdXBwb3J0R3RrLmgKKysrIGIvU291cmNlL1dlYktpdC9ndGsvV2ViQ29yZVN1cHBvcnQvRHVt cFJlbmRlclRyZWVTdXBwb3J0R3RrLmgKQEAgLTEwMCw2ICsxMDAsMTAgQEAgcHVibGljOgogICAg IHN0YXRpYyBkb3VibGUgZGVmYXVsdE1pbmltdW1UaW1lckludGVydmFsKCk7IC8vIE5vdCByZWFs bHkgdGllZCB0byBXZWJWaWV3CiAgICAgc3RhdGljIHZvaWQgc2V0TWluaW11bVRpbWVySW50ZXJ2 YWwoV2ViS2l0V2ViVmlldyosIGRvdWJsZSk7CiAKKyAgICAvLyBBY2Nlc3NpYmlsaXR5CisgICAg c3RhdGljIHZvaWQgaW5jcmVtZW50QWNjZXNzaWJpbGl0eVZhbHVlKEF0a09iamVjdCopOworICAg IHN0YXRpYyB2b2lkIGRlY3JlbWVudEFjY2Vzc2liaWxpdHlWYWx1ZShBdGtPYmplY3QqKTsKKwog ICAgIC8vIEdDCiAgICAgc3RhdGljIHZvaWQgZ2NDb2xsZWN0SmF2YXNjcmlwdE9iamVjdHMoKTsK ICAgICBzdGF0aWMgdm9pZCBnY0NvbGxlY3RKYXZhc2NyaXB0T2JqZWN0c09uQWx0ZXJuYXRlVGhy ZWFkKGJvb2wgd2FpdFVudGlsRG9uZSk7CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cgYi9U b29scy9DaGFuZ2VMb2cKaW5kZXggY2JkODk2NThmNTUzNGRhYjViNTM3YjcxYWZkMTBkZWUyMTgy MWRjMy4uYzI1OWI3ZWI3ZDY0NWJlMDJiYmJlNzEzNzdhOTFlZmFlZDZhNmQ5MCAxMDA2NDQKLS0t IGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBA CisyMDExLTA0LTA3ICBNYXJpbyBTYW5jaGV6IFByYWRhICA8bXNhbmNoZXpAaWdhbGlhLmNvbT4K KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbR1RLXSBJ bXBsZW1lbnQgaW5jcmVtZW50KCkgYW5kIGRlY3JlbWVudCgpIGZ1bmN0aW9ucyBpbiBEUlQncyBB Y2Nlc3NpYmlsaXR5VUlFbGVtZW50CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD01ODAzOQorCisgICAgICAgIEltcGxlbWVudCBtaXNzaW5nIGZ1bmN0aW9u cyBpbiBHVEsncyBEUlQuCisKKyAgICAgICAgKiBEdW1wUmVuZGVyVHJlZS9ndGsvQWNjZXNzaWJp bGl0eVVJRWxlbWVudEd0ay5jcHA6CisgICAgICAgIChBY2Nlc3NpYmlsaXR5VUlFbGVtZW50Ojpp bmNyZW1lbnQpOiBJbXBsZW1lbnRlZC4KKyAgICAgICAgKEFjY2Vzc2liaWxpdHlVSUVsZW1lbnQ6 OmRlY3JlbWVudCk6IEltcGxlbWVudGVkLgorCiAyMDExLTA0LTA2ICBDc2FiYSBPc3p0cm9nb27D oWMgIDxvc3N5QHdlYmtpdC5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgQW5kcmVhcyBLbGlu Zy4KZGlmZiAtLWdpdCBhL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL2d0ay9BY2Nlc3NpYmlsaXR5VUlF bGVtZW50R3RrLmNwcCBiL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL2d0ay9BY2Nlc3NpYmlsaXR5VUlF bGVtZW50R3RrLmNwcAppbmRleCBmZjc2ZTRiZjc5OGU4YWY0OGE2MzkyOTNlMTJmNWMyMzVhOTEw YWU5Li42MzM4MDNmYTU0NzJlYzYwOTZiOGU3YWE0NTc4YjU3M2U5YTlkZjZhIDEwMDY0NAotLS0g YS9Ub29scy9EdW1wUmVuZGVyVHJlZS9ndGsvQWNjZXNzaWJpbGl0eVVJRWxlbWVudEd0ay5jcHAK KysrIGIvVG9vbHMvRHVtcFJlbmRlclRyZWUvZ3RrL0FjY2Vzc2liaWxpdHlVSUVsZW1lbnRHdGsu Y3BwCkBAIC0yOCw2ICsyOCw3IEBACiAjaW5jbHVkZSAiQWNjZXNzaWJpbGl0eVVJRWxlbWVudC5o IgogI2luY2x1ZGUgIkdPd25QdHIuaCIKICNpbmNsdWRlICJHUmVmUHRyLmgiCisjaW5jbHVkZSAi V2ViQ29yZVN1cHBvcnQvRHVtcFJlbmRlclRyZWVTdXBwb3J0R3RrLmgiCiAKICNpbmNsdWRlIDxK YXZhU2NyaXB0Q29yZS9KU1N0cmluZ1JlZi5oPgogI2luY2x1ZGUgPHd0Zi9Bc3NlcnRpb25zLmg+ CkBAIC01NzIsMTIgKzU3MywyMiBAQCBib29sIEFjY2Vzc2liaWxpdHlVSUVsZW1lbnQ6OmlzQXR0 cmlidXRlU3VwcG9ydGVkKEpTU3RyaW5nUmVmIGF0dHJpYnV0ZSkKIAogdm9pZCBBY2Nlc3NpYmls aXR5VUlFbGVtZW50OjppbmNyZW1lbnQoKQogewotICAgIC8vIEZJWE1FOiBpbXBsZW1lbnQKKyAg ICBpZiAoIW1fZWxlbWVudCkKKyAgICAgICAgcmV0dXJuOworCisgICAgQVNTRVJUKEFUS19JU19P QkpFQ1QobV9lbGVtZW50KSk7CisKKyAgICBEdW1wUmVuZGVyVHJlZVN1cHBvcnRHdGs6OmluY3Jl bWVudEFjY2Vzc2liaWxpdHlWYWx1ZShBVEtfT0JKRUNUKG1fZWxlbWVudCkpOwogfQogCiB2b2lk IEFjY2Vzc2liaWxpdHlVSUVsZW1lbnQ6OmRlY3JlbWVudCgpCiB7Ci0gICAgLy8gRklYTUU6IGlt cGxlbWVudAorICAgIGlmICghbV9lbGVtZW50KQorICAgICAgICByZXR1cm47CisKKyAgICBBU1NF UlQoQVRLX0lTX09CSkVDVChtX2VsZW1lbnQpKTsKKworICAgIER1bXBSZW5kZXJUcmVlU3VwcG9y dEd0azo6ZGVjcmVtZW50QWNjZXNzaWJpbGl0eVZhbHVlKEFUS19PQkpFQ1QobV9lbGVtZW50KSk7 CiB9CiAKIHZvaWQgQWNjZXNzaWJpbGl0eVVJRWxlbWVudDo6cHJlc3MoKQo=