58035 2011-04-07 06:01:11 -0700 Web Inspector: Tweak dynamically constants for the async highlighting in text editor 2011-04-08 02:55:34 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 aandrey webkit-unassigned apavlov bweinstein joepeck keishi loislo pfeldman pmuellr podivilov rik timothy yurys oldest_to_newest 381262 0 aandrey 2011-04-07 06:01:11 -0700 On faster machines we can highlight faster, while on slower machines text editor is a bit unresponsive while highlighting the text. We can implement a simple heuristic to work smoothly on both cases. 381306 1 88626 aandrey 2011-04-07 07:04:38 -0700 Created attachment 88626 Patch 382106 2 88626 podivilov 2011-04-08 02:55:26 -0700 Comment on attachment 88626 Patch Clearing flags on attachment: 88626 Committed r83276: <http://trac.webkit.org/changeset/83276> 382107 3 podivilov 2011-04-08 02:55:34 -0700 All reviewed patches have been landed. Closing bug. 88626 2011-04-07 07:04:38 -0700 2011-04-08 02:55:26 -0700 Patch bug-58035-20110407180436.patch text/plain 3653 aandrey U3VidmVyc2lvbiBSZXZpc2lvbjogODMxNTkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBkNjlmZDE5NjZjYTIyYWU5 NzNhN2JlYjllMjk1ZTZmODE0MDJhNjNiLi41OTBiMzM5OTI5ZWQ1ZmQxNTEzYTE3Y2FkODA2N2Nk MDZlYmE4YmU4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTEtMDQtMDcgIEFuZHJl eSBBZGFpa2luICA8YWFuZHJleUBnb29nbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIFdlYiBJbnNwZWN0b3I6IFR3ZWFrIGR5bmFtaWNhbGx5 IGNvbnN0YW50cyBmb3IgdGhlIGFzeW5jIGhpZ2hsaWdodGluZyBpbiB0ZXh0IGVkaXRvcgorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTgwMzUKKworICAg ICAgICAqIGluc3BlY3Rvci9mcm9udC1lbmQvVGV4dFZpZXdlci5qczoKKyAgICAgICAgKFdlYklu c3BlY3Rvci5UZXh0RWRpdG9yTWFpblBhbmVsLnByb3RvdHlwZS5fZXhwYW5kQ2h1bmtzKToKKyAg ICAgICAgKFdlYkluc3BlY3Rvci5UZXh0RWRpdG9yTWFpblBhbmVsLnByb3RvdHlwZS5fc2NoZWR1 bGVQYWludExpbmVzKToKKyAgICAgICAgKFdlYkluc3BlY3Rvci5UZXh0RWRpdG9yTWFpblBhbmVs LnByb3RvdHlwZS5fcGFpbnRTY2hlZHVsZWRMaW5lcyk6CisgICAgICAgIChXZWJJbnNwZWN0b3Iu VGV4dEVkaXRvck1haW5QYW5lbC5wcm90b3R5cGUuX3Jlc3RvcmVQYWludExpbmVzT3BlcmF0aW9u c0NyZWRpdCk6CisgICAgICAgIChXZWJJbnNwZWN0b3IuVGV4dEVkaXRvck1haW5QYW5lbC5wcm90 b3R5cGUuX2FkanVzdFBhaW50TGluZXNPcGVyYXRpb25zUmVmcmVzaFZhbHVlKToKKwogMjAxMS0w NC0wNyAgQWRhbSBCYXJ0aCAgPGFiYXJ0aEB3ZWJraXQub3JnPgogCiAgICAgICAgIFJldmlld2Vk IGJ5IEVyaWMgU2VpZGVsLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zy b250LWVuZC9UZXh0Vmlld2VyLmpzIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVu ZC9UZXh0Vmlld2VyLmpzCmluZGV4IGZmMDIxMTRkMTNkYTQ3ZTE3N2ExNTUyYjhhOGFmMzk5MDY2 YzdjMDguLjgyZWQ1NTMxYWU4ODNkOWQyZjU3NzFkZWQ2NTE1NTg2ZGE5YTg3YzggMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvVGV4dFZpZXdlci5qcworKysg Yi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1RleHRWaWV3ZXIuanMKQEAgLTg1 Niw2ICs4NTYsNyBAQCBXZWJJbnNwZWN0b3IuVGV4dEVkaXRvck1haW5QYW5lbC5wcm90b3R5cGUg PSB7CiAKICAgICAgICAgdGhpcy5fcmVzdG9yZVBhaW50TGluZXNPcGVyYXRpb25zQ3JlZGl0KCk7 CiAgICAgICAgIFdlYkluc3BlY3Rvci5UZXh0RWRpdG9yQ2h1bmtlZFBhbmVsLnByb3RvdHlwZS5f ZXhwYW5kQ2h1bmtzLmNhbGwodGhpcywgZnJvbUluZGV4LCB0b0luZGV4KTsKKyAgICAgICAgdGhp cy5fYWRqdXN0UGFpbnRMaW5lc09wZXJhdGlvbnNSZWZyZXNoVmFsdWUoKTsKIAogICAgICAgICB0 aGlzLl9yZXN0b3JlU2VsZWN0aW9uKHNlbGVjdGlvbik7CiAgICAgfSwKQEAgLTg3NSw3ICs4NzYs NyBAQCBXZWJJbnNwZWN0b3IuVGV4dEVkaXRvck1haW5QYW5lbC5wcm90b3R5cGUgPSB7CiAKICAg ICAgICAgaWYgKCF0aGlzLl9zY2hlZHVsZWRQYWludExpbmVzKSB7CiAgICAgICAgICAgICB0aGlz Ll9zY2hlZHVsZWRQYWludExpbmVzID0gWyB7IHN0YXJ0TGluZTogc3RhcnRMaW5lLCBlbmRMaW5l OiBlbmRMaW5lIH0gXTsKLSAgICAgICAgICAgIHRoaXMuX3BhaW50U2NoZWR1bGVkTGluZXNUaW1l ciA9IHNldFRpbWVvdXQodGhpcy5fcGFpbnRTY2hlZHVsZWRMaW5lcy5iaW5kKHRoaXMpLCAxMCk7 CisgICAgICAgICAgICB0aGlzLl9wYWludFNjaGVkdWxlZExpbmVzVGltZXIgPSBzZXRUaW1lb3V0 KHRoaXMuX3BhaW50U2NoZWR1bGVkTGluZXMuYmluZCh0aGlzKSwgMCk7CiAgICAgICAgIH0gZWxz ZSB7CiAgICAgICAgICAgICBmb3IgKHZhciBpID0gMDsgaSA8IHRoaXMuX3NjaGVkdWxlZFBhaW50 TGluZXMubGVuZ3RoOyArK2kpIHsKICAgICAgICAgICAgICAgICB2YXIgY2h1bmsgPSB0aGlzLl9z Y2hlZHVsZWRQYWludExpbmVzW2ldOwpAQCAtOTEwLDE0ICs5MTEsMzEgQEAgV2ViSW5zcGVjdG9y LlRleHRFZGl0b3JNYWluUGFuZWwucHJvdG90eXBlID0gewogCiAgICAgICAgIHZhciBzY2hlZHVs ZWRQYWludExpbmVzID0gdGhpcy5fc2NoZWR1bGVkUGFpbnRMaW5lczsKICAgICAgICAgZGVsZXRl IHRoaXMuX3NjaGVkdWxlZFBhaW50TGluZXM7Ci0gICAgICAgIAorCiAgICAgICAgIHRoaXMuX3Jl c3RvcmVQYWludExpbmVzT3BlcmF0aW9uc0NyZWRpdCgpOwogICAgICAgICB0aGlzLl9wYWludExp bmVDaHVua3Moc2NoZWR1bGVkUGFpbnRMaW5lcywgIXNraXBSZXN0b3JlU2VsZWN0aW9uKTsKKyAg ICAgICAgdGhpcy5fYWRqdXN0UGFpbnRMaW5lc09wZXJhdGlvbnNSZWZyZXNoVmFsdWUoKTsKICAg ICB9LAogCiAgICAgX3Jlc3RvcmVQYWludExpbmVzT3BlcmF0aW9uc0NyZWRpdDogZnVuY3Rpb24o KQogICAgIHsKLSAgICAgICAgdGhpcy5fcGFpbnRMaW5lc09wZXJhdGlvbnNDcmVkaXQgPSAyNTA7 CisgICAgICAgIGlmICghdGhpcy5fcGFpbnRMaW5lc09wZXJhdGlvbnNSZWZyZXNoVmFsdWUpCisg ICAgICAgICAgICB0aGlzLl9wYWludExpbmVzT3BlcmF0aW9uc1JlZnJlc2hWYWx1ZSA9IDI1MDsK KyAgICAgICAgdGhpcy5fcGFpbnRMaW5lc09wZXJhdGlvbnNDcmVkaXQgPSB0aGlzLl9wYWludExp bmVzT3BlcmF0aW9uc1JlZnJlc2hWYWx1ZTsKKyAgICAgICAgdGhpcy5fcGFpbnRMaW5lc09wZXJh dGlvbnNMYXN0UmVmcmVzaCA9IERhdGUubm93KCk7CisgICAgfSwKKworICAgIF9hZGp1c3RQYWlu dExpbmVzT3BlcmF0aW9uc1JlZnJlc2hWYWx1ZTogZnVuY3Rpb24oKQorICAgIHsKKyAgICAgICAg dmFyIG9wZXJhdGlvbnNEb25lID0gdGhpcy5fcGFpbnRMaW5lc09wZXJhdGlvbnNSZWZyZXNoVmFs dWUgLSB0aGlzLl9wYWludExpbmVzT3BlcmF0aW9uc0NyZWRpdDsKKyAgICAgICAgaWYgKG9wZXJh dGlvbnNEb25lIDw9IDApCisgICAgICAgICAgICByZXR1cm47CisgICAgICAgIHZhciB0aW1lUGFz dCA9IERhdGUubm93KCkgLSB0aGlzLl9wYWludExpbmVzT3BlcmF0aW9uc0xhc3RSZWZyZXNoOwor ICAgICAgICBpZiAodGltZVBhc3QgPD0gMCkKKyAgICAgICAgICAgIHJldHVybjsKKyAgICAgICAg Ly8gTWFrZSB0aGUgc3luY2hyb25vdXMgQ1BVIGNodW5rIGZvciBwYWludGluZyB0aGUgbGluZXMg NTAgbXNlYy4KKyAgICAgICAgdmFyIHZhbHVlID0gTWF0aC5mbG9vcihvcGVyYXRpb25zRG9uZSAv IHRpbWVQYXN0ICogNTApOworICAgICAgICB0aGlzLl9wYWludExpbmVzT3BlcmF0aW9uc1JlZnJl c2hWYWx1ZSA9IE51bWJlci5jb25zdHJhaW4odmFsdWUsIDE1MCwgMTUwMCk7CiAgICAgfSwKIAog ICAgIF9wYWludExpbmVzOiBmdW5jdGlvbihmcm9tTGluZSwgdG9MaW5lLCByZXN0b3JlU2VsZWN0 aW9uKQo=